*** th1a has quit IRC | 00:11 | |
*** replaceafill has quit IRC | 00:27 | |
*** replaceafill has joined #schooltool | 00:49 | |
*** replaceafill has quit IRC | 01:32 | |
*** alga has quit IRC | 02:39 | |
*** alga has joined #schooltool | 02:40 | |
*** alga has quit IRC | 03:36 | |
*** aks has joined #schooltool | 05:04 | |
*** aks has quit IRC | 05:04 | |
*** aks has joined #schooltool | 05:04 | |
*** Lumiere has quit IRC | 08:50 | |
*** Lumiere has joined #schooltool | 09:01 | |
*** yvl has joined #schooltool | 10:26 | |
*** replaceafill has joined #schooltool | 11:22 | |
replaceafill | yvl, ping | 11:23 |
---|---|---|
yvl | hey | 11:23 |
replaceafill | hey yvl | 11:23 |
replaceafill | could i show you something? | 11:23 |
replaceafill | not related to photos :) | 11:23 |
yvl | sure! | 11:23 |
replaceafill | http://69.164.203.135:6663/contacts | 11:23 |
* yvl is playing with photos btw :) | 11:24 | |
replaceafill | try: | 11:24 |
replaceafill | abate kim, alan | 11:24 |
replaceafill | ;) | 11:24 |
yvl | 10000x10000 empty png is 300k file :D | 11:24 |
replaceafill | :| | 11:24 |
yvl | woooot! | 11:24 |
* yvl wants that search :D | 11:25 | |
replaceafill | hold on let me push the last fix | 11:25 |
replaceafill | ok, you can throw up now: | 11:26 |
replaceafill | https://code.launchpad.net/~replaceafill/schooltool/flourish_search | 11:26 |
replaceafill | i did it ala "the old grok days style" | 11:26 |
replaceafill | like i told you in the sprint | 11:26 |
replaceafill | text index + searchable text adapter | 11:26 |
replaceafill | and i build the query splitting by commas | 11:27 |
* yvl looking | 11:30 | |
replaceafill | the query building needs more thought ;) | 11:30 |
replaceafill | try just a comma in the search :P | 11:30 |
yvl | a small nitpick | 11:30 |
yvl | in terms, do filter(None, terms) | 11:30 |
yvl | so you dont get | 11:31 |
yvl | Alan or or Jane | 11:31 |
replaceafill | ah | 11:31 |
* replaceafill needs to learn python... | 11:31 | |
yvl | :D | 11:32 |
yvl | btw, the search is awesome | 11:32 |
yvl | thanks man! | 11:33 |
replaceafill | it has some drawbacks though iirc | 11:33 |
replaceafill | like "niño" | 11:33 |
replaceafill | vs "NIÑO" | 11:33 |
replaceafill | i have to try non-ascii | 11:34 |
* yvl tried lt | 11:34 | |
replaceafill | i remember i had to hack some á -> a, logic | 11:34 |
yvl | ah, right | 11:34 |
yvl | well, it is waaaaaaay more usable than it was before | 11:35 |
replaceafill | definitely | 11:35 |
yvl | with one huge drawback | 11:35 |
yvl | (to be fixed) | 11:35 |
yvl | you can find Alan | 11:35 |
yvl | you can't find Ala | 11:35 |
replaceafill | try ala* | 11:35 |
replaceafill | ;) | 11:35 |
yvl | doh | 11:35 |
replaceafill | needs a serious hint :P | 11:36 |
yvl | but can you find *lan ? | 11:36 |
replaceafill | ah come on! | 11:36 |
* replaceafill goes to see | 11:36 | |
replaceafill | :( | 11:36 |
replaceafill | i'll look for *stas... | 11:37 |
replaceafill | ¬¬ | 11:37 |
yvl | but you can find | 11:37 |
yvl | a*an | 11:37 |
yvl | or e*th | 11:37 |
replaceafill | i wouldnt even mention the globbing in the hint :D | 11:37 |
replaceafill | "type exactly the words you entered" | 11:38 |
replaceafill | :) | 11:38 |
yvl | ? | 11:39 |
yvl | wait, what? | 11:39 |
replaceafill | i mean, i think globbing is too complicated for the user | 11:40 |
yvl | then again, good for power user | 11:41 |
yvl | we can add a "Advanced search" after "What's this" | 11:41 |
replaceafill | true | 11:41 |
replaceafill | https://code.launchpad.net/~replaceafill/schooltool/flourish_search | 11:42 |
replaceafill | used filter(None, terms) | 11:42 |
yvl | oh, it can even search "ala?" :) | 11:42 |
replaceafill | like the old MS-DOS days :) | 11:43 |
replaceafill | should i use this on the person search? | 11:43 |
replaceafill | i think that was the task actually | 11:44 |
yvl | yes, please! | 11:45 |
replaceafill | kk, will do | 11:45 |
replaceafill | time to go to sleep :) | 11:46 |
replaceafill | let me know if you have more comments | 11:46 |
replaceafill | thanks yvl see you | 11:46 |
yvl | thanks for all the work! | 11:46 |
*** replaceafill has quit IRC | 11:46 | |
yvl | see you Monday :) | 11:46 |
*** ignas has joined #schooltool | 13:19 | |
*** aks has quit IRC | 13:59 | |
*** alga has joined #schooltool | 14:38 | |
*** alga has quit IRC | 15:51 | |
*** alga has joined #schooltool | 15:56 | |
*** replaceafill has joined #schooltool | 16:40 | |
yvl | hey replaceafill | 17:03 |
replaceafill | hey yvl | 17:03 |
yvl | can you sync with trunk on your search branch? | 17:03 |
replaceafill | sure | 17:04 |
yvl | thanks man | 17:04 |
yvl | if you get to speak to th1a before Mon meeting | 17:04 |
yvl | ask him what he thinks about search + batch adding | 17:05 |
* yvl thinks we dont need two buttons: "add displayed" and "add all" | 17:05 | |
replaceafill | ah ok | 17:05 |
yvl | "add displayed" is more than enough | 17:06 |
replaceafill | testing instance updated | 17:06 |
replaceafill | http://69.164.203.135:6663/ | 17:06 |
yvl | man, can't wait for this to land on trunk :D | 17:07 |
replaceafill | this? | 17:07 |
yvl | search :) | 17:08 |
replaceafill | ah | 17:08 |
yvl | and photos, frankly :D | 17:08 |
replaceafill | i'm working on person search now | 17:08 |
replaceafill | ah btw | 17:09 |
yvl | \o/ | 17:09 |
replaceafill | about the urlopen issue | 17:09 |
yvl | yes? | 17:09 |
replaceafill | do you think i should generate a namedtemporaryfile for the photo? | 17:09 |
replaceafill | that's the only way i can think of to point file="..." to something on the filesystem | 17:09 |
yvl | hmm | 17:10 |
replaceafill | or maybe that's not what you meant? | 17:11 |
yvl | I naively thought that there's an easy way to point to a file in blob storage | 17:13 |
replaceafill | ah! | 17:14 |
replaceafill | for a second i thought that's what you meant :) | 17:14 |
yvl | :))) | 17:14 |
yvl | ok, I'll look at that a bit later, if it's ok | 17:15 |
replaceafill | but then i started to think if that would be reliable, etc | 17:15 |
replaceafill | sure | 17:15 |
replaceafill | thanks | 17:15 |
*** th1a has joined #schooltool | 17:27 | |
yvl | hi th1a | 17:33 |
yvl | before I go... | 17:33 |
th1a | hi yvl. | 17:33 |
yvl | I chose not to add "Add ALL" button | 17:33 |
th1a | Feeling a little under the weather today. | 17:34 |
yvl | and go with "Add displayed" only | 17:34 |
yvl | sorry to hear, th1a | 17:34 |
th1a | yvl: OK. | 17:34 |
yvl | we have "show all" anyway | 17:34 |
th1a | Just a cold at this point. | 17:34 |
th1a | That probably makes sense. | 17:34 |
yvl | replaceafill is working on absolutely awesome search improvements | 17:35 |
yvl | with batch adding they make the views quite usable actually | 17:36 |
yvl | search for | 17:36 |
yvl | student1, student142, student12* | 17:36 |
yvl | add all | 17:36 |
yvl | one of the features I got quite excited about :) | 17:37 |
yvl | well, see you Monday | 17:37 |
* yvl off to config his new laptop | 17:37 | |
yvl | get better, th1a! | 17:37 |
* replaceafill hopes yvl's selenium tests fail now in his new laptop >:D | 17:38 | |
*** yvl has quit IRC | 17:43 | |
replaceafill | th1a, u there? | 17:59 |
th1a | I am here. | 17:59 |
th1a | I feel ok now after sleeping two extra hours. | 17:59 |
replaceafill | i forgot to ask yvl about his round corners comment | 18:00 |
replaceafill | and in your mail you said that you liked them | 18:00 |
replaceafill | does that mean we shouldn't put the uploaded image on a bigger background? | 18:01 |
th1a | I don't follow. | 18:01 |
replaceafill | ah ok, yvl said: | 18:02 |
th1a | I just like rounded corners. ;-) | 18:02 |
replaceafill | the way they are now? | 18:02 |
th1a | Are they rounded now? | 18:02 |
replaceafill | yes | 18:02 |
replaceafill | this is what yvl said (which i don't follow either): | 18:03 |
th1a | uH... which one should I be looking at? | 18:03 |
replaceafill | "Frankly, I miss rounded corners on "landscape" images like this http://69.164.203.135:6662/persons/student055" | 18:03 |
th1a | Oh! | 18:03 |
th1a | Yes, that seems much too tricky. | 18:03 |
th1a | If they have the right aspect ratio they're rounded now? | 18:04 |
replaceafill | yes | 18:04 |
replaceafill | the thing is that the image has never had rounded corners | 18:04 |
th1a | OK, fine. | 18:04 |
replaceafill | it's just a display setting | 18:04 |
replaceafill | css | 18:04 |
th1a | Yes. | 18:04 |
th1a | Just leave it that way. | 18:04 |
th1a | Is there a border now? | 18:04 |
replaceafill | yes | 18:04 |
replaceafill | same color as the accordion's | 18:05 |
* replaceafill thinks this is one of those cases th1a mentioned in the sprint when it's hard for me to follow IRC conversations :) | 18:05 | |
th1a | I think I prefer no border for the image. | 18:06 |
th1a | Or, I'd like to see it. | 18:06 |
replaceafill | ok, let me remove it and show you | 18:06 |
*** ignas has quit IRC | 18:06 | |
replaceafill | http://69.164.203.135:6662/persons/student055 | 18:07 |
replaceafill | reload | 18:07 |
th1a | That's better. | 18:08 |
replaceafill | kk, i'll remove the border then | 18:09 |
replaceafill | here's my search work so far: http://69.164.203.135:6663/contacts | 18:10 |
replaceafill | you can look stuff like: | 18:10 |
replaceafill | kim abate, alan | 18:10 |
replaceafill | , means "or" | 18:10 |
th1a | sub-string searches would be nice too... | 18:11 |
replaceafill | it's possible to use "globbing" | 18:11 |
replaceafill | an* | 18:11 |
th1a | Can we make it do that by default? | 18:11 |
replaceafill | hhmm | 18:11 |
replaceafill | we could create the query that way | 18:12 |
replaceafill | but i think it would lose the "or" functionality... | 18:12 |
th1a | I don't think anyone would use that. | 18:14 |
replaceafill | so if someone looks for: | 18:15 |
replaceafill | kim abate | 18:15 |
replaceafill | you want that converted to: | 18:15 |
replaceafill | kim* abate* | 18:15 |
replaceafill | ? | 18:15 |
th1a | *kim* *abate* | 18:16 |
th1a | ? | 18:16 |
replaceafill | a search term cannot start with * or ? | 18:16 |
replaceafill | in the query | 18:16 |
th1a | So you can't search for something coming later in the string, just the beginning? | 18:16 |
replaceafill | correct | 18:16 |
replaceafill | that's TextIndex :) | 18:17 |
th1a | Oh, I see... you would want "or" even though you wouldn't be consciously doing it. | 18:17 |
th1a | you can't force them all to be kim* OR abate* | 18:17 |
replaceafill | right | 18:18 |
replaceafill | it would not find only "kim abate" (that is probably what you wanted) | 18:18 |
replaceafill | it would find any kim and any abate too | 18:18 |
th1a | Well, too many results, within reason are much better than too few. | 18:19 |
th1a | MUCH. | 18:19 |
th1a | Since we require you to click on the link anyhow. | 18:19 |
th1a | Clicking on 1 of 10 is not much worse than 1 of 1. | 18:19 |
replaceafill | but suppose you want to use the "Add displayed" button | 18:20 |
th1a | That's really more of a filter by group case. | 18:20 |
th1a | If you're searching for a name you're just going to be adding one. | 18:20 |
th1a | Unless you have a section just for all the Garcias in the school. | 18:20 |
replaceafill | here are the rules for searching: | 18:23 |
replaceafill | http://svn.zope.org/*checkout*/zope.index/trunk/src/zope/index/text/queryparser.py?content-type=text%2Fplain&rev=113036 | 18:23 |
replaceafill | "Summarizing the default operator rules:" | 18:24 |
replaceafill | i build a new query that supports the comma | 18:24 |
replaceafill | so if the user enters: | 18:24 |
replaceafill | tom hoffman, justas, alan | 18:25 |
replaceafill | the final query is: | 18:25 |
th1a | Users are not going to use operators. | 18:25 |
th1a | Period. | 18:25 |
th1a | Put that out of your mind. | 18:25 |
replaceafill | yvl inserted it in my mind :D | 18:25 |
th1a | Remember a) we're just searching names | 18:25 |
replaceafill | http://schooltool.pov.lt/irclogs/latest.log.html#t2012-02-17T11:37:46 | 18:26 |
th1a | b) there is no use case for searching for more than one person at a time by name. | 18:26 |
th1a | Since my new computer goes to sleep I miss more action in the chat room. | 18:26 |
th1a | But I save electricity. ;-) | 18:26 |
replaceafill | :)) | 18:27 |
replaceafill | $$$ ;) | 18:27 |
th1a | Can you just let me try the automatic globbing? | 18:28 |
replaceafill | sure | 18:28 |
replaceafill | just to be clear | 18:28 |
th1a | OK. | 18:28 |
replaceafill | kim abate | 18:28 |
replaceafill | becomes: | 18:28 |
replaceafill | kim* abate* | 18:28 |
replaceafill | right? | 18:28 |
replaceafill | and we assume no operators (commas, etc) | 18:28 |
th1a | Make them all "or" | 18:31 |
replaceafill | http://69.164.203.135:6663/contacts/@@index.html | 18:33 |
replaceafill | automatic globbing | 18:33 |
replaceafill | btw, Show All has a bug | 18:34 |
replaceafill | doesn't keep the search terms | 18:34 |
* replaceafill goes to report it | 18:34 | |
th1a | So can this do "or" automatically? | 18:35 |
replaceafill | ah hold on, let me do that change too | 18:35 |
* replaceafill is multitasking :P | 18:35 | |
replaceafill | ok | 18:35 |
replaceafill | automatic globbing + or by default | 18:36 |
th1a | ok without or is better. | 18:36 |
replaceafill | ok, removing or... | 18:36 |
th1a | You can leave the comma functionality in there. | 18:36 |
th1a | But I think auto-glob is definitely good. | 18:37 |
th1a | It is good to be able to do last name and first initial. | 18:37 |
replaceafill | th1a, can you try again? | 18:46 |
replaceafill | automatic globbing, optional comma separator | 18:46 |
replaceafill | kim abate => kim* abate* | 18:47 |
replaceafill | kim abate, alan, jeffrey => kim* abate* or alan* or jeffrey* | 18:47 |
replaceafill | that ok? | 18:47 |
th1a | Yes. | 18:48 |
replaceafill | cool, moving it persons then | 18:50 |
replaceafill | to* | 18:50 |
*** menesis has quit IRC | 19:07 | |
*** hjbehling has quit IRC | 19:17 | |
replaceafill | th1a, http://69.164.203.135:6663/persons/@@index.html | 19:57 |
replaceafill | text search in person filter widget | 19:58 |
th1a | Nice. Thanks. | 19:58 |
replaceafill | it works on relationship views too: http://69.164.203.135:6663/schoolyears/2011-2012/groups/group07/members_persons.html | 19:59 |
replaceafill | with yvl's new buttons | 19:59 |
replaceafill | ok, i think i'm close to finish these two tasks (photos and search) | 20:00 |
replaceafill | i'll wait for the monday meeting to merge | 20:00 |
* replaceafill goes to get lunch | 20:02 | |
th1a | replaceafill: ayt? | 20:59 |
replaceafill | th1a, yes | 20:59 |
th1a | we need to make an id card template. | 20:59 |
th1a | Like nowish. | 20:59 |
replaceafill | did you see my question to yvl about the openurl issue? | 20:59 |
th1a | (that is, quick enough to stick it in the release) | 20:59 |
th1a | no | 21:00 |
replaceafill | we have a problem with z3c.rml | 21:00 |
replaceafill | when it retrieves images | 21:00 |
replaceafill | uses a new request | 21:00 |
replaceafill | which doesnt have session info | 21:00 |
replaceafill | so when it tries to access a person like /person/photo, it gets a forbidden | 21:00 |
replaceafill | yvl kind of suggested using files in the filesystem | 21:01 |
replaceafill | but that feels kind of insecure to me | 21:01 |
replaceafill | he said he would think about it | 21:02 |
th1a | OK. | 21:02 |
th1a | I guess we'll wait for that. I did see that issue. | 21:02 |
replaceafill | want me to experiment with temporary files? | 21:02 |
replaceafill | just to see if it's doable? | 21:03 |
th1a | You can let yvl think about it. | 21:03 |
replaceafill | cool | 21:04 |
*** alga has quit IRC | 21:26 | |
* th1a likes adding breakpoints to javascript. | 22:17 | |
replaceafill | :D | 22:17 |
replaceafill | firebug? | 22:17 |
replaceafill | or chrome? | 22:17 |
th1a | Chrome. | 22:17 |
* replaceafill is not very used to the chrome dev tools | 22:17 | |
th1a | Makes it easy to figure out what's going on in the d3 demo scripts. | 22:18 |
*** alga has joined #schooltool | 22:18 | |
th1a | I think Chrome's javascript dev support may be better. | 22:18 |
replaceafill | "Just formatting so it's gets printed into cards nicely. with a picture of the student." :) | 22:57 |
th1a | Yes... we need an example with a plausible looking photo... | 22:58 |
replaceafill | th1a, zyt? | 23:24 |
th1a | y | 23:24 |
replaceafill | http://img850.imageshack.us/img850/698/fooo.jpg | 23:24 |
replaceafill | contacts should look like the one on the right, correct? | 23:24 |
replaceafill | i mean, we should hide empty fields | 23:25 |
replaceafill | right? | 23:25 |
th1a | y | 23:25 |
replaceafill | kk | 23:25 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!