*** replaceafill has joined #schooltool | 00:08 | |
*** th1a has quit IRC | 00:29 | |
*** th1a has joined #schooltool | 03:26 | |
*** alga has quit IRC | 03:37 | |
*** aks has joined #schooltool | 05:04 | |
*** aks has quit IRC | 05:15 | |
*** aks has joined #schooltool | 05:15 | |
*** hjbehling has quit IRC | 06:33 | |
*** hjbehling has joined #schooltool | 06:34 | |
*** th1a has quit IRC | 07:05 | |
*** replaceafill has quit IRC | 07:53 | |
*** yvl has joined #schooltool | 09:58 | |
*** alga has joined #schooltool | 10:06 | |
*** menesis has quit IRC | 13:55 | |
*** ignas has joined #schooltool | 14:18 | |
*** menesis has joined #schooltool | 15:11 | |
*** menesis has quit IRC | 15:14 | |
*** menesis has joined #schooltool | 15:14 | |
*** aks has quit IRC | 15:21 | |
*** replaceafill has joined #schooltool | 16:02 | |
*** th1a has joined #schooltool | 16:05 | |
*** menesis_ has joined #schooltool | 16:28 | |
th1a | hi menesis, aelkner, replaceafill, yvl. | 16:31 |
---|---|---|
yvl | good morning | 16:31 |
replaceafill | good morning/afternoon | 16:31 |
aelkner | morning | 16:31 |
aelkner | i see we all safely made it home | 16:32 |
*** menesis has quit IRC | 16:32 | |
*** menesis_ is now known as menesis | 16:32 | |
th1a | Yes, that's something. | 16:33 |
th1a | I should get the invoices out today. | 16:33 |
menesis | hi | 16:34 |
* th1a opens his planner document so he can update task completion... | 16:34 | |
th1a | hi menesis. | 16:34 |
th1a | OK... | 16:35 |
th1a | yvl? | 16:35 |
yvl | didn't do much on Mon/Tue | 16:36 |
yvl | fixed some bugs today: | 16:36 |
yvl | https://bugs.launchpad.net/schooltool/+bug/918353 | 16:36 |
yvl | https://bugs.launchpad.net/schooltool/+bug/930467 | 16:36 |
th1a | What kind of issues did you find there? | 16:37 |
th1a | (just so I have some perspective) | 16:37 |
yvl | and https://bugs.launchpad.net/schooltool/+bug/930312 | 16:37 |
yvl | umm... | 16:38 |
* th1a is not adding every bugfix to the planner doc, btw... | 16:38 | |
yvl | yes | 16:38 |
th1a | "They are all different" is a valid response. | 16:38 |
yvl | calendar crash was because timetabled calendar view did not handle hour 24 properly | 16:38 |
yvl | edit relationships was broken when there were no schoolyears | 16:39 |
yvl | i.e. no groups, but you wanted to edit group membership | 16:39 |
yvl | for manager | 16:39 |
th1a | ah | 16:39 |
yvl | and weekday timetable templates were ignoring school days | 16:39 |
yvl | fixed + evolution to upate calendars | 16:40 |
yvl | now I'm making relationship views to remember filter settings when adding a person | 16:40 |
yvl | nearly done | 16:40 |
th1a | OK. Cool. | 16:40 |
th1a | We are starting to get a lot more small bug reports, which is a very good thing. | 16:41 |
yvl | true | 16:41 |
yvl | I couldn't repro a bug where... | 16:41 |
yvl | a section did not get scheduled correctly under some timezone | 16:42 |
yvl | what else.. | 16:42 |
yvl | I'll need more info on how you imagine "Add all" to work in relationship views | 16:42 |
yvl | then it's on to "ajax batching" | 16:43 |
yvl | then comes testing love | 16:43 |
yvl | oh, and I should have a new laptop to work on! \o/ | 16:43 |
yvl | (this one is slowly dying on me) | 16:43 |
th1a | So you'll be 50% more productive? | 16:43 |
yvl | I'll stare at the screen way more efficiently | 16:44 |
th1a | I read that developers are primarily constrained by processor speed. | 16:44 |
th1a | Let me know when you want to discuss "add all." | 16:45 |
yvl | I kind of just want you to tell me what to do :D | 16:45 |
th1a | Basically add all the results of the search. | 16:45 |
yvl | all | 16:45 |
yvl | or all visible | 16:45 |
th1a | I'm thinking maybe two buttons, tbh. | 16:45 |
yvl | well that | 16:45 |
* yvl couldn't figure out what to choose, so... | 16:46 | |
yvl | one button, two buttons, a button with checkboxes, something else... | 16:46 |
th1a | Two buttons I think | 16:46 |
yvl | but not image buttons | 16:46 |
th1a | I mean, if you have one button you have to have some explanatory text, whereas two buttons kind of explain themselves. | 16:47 |
yvl | like ones in table row | 16:47 |
th1a | This requires some explicit text. | 16:47 |
* yvl is struggling a bit on how anyone would actually use the buttons | 16:47 | |
yvl | - and why | 16:47 |
th1a | If you have a group of students you want to add to a section. | 16:48 |
yvl | then there's a choice of adding "Add this group" next to "Search" button | 16:48 |
yvl | but anyway | 16:48 |
th1a | I don't think we'd want that. | 16:49 |
* yvl just wants to get that done and move on | 16:49 | |
yvl | so... "Add displayed" and "Add all results" | 16:49 |
yvl | ? | 16:49 |
yvl | ok | 16:51 |
* yvl done | 16:51 | |
th1a | Perhaps "Add only displayed" | 16:51 |
th1a | And make "Add all results" first and/or generally more prominent. | 16:52 |
yvl | ok | 16:53 |
th1a | I'm open to alternatives on this. | 16:53 |
th1a | Thanks yvl. | 16:53 |
th1a | menesis? | 16:53 |
menesis | I have made a schooltool 2.0.2 release yesterday | 16:54 |
menesis | before too many changes after the sprint are going to land | 16:54 |
menesis | meant to do that last week, released gradebook. but had work on other project | 16:55 |
menesis | fixed some zope incompatibilities in recent z3c.template and friends | 16:55 |
menesis | not much | 16:56 |
th1a | OK. We've just got a few small features still in the pipeline. | 16:57 |
th1a | Hopefully they'll be done this week. | 16:57 |
th1a | Thanks menesis. | 16:58 |
th1a | replaceafill? | 16:58 |
replaceafill | ok | 16:58 |
replaceafill | during the sprint i talked to yvl about my demographics fields fixes | 16:58 |
replaceafill | i'm about to merge them | 16:58 |
replaceafill | i just need one more error message: | 16:58 |
replaceafill | http://schooltool.pov.lt/irclogs/%23schooltool.2012-01-25.log.html#t2012-01-25T17:10:52 | 16:59 |
replaceafill | we started to have that conversation :) | 16:59 |
replaceafill | when you set the ID for a demo field, you can only use alphanumeric text | 16:59 |
replaceafill | so far i have __doc__ = _(u'XXX Invalid field ID XXX') | 17:00 |
th1a | Are the valid constraints already in the hint? | 17:00 |
replaceafill | the hint only says: | 17:01 |
replaceafill | description = _(u"A unique one word identifier.")) | 17:01 |
th1a | OK, so add the constraints to the hint, and I can't remember if we have a particular wording in error messages now... | 17:02 |
th1a | Do we do something like "Please enter a valid ID" ? | 17:03 |
*** Lumiere has quit IRC | 17:03 | |
replaceafill | i can set the branch up and show it to you after the meeting, if that's ok | 17:03 |
replaceafill | i'm also finishing the photo work | 17:04 |
replaceafill | which i'd like you to see too | 17:04 |
th1a | OK. | 17:04 |
replaceafill | my only question is how to edit the photo field | 17:04 |
replaceafill | i mean, a <input type="file" ... /> on editing doesnt seem enough for me | 17:04 |
replaceafill | i'd rather have some radio buttons: | 17:05 |
replaceafill | ( .) keep existing image | 17:05 |
*** alga has quit IRC | 17:05 | |
replaceafill | ( ) upload new image | 17:05 |
replaceafill | or something like that | 17:05 |
replaceafill | and ( ) delete image | 17:06 |
th1a | replaceafill: You've given the image form a lot more thought than I have. | 17:06 |
replaceafill | np, i'll set up that too | 17:06 |
replaceafill | and show it to you | 17:06 |
th1a | Just make the id error message what I suggested above -- that's probably the style of error message we should go to although it isn't what we use now for the most part. | 17:06 |
replaceafill | ok | 17:07 |
replaceafill | yvl, i've been playing more with the text search + catalogs, i'll probably bug you tomorrow for a review of my branch | 17:07 |
yvl | sure | 17:08 |
th1a | Thanks replaceafill. | 17:08 |
th1a | aelkner? | 17:08 |
aelkner | i'd like you to look at the filldown dialog for text comments | 17:08 |
aelkner | http://69.164.203.135:36660/schoolyears/2010-2011/2010-fall/sections/math_a_2010-fall_teacher001_000/activities/Worksheet/gradebook/index.html# | 17:09 |
aelkner | teacher001 | 17:09 |
aelkner | i didn't include the name of the activity yet, but i could if you'd like | 17:09 |
aelkner | this is our first modal that is a form, so it needs some css love | 17:09 |
aelkner | replaceafill, can we talk about that after the meeting | 17:09 |
replaceafill | sure | 17:09 |
aelkner | also, i got your message about display: none | 17:10 |
aelkner | let's talk about that, too, after the meeting | 17:10 |
replaceafill | yes, please :) | 17:10 |
replaceafill | ok | 17:10 |
aelkner | but th1a, any text comments now will end up in improvements if you'd like | 17:10 |
th1a | I'd make the menu item "Fill down" | 17:11 |
th1a | We don't need that "Grade" header, do we? | 17:12 |
replaceafill | one thing it's weird for me, don't know if you have seen it | 17:12 |
replaceafill | but the dialog disappears the first time i open it | 17:12 |
th1a | I got that too. | 17:12 |
th1a | We need aelkner to start testing with Chrome. | 17:12 |
aelkner | i get that sometimes, not always | 17:12 |
replaceafill | ah, it's not just me then | 17:12 |
th1a | OK, so yes, that's a bug. ;-) | 17:12 |
aelkner | could it be that the library we are using is buggy? | 17:13 |
th1a | It isn't that buggy. | 17:14 |
aelkner | all we do is call the dialog method | 17:14 |
aelkner | it's not like we are doing something tricky, but if the library has bugs, then we can't be blamed | 17:14 |
th1a | We just have to get better at debugging javascript. | 17:15 |
aelkner | perhaps debugging the library would be a good way to do that | 17:16 |
aelkner | i could give that a try | 17:16 |
th1a | This is not just a jquery bug. | 17:16 |
aelkner | plus, test out on chrome some | 17:16 |
aelkner | how do you mean? | 17:16 |
th1a | Well, if you get the same thing on firefox, never mind, but generally, just fire up Chrome once and a while and try it. | 17:17 |
aelkner | will do | 17:18 |
aelkner | in the meantime, i'm also working on finishing up the course worksheets | 17:18 |
aelkner | https://bugs.launchpad.net/schooltool/+bug/927862 | 17:18 |
th1a | http://www.youtube.com/watch?v=c_oiQYirKuY&feature=plcp& | 17:18 |
aelkner | nothing much say about that until i've finshed it | 17:18 |
th1a | ^ how to set breakpoints in your Javascript. | 17:19 |
aelkner | thanks | 17:19 |
aelkner | chrome's js debugger looks cleaner at first glance | 17:19 |
replaceafill | btw, i got the bug in ff and chrome | 17:19 |
aelkner | th1a, so no more text changes than just the menu item? | 17:20 |
th1a | Anyhow, can we just be rid of that "Grade" header in the dialog? | 17:20 |
aelkner | it's not a header, it's the standard form element heirarchy | 17:21 |
aelkner | it just needs to be styled | 17:21 |
th1a | It needs to go away. | 17:21 |
th1a | Can it go away? | 17:21 |
aelkner | do we have a case of a form that has an edit field with no label? | 17:22 |
aelkner | and if not, do we want to have a different set of rules for modals? | 17:22 |
aelkner | in any event, i can make the form not have a label for the edit field if you want | 17:23 |
th1a | We certainly don't need a title in the bar and a title in the body. | 17:23 |
aelkner | it's a hint | 17:23 |
aelkner | i can get rid of that, too | 17:23 |
replaceafill | aelkner, since you're building the form manually, it's just a matter of removing the <label> element | 17:24 |
th1a | Perhaps you need to tell me what the three things I'm looking at are. | 17:24 |
replaceafill | or <div class="label"> | 17:24 |
aelkner | replaceafill, i put the standard form heirarchy in place | 17:24 |
aelkner | we all know what is there | 17:24 |
aelkner | <label>, <p> (for the hint> <input> | 17:25 |
aelkner | of, course the divs class="row" | 17:25 |
aelkner | class="label", "widget", "viewspace", etc | 17:25 |
aelkner | these things are auto-generated by our view macros | 17:26 |
aelkner | i just just did it manually because it was easier to do that way | 17:26 |
aelkner | but the css issues are the same regardless | 17:26 |
th1a | Why don't you fix the CSS first. | 17:27 |
th1a | Does anyone have an opinion about this being a non-modal dialog? | 17:27 |
th1a | My general feeling is that it makes it more likely someone will come up with some surprising way to break it. | 17:28 |
th1a | Also, I'm thinking fill down should not overwrite existing scores. | 17:29 |
th1a | Also, if a cell is highlighted because of an existing score, the highlighting doesn't go away after the row is filled and saved. | 17:29 |
aelkner | highlighted? how is it highlighted? i can't see that | 17:31 |
th1a | enter a score | 17:31 |
*** menesis has quit IRC | 17:31 | |
th1a | (thus the cell is highlighted) | 17:31 |
aelkner | i did, the row gets focus | 17:31 |
th1a | do filldown | 17:31 |
aelkner | i did, the cell loses focus | 17:31 |
th1a | It should be highlighted as an unsaved cell. | 17:32 |
th1a | Yes? | 17:32 |
replaceafill | the changes in the cell classes are handled by keydown and keyup events | 17:34 |
aelkner | yeah, the old javascript | 17:34 |
replaceafill | in this case, there are no keys being pressed, so that's why you dont get the change | 17:34 |
replaceafill | yep | 17:34 |
aelkner | i would have to add the same logic to the fill down | 17:35 |
th1a | Yes, that needs to be cleaned up. | 17:35 |
aelkner | and definitely leave non-empty cells alone? | 17:35 |
th1a | Why aren't the highlight colors cleared on every save? | 17:35 |
replaceafill | they're not? | 17:35 |
* replaceafill goes to check | 17:35 | |
aelkner | yeah, i don't get that | 17:36 |
th1a | That's what I'm saying. | 17:36 |
replaceafill | th1a they get cleared on ff | 17:36 |
th1a | Or does fill down not automatically save. | 17:37 |
th1a | That's what I was assuming. | 17:37 |
aelkner | it doesn't | 17:37 |
aelkner | that was on purpose | 17:37 |
th1a | OK, so just color the cells then. | 17:37 |
th1a | And yes, don't change existing grades when you fill down. | 17:37 |
aelkner | ok, got it | 17:37 |
aelkner | moving on then... | 17:38 |
aelkner | i don't have any question about the course worksheets work | 17:38 |
aelkner | th1a, could you create a bug for the section locations task | 17:38 |
aelkner | so that i know exactly what you want done there | 17:38 |
th1a | ok | 17:38 |
aelkner | i'll be able to get started on that later this week | 17:38 |
aelkner | that's it for me | 17:39 |
th1a | OK, thanks aelkner. | 17:40 |
th1a | Thanks guys. | 17:40 |
th1a | I guess that's it until Monday. | 17:41 |
th1a | Have a great week & weekend. | 17:41 |
th1a | Thanks again for a great sprint! | 17:41 |
* th1a drops the bag of gravel. | 17:41 | |
aelkner | great week guys | 17:41 |
replaceafill | thanks everybody | 17:41 |
*** menesis has joined #schooltool | 17:41 | |
aelkner | replaceafill, i'm ready to talk modal css when you are | 17:42 |
replaceafill | go ahead | 17:42 |
aelkner | first, what would you prefer for the display:none, create a style for the specific id? | 17:43 |
aelkner | and in which file would you want that, and where? | 17:43 |
replaceafill | i'd set it in the javascript code | 17:43 |
replaceafill | but if you want to do it in a css file, use jquery-overrides.css | 17:44 |
aelkner | it needs to be invisible by default so that the user doesn't see it until they click on the menu item | 17:45 |
aelkner | setting it in javascript would make it flash on page-load, right? | 17:45 |
replaceafill | probably | 17:45 |
aelkner | so instead of creating css for a specific id, would it be better to have a class for that? | 17:46 |
replaceafill | we decided not to use ids for css | 17:47 |
replaceafill | so yes, a class would be better | 17:47 |
aelkner | ok, so since you authored the current css files, would you like to author the css rules for this? | 17:47 |
aelkner | that includes the odal css we need | 17:47 |
aelkner | modal | 17:47 |
replaceafill | besides the display:none, what other css changes you need? | 17:48 |
aelkner | doesn't the form look terrible? | 17:48 |
aelkner | th1a didn't even recognize the label from the hint | 17:48 |
th1a | Can we make it look like a form? | 17:49 |
aelkner | also, what about the dialog width? | 17:49 |
aelkner | if we are going to have forms, what width should the dialog have? | 17:49 |
aelkner | replaceafill, i'm thinking your magic css rules just need a little love | 17:50 |
aelkner | to get them to apply the same way within a modal | 17:50 |
replaceafill | aelkner, you can modify them as you need | 17:50 |
replaceafill | just take into account that we use them in several other places | 17:51 |
replaceafill | i'd suggest you start with a specific class for your fill down dialog | 17:51 |
replaceafill | and use that class in every new rule | 17:52 |
replaceafill | so it doesnt affect other dialogs (the ones that dont have forms) | 17:52 |
aelkner | so are we talking about cloning half a file's worth of rules and tweaking? | 17:52 |
aelkner | i'm not sure what we;re talking about here | 17:53 |
aelkner | i think i need to understand your rules better first | 17:53 |
replaceafill | one thing, they are *OUR* rules ;) | 17:53 |
aelkner | are you stepping down as VP :) | 17:54 |
th1a | Boys! | 17:54 |
replaceafill | always :) | 17:54 |
aelkner | just kidding | 17:54 |
*** ignas has quit IRC | 17:54 | |
aelkner | i can play around and make my own set of changes, perhaps in a new file | 17:55 |
aelkner | and replaceafill, you could change them to whatever you think better after that | 17:55 |
aelkner | i was just hoping to get you to agree to handle the issue :) | 17:55 |
replaceafill | nah, you do it :) | 17:56 |
aelkner | it's probably better for me to take a little ownership (as you suggest) | 17:56 |
replaceafill | and i'd suggest using an existing file | 17:56 |
replaceafill | like jquery-ui-overrides.css | 17:56 |
aelkner | see, that suggestion alone helps :) | 17:56 |
replaceafill | you can insert a section at the button | 17:56 |
replaceafill | sorry | 17:56 |
replaceafill | bottom :) | 17:56 |
aelkner | now we're talking | 17:56 |
replaceafill | with your changes | 17:56 |
replaceafill | and then we move them to a better place (if needed) | 17:57 |
aelkner | and it can clone as long as the whole section is labeled "Modal css (clones non-modal rules)" | 17:57 |
replaceafill | and keep checking other dialogs | 17:58 |
replaceafill | download request, password change, section linking | 17:58 |
replaceafill | even section linking dialogs could use that kind of love | 17:59 |
aelkner | are each of those modal? | 17:59 |
replaceafill | and some download request ones | 17:59 |
replaceafill | yes | 17:59 |
replaceafill | and they use form controls | 17:59 |
replaceafill | for dates, etc | 17:59 |
aelkner | right, thanks | 17:59 |
replaceafill | but they use a custom (manual) layout | 17:59 |
aelkner | you didn't keep the form macro format? | 18:01 |
replaceafill | http://69.164.203.135:36660/schoolyears/2011-2012/2011-fall/sections/art_a_2011-fall_teacher004_000/section_linkage.html | 18:01 |
aelkner | i would think that we need to use the same pattern since some modal will use that macro at some point | 18:02 |
replaceafill | click on Link an Existing Section | 18:02 |
replaceafill | aelkner, these are very specific forms | 18:02 |
replaceafill | like 2 forms fields in that one ^ | 18:02 |
replaceafill | fieldsets* | 18:02 |
aelkner | hmm, thinking of our non-modals for the moment, do we have a pattern? | 18:04 |
aelkner | you created rules based on a pattern, right | 18:05 |
replaceafill | we have no patterns for modals afaik | 18:05 |
aelkner | shouldn't we? | 18:05 |
replaceafill | look at the request dialogs, they're different to this | 18:05 |
replaceafill | no form controls | 18:05 |
replaceafill | just buttons | 18:05 |
aelkner | perhaps they should be fixed | 18:06 |
aelkner | i mean, if we want to benefit from a pattern as we did with the non-modals | 18:06 |
replaceafill | but even then you have to remember what used to happen in some of the gradebook forms | 18:07 |
replaceafill | the ones that had text above them | 18:07 |
replaceafill | before we moved all those instructions to the right sidebar | 18:07 |
replaceafill | they looked weird | 18:07 |
th1a | Couldn't we start with the regular form styles and move them over to the dialog styles? | 18:07 |
th1a | Isn't that the point? | 18:08 |
aelkner | replaceafill, this is my point, that work was extensive and already done | 18:09 |
replaceafill | i'd love to have rules for forms inside dialogs | 18:10 |
th1a | You should be able to do that aelkner. | 18:10 |
aelkner | yes, so i'll add new rules to that section at the end of the file | 18:11 |
th1a | Assuming that we don't want or need a grand unified form CSS for both. | 18:11 |
aelkner | ah, i was going to say | 18:11 |
replaceafill | no, that's why i suggested a base css class | 18:11 |
replaceafill | and start your rules from there | 18:11 |
aelkner | right now things are based on .viewspace mostly, right? | 18:12 |
replaceafill | actually on fieldsets | 18:14 |
replaceafill | form fieldset ... | 18:14 |
aelkner | i just did a grep for viewspace in floursh/skin and get nothing rules-wise | 18:15 |
replaceafill | grep for "form fieldset" :) | 18:15 |
aelkner | just as an aside, are we using viewspace only because of old macros from pre-flourish? | 18:16 |
replaceafill | yes | 18:16 |
replaceafill | z3c.formui original macro | 18:16 |
aelkner | ok, so i see that the form fieldset css is found in form.css and color.css | 18:18 |
aelkner | and one rule in jquery-ui-overrides.css | 18:18 |
replaceafill | those few rules in jquery-ui-overrides.css are used for the other dialogs (section linkage, password edit, preferences, etc) | 18:19 |
replaceafill | and as you can see they're nothing compared to the ones in form.css | 18:20 |
replaceafill | that's the missing pattern you were talking about | 18:20 |
aelkner | colors.css matters, too, right? | 18:21 |
replaceafill | yes, but colors.css can be modified as the last step | 18:21 |
replaceafill | it's easy to set full rules at the beginning | 18:21 |
replaceafill | and when everything is working, you move only the related to colors there | 18:21 |
aelkner | for our purposes the cloning of both forms.css and colors.css (as needed) should go together | 18:22 |
aelkner | at the end of the jquery-ui-overrides.css, right? | 18:22 |
replaceafill | yes | 18:22 |
aelkner | ok, got it | 18:23 |
aelkner | should be no problem | 18:23 |
aelkner | can i move the one rule that is already in the file down to end with my new stuff? | 18:24 |
aelkner | it will help to see related things together | 18:24 |
replaceafill | sure | 18:24 |
aelkner | cool | 18:24 |
yvl | ... | 18:29 |
aelkner | yvl, yes? | 18:29 |
yvl | thought I pinged out :D | 18:29 |
aelkner | :) | 18:30 |
*** alga has joined #schooltool | 18:43 | |
*** menesis has quit IRC | 21:01 | |
*** menesis has joined #schooltool | 22:45 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!