| *** ignas has joined #schooltool | 02:04 | |
| *** menesis has quit IRC | 02:27 | |
| *** ignas has quit IRC | 02:38 | |
| *** aks has joined #schooltool | 05:19 | |
| *** aks has quit IRC | 09:11 | |
| *** alga_ has joined #schooltool | 12:06 | |
| *** alga has quit IRC | 12:07 | |
| *** 13WAAAAMD has joined #schooltool | 12:08 | |
| *** 13WAAAAMD is now known as aks | 12:47 | |
| *** aks has joined #schooltool | 12:47 | |
| *** menesis has joined #schooltool | 12:52 | |
| *** ignas has joined #schooltool | 13:10 | |
| *** aks has quit IRC | 13:28 | |
| *** menesis has quit IRC | 13:44 | |
| *** alga_ has quit IRC | 13:45 | |
| *** alga has joined #schooltool | 13:49 | |
| *** alga has quit IRC | 13:55 | |
| *** alga has joined #schooltool | 15:33 | |
| *** th1a has joined #schooltool | 16:14 | |
| *** menesis has joined #schooltool | 16:18 | |
| *** replaceafill has joined #schooltool | 16:19 | |
| th1a | hi aelkner, replaceafill, menesis. | 16:32 |
|---|---|---|
| replaceafill | good morning/afternoon | 16:32 |
| aelkner | morning | 16:33 |
| menesis | hi | 16:33 |
| th1a | Would you like to start replaceafill? | 16:33 |
| replaceafill | sure | 16:33 |
| replaceafill | last week i fixed a couple of bugs: | 16:33 |
| replaceafill | https://bugs.launchpad.net/schooltool.gradebook/+bug/913581 | 16:33 |
| replaceafill | wrote some instructions for Jean | 16:34 |
| replaceafill | seemed like they worked :) | 16:34 |
| th1a | Yes, good. | 16:35 |
| replaceafill | also fixed this: https://bugs.launchpad.net/schooltool/+bug/914609 | 16:35 |
| th1a | Will that cause a problem when he tries to upgrade? | 16:35 |
| replaceafill | th1a, i was wondering the same | 16:35 |
| th1a | I think it will. | 16:35 |
| replaceafill | menesis, if i modify a module in a deb package, will that prevent me from upgrading? | 16:35 |
| menesis | replaceafill: no. the file will be overwritten on next update | 16:36 |
| menesis | unless it is a config file in /etc | 16:36 |
| replaceafill | ah | 16:36 |
| replaceafill | like the warnings you get when you upgrade apache | 16:36 |
| replaceafill | well, i hope Jean doesn't have much trouble then | 16:37 |
| menesis | no. if the fix is merged it will be in next release so will have the same code | 16:37 |
| replaceafill | ok, i needed limited demographics to be available on edit for cambodia | 16:37 |
| replaceafill | so i fixed that | 16:38 |
| replaceafill | menesis, thanks for checking and merging the integer demographics fields change | 16:38 |
| replaceafill | i can take that out from cambodia too | 16:38 |
| th1a | I added a comment to that effect. | 16:38 |
| th1a | (to the bug) | 16:38 |
| replaceafill | th1a, on the cambodia side, i finally was able to move the code to use global levels | 16:39 |
| replaceafill | instead of year-by-year | 16:40 |
| replaceafill | now, i just have to finish "classes" | 16:40 |
| replaceafill | groups linked to sections | 16:40 |
| replaceafill | and create a global view /classes or something | 16:40 |
| replaceafill | like what we have for everything else | 16:40 |
| replaceafill | and now it's easier to find stuff | 16:41 |
| replaceafill | you don't have to dig in the hierarchy | 16:41 |
| replaceafill | i also checked this one: | 16:42 |
| replaceafill | https://bugs.launchpad.net/schooltool/+bug/916086 | 16:42 |
| replaceafill | it's the same problem we have with courses with non-unicode characters | 16:42 |
| replaceafill | and their cancel action in links | 16:43 |
| replaceafill | we need to encode those urls properly | 16:43 |
| replaceafill | i remember yvl told me to try the IDNA encoding or something like that | 16:43 |
| replaceafill | will try that later | 16:43 |
| th1a | OK. | 16:43 |
| menesis | maybe urls in request parameters can be avoided there.. | 16:44 |
| th1a | Indeed. | 16:44 |
| replaceafill | i'll investigate | 16:44 |
| replaceafill | that's it from me | 16:45 |
| replaceafill | btw, aelkner | 16:45 |
| replaceafill | check the project you assigned to your bugs | 16:45 |
| replaceafill | it's CanDo | 16:45 |
| replaceafill | by default, i mean | 16:46 |
| aelkner | why is that? | 16:46 |
| replaceafill | when you hit "report a new bug button" | 16:46 |
| replaceafill | you get a dropdown with the subprojects of schooltool-project | 16:46 |
| replaceafill | cando is the first alphabetically | 16:46 |
| aelkner | ah, i see | 16:46 |
| replaceafill | ok | 16:47 |
| * replaceafill done | 16:47 | |
| th1a | Do you think you can wrap up Cambodia by Wednesday? | 16:47 |
| replaceafill | th1a, yes | 16:47 |
| th1a | OK. I don't want it lingering forever. | 16:48 |
| replaceafill | got it, it will be done by wed | 16:48 |
| th1a | Anything to throw in, menesis? I know you're working on other projects. | 16:48 |
| menesis | no | 16:49 |
| menesis | reviewed some code and bugs | 16:49 |
| menesis | but haven't looked at aelkner's course worksheets branch yet | 16:49 |
| menesis | sorry | 16:50 |
| aelkner | well, i can merge it anyway, and you can look at it at your convenience | 16:50 |
| aelkner | i just don't want to have weeks worth of work diverge from trunk anymore | 16:50 |
| aelkner | especially if i need to do more work on trunk | 16:51 |
| th1a | At this point if replaceafill would merge it with his work you'd be pretty safe. | 16:51 |
| th1a | Since yvl is on vacation. | 16:51 |
| aelkner | menesis, how soon will you be able to look at it? | 16:52 |
| menesis | aelkner: soon | 16:52 |
| aelkner | ok, in the meantime, i can write some functional tests | 16:53 |
| menesis | maybe today | 16:53 |
| menesis | I will look next after the meeting | 16:53 |
| aelkner | ok, thanks | 16:54 |
| th1a | So where are you aelkner? | 16:55 |
| aelkner | i wanted to show you the empty message from the bug fx i did last week | 16:56 |
| menesis | aelkner: thank you for the bugs created that explain the features | 16:56 |
| aelkner | i'm loading the demo instance with data right now | 16:57 |
| aelkner | menesis, np, i will try to do more of that in the future | 16:57 |
| aelkner | the thing i need to do is even if th1a just says 'fix this' | 16:57 |
| aelkner | i need to create a lp bug and then add a ref to it in CHANGEStxt | 16:57 |
| aelkner | it is the best way for us to communicate with each other | 16:58 |
| aelkner | th1a, as teacher001 (teacher001): | 16:59 |
| aelkner | http://69.164.203.135:36660/schoolyears/2010-2011/2010-fall/sections/science_a_2010-fall_teacher001_000/activities/Worksheet/gradebook | 16:59 |
| aelkner | i know the font is maybe too big | 16:59 |
| aelkner | but it seemed to small to use the default | 16:59 |
| aelkner | also, any text changes? | 16:59 |
| aelkner | replaceafill, thanks for catching the conflict with the default | 17:00 |
| aelkner | i fixed that by applying the css class only to the elements that needed styling | 17:00 |
| replaceafill | sure, i'm using trunk in cambodia, so it's easy to see :) | 17:00 |
| th1a | Just use the default size. | 17:01 |
| th1a | Put the links on the sma line. | 17:01 |
| aelkner | so, after the : with no line break? | 17:02 |
| th1a | Yes. | 17:02 |
| aelkner | ok | 17:02 |
| th1a | Otherwise that seems fine. | 17:02 |
| replaceafill | why not "you can also <a ...>add a new worksheet</a>"? | 17:03 |
| replaceafill | without the "using this link" part | 17:03 |
| th1a | I'd probably do it replaceafill's way. | 17:03 |
| th1a | It is kind of a toss up. | 17:03 |
| replaceafill | like we do in empty schoolyears | 17:03 |
| aelkner | so, 'This section contains only <a ..>Worksheets</a> that are hidden | 17:04 |
| aelkner | then | 17:04 |
| aelkner | You could also <a ...>Add</a> a new worksheet | 17:04 |
| aelkner | periods included, of course | 17:04 |
| aelkner | th1a, what do you think? | 17:05 |
| aelkner | replaceafill, empty schoolyears, how do you mean, no schoolyears or a schoolyear that is empty? | 17:06 |
| th1a | I think it is ok as is because it is kind of a confusing situation for the user. | 17:06 |
| replaceafill | aelkner, no schoolyears | 17:06 |
| th1a | So being a little more pedantic than usual is not a bad idea. | 17:06 |
| aelkner | ok th1a | 17:06 |
| aelkner | i'll show you in a minute the change | 17:06 |
| aelkner | replaceafill, can you help me get started with flourish functional tests after the meeting? | 17:07 |
| replaceafill | hhmm | 17:07 |
| aelkner | i believe you are the only one who wrote any, right? | 17:07 |
| replaceafill | i advise you not to write them yet | 17:07 |
| th1a | If not now when? | 17:07 |
| replaceafill | or no, maybe you should :) | 17:07 |
| aelkner | :) | 17:07 |
| replaceafill | here's the thing | 17:08 |
| replaceafill | let me get the bug | 17:08 |
| replaceafill | https://bugs.launchpad.net/schooltool/+bug/893186 | 17:08 |
| replaceafill | to me, the runner it's too unstable | 17:08 |
| aelkner | ok, i can wait for you to sort that out first | 17:09 |
| replaceafill | you can try and report if you find the same issues | 17:10 |
| th1a | Yes, it seems like those are somewhat isolated issues. | 17:10 |
| aelkner | i can avoid datepicker | 17:10 |
| replaceafill | hhmm how? | 17:10 |
| th1a | I think aelkner should get started and we'll fix some things as we go. | 17:10 |
| aelkner | oh, i don't know, can't i? | 17:10 |
| replaceafill | aelkner, i mean, you need to set up schoolyears and terms, right? | 17:11 |
| aelkner | is even setting up a schoolyear not possible? | 17:11 |
| aelkner | ok, so tests can't be written just yet | 17:11 |
| aelkner | replaceafill, but you'll look into this right away? | 17:11 |
| replaceafill | aelkner, yvl will fix this | 17:12 |
| replaceafill | not me | 17:12 |
| aelkner | do we know how soon he will be able to? | 17:12 |
| th1a | Why can't you just enter dates into the field? | 17:13 |
| replaceafill | i dont | 17:13 |
| replaceafill | th1a, the datepicker blocks the buttons | 17:13 |
| replaceafill | and the test fails | 17:13 |
| th1a | But it doesn't in real life? | 17:13 |
| replaceafill | no | 17:14 |
| replaceafill | because we're slow enough :) | 17:14 |
| replaceafill | but selenium isn't | 17:14 |
| th1a | OK... this probably shouldn't be one big bug report. | 17:14 |
| th1a | btw. | 17:14 |
| th1a | All right then... | 17:15 |
| * replaceafill was expecting something from th1a after btw :D | 17:16 | |
| * aelkner too | 17:16 | |
| th1a | That was modifying the previous sentence. ;-) | 17:16 |
| replaceafill | ah | 17:16 |
| replaceafill | th1a, well, the bug report was just a reminder yvl asked me to write | 17:17 |
| aelkner | it's a good bug report because the problem is that big | 17:17 |
| th1a | It is no big deal, but it doesn't really communicate the severity of the situation to me. | 17:17 |
| replaceafill | th1a, ah, got it | 17:17 |
| th1a | It seems to be that it is 2/3rds very severe. | 17:18 |
| aelkner | Selenium test runner issues could be changed to Selenium tests don't run | 17:18 |
| th1a | Since we can't write any functional tests. | 17:18 |
| th1a | Anyhow, I told yvl to work on other equally important stuff, so it isn't a huge deal. | 17:18 |
| replaceafill | yvl said he would jump into this one after he finishes the relationships views | 17:18 |
| th1a | (as signified by "btw") ;-) | 17:18 |
| replaceafill | :D | 17:19 |
| th1a | I think we're fine. | 17:19 |
| replaceafill | btw, i requested the khmer translation to be included in jquery core: https://github.com/jquery/jquery-ui/pull/568 | 17:20 |
| replaceafill | so, it lands in the jquery debs someday | 17:20 |
| th1a | Excellent. | 17:20 |
| th1a | Thanks replaceafill. | 17:21 |
| th1a | OK, so we need something for aelkner to do? | 17:22 |
| aelkner | there are two things that i have on my plate | 17:24 |
| aelkner | ok, just one | 17:24 |
| aelkner | do more manual testing of report/course sheets | 17:24 |
| aelkner | it seems that i can't hide them at the moment, something that wasn't true just before | 17:24 |
| aelkner | i just was able to hide things before, so this is strange | 17:25 |
| th1a | OK, do that. | 17:25 |
| th1a | And? | 17:25 |
| aelkner | but besides figuring that out, i could use more bug prioritization | 17:25 |
| aelkner | th1a, perhaps we could go over my list after the meeting? | 17:26 |
| th1a | OK. | 17:26 |
| th1a | We need to shift to transcripts soon, so we may just do that. | 17:27 |
| th1a | So, have a good week gentlemen, and | 17:27 |
| * th1a drops the bag of gravel. | 17:28 | |
| aelkner | thanks guys | 17:28 |
| aelkner | th1a, http://69.164.203.135:36660/schoolyears/2010-2011/2010-fall/sections/science_a_2010-fall_teacher001_000/activities/Worksheet/gradebook | 17:28 |
| aelkner | refresh your css with shit ctrl r | 17:28 |
| aelkner | i still have the 10px padding style there, is that wrong? | 17:29 |
| th1a | aelkner, We have defaults which you should always use by default. | 17:31 |
| th1a | I just made a bunch of small gradebook bugs critical for you. | 17:31 |
| th1a | Do those first. | 17:31 |
| aelkner | th1a, try cltr shift r again, i got rid of the padding so that it uses all the default styles | 17:33 |
| aelkner | how does that look to you:? | 17:33 |
| th1a | Probably we should wrap it in a warning thing. | 17:34 |
| aelkner | warning thing? | 17:35 |
| aelkner | replaceafill, do you know what th1a means? | 17:35 |
| replaceafill | aelkner, hhmm no | 17:35 |
| th1a | Don't we have a red warning box style? | 17:35 |
| replaceafill | for form errors | 17:36 |
| aelkner | replaceafill, can you follow the link and ctrl shift r please | 17:36 |
| replaceafill | aelkner, ok | 17:36 |
| th1a | We could use that. | 17:36 |
| aelkner | use what? | 17:37 |
| replaceafill | aelkner, when you get an error in a form, you get the "please correct the errors below" message | 17:37 |
| replaceafill | at the top of the form | 17:37 |
| aelkner | class="warning"? | 17:37 |
| th1a | It isn't an error in the form. | 17:38 |
| th1a | It is just a question of using existing styles instead of custom ones if possible. | 17:38 |
| th1a | Using any custom style at all is a last resort. | 17:38 |
| aelkner | replaceafill, your styles are dependent on element containment, right? | 17:39 |
| replaceafill | aelkner, yes | 17:39 |
| aelkner | so i need to move the div back into the form | 17:39 |
| aelkner | class="status" | 17:39 |
| aelkner | and then the <span> within that, right? | 17:40 |
| replaceafill | yes | 17:40 |
| replaceafill | or you can modify the rule | 17:40 |
| replaceafill | although i don't know how good link will look in red | 17:40 |
| replaceafill | *links | 17:41 |
| aelkner | and i just made the form itself dependent on all_hidden :( | 17:41 |
| aelkner | replaceafill, if i modify rules, there's no telling whether i'll break something that i didn't even know i broke | 17:42 |
| aelkner | like what you caught late last week | 17:42 |
| th1a | Can you just make it style like regular content? | 17:42 |
| th1a | That would be fine. | 17:42 |
| aelkner | let me try putting the empty message in it's own form and divs to see what happens | 17:44 |
| aelkner | replaceafill, could you look at this with me please | 17:46 |
| replaceafill | ok | 17:46 |
| aelkner | do i need form, div class="gradebook", span? | 17:46 |
| aelkner | f_gradebook.css has lots of table rules | 17:47 |
| replaceafill | let me check | 17:47 |
| aelkner | do i need to put a table in my gradebook div? | 17:47 |
| replaceafill | aelkner, those table rules are for the score system form | 17:47 |
| th1a | I guess the only reason I'm dragging this out is that it seems to me you should be able to style it like a regular content area pretty easily. | 17:48 |
| th1a | I would think it wouldn't need to be styled like a gradebook at all. | 17:49 |
| aelkner | replaceafill, is it possible to not even need the form element? | 17:49 |
| th1a | It isn't a form. | 17:50 |
| aelkner | i know, i'm just assuming that the styles are based on form elements | 17:50 |
| th1a | Just style it like regular content and I'll shut up. | 17:51 |
| replaceafill | aelkner, the warning box is used only in forms so far | 17:52 |
| aelkner | replaceafill, do we have such a concept, regular content | 17:52 |
| aelkner | aren't most of the styles based on a set of possible element heirarchies? | 17:52 |
| th1a | I threw the whole damn thing off bringing up the warning box. | 17:52 |
| replaceafill | :D | 17:52 |
| aelkner | replaceafill, if you could point me to the style that i need, i can create the needed elements | 17:53 |
| replaceafill | aelkner, ok | 17:53 |
| replaceafill | aelkner, check a course with no leaders | 17:54 |
| replaceafill | http://69.164.203.135:6660/schoolyears/2011-2012/courses/goobers | 17:54 |
| replaceafill | This course has no responsible parties | 17:54 |
| replaceafill | i think that's regular content | 17:54 |
| replaceafill | a regular p | 17:54 |
| replaceafill | i mean, <p> | 17:54 |
| aelkner | and <h3> including a <p>, right? | 17:55 |
| aelkner | an <h3>, i mean | 17:55 |
| replaceafill | no | 17:55 |
| replaceafill | just a p | 17:55 |
| replaceafill | content > body > p | 17:55 |
| replaceafill | no h3 as container | 17:55 |
| aelkner | oh, the h3 is not inclouding it, i'm seeing things | 17:56 |
| replaceafill | aelkner, i think your <p> seems strange just because the gradebook has 0 padding | 17:56 |
| aelkner | i can move the div outside of the div class="schooltool.gradebook" | 17:57 |
| aelkner | at the very top | 17:57 |
| replaceafill | or you could add the 16px padding to it | 17:58 |
| th1a | I could have suggested that and saved a half hour. | 17:58 |
| th1a | But can't we just make it not styled like a gradebook at all? | 17:58 |
| aelkner | th1a is trying to get us to use less custom css, and i agree | 17:59 |
| aelkner | out rules should work universally | 17:59 |
| replaceafill | ok, move out from the gradebook style then | 17:59 |
| aelkner | replaceafill, check out the link again: | 18:01 |
| aelkner | http://69.164.203.135:36660/schoolyears/2010-2011/2010-fall/sections/science_a_2010-fall_teacher001_000/activities/Worksheet/gradebook | 18:01 |
| replaceafill | ok, im on it | 18:02 |
| replaceafill | you're still using the gradebook styles: grid for page_class | 18:02 |
| aelkner | my <p> is now in main > content > body | 18:03 |
| replaceafill | that's fine | 18:03 |
| replaceafill | but you're page class is applying 0 padding | 18:03 |
| aelkner | where? | 18:03 |
| replaceafill | look for the class="page grid" container | 18:04 |
| replaceafill | look at how it looks after i take the "grid" class out: http://img100.imageshack.us/img100/644/pantallazodel2012011610.png | 18:05 |
| aelkner | damn, that's determined at the view class level | 18:05 |
| replaceafill | you can make it dynamic | 18:05 |
| replaceafill | if not empty: 'page grid' else 'page' | 18:06 |
| aelkner | trying now | 18:08 |
| aelkner | replaceafill, try the demo link again | 18:11 |
| aelkner | it seems we've lost some padding above | 18:11 |
| replaceafill | it's because you need a title in the view | 18:11 |
| replaceafill | regular views use it | 18:11 |
| aelkner | this is not a regular view | 18:12 |
| aelkner | there is no title on purpose | 18:12 |
| th1a | There could be a title. | 18:12 |
| replaceafill | then you can't use "regular" styles, right? | 18:12 |
| aelkner | i don't know, if you say so | 18:12 |
| aelkner | is there a small fix i can make to what i have loaded on the demo"? | 18:13 |
| th1a | Title "No Visible Worksheets" | 18:13 |
| aelkner | you mean change the view class in the same manner as with the page_class? | 18:15 |
| aelkner | title property, conditional on all_hidden? | 18:15 |
| th1a | I'm just saying, if the problem is there is no title, can't you add a title? | 18:15 |
| replaceafill | correct | 18:15 |
| aelkner | replaceafill, the gradebook already has a title, 'Enter Grades', but it doesn't render | 18:19 |
| replaceafill | aelkner, do you have has_header set to True? | 18:19 |
| aelkner | ah, yes, that needs to be conditional | 18:21 |
| replaceafill | yep | 18:21 |
| aelkner | replaceafill, th1a, check out the demo: | 18:24 |
| aelkner | http://69.164.203.135:36660/schoolyears/2010-2011/2010-fall/sections/science_a_2010-fall_teacher001_000/activities/Worksheet/gradebook | 18:24 |
| aelkner | switch to a different section to see the difference | 18:24 |
| replaceafill | that looks more like a "regular" view ;) | 18:25 |
| th1a | OK, that's fine. | 18:25 |
| th1a | Our work is done. ;-) | 18:25 |
| aelkner | ok, cool, glad that's behind me | 18:25 |
| aelkner | thanks guys | 18:25 |
| th1a | Hopefully you learned some useful things... | 18:25 |
| replaceafill | next task is to make those dialogs :P | 18:25 |
| replaceafill | good job aelkner | 18:26 |
| aelkner | thanks to your help regarding changing view attributes | 18:26 |
| th1a | http://www.arlingtonva.us/Departments/ParksRecreation/scripts/planning/powhatan/ParksRecreationScriptsPowhatanSkatepark.aspx | 18:47 |
| aelkner | menesis, thanks for the merge! | 18:55 |
| *** alga has quit IRC | 20:11 | |
| *** th1a has quit IRC | 20:18 | |
| *** menesis has quit IRC | 20:31 | |
| *** th1a has joined #schooltool | 20:44 | |
| *** ignas has quit IRC | 21:05 | |
| *** alga has joined #schooltool | 21:10 | |
| *** replaceafill has quit IRC | 21:31 | |
| *** menesis has joined #schooltool | 21:50 | |
| *** th1a has quit IRC | 21:52 | |
| *** th1a has joined #schooltool | 22:24 | |
| *** replaceafill has joined #schooltool | 22:24 | |
| *** th1a has quit IRC | 23:54 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!
