| jelkner | replaceafill, fixes worked! | 01:01 |
|---|---|---|
| *** alga has quit IRC | 01:13 | |
| *** jelkner has quit IRC | 02:06 | |
| *** aelkner has quit IRC | 03:52 | |
| *** replaceafill has quit IRC | 03:58 | |
| *** aelkner has joined #schooltool | 04:06 | |
| *** aks has joined #schooltool | 06:12 | |
| *** aks has joined #schooltool | 06:12 | |
| *** alga has joined #schooltool | 10:01 | |
| *** menesis has quit IRC | 10:14 | |
| *** menesis has joined #schooltool | 10:16 | |
| *** menesis has quit IRC | 11:32 | |
| *** aks has quit IRC | 11:59 | |
| *** aks has joined #schooltool | 11:59 | |
| *** Guest47596 is now known as issyl0 | 12:14 | |
| *** issyl0 has quit IRC | 12:14 | |
| *** issyl0 has joined #schooltool | 12:14 | |
| *** yvl has quit IRC | 12:35 | |
| *** yvl has joined #schooltool | 12:47 | |
| *** menesis has joined #schooltool | 13:49 | |
| *** menesis has quit IRC | 14:01 | |
| *** menesis has joined #schooltool | 14:09 | |
| *** aks has quit IRC | 14:21 | |
| *** menesis has quit IRC | 14:33 | |
| *** menesis has joined #schooltool | 14:39 | |
| *** menesis has quit IRC | 14:48 | |
| *** menesis has joined #schooltool | 14:53 | |
| *** replaceafill has joined #schooltool | 16:03 | |
| th1a | hi replaceafill, menesis, yvl, aelkner. | 16:30 |
| yvl | good morning! :) | 16:30 |
| menesis | hi | 16:30 |
| replaceafill | good morning/afternoon | 16:30 |
| aelkner | morning | 16:31 |
| th1a | Are you guys getting emails when Vinny and I make comments on Basecamp? | 16:31 |
| replaceafill | i do, i suscribed to the message thread in the base camp | 16:31 |
| th1a | Ah. | 16:32 |
| th1a | Can you guys see this? | 16:32 |
| th1a | http://www.schwadesign.com/basecamp/2591274/2682003phase1/schooltool_mockup_tealnav.png | 16:32 |
| yvl | subscribing... | 16:32 |
| aelkner | i know this is not helpful, but i like the red better (: | 16:33 |
| aelkner | i know red=danger and all, but i guess i'm used to it | 16:33 |
| th1a | I'm becoming used to teal. | 16:34 |
| th1a | Now that we're getting it dark enough. | 16:34 |
| aelkner | i was going to say it would be better lighter, but there i go again not being helpful | 16:35 |
| aelkner | the dark teal seems ominous to me, similar to red=danger | 16:35 |
| th1a | Maybe the Eagles lost to the Dolphins too many times? | 16:35 |
| th1a | I think the logo looks better against the dark background than white. | 16:36 |
| th1a | Any other comments? | 16:36 |
| aelkner | ok, i just pulled up the person form to compare, and the tela is uch better than all that red | 16:36 |
| th1a | btw, I'm not planning on changing our navigation. | 16:37 |
| th1a | I don't think the years would make sense where Vinny has the subnav. | 16:37 |
| yvl | phew :) | 16:38 |
| aelkner | yay | 16:38 |
| yvl | thanks, Tom | 16:38 |
| th1a | I don't think he's really aware of what our "subnav" actually is. | 16:38 |
| th1a | Yeah, we're just talking color here. | 16:38 |
| aelkner | he may be thinking breadcrumbs? | 16:38 |
| th1a | No... | 16:38 |
| aelkner | oh, right, that's at the right | 16:39 |
| aelkner | having both on one like is better for screen real estate, but the years tabs we have are nice | 16:39 |
| th1a | It would me more like if you did "School" and then chose "Persons" "Sections" etc. from the subnav. | 16:39 |
| th1a | Years makes more sense in a tabby way. | 16:40 |
| * yvl wonders if the blueish gray could be changed to some warmer gray | 16:40 | |
| th1a | Well... | 16:40 |
| th1a | I think the gray is what is pulling it together for me. | 16:40 |
| th1a | But basically replaceafill and I have to try installing this later today. | 16:41 |
| yvl | right | 16:41 |
| th1a | Also, I finally remembered how we're supposed to be doing the CSS. | 16:41 |
| yvl | and I was purely wondering if warm gray would work in this context | 16:41 |
| th1a | We just need a final style sheet which just has slots for the colors we or other people want to customize. | 16:42 |
| th1a | The relevant ones. | 16:42 |
| th1a | yvl craves warmth. | 16:43 |
| th1a | Do you see what I mean, replaceafill? | 16:43 |
| replaceafill | th1a you mean slots like the "variables" you were mentioning? | 16:43 |
| th1a | Just a style sheet. | 16:44 |
| th1a | In this case. | 16:44 |
| replaceafill | or just put all the colors in a single stylesheet? | 16:44 |
| th1a | Just one style sheet I could go to if I wanted to change the interface colors only. | 16:44 |
| replaceafill | got it | 16:44 |
| th1a | Nothing magical. | 16:44 |
| th1a | But then we can also point users to just one file to customize. | 16:45 |
| th1a | OK, let's hear from yvl and menesis and then discuss contacts import with aelkner. | 16:45 |
| yvl | (darkened http://en.wikipedia.org/wiki/Olive_gray#Pistachio :) ) | 16:46 |
| yvl | ok | 16:46 |
| yvl | so, some good progress on the selenium layer | 16:46 |
| yvl | still stuff to do, but I'm pretty happy the way it's turning out | 16:46 |
| replaceafill | yvl i had a question: are we going to keep using doctests for ftests? | 16:47 |
| yvl | I think so | 16:47 |
| yvl | do you have a preference? | 16:47 |
| replaceafill | with >>> and all | 16:47 |
| th1a | Will I still be able to run the tests on an individual module? | 16:47 |
| yvl | maybe :) | 16:48 |
| replaceafill | yvl not really | 16:48 |
| yvl | It's a really good time to bring some input | 16:48 |
| yvl | if you have stuff you dislike about ftests, please voice it! | 16:48 |
| aelkner | i just hope that we can still do what we always have been able to do | 16:49 |
| yvl | apart from the fact that they're slow. | 16:49 |
| yvl | we will | 16:49 |
| yvl | + some extras | 16:49 |
| yvl | like, if you run the tests with -D (debug) flag | 16:49 |
| yvl | and the test fails | 16:49 |
| yvl | test runner will halt, as usual | 16:49 |
| yvl | and leave you with basically the same effect that browser.serve had | 16:50 |
| aelkner | that will be nice | 16:50 |
| yvl | I think we'll end up doing more TDD actually | 16:50 |
| yvl | the reason being, that func tests do start up way faster than the full-blown zope server | 16:50 |
| yvl | so it's just easier: | 16:51 |
| yvl | when developing a form or something | 16:51 |
| yvl | write a one-line test that fails for it | 16:51 |
| aelkner | amen | 16:51 |
| yvl | run it, you'll end up with a open browser | 16:51 |
| yvl | click around, implement some things | 16:52 |
| yvl | run the test again | 16:52 |
| yvl | when something starts working the way it should - fill in the test | 16:52 |
| yvl | I guess you probably were doing something like that already | 16:52 |
| replaceafill | why is it faster than starting the server? | 16:53 |
| yvl | less payload | 16:53 |
| yvl | in-mem DB | 16:53 |
| aelkner | so if a test fails, you see the failure diff AND the serve() thing if -D specified? | 16:53 |
| yvl | only functional scope you need | 16:53 |
| yvl | yes, aelkner | 16:53 |
| aelkner | that's very helpful | 16:53 |
| yvl | a drawback of that | 16:54 |
| replaceafill | yvl you mean, like unnecessary packages are not loaded? | 16:54 |
| yvl | yes, replaceafill - we do have functional.zcml that limits the scope somewhat | 16:54 |
| replaceafill | yvl yes, i was thinking the same | 16:54 |
| replaceafill | (about we having ftesting.zcml) | 16:54 |
| yvl | also - DemoStorage is somewhat faster than actual thing in the file system | 16:54 |
| yvl | ok, so I'll survey you about your dev habits later on | 16:55 |
| yvl | preferred browser, tools and so on | 16:55 |
| yvl | th1a, with much pain I have to ask you to timebox me | 16:55 |
| yvl | so I don't get carried away | 16:56 |
| th1a | End of next week? | 16:56 |
| yvl | ok | 16:56 |
| yvl | thanks, I needed that :) | 16:56 |
| th1a | No problem. | 16:56 |
| replaceafill | yvl it would be nice to have it ready to use soon, so we can test it | 16:56 |
| replaceafill | even if it's still rough :) | 16:56 |
| th1a | I'm always available to pull an arbitrary date from the air. | 16:56 |
| yvl | :) | 16:57 |
| yvl | that helps a lot! | 16:57 |
| yvl | so I'll give you guys something Monday | 16:57 |
| aelkner | :) | 16:57 |
| replaceafill | yvl great | 16:57 |
| yvl | oh, and a nice thing on screenshots | 16:57 |
| th1a | I don't want it to take longer than that though -- it is only arbitrary in terms of knowing what you're actually doing technically. | 16:57 |
| yvl | FFox does screenshot the whole page | 16:57 |
| aelkner | but we still are going to get bin/test to pass for the old skin tests, right? | 16:57 |
| yvl | understood Tom | 16:58 |
| yvl | yes aelkner | 16:58 |
| th1a | If you can integrate this with my book screenshot generation, that'd be cool. | 16:58 |
| yvl | that's the plan, th1a | 16:58 |
| th1a | Cool. | 16:58 |
| yvl | I think we may even end up with stuff like | 16:58 |
| yvl | screenshot of this dialog there | 16:58 |
| yvl | or screenshot of that table here | 16:59 |
| yvl | but we'll see | 16:59 |
| yvl | ok | 16:59 |
| * yvl done :) | 16:59 | |
| th1a | Thanks. | 16:59 |
| th1a | menesis? | 17:00 |
| menesis | I have been doing merges and releases yesterday | 17:00 |
| menesis | released schooltool 1.6.1, then schooltool 1.7.0 from trunk | 17:00 |
| menesis | retargeted bugs that were assigned to those milestones | 17:01 |
| menesis | and other stuff on launchpad | 17:01 |
| menesis | merged all this to flourish branch | 17:01 |
| menesis | was fixing some problems on flourish | 17:02 |
| menesis | including datetimewidget issues that I introduced two days ago | 17:02 |
| menesis | so I am finished with merging everything to flourish | 17:04 |
| menesis | and can do a release | 17:04 |
| menesis | was solving problems with flourish-gradebook resourcelibrary | 17:04 |
| th1a | Great. So maybe in Oneiric tomorrow? | 17:05 |
| menesis | tried running an old skin from flourish branch | 17:05 |
| menesis | found some problems with gradebok and journal, fixed. not played too much. | 17:06 |
| menesis | Oneiric Beta2 freeze is tonight | 17:06 |
| aelkner | menesis, did you solve the gradebook functional test issues? | 17:06 |
| aelkner | the resourselibrary thing, i mean | 17:07 |
| th1a | menesis: Is there any chance we can get in beta2? | 17:07 |
| th1a | (the fixes, that is) | 17:07 |
| menesis | aelkner: I had to add a meta feature "schooltool.skin.flourish" and conditionally include flourish.zcml from gradebook/configure.zcml | 17:08 |
| menesis | th1a: what fixes? | 17:08 |
| aelkner | menesis, i don't see anything new in gradebook trunk, still working in your own branch? | 17:09 |
| th1a | I guess the "fixes" are the package changes that let SchoolTool run at all in Oneiric. | 17:10 |
| menesis | aelkner: not committed yet | 17:10 |
| menesis | th1a: yes having the freeze in mind I made a release from trunk | 17:10 |
| menesis | and fixed other packages that prevented schooltool from starting | 17:10 |
| th1a | OK. | 17:10 |
| aelkner | yvl, regarding the note you sent me, i guess menesis is on that one | 17:11 |
| menesis | am still fixing other package issues today | 17:11 |
| yvl | ah, ok aelkner | 17:11 |
| aelkner | yvl, menesis, could you guys make sure to let us know when that is resolved in trunk? | 17:12 |
| th1a | Should aelkner be subscribed to something in LP? | 17:13 |
| menesis | aelkner: done | 17:14 |
| menesis | but need latest schooltool/flourish | 17:14 |
| aelkner | menesis, thanks | 17:16 |
| th1a | Anything else, menesis? | 17:17 |
| menesis | updated http://book.schooltool.org/fedora.html | 17:17 |
| menesis | while adding release notes | 17:17 |
| th1a | Thanks. | 17:18 |
| menesis | will continue with packages/launchpad today | 17:18 |
| menesis | and see what else do I need in flourish to make a release | 17:18 |
| menesis | of course if more tests were passing that would be more reassuring | 17:19 |
| th1a | Of course. | 17:20 |
| menesis | I noticed two things missing in flourish | 17:20 |
| menesis | Cancel school in emergency | 17:20 |
| menesis | and | 17:20 |
| menesis | Book resources | 17:20 |
| menesis | hmm. | 17:20 |
| aelkner | yvl, ok, i merged with menesis fixes, but timetables still making gradebook tests fail | 17:21 |
| th1a | emergency days are still there. | 17:22 |
| th1a | yvl: Book resources? | 17:22 |
| yvl | menesis, you meant - book resources in old skin? | 17:22 |
| menesis | in import sections | 17:22 |
| menesis | from xls | 17:22 |
| menesis | I saw some code removed | 17:23 |
| yvl | ah | 17:23 |
| yvl | yes, that one is removed | 17:23 |
| aelkner | menesis, xls import is not different in flourish | 17:23 |
| yvl | "importing section resources" | 17:23 |
| yvl | or location, to be more precise | 17:23 |
| aelkner | if that's gone in flourish, it's gone in old skin, too | 17:23 |
| yvl | yes | 17:24 |
| menesis | ok maybe that's ok | 17:24 |
| th1a | Wait, what? | 17:24 |
| th1a | Booking resources for a section? | 17:24 |
| menesis | in section view, resources was always blank | 17:24 |
| menesis | and edit resources link was removed a year ago or so | 17:25 |
| th1a | Oh, yes, it didn't work. | 17:25 |
| th1a | Correct? | 17:25 |
| yvl | yes | 17:25 |
| menesis | didn't | 17:25 |
| th1a | Just for the record, this was removed because it didn't actually work, but we would like it to work. | 17:25 |
| menesis | understood | 17:25 |
| th1a | kk | 17:26 |
| * menesis finished | 17:26 | |
| * yvl +1 for reimplementing that feature at some point | 17:27 | |
| th1a | Thanks menesis. | 17:27 |
| th1a | replaceafill? | 17:27 |
| replaceafill | ok | 17:27 |
| replaceafill | i fixed the journal bug that was doubling absences for consecutive periods | 17:27 |
| replaceafill | and added "Sort by" options to the section journal | 17:28 |
| replaceafill | student, "activities" and "totals", like in the gradebook | 17:28 |
| replaceafill | i'm adding a "reverse" order option now, but i noticed that we don't mark the option | 17:28 |
| replaceafill | i mean | 17:29 |
| replaceafill | if i sort by Student | 17:29 |
| replaceafill | the option still says "Sort by" | 17:29 |
| replaceafill | not a big deal, just a comment | 17:29 |
| replaceafill | also, i fixed a problem with the password validator in the person add form | 17:29 |
| replaceafill | and tracked down the birth date widget issue reported by jelkner, which menesis already fixed, thanks menesis | 17:30 |
| th1a | Ah. | 17:30 |
| replaceafill | i guess that's it from me | 17:31 |
| replaceafill | still have small things in my TODO | 17:31 |
| replaceafill | like: Selection List Fields in person/resource demographics should be rendered as optional. Currently they're set with the first option selected | 17:31 |
| th1a | OK. We'll talk CSS after the meeting. | 17:32 |
| replaceafill | th1a ah ok | 17:32 |
| th1a | And other small things. | 17:32 |
| th1a | Thanks replaceafill. | 17:32 |
| th1a | aelkner, did you consider doing contact creation and contact linking as two separate sheets? | 17:33 |
| aelkner | uh, no, i ddn't consider it because i don't see how that would be | 17:34 |
| aelkner | i laid out the scenarios in my email | 17:34 |
| th1a | One sheet to add the contacts. | 17:34 |
| th1a | Another sheet specifying the relationship between persons and contacts (or other persons) | 17:35 |
| aelkner | not specific, so no meaning to me | 17:35 |
| th1a | One sheet adds contacts. | 17:35 |
| aelkner | how? | 17:35 |
| th1a | Creates the objects. | 17:35 |
| th1a | Another links them. | 17:35 |
| aelkner | how? | 17:36 |
| aelkner | you need things to have keys to link them | 17:36 |
| aelkner | contacts don't have keys | 17:36 |
| aelkner | they just exist with silly __name__ attributes that have no meaning | 17:36 |
| aelkner | actually, i still have the issue of how to reimport contacts when there is no key for them | 17:37 |
| aelkner | yvl, what are your thoughts for starters on the table i defined in the email i sent? | 17:37 |
| yvl | pretty good | 17:37 |
| yvl | I think importer should ignore the namechooser and have an optional column for __name__ | 17:37 |
| yvl | for contact reimporting | 17:37 |
| aelkner | ah, good | 17:38 |
| yvl | contact linking can be done in a separate sheet if there's a point in that | 17:38 |
| aelkner | i was going to say that the __name__ of all the other sheets makes reimporting possible | 17:38 |
| * yvl just can't think of a reason right now | 17:38 | |
| * aelkner neither | 17:39 | |
| th1a | Where do contacts live? | 17:39 |
| yvl | unbound contacts - in a global container | 17:39 |
| yvl | bound - in person annotations I think | 17:39 |
| yvl | catalogs mash them up | 17:39 |
| th1a | Perhaps aelkner didn't read my last comment on Wednesday: | 17:40 |
| th1a | th1aaelkner: In terms of linking contacts, basically what yvl has above should work.18:28 | 17:40 |
| th1a | th1aBut we might also have to let the user set the contact ID's from the spreadsheet.18:28 | 17:40 |
| th1a | th1aAnd they may have to specify whether the contact is a contact or person so the ID's don't collide. | 17:40 |
| aelkner | btw, there is no way to establish the relationship type for bound contacts | 17:41 |
| yvl | ? | 17:41 |
| yvl | how come, aelkner? | 17:41 |
| aelkner | if you choose a teacher for a contact of a student, you can't specify whether that teacher is a parent | 17:41 |
| aelkner | look in the old skin, relationship is always blank in those cases | 17:41 |
| th1a | So... that's a bug? | 17:42 |
| aelkner | that's a question on my part, i don't know if it's a bug? | 17:42 |
| yvl | if aelkner is correct, then yes, a bug! | 17:42 |
| th1a | BUg. | 17:42 |
| th1a | Do you see why it happens in code? | 17:43 |
| aelkner | yes, because the way bound contact is implemented is different from user contacts | 17:43 |
| th1a | When importing I don't see any reason not to just make unbound contacts, btw. | 17:43 |
| th1a | Well, what is the difference between bound and unbound? | 17:44 |
| yvl | bound has a user in ST | 17:44 |
| th1a | A "self" contact. | 17:44 |
| yvl | and shares name and something else | 17:44 |
| yvl | yes | 17:44 |
| aelkner | there are three cases | 17:44 |
| yvl | and you can specify if a teacher is a parent | 17:44 |
| aelkner | bound to self, bound to other person, unbound | 17:44 |
| yvl | (just checked) | 17:44 |
| yvl | it's not bound to self | 17:45 |
| aelkner | yvl, in the contacts form? | 17:45 |
| * replaceafill checked too and it's possible | 17:45 | |
| aelkner | where in the UI? | 17:45 |
| yvl | that form adds "contact" contacts | 17:45 |
| yvl | you need to edit to specify a relationship | 17:45 |
| yvl | same happens if you add a simple unbound contact there | 17:45 |
| yvl | with the + button | 17:45 |
| yvl | in the system, there are Contact objects and BoundContact objects | 17:46 |
| th1a | With the current spreadsheet can I use the same contact with multiple students? | 17:46 |
| yvl | latter shares name, etc. with the BasicPerson | 17:46 |
| th1a | That's very common since multiple students often have the same parents. | 17:47 |
| yvl | oh, it seems no | 17:49 |
| th1a | That's my practical concern. | 17:49 |
| aelkner | yvl, please explain how to edit contact | 17:50 |
| aelkner | the UI only seems to suppost adding/removing | 17:50 |
| aelkner | i just added a teacher as a contact for a student | 17:50 |
| yvl | Person -> Manage Contacts -> click on added contact -> click edit icon | 17:50 |
| aelkner | yvl, please do this right now in UI | 17:50 |
| aelkner | add a teacher as contact of a student | 17:51 |
| th1a | flourish? | 17:51 |
| aelkner | it doesn't matter | 17:51 |
| aelkner | either way | 17:51 |
| yvl | ok | 17:51 |
| yvl | done | 17:51 |
| replaceafill | aelkner http://69.164.203.135:7777/persons/camila/contact | 17:51 |
| yvl | it's now in current contacts | 17:51 |
| aelkner | what does that mean, the url that replaceafill just posed | 17:52 |
| aelkner | posted | 17:52 |
| aelkner | jelkner is a teacher | 17:52 |
| replaceafill | yes | 17:52 |
| aelkner | and if you go to edit that contact, you can fill in the address | 17:52 |
| replaceafill | and the relationship is at the end | 17:52 |
| aelkner | so if jelkner is a contact of a different student | 17:52 |
| aelkner | what happens then? | 17:52 |
| replaceafill | http://69.164.203.135:7777/persons/jeffrey/contact | 17:53 |
| aelkner | ah, i see, jelkners contact info is editable from that form | 17:54 |
| aelkner | and the changes apply to all cases of links to jelkner | 17:54 |
| aelkner | that's not exactly obvious from the form, but... | 17:54 |
| aelkner | in other words | 17:55 |
| yvl | aelkner: http://69.164.203.135:38000/persons/student190/contact/edit.html | 17:55 |
| aelkner | ok, so i begin to see what th1a was saying | 17:56 |
| yvl | cool | 17:56 |
| aelkner | if jelkner's contact info was fixable in one place | 17:56 |
| aelkner | and the lnkage/relationship was established in another | 17:56 |
| aelkner | only problem is how to define the linkage | 17:57 |
| aelkner | the __name__ of an unbound contact like a non-user parent could be required of the user | 17:57 |
| aelkner | but then there's the case of linking to a teacher | 17:57 |
| aelkner | would we use the user id in that case? | 17:57 |
| th1a | You just need a field to specify if you're linking to a person or a contact. | 17:58 |
| aelkner | interesting if we force the user to come up with __name__ of non-user parents | 17:58 |
| aelkner | kind of like coming up with a user id in a way | 17:58 |
| yvl | call it ID | 17:59 |
| yvl | for re-importing | 17:59 |
| aelkner | th1a, are you cool with the user having to create ids for non-user parents | 17:59 |
| aelkner | and we would have to make sure they were not identical to user ids that already exist?! | 18:00 |
| th1a | Yes. | 18:00 |
| yvl | no, we would not need to make sure | 18:00 |
| yvl | but I see th1a's point where separate sheet would be easier to understand | 18:00 |
| aelkner | would it have to be a spearate sheet or separate section of the Cntacts sheet? | 18:01 |
| aelkner | if a separate sheet, what are the two sheet names? | 18:01 |
| th1a | Two sheets. | 18:03 |
| th1a | Contact Persons & Contact Relationships | 18:03 |
| aelkner | Contact Person is the table as I have, but cols two and three are replaced by an ID column | 18:04 |
| th1a | I think in Persons you need a field to specify if it is a "self" contact for an existing person (where the ID would have to match the existing person id) | 18:04 |
| aelkner | i was just about to say :) | 18:04 |
| th1a | Contact Persons, that is. | 18:04 |
| aelkner | yes, so if the ID is found in the persons container it's contact info for that person | 18:04 |
| aelkner | therwise, it's an unbound contact like a non-user parent | 18:05 |
| th1a | Yes. | 18:05 |
| aelkner | and the ID would be the __name__ of the contact on the Contacts container | 18:05 |
| th1a | Yes. | 18:05 |
| aelkner | so Contact Relationships would be a simple three col table | 18:05 |
| aelkner | User id, Contact Id, Relationship | 18:06 |
| aelkner | for Contact ID, the iporter would look in persons first, them contacts | 18:07 |
| th1a | Either that or you let user and contact id's overlap and have an additional row to specify which you're connecting to. | 18:07 |
| yvl | ok, so I tried a mashup of contact info + relationships in a single sheet | 18:07 |
| yvl | two sheets look way better | 18:08 |
| aelkner | th1a, i don't think we should allow name collision | 18:08 |
| aelkner | if we did, we would need that special col in both sheets | 18:08 |
| th1a | OK. | 18:09 |
| aelkner | in any event, i think the issue is well defined now, and it solves the reimporting issue | 18:09 |
| aelkner | and that's good because i had that hanging over me anyway | 18:09 |
| yvl | cool | 18:10 |
| th1a | Excellent. | 18:10 |
| aelkner | yvl, while you are resolving the gradebook tests failing on timetable import (like you prommissed) | 18:11 |
| aelkner | could you please make this test pass as well: | 18:11 |
| aelkner | bin/test -vs schooltool.export --at-level 2 | 18:11 |
| aelkner | i'd like to be able to write automated tests for this stuff | 18:12 |
| yvl | it broke again? | 18:12 |
| yvl | ok, will look into it | 18:12 |
| aelkner | thanks | 18:12 |
| aelkner | please email me when you have that working | 18:12 |
| yvl | sure | 18:12 |
| yvl | ok... should we wrap this up? | 18:13 |
| aelkner | th1a, regarding https://bugs.launchpad.net/schooltool/+bug/585119 | 18:13 |
| aelkner | i think we should mark that as fixed or whatever | 18:13 |
| aelkner | since we use the __name__ in all the sheets | 18:14 |
| th1a | That's what I was thinking. | 18:14 |
| aelkner | Fixed committed? | 18:14 |
| aelkner | there isn't any code fix in particular, but last time I used Invalid, i got into trouble | 18:14 |
| yvl | :) | 18:15 |
| yvl | fixed committed it is | 18:15 |
| th1a | They should be in the last release right? | 18:15 |
| aelkner | i guess | 18:15 |
| aelkner | fixed commited it is, and that's it | 18:15 |
| aelkner | done | 18:15 |
| th1a | OK, thanks guys. | 18:16 |
| * th1a drops the bag of gravel. | 18:16 | |
| th1a | replaceafill: Meet in an hour? | 18:16 |
| replaceafill | th1a kk | 18:16 |
| yvl | thanks guys | 18:16 |
| yvl | see you on Mon | 18:16 |
| aelkner | yvl, can i reach you Friday morning at the same time possibly? | 18:16 |
| yvl | I'll be around, aelkner | 18:17 |
| aelkner | i'd like to check about the export tests at the point | 18:17 |
| aelkner | thanks | 18:17 |
| aelkner | have a nice evening, pov guys :) | 18:17 |
| yvl | thanks! :) | 18:17 |
| * th1a still needs to make lunch... | 19:08 | |
| replaceafill | np th1a i'll be here | 19:08 |
| th1a | ok | 19:22 |
| th1a | I guess you don't necessarily need me to get started. | 19:22 |
| * th1a is here, eating | 19:22 | |
| replaceafill | th1a i'm working on other small things | 19:22 |
| replaceafill | like hiding the Demographics fieldset if there are no demographics fields | 19:22 |
| th1a | Make the colors look like the colors. | 19:22 |
| replaceafill | ah ok | 19:23 |
| replaceafill | you mean, switch definitely to teal, right? | 19:23 |
| th1a | y | 19:24 |
| th1a | well no | 19:24 |
| replaceafill | k | 19:24 |
| th1a | :-D | 19:24 |
| replaceafill | ? | 19:24 |
| th1a | Let's work on the prototype. | 19:24 |
| replaceafill | ah | 19:24 |
| replaceafill | ok | 19:24 |
| th1a | I'm not saying add it to trunk right now. | 19:24 |
| replaceafill | got it | 19:24 |
| th1a | I mean, Vinny's last wireframe is different than our last test, right? | 19:25 |
| replaceafill | yes | 19:25 |
| replaceafill | active tab is not gray | 19:25 |
| replaceafill | it's dark teal | 19:25 |
| replaceafill | it would be nice if vinny added the hex codes to the mocks :) | 19:28 |
| th1a | I know... | 19:28 |
| replaceafill | th1a http://69.164.203.135:6661/persons/teacher001/ | 19:40 |
| replaceafill | we don't have the logo with teal background, gray foreground | 19:40 |
| replaceafill | i'll cut/paste the one from Vinny's mock | 19:41 |
| th1a | kk. | 19:41 |
| replaceafill | done | 19:43 |
| replaceafill | do you want me to use the same gray in the person accordions? | 19:43 |
| th1a | Oh, yes. | 19:43 |
| replaceafill | k | 19:44 |
| th1a | Is there a difference in our dark green text and the dark green active tab color? | 19:44 |
| replaceafill | yes | 19:44 |
| replaceafill | dark green text: #005C61 | 19:45 |
| replaceafill | dark green tab: #026B6E | 19:45 |
| replaceafill | want me to change the text to match the tab? | 19:45 |
| th1a | y | 19:45 |
| replaceafill | k | 19:45 |
| replaceafill | done | 19:48 |
| replaceafill | http://69.164.203.135:6661/persons/teacher001/ | 19:48 |
| replaceafill | i liked the other dark green for text | 19:49 |
| th1a | Can we update the favicon too? | 19:49 |
| replaceafill | ah ok | 19:49 |
| th1a | Yah, revert the link color. | 19:49 |
| replaceafill | k | 19:50 |
| th1a | Why does the icon look light green? | 19:50 |
| replaceafill | it lost quality on the export to jpg | 19:52 |
| replaceafill | let me fix it | 19:52 |
| th1a | Sorry to be picky about it, but we need to get a good sense of the final look. | 19:53 |
| replaceafill | np, i understand | 19:54 |
| replaceafill | refresh | 19:54 |
| replaceafill | ah the favicon! | 19:54 |
| replaceafill | forgot it ;) | 19:54 |
| replaceafill | refresh | 19:55 |
| replaceafill | i should make the favicon background transparent | 19:55 |
| replaceafill | it's gray | 19:55 |
| replaceafill | and you see the little box around it | 19:56 |
| th1a | Well... maybe. | 19:56 |
| replaceafill | although now that i pay attention, zonki had it :D | 19:56 |
| th1a | It might get indistinct against a dark backround. | 19:56 |
| th1a | It could be tweaked a bit. Overall looks ok though. | 19:57 |
| replaceafill | ok done | 19:58 |
| replaceafill | ff stills shows the box around the favicon :( | 19:59 |
| replaceafill | chrome doesnt though | 19:59 |
| th1a | Maybe I'm not clearing my cache. | 19:59 |
| th1a | (I see it) | 19:59 |
| replaceafill | or maybe it's there, but my chrome ui it's the same color :D | 20:00 |
| th1a | Make it the inactive tab. | 20:00 |
| th1a | I guess my remaining question is whether the breadcrumbs bar needs to be colored at all. | 20:01 |
| th1a | So lets look at that. | 20:01 |
| replaceafill | ok | 20:02 |
| replaceafill | remove the gray background? | 20:02 |
| th1a | YEah, we need to a/b it. | 20:04 |
| replaceafill | done | 20:05 |
| th1a | I like the gray. | 20:08 |
| th1a | You? | 20:08 |
| replaceafill | me 2 | 20:08 |
| th1a | OK. | 20:09 |
| replaceafill | put it back? | 20:09 |
| th1a | Yes. | 20:09 |
| replaceafill | done | 20:09 |
| th1a | Would you like to shorten the tertiary navigation? | 20:10 |
| replaceafill | hhmm let me see | 20:10 |
| replaceafill | refresh | 20:11 |
| th1a | It has moved. | 20:16 |
| replaceafill | ah | 20:17 |
| replaceafill | fixed | 20:19 |
| th1a | I meant in height. | 20:20 |
| th1a | You made them more narrow, right? | 20:20 |
| replaceafill | oops! | 20:20 |
| replaceafill | ok, let me rever that | 20:20 |
| th1a | np | 20:20 |
| replaceafill | 40px height | 20:21 |
| replaceafill | want it as short as the breadcrumbs? | 20:22 |
| replaceafill | which is 24px | 20:22 |
| th1a | Just try something. | 20:22 |
| replaceafill | refresh | 20:24 |
| replaceafill | that's 32px | 20:24 |
| th1a | I think that works. | 20:24 |
| th1a | Do you want to try the lettering in the non-active tabs as gray and the active one as regular teal? | 20:25 |
| replaceafill | ah sure | 20:25 |
| replaceafill | should i remove the background for the hover of tabs in the third? | 20:29 |
| replaceafill | refresh btw | 20:29 |
| th1a | idk | 20:32 |
| replaceafill | ah no, the background doesnt look that bad in the hover | 20:32 |
| th1a | I'm not sure if the active one should be teal and the inactive ones gray. | 20:32 |
| th1a | Probably the latter. | 20:32 |
| replaceafill | you mean the backgrounds, like in the other navigations? | 20:33 |
| th1a | I mean the text. | 20:35 |
| th1a | I think we have it backwards. | 20:35 |
| th1a | What do you think? | 20:36 |
| th1a | no... keep the backgrounds the way they were. | 20:36 |
| replaceafill | ah | 20:36 |
| * replaceafill is getting all th1a's instructions backwards today :( | 20:37 | |
| replaceafill | i just saw: | 20:37 |
| replaceafill | "non-active tabs as gray and the active one as regular teal" | 20:37 |
| replaceafill | my bad | 20:37 |
| th1a | np | 20:37 |
| th1a | I'm being overly terse. | 20:37 |
| replaceafill | refresh | 20:38 |
| th1a | Maybe the darker teal. | 20:38 |
| th1a | (the link teal) | 20:38 |
| replaceafill | ah! right | 20:39 |
| replaceafill | refersh | 20:39 |
| replaceafill | could i change the color of the inactive to dark teal on hover | 20:40 |
| replaceafill | they look like regular text | 20:40 |
| replaceafill | not like links | 20:40 |
| replaceafill | but we have the background on hover anyway | 20:40 |
| th1a | change the color on hover. | 20:40 |
| replaceafill | better | 20:41 |
| replaceafill | :) | 20:41 |
| replaceafill | are we going to adjust fieldsets and table headers to this new gray? | 20:42 |
| th1a | Yes. | 20:43 |
| th1a | We can ask Vinny about it though. | 20:43 |
| th1a | I don't think we want to use the breadcrumbs gray in the table headers. | 20:43 |
| th1a | Could you make a list of the things we need colors for? | 20:44 |
| th1a | table header | 20:44 |
| th1a | sub-header | 20:44 |
| replaceafill | fieldsets | 20:44 |
| th1a | calendar events (several colors) | 20:44 |
| th1a | warning highlights | 20:45 |
| replaceafill | the * required info marker | 20:45 |
| th1a | acceptable entry highlight | 20:45 |
| replaceafill | focused entry | 20:45 |
| th1a | warning message | 20:45 |
| th1a | info message | 20:45 |
| replaceafill | we use hover on rows on some tables | 20:46 |
| th1a | OK -- work on that list. | 20:46 |
| th1a | Also, do you want to do the CSS layer for custom colors? | 20:46 |
| replaceafill | ah yes | 20:46 |
| replaceafill | colors.css? :) | 20:46 |
| th1a | Sure. | 20:47 |
| replaceafill | with comments | 20:47 |
| th1a | I guess we might as well make it fairly complete, so CL can use it. | 20:47 |
| replaceafill | i'll create the layer first and will create the list from there, if that's ok | 20:48 |
| replaceafill | it will be easier to see what colors we need once they're in a single place | 20:49 |
| replaceafill | ah dialogs | 20:49 |
| replaceafill | and buttons | 20:49 |
| th1a | Also, we'll have to discuss background content colors with Vinny anyhow. | 20:49 |
| replaceafill | k, will start on colors.css | 20:49 |
| replaceafill | th1a are we going to implement Vinny's suggestion on the gradebook table header? | 20:53 |
| replaceafill | with multiple rows for activity details | 20:53 |
| th1a | Ah... I don't know. | 20:53 |
| th1a | I actually think it is a little busy. | 20:58 |
| th1a | Also, I'd want to let you sort that way too if we did it. | 20:58 |
| th1a | And/or select which ones show up. | 20:59 |
| th1a | So it is a little more complicated than it might seem. | 20:59 |
| replaceafill | right | 20:59 |
| replaceafill | preferences style | 20:59 |
| th1a | This is looking pretty good. | 21:11 |
| replaceafill | :) | 21:11 |
| replaceafill | i think i'm going to restart the vps | 21:16 |
| replaceafill | it takes a lot to stop/start an instance... | 21:17 |
| replaceafill | th1a are we going to keep yvl's trick to switch the tabs from left to right? | 21:21 |
| th1a | Hm? | 21:23 |
| replaceafill | refresh and click the schooltool logo | 21:24 |
| th1a | Oh, no, that's just a demo hack. | 21:25 |
| replaceafill | kk, i'm trying to match the prototype with the current code, so it's easy to merge | 21:26 |
| th1a | We will be ready to merge with trunk soonish. | 21:27 |
| th1a | I mean, I will be ready to. | 21:27 |
| *** menesis has quit IRC | 21:43 | |
| * replaceafill is thinking about creating a "SchoolTool design guidelines" doc :D | 21:50 | |
| th1a | I won't stop you. | 21:51 |
| replaceafill | :D | 21:51 |
| * th1a is thinking about installing his new fanless power supply. | 21:51 | |
| th1a | My 12 year old one is starting to make noise. | 21:51 |
| replaceafill | lately my laptop vibrates :( | 21:52 |
| replaceafill | i wonder if it's some fan too | 21:52 |
| th1a | Hopefully. | 21:52 |
| th1a | OK, shutting down for a while... | 21:55 |
| th1a | Later. | 21:55 |
| replaceafill | see u th1a | 21:55 |
| *** th1a has quit IRC | 21:55 | |
| * replaceafill goes to get lunch | 22:42 | |
| *** replaceafill is now known as replaceafill_lun | 22:42 | |
| *** replaceafill_lun is now known as replaceafill_afk | 22:42 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!
