| *** menesis has joined #schooltool | 00:02 | |
| *** replaceafill has joined #schooltool | 00:21 | |
| *** menesis has quit IRC | 00:45 | |
| *** fsufitch has quit IRC | 00:59 | |
| *** issyl0_ has joined #schooltool | 01:10 | |
| *** issyl0_ is now known as Guest68804 | 01:11 | |
| *** issyl0 has quit IRC | 01:13 | |
| *** th1a_ has joined #schooltool | 01:50 | |
| *** th1a has quit IRC | 01:54 | |
| *** ignas has joined #schooltool | 02:09 | |
| *** replaceafill has quit IRC | 02:31 | |
| *** ignas has quit IRC | 02:44 | |
| *** fsufitch has joined #schooltool | 03:05 | |
| *** replaceafill has joined #schooltool | 03:49 | |
| aelkner | replaceafill, hey | 03:51 |
|---|---|---|
| replaceafill | hey aelkner | 03:51 |
| aelkner | can you look at something with me a second? | 03:52 |
| replaceafill | sure | 03:52 |
| aelkner | ok, i'm about to push, one sec | 03:53 |
| aelkner | ok, everything is pushed all the way to trunk | 03:55 |
| replaceafill | k, pulling | 03:55 |
| aelkner | so if you look at f_term_add.pt, i only changed the cloned template to get the legend set up | 03:55 |
| aelkner | and add an extra <p> markup for spacing | 03:55 |
| aelkner | but you'll notice that there are a lot of classes set up for old skin css | 03:56 |
| aelkner | and removing them doesn't seem to matter anyway | 03:56 |
| aelkner | i guess because they are not in the flourish skin | 03:56 |
| replaceafill | right | 03:56 |
| replaceafill | correct | 03:56 |
| replaceafill | you can safely remove them | 03:56 |
| aelkner | cool | 03:57 |
| replaceafill | in fact, we should remove classes we dont use | 03:57 |
| replaceafill | so, is anything wrong with the template? | 03:57 |
| aelkner | can you try adding a term until you get to the refresh screen | 03:57 |
| replaceafill | ah, ok | 03:57 |
| aelkner | nothing that i have an opinion on, but i thought you wold be able to anticipate what tom | 03:57 |
| aelkner | would want to have changed | 03:57 |
| aelkner | let me know when you have the screen loaded | 03:58 |
| replaceafill | do terms have the 12 chars constraint for titles? | 03:58 |
| aelkner | oh, and make sure that the term is multi-month | 03:58 |
| aelkner | not that i know | 03:58 |
| replaceafill | i thought th1a asked for it | 03:58 |
| replaceafill | (but maybe i'm wrong) | 03:58 |
| aelkner | there is a table for each month | 03:59 |
| replaceafill | ok, adding a term | 03:59 |
| aelkner | it doesn't look so bad, but i thought you would have some thoughts | 03:59 |
| aelkner | the buttons have to be buttons because the form has to stay up | 04:00 |
| aelkner | it's like a wizard, a multi-step form | 04:00 |
| aelkner | i'm referring to Monday, Tuesday, btw when i refer to the buttons | 04:01 |
| replaceafill | you could set classes on them | 04:01 |
| replaceafill | like button-ok|neutral | 04:02 |
| replaceafill | if you do that, make sure you also set a class on the parent element containing the buttons | 04:02 |
| replaceafill | the <p> | 04:02 |
| replaceafill | should be <p class="buttons"> | 04:02 |
| replaceafill | and the buttons like <input type="submit" class="button-ok" ...> | 04:03 |
| replaceafill | that would matter when we have the final palette | 04:03 |
| replaceafill | also, http://img64.imageshack.us/img64/4748/pantallazousj.png | 04:04 |
| replaceafill | i think the fieldset legend should be shorter | 04:04 |
| replaceafill | but not a big deal | 04:05 |
| aelkner | yeah, i'll let tom come up wth that one | 04:05 |
| replaceafill | you know, you should leave the old css classes in this template | 04:05 |
| aelkner | how did you get your buttons to come out that way | 04:05 |
| aelkner | what did you change? | 04:06 |
| replaceafill | hhmm nothing | 04:06 |
| replaceafill | what do you mean "that way"? | 04:06 |
| aelkner | Monday, etc. is dark grey for me, your screenshot has them light-grey, aolmost white | 04:07 |
| replaceafill | they dont have a flourish css class, so it's defined by the browser | 04:07 |
| replaceafill | they have class="button" | 04:08 |
| replaceafill | and we dont have a style for that | 04:08 |
| aelkner | what bowser are you using? | 04:09 |
| replaceafill | ff 3.5 | 04:09 |
| replaceafill | but in any case, i think those buttons need flourish css classes | 04:09 |
| aelkner | yes, i should add those | 04:10 |
| aelkner | also, how should i add the old css classes? | 04:10 |
| aelkner | i can copy them from the old skin, but wereto? | 04:10 |
| replaceafill | old css classes? | 04:10 |
| aelkner | <replaceafill> you know, you should leave the old css classes in this template | 04:10 |
| replaceafill | ah yes | 04:11 |
| replaceafill | i meant, dont remove them | 04:11 |
| replaceafill | i'll need them | 04:11 |
| aelkner | ok, you'll handle adding the css to the new skin to style them | 04:11 |
| aelkner | right? | 04:12 |
| replaceafill | yes | 04:12 |
| aelkner | cool, thanks | 04:12 |
| replaceafill | one comment though | 04:12 |
| replaceafill | hold on, let me check something | 04:12 |
| replaceafill | ah yes | 04:13 |
| replaceafill | you know, the old view | 04:13 |
| replaceafill | uses javascript to mark the holidays | 04:13 |
| replaceafill | you just click on the day | 04:13 |
| replaceafill | the checkboxes are backup for not having js | 04:13 |
| replaceafill | you should ask th1a if he wants to keep that | 04:14 |
| replaceafill | i mean, it's nice being able to click the whole square to enable/disable the day | 04:15 |
| replaceafill | just nitpicking i guess :) | 04:15 |
| aelkner | not really, all good points | 04:16 |
| replaceafill | that's all i have, good work on this view | 04:17 |
| replaceafill | will be fun to style :/ | 04:17 |
| replaceafill | lots of parts :) | 04:17 |
| aelkner | cool, thanks for you help | 04:19 |
| replaceafill | np | 04:19 |
| replaceafill | hhmm interesting | 04:20 |
| replaceafill | suppose i have a year from jan 1 to dec 31 | 04:21 |
| replaceafill | ah no, never mind | 04:21 |
| replaceafill | what i'm thinking it's not possible | 04:21 |
| replaceafill | :P | 04:21 |
| aelkner | i added back the js that i removed before and it changes the checkboxes to cells that have no checkbox | 04:22 |
| aelkner | but clicking on them doesn't change to red like in the old version | 04:22 |
| replaceafill | it also needs the flourish css class | 04:22 |
| aelkner | a, of course | 04:23 |
| replaceafill | check in firebug if a new class is set | 04:23 |
| replaceafill | when you click | 04:23 |
| replaceafill | if it does, your ok | 04:23 |
| replaceafill | your'e | 04:23 |
| aelkner | excellent, that was a great idea, the classes toggle between holiday and schoolday | 04:24 |
| aelkner | so yeah, it's just the css that i will leave in your capable hands | 04:24 |
| replaceafill | :D | 04:24 |
| replaceafill | you know, looking at /terms closely | 04:24 |
| replaceafill | it's difficult to understand why do you have two rows with the same data | 04:25 |
| replaceafill | (if your year has only one term for example) | 04:25 |
| replaceafill | but i guess th1a is ok with that | 04:25 |
| replaceafill | i'll leave /terms alone :) | 04:25 |
| aelkner | well, i guess having the second row display to the user the fact that the year has only one term | 04:27 |
| aelkner | even if they didn't need to be told that | 04:27 |
| aelkner | it is an honest account of what's going on | 04:27 |
| aelkner | and when the user adds more than one term, the difference is visually clear | 04:28 |
| replaceafill | yes | 04:28 |
| *** aks has joined #schooltool | 06:28 | |
| *** th1a_ has quit IRC | 07:01 | |
| *** replaceafill has quit IRC | 07:38 | |
| *** menesis has joined #schooltool | 10:04 | |
| *** menesis has quit IRC | 11:06 | |
| *** menesis has joined #schooltool | 11:09 | |
| *** aks has quit IRC | 11:17 | |
| *** aks has joined #schooltool | 11:26 | |
| *** aks has joined #schooltool | 11:26 | |
| *** menesis has quit IRC | 13:15 | |
| *** ignas has joined #schooltool | 13:16 | |
| *** aks has quit IRC | 14:19 | |
| *** itsurkg has joined #schooltool | 14:24 | |
| *** fsufitch has quit IRC | 14:26 | |
| *** itsurkg has quit IRC | 15:16 | |
| *** fsufitch has joined #schooltool | 15:49 | |
| *** replaceafill has joined #schooltool | 16:24 | |
| *** th1a has joined #schooltool | 16:31 | |
| th1a | hi aelkner, replaceafill. | 16:32 |
| replaceafill | good morning | 16:32 |
| aelkner | morning | 16:32 |
| * th1a was hoping for the return of yvl... | 16:32 | |
| th1a | I do want to talk to him about School/Application page design before we do that, because I know he was thinking about it. | 16:33 |
| th1a | And I don't have any particularly brilliant ideas. | 16:33 |
| th1a | Regarding old skin tests. | 16:35 |
| th1a | For me this is a "pay me now or pay me later" issue. | 16:35 |
| aelkner | how do you mean that? | 16:36 |
| th1a | I'm going to pay for it either way, and what I don't want is five years from now a new developer wasting an afternoon trying to figure out why some views are weird and eventually remembering that it was a workaround to not break tests five years ago. | 16:36 |
| th1a | So lets keep things consistent. | 16:38 |
| th1a | Understood? | 16:39 |
| replaceafill | understood | 16:40 |
| th1a | We'll decide which old tests to fix when we get there. | 16:40 |
| th1a | aelkner? | 16:42 |
| aelkner | this is the way i understand the situations | 16:42 |
| aelkner | we have a flourish skin, why, couldn't tell you | 16:43 |
| aelkner | i was guessing that we did so to allow us to have the old skin running for some reason | 16:43 |
| aelkner | again, don't know why, but there it is | 16:43 |
| aelkner | so my only question is, if we need the thing running, do we need it to run without crashing? | 16:44 |
| aelkner | as far as weird views, they're all weird because they have this special flourish registration | 16:44 |
| aelkner | and base class usage | 16:44 |
| aelkner | i didn'[t have a problem with the new flourish classes, i just figured out how to use them | 16:45 |
| aelkner | we don'[t need to break the old skin | 16:45 |
| aelkner | we can override anything we want in the flourish classes and templates | 16:46 |
| th1a | Perhaps we should step back to the actual question at hand. | 16:46 |
| aelkner | it's just changing the interfaces that is a no-no | 16:46 |
| aelkner | changing interfaces or old skin base classes means breaking the old skin | 16:46 |
| aelkner | but we don't need to do that | 16:46 |
| th1a | Was the question yesterday about changing text in the interface schema rather than just changing it at the skin level?on | 16:46 |
| aelkner | yes | 16:47 |
| th1a | In that issue in particular I'd much rather fix the old tests because you're improving the old skin. | 16:47 |
| th1a | You're fixing the interface, not breaking it. | 16:48 |
| th1a | And it will be easy to update the tests if we decide to. | 16:48 |
| aelkner | if we are only changing test of interface fields, fixing the tests will be straight-forward | 16:48 |
| aelkner | text of interface fields | 16:48 |
| aelkner | i would advise against any changes to base classes however | 16:49 |
| aelkner | old skin classes, i mean | 16:49 |
| th1a | I don't really think those are on the table anyhow. | 16:49 |
| aelkner | ok, so only interface text changes | 16:49 |
| aelkner | so replaceafill, what was your original question about? | 16:50 |
| th1a | Let's say it should be discussed on a case by case basis. | 16:50 |
| aelkner | why i didn't change the interface somewhere? | 16:50 |
| replaceafill | i wondered if you knew of a reason to use updateWidgets instead of changing the interfaces | 16:51 |
| aelkner | which case? | 16:52 |
| replaceafill | the forms where you set descriptions on widget fields | 16:52 |
| aelkner | in the case of adding a term, the first/last hints are dynamic now | 16:52 |
| replaceafill | i'm ok with using updateWidgets for that | 16:52 |
| aelkner | The year starts Jan 1, 2012 | 16:52 |
| replaceafill | for dynamic stuff | 16:53 |
| th1a | I think if aelkner had used that answer the first time, we would have saved an hour. | 16:53 |
| replaceafill | but for static text, i say change the interface | 16:53 |
| aelkner | it's ok, i think the discussion was fruitful, and i think we all agree on how to go from here | 16:53 |
| aelkner | only text changes in interfaces, no old skin class changes, and we'll be ok | 16:54 |
| th1a | aelkner: That was not the decision. | 16:54 |
| replaceafill | why is wrong to change base classes? | 16:55 |
| th1a | The decision is: | 16:55 |
| th1a | - definitely change text in interfaces; | 16:55 |
| th1a | - discuss other changes. | 16:55 |
| th1a | But the bias is still toward the new when it comes up. | 16:55 |
| th1a | I just don't think the "other changes" are going to come up. | 16:55 |
| aelkner | ok, sounds good to me | 16:56 |
| replaceafill | aelkner why do you think changing old classes is wrong? | 16:57 |
| *** Guest68804 is now known as issyl0 | 16:57 | |
| *** issyl0 has quit IRC | 16:57 | |
| *** issyl0 has joined #schooltool | 16:57 | |
| th1a | I think we're arguing now about things that aren't going to happen. | 16:57 |
| aelkner | replaceafill, if you want to create work for us later and potential deadline pressure, i won't stop you :) | 16:57 |
| th1a | By definition we shouldn't need to change things in the old skin. | 16:57 |
| aelkner | yes | 16:58 |
| replaceafill | ok an example: | 16:58 |
| th1a | And there is no reason to think we'll need to suddenly change base classes. | 16:58 |
| aelkner | that's why we created flourish, i figured | 16:58 |
| replaceafill | suppose you need to redirect to a newly created object | 16:58 |
| replaceafill | but the old class redirects to the container | 16:58 |
| aelkner | do it in the flourish view class please | 16:58 |
| replaceafill | you can easily add self._resource = resource to the old class | 16:58 |
| aelkner | i just handled that last night | 16:58 |
| replaceafill | and change the redirect | 16:58 |
| replaceafill | without duplicating the whole method | 16:59 |
| aelkner | i needed the term delet to redirect to /terms | 16:59 |
| aelkner | so i did it in the flourish view class | 16:59 |
| aelkner | i didn't change the old skin class | 16:59 |
| aelkner | why break it and have to fix it later | 16:59 |
| aelkner | we have a lot of old skin tests that have navigation in them | 16:59 |
| aelkner | and it will be a lot of work to fix them if we mess with the old skin classes | 17:00 |
| aelkner | so let's not, ok replaceafill? | 17:00 |
| replaceafill | why do we care about old tests again? | 17:00 |
| aelkner | :) | 17:00 |
| th1a | I'm ambivalent about that one. I have nothing against copying the method. | 17:00 |
| aelkner | replaceafill, we only care about tests if we care about code working | 17:00 |
| aelkner | if not, then why not delete all the tests from the codebase?! | 17:01 |
| aelkner | we are going to have flourish tests | 17:01 |
| replaceafill | well, i'll wait for yvl opinion but i thought that's what we're going to do | 17:01 |
| replaceafill | get rid of most of the old tests | 17:01 |
| replaceafill | functional at least | 17:01 |
| replaceafill | the ones that simulate the UI | 17:01 |
| aelkner | and why do we need the old skin code that has no test coverage? | 17:02 |
| aelkner | or the old skin for that matter? | 17:02 |
| th1a | Well, let's say CanDo says "NO WE CAN'T USE FLOURISH" next year. | 17:02 |
| aelkner | right | 17:03 |
| aelkner | so we better amke sure that code isn't broken | 17:03 |
| replaceafill | th1a they stick to core, right? | 17:03 |
| th1a | If the old skin is still there with a few trivially broken functional tests, it isn't the end of the world. | 17:03 |
| replaceafill | a different branch | 17:03 |
| aelkner | passing tests is the only way to know if code is not broken | 17:03 |
| th1a | aelkner: In a sense, it is their problem. | 17:03 |
| th1a | It is still a small change anyhow. | 17:04 |
| th1a | Whatever kind of fix you want is still pretty straightforward. | 17:04 |
| aelkner | we can change redirects in the flourish view classes so as not to break the old skin | 17:04 |
| aelkner | i know yvl will back me up on this | 17:05 |
| aelkner | th1a, but you answered the question as to why we need to support the old skin | 17:06 |
| th1a | I have no problem with that one. | 17:06 |
| aelkner | also, courseinfo package will probably use the old skin this year | 17:06 |
| aelkner | so breaking it would be mean to them | 17:06 |
| replaceafill | sorry, but i still dont understand this part, worrying about cando, isnt flourish a new different series from core? | 17:08 |
| th1a | No. | 17:08 |
| replaceafill | if cando doesnt want to use flourish yet, they use core | 17:08 |
| replaceafill | so, flourish will be the new core? | 17:08 |
| th1a | YES. | 17:08 |
| replaceafill | ah! | 17:08 |
| replaceafill | in that case, old code should stay exactly the same :D | 17:09 |
| aelkner | cando already derives its skin from the old skin, so they will not need to know about flourish | 17:09 |
| aelkner | replaceafill, thanks :) | 17:09 |
| replaceafill | exactly exactly the same ;) | 17:09 |
| aelkner | and keep in mind, cando is not testing the labels that result from the interface changes we make | 17:09 |
| aelkner | at least, it should only break a couple tests that will be easy to fix | 17:10 |
| replaceafill | i always thought flourish was like the schooltool 1.2 vs schooltool 1.0 case | 17:10 |
| replaceafill | where you had bleeding edge features in 1.2 and stable ones in 1.0 | 17:11 |
| replaceafill | and you backported from one to the other | 17:11 |
| th1a | The debatable question is the rare occurrence when we do want to change the base code, not the view code. | 17:11 |
| aelkner | as you pointed out, that will be rare, and we only need to respect the consideration of the costs of making changes of that nature | 17:12 |
| aelkner | just breaking code without considering costs is the only mistake we would make | 17:12 |
| th1a | OK, so NOW I think we've got that settled. | 17:13 |
| replaceafill | :) | 17:13 |
| replaceafill | ok, we need to fix old tests then :) | 17:13 |
| replaceafill | or at least find a way to run them together with the new skin | 17:14 |
| replaceafill | i'm sure yvl already has something in mind for that :) | 17:14 |
| aelkner | yes, let's see what yvl has planned | 17:14 |
| * replaceafill leaves the old code alone ;) | 17:15 | |
| aelkner | thank god! :) | 17:15 |
| th1a | Now, what do you have for me aelkner? | 17:15 |
| aelkner | http://69.164.203.135:36660/terms | 17:15 |
| aelkner | i fixed the add term view so that you can add a term now | 17:15 |
| aelkner | replaceafill was kind to offer to handle fixing the css | 17:16 |
| aelkner | i also created the index.html viedw for a term | 17:16 |
| aelkner | and the delete action and dialog | 17:16 |
| aelkner | so you can delete terms that you add | 17:16 |
| aelkner | i can work on edit.html today | 17:17 |
| th1a | The header on the term index should say "Title" not "Term" | 17:17 |
| th1a | I agree with you guys that the distinction between year and term in the table could be a little better. | 17:17 |
| aelkner | how about the year title having prefix of 'School Year:'? | 17:18 |
| th1a | Yeah, something like that. | 17:18 |
| th1a | Try that. | 17:19 |
| replaceafill | +1 | 17:19 |
| aelkner | ok | 17:19 |
| th1a | Jesus H. Christ aelkner, this looks pretty good. | 17:19 |
| replaceafill | +1 | 17:20 |
| replaceafill | :) | 17:20 |
| aelkner | why, thank you, th1a! | 17:20 |
| th1a | Needs some work, but much cleaner than the original. | 17:20 |
| aelkner | i haven't even had the chance to look at the improvements you guys are making to /courses | 17:21 |
| aelkner | is that in trunk yet? | 17:21 |
| th1a | OK, let's look at replaceafill's work now and come back to tweaking the calendar. | 17:21 |
| aelkner | wait, on e sec | 17:21 |
| replaceafill | aelkner no, not yet | 17:21 |
| replaceafill | http://69.164.203.135:6660/courses | 17:21 |
| aelkner | replaceafill, i definitely like the idea of letting you fix the css in terms view | 17:22 |
| replaceafill | aelkner :) | 17:22 |
| th1a | OK, we'll do that. | 17:22 |
| aelkner | views, but can we wait until i move on to another package to reduce merge conflicts | 17:22 |
| replaceafill | it's in my flourish todo already ;) | 17:22 |
| aelkner | i still have other term views to get going | 17:22 |
| replaceafill | aelkner sure | 17:22 |
| th1a | OK. | 17:22 |
| aelkner | great | 17:22 |
| replaceafill | i'll work on that until you tell me you're leaving, ok? | 17:23 |
| th1a | replaceafill: The add link is going to have to be year-aware for courses. | 17:23 |
| replaceafill | it is | 17:23 |
| replaceafill | (i think) | 17:23 |
| th1a | Oh, I'm not logged in. | 17:23 |
| replaceafill | :) | 17:23 |
| replaceafill | well /courses and course index are public | 17:23 |
| th1a | yes. | 17:24 |
| th1a | it is the right behavior. | 17:24 |
| replaceafill | i guess most of the functionality is finished for courses | 17:24 |
| replaceafill | index, edit, delete | 17:25 |
| replaceafill | leaders | 17:25 |
| replaceafill | Add Course inside course index ;) | 17:25 |
| th1a | aelkner: That's a controversial move. | 17:25 |
| th1a | What do you think? | 17:26 |
| replaceafill | th1a i have a few questions | 17:27 |
| aelkner | sorry, was making a fix | 17:27 |
| replaceafill | th1a should we hide empty non-required values in course index? | 17:27 |
| replaceafill | like empty description for example | 17:27 |
| replaceafill | like we do with person accordions | 17:27 |
| replaceafill | that we only display fields with data | 17:27 |
| aelkner | th1a, what's controversial? | 17:28 |
| aelkner | i'm missing something | 17:28 |
| replaceafill | aelkner Add Course inside the course view | 17:28 |
| th1a | replaceafill: I'd say yes. | 17:29 |
| replaceafill | meaning adding a course from a course | 17:29 |
| replaceafill | th1a ok, will do | 17:29 |
| aelkner | you mean /courses? | 17:29 |
| th1a | LIke http://69.164.203.135:6660/schoolyears/2011/courses/chemistry | 17:29 |
| aelkner | sorry guys, my head s not in that view, so i can't offer an opinion | 17:29 |
| aelkner | could you push to trunk so i could look? | 17:29 |
| th1a | Course needs a Done, too. | 17:29 |
| th1a | I gave you a link. | 17:29 |
| aelkner | th1a, http://69.164.203.135:36660/terms, is that good enough for now? | 17:29 |
| replaceafill | th1a the Done button was another question :) | 17:30 |
| replaceafill | put it at the bottom, right? | 17:30 |
| th1a | Yes. | 17:30 |
| replaceafill | th1a also, could you review the message for the delete dialog? | 17:30 |
| aelkner | ok, i followed the link, so i'm lloking at the view | 17:31 |
| th1a | You can add a course from there. | 17:31 |
| aelkner | so adding a course from that view makes sense to me | 17:31 |
| aelkner | is that the question? | 17:31 |
| th1a | Yes. | 17:31 |
| aelkner | i am a little concerned about the user knowing what year it is | 17:32 |
| aelkner | i know we have th tab | 17:32 |
| aelkner | but i'm not sure the user will always notice | 17:32 |
| replaceafill | ah that's another change i made | 17:32 |
| th1a | It will be the active year, so that's ok. | 17:32 |
| replaceafill | i removed the "Courses for 2011" from the title | 17:32 |
| replaceafill | assuming you have the right year highlighted | 17:32 |
| replaceafill | and the title for /courses is just "Courses" | 17:33 |
| th1a | oh, I prefered it with the year. | 17:33 |
| aelkner | i actually think that title would help | 17:33 |
| replaceafill | cool, i'll put the year back | 17:33 |
| aelkner | even if it is redundant with the tab | 17:33 |
| replaceafill | th1a is the delete dialog message scary enough? :) | 17:34 |
| th1a | Yeah. | 17:34 |
| replaceafill | kk, next question | 17:34 |
| replaceafill | ah this: | 17:34 |
| replaceafill | the redirect button in Add Course | 17:34 |
| replaceafill | sorry | 17:34 |
| replaceafill | the Cancel button | 17:34 |
| replaceafill | should it be smart enough to know where to return? | 17:35 |
| th1a | In terms of year? | 17:35 |
| replaceafill | for example if you hit Add Course from /courses or from course index | 17:35 |
| th1a | No. | 17:35 |
| replaceafill | should Cancel always take you back to /courses? | 17:36 |
| th1a | I think that's fine. | 17:36 |
| replaceafill | ok | 17:36 |
| replaceafill | and my final question | 17:36 |
| aelkner | that's the way adding term works, it returns to /terms | 17:36 |
| th1a | Oh... | 17:36 |
| replaceafill | aelkner yes but you dont add terms from inside a term ;) | 17:36 |
| th1a | No, but aelkner, it seems we're standardizing on sending you to the object after you create it. | 17:37 |
| aelkner | i'm confused, isn't adding a course from /courses the same as adding a term from /terms? | 17:37 |
| replaceafill | it is | 17:37 |
| aelkner | th1a, yes, i do that with successful add of term | 17:37 |
| aelkner | it goes to the new term's index.html | 17:37 |
| th1a | Oh, if you cancel you go to /terms | 17:37 |
| th1a | OK, that's fine. | 17:37 |
| aelkner | right | 17:37 |
| replaceafill | but returning to /courses after you hit Add Course from inside a course feels funny | 17:38 |
| replaceafill | i'd expect to return to the course index | 17:38 |
| th1a | It is probably most correct to go back to where you came. | 17:38 |
| aelkner | i thought /courses is the course index | 17:38 |
| replaceafill | th1a +1 | 17:38 |
| aelkner | yes | 17:38 |
| replaceafill | ok, i'll make the Cancel button smart | 17:38 |
| th1a | replaceafill: Is it a 10 minute fix? | 17:38 |
| replaceafill | th1a yes | 17:38 |
| th1a | Fine. | 17:38 |
| replaceafill | ok, last question | 17:39 |
| replaceafill | regarding responsible parties | 17:39 |
| replaceafill | - What tasks should course/resource leaders do? | 17:39 |
| replaceafill | + Edit data | 17:39 |
| replaceafill | + Manage leaders | 17:39 |
| replaceafill | + Delete | 17:39 |
| replaceafill | i guess Edit course attributes, right | 17:39 |
| th1a | Looking at what we have now, it is just edit. | 17:39 |
| replaceafill | can a leader manage other leaders? | 17:39 |
| th1a | Can they now? | 17:40 |
| th1a | I'd say no. | 17:40 |
| replaceafill | ok, just Edit then | 17:40 |
| replaceafill | that's it from me :) | 17:40 |
| replaceafill | ok, my todo list: | 17:41 |
| replaceafill | - Make Cancel button in Add Course smart to redirect to where you came from | 17:41 |
| replaceafill | - Put the year back in Courses title | 17:41 |
| replaceafill | - Hide empty non-required values in course index | 17:41 |
| replaceafill | - Put a Done button at the bottom of course index | 17:41 |
| replaceafill | - What tasks should course/resource leaders do? | 17:41 |
| replaceafill | + Edit data | 17:41 |
| replaceafill | th1a is /sections coming next for me? | 17:42 |
| th1a | Yes. | 17:42 |
| replaceafill | same way, right? | 17:42 |
| replaceafill | ah! | 17:42 |
| replaceafill | by the way | 17:42 |
| replaceafill | i also need to fix search in /courses :) | 17:42 |
| replaceafill | it only looks in the active year ;) | 17:43 |
| replaceafill | so, i'll add that to my TODO | 17:43 |
| th1a | Sections is tricky because we have to decide how to select the course. | 17:43 |
| replaceafill | th1a correct i was going to ask that | 17:43 |
| th1a | I guess we should just do it from the add form. | 17:43 |
| th1a | And add an add section link from the course view. | 17:43 |
| th1a | Of course, that might make the add course link more confusing... | 17:44 |
| th1a | We'll make it work. | 17:44 |
| replaceafill | aelkner does add term uses sessions? | 17:45 |
| replaceafill | for storing the initial title and date values? | 17:45 |
| aelkner | i don't think so | 17:45 |
| replaceafill | or does it pass them in the request | 17:45 |
| aelkner | those fields are in the form each step | 17:45 |
| aelkner | so i guess there's no need to save them in session data | 17:45 |
| aelkner | why do you ask? | 17:46 |
| replaceafill | i'm just wondering how to pass data from one view to another | 17:46 |
| aelkner | querystrings work :) | 17:46 |
| replaceafill | :D | 17:46 |
| replaceafill | th1a the first step in add section would be to search for the course right | 17:47 |
| aelkner | th1a, are you trying to make it so that the user can add a section without navigating to the course? | 17:47 |
| replaceafill | i'm thinking how that result table would look like | 17:47 |
| replaceafill | aelkner correct | 17:48 |
| aelkner | is it so bad to have to navigate to the course? | 17:48 |
| th1a | replaceafill: Yes. | 17:48 |
| replaceafill | actually, the current skin allows you to do that | 17:48 |
| aelkner | i never thought the old skin was so bad with that | 17:48 |
| aelkner | th1a, what's your thinking here? | 17:48 |
| replaceafill | if you navigate to the course, it's selected automatically | 17:48 |
| replaceafill | but you can select another course if you want | 17:48 |
| th1a | Basically, we're not requiring the user to think hierarchically. | 17:49 |
| replaceafill | just inside the year, right? | 17:49 |
| replaceafill | Sections for 2011 | 17:49 |
| replaceafill | click Add Section | 17:49 |
| th1a | Yes. | 17:49 |
| replaceafill | you look in courses in 2011 | 17:49 |
| th1a | But it is still like switching tabs to them, not drilling down. | 17:50 |
| replaceafill | th1a can i put a + column at the end of the courses result list | 17:50 |
| replaceafill | to select the course you want | 17:50 |
| replaceafill | and then take you to the add form with the section fields | 17:51 |
| replaceafill | starting term, ending term, etc | 17:51 |
| th1a | OK. | 17:52 |
| replaceafill | ok, will work on that next | 17:52 |
| * replaceafill is enjoying this work :) | 17:52 | |
| th1a | Oh, I have a conference call with the designers in 8 minutes. | 17:52 |
| th1a | aelkner: You have stuff to do, right? | 17:52 |
| th1a | (for the next hour...) | 17:53 |
| th1a | OK, later guys. | 17:56 |
| * th1a drops the bag of gravel. | 17:56 | |
| replaceafill | good luck th1a | 17:56 |
| th1a | Since I'm paying them, I shouldn't need luck. | 17:57 |
| replaceafill | :)) | 17:57 |
| aelkner | th1a, i have stuff to do, yea | 17:58 |
| th1a | btw, I decided to wait until we get School and Application together to do the screencast. | 18:47 |
| th1a | replaceafill: The Shuttleworth Foundation appears to have changed its motto again. | 18:47 |
| replaceafill | :) | 18:47 |
| th1a | Also, they seem even more anti "The" in their name. | 18:48 |
| replaceafill | time to update the footer | 18:48 |
| replaceafill | ah | 18:48 |
| th1a | Also, their new site seems kind of tweaked. | 18:48 |
| replaceafill | "Supporting exceptional people to change the world" | 18:49 |
| replaceafill | are we exceptional people!?!? :D | 18:49 |
| * replaceafill updates the footer | 18:50 | |
| replaceafill | © 2011 Shuttleworth Foundation :O | 18:50 |
| th1a | You are exceptional, but you aren't supported by Shuttleworth Foundation. | 18:50 |
| th1a | Get rid of the "the!" | 18:50 |
| replaceafill | ah :( | 18:51 |
| replaceafill | ok | 18:51 |
| replaceafill | th1a http://69.164.203.135:6660/courses | 18:52 |
| replaceafill | footer updated | 18:52 |
| th1a | Perfecto! | 18:53 |
| replaceafill | btw, search is fixed in /courses | 18:53 |
| replaceafill | i only have 2 more items in my TODO | 18:53 |
| replaceafill | th1a i think leaders should work the same way for resources as for courses, right? | 18:54 |
| replaceafill | i mean, they can only edit resource data | 18:54 |
| th1a | They have some permissions regarding scheduling though? | 18:55 |
| th1a | Or is there a choice regarding that? | 18:55 |
| replaceafill | havent checked scheduling | 18:55 |
| th1a | racing you... | 18:55 |
| replaceafill | i've only seen them in courses, groups, and resources | 18:55 |
| replaceafill | btw, are we adding a /groups view too? | 18:56 |
| replaceafill | like /courses and /sections, with multitabs? | 18:56 |
| th1a | No, that's the point... the responsible party for the resource should have different permissions to schedule it. | 18:56 |
| replaceafill | or is that too much :D | 18:56 |
| replaceafill | ah | 18:56 |
| th1a | replaceafill: Yes, tabs for groups. | 18:56 |
| replaceafill | schedule it = reserve, correct? | 18:57 |
| th1a | Yes. | 18:57 |
| th1a | So something like: | 18:57 |
| replaceafill | well, since Reserve doesnt work yet, i'll put it on my TODO | 18:57 |
| th1a | "These users can modify and schedule reservations for the resource." | 18:58 |
| th1a | No... | 18:59 |
| th1a | It affects just booking the resource in a regular calendar event. | 18:59 |
| th1a | So it is still applicable. | 18:59 |
| th1a | Our terminology is mushy here. | 19:00 |
| th1a | We say "book resources" when you're creating a calendar event. | 19:00 |
| th1a | Let's use "book" here since it applies specifically to reserving a resource. | 19:01 |
| replaceafill | btw, should /resources be public? | 19:02 |
| replaceafill | and should resources be public? | 19:03 |
| replaceafill | i wonder if that's a control access setting... | 19:03 |
| th1a | Do you need to reset all these in the new skin or something? | 19:04 |
| replaceafill | "Only school administration can view the list of resources." | 19:05 |
| replaceafill | access setting | 19:05 |
| replaceafill | th1a what do you mean? | 19:05 |
| th1a | I'm not sure why you're asking me these questions. | 19:06 |
| th1a | It is in the code already, right? | 19:06 |
| replaceafill | ah, to match the behaviour of the course view | 19:06 |
| replaceafill | for leaders | 19:07 |
| replaceafill | letting resource leaders to have access to certain parts of the rsource only | 19:07 |
| th1a | That resources permission is a little weird. | 19:07 |
| replaceafill | but in the case of resources, it set by access control settings | 19:07 |
| replaceafill | courses are not | 19:07 |
| th1a | It could just as easily be public/admin-teachers-leaders | 19:08 |
| th1a | instead of public/admin | 19:08 |
| th1a | I don't remember what I was thinking for that. | 19:08 |
| th1a | It is pretty paranoid. | 19:08 |
| replaceafill | :) | 19:08 |
| replaceafill | well, i'll write "review resources security" in my TODO | 19:08 |
| replaceafill | will finish these course changes first | 19:09 |
| replaceafill | damn! | 19:15 |
| replaceafill | continuing the leaders conversation... | 19:15 |
| replaceafill | leaders get schooltool.edit on their contexts :( | 19:16 |
| replaceafill | so they can access object/leaders.html!!! | 19:16 |
| replaceafill | through URL | 19:16 |
| replaceafill | writing it down in the TODO | 19:16 |
| replaceafill | * fix: schoolyears/AYEAR/courses/ACOURSE/leaders.html is still accessible to leaders through URL | 19:16 |
| th1a | Probably we should change the permissions. | 19:16 |
| th1a | These are overly complicated. | 19:16 |
| th1a | Er. | 19:17 |
| th1a | Oh, they can edit it? | 19:17 |
| replaceafill | yes, leaders get schooltool.edit on things they're responsible for | 19:17 |
| replaceafill | i managed to hide the "Add" menu from the course index for leaders | 19:17 |
| replaceafill | and the "Responsible parties" block | 19:17 |
| replaceafill | but they can access the urls | 19:18 |
| replaceafill | well, not for adding courses | 19:18 |
| replaceafill | but yes for editing other leaders in the object | 19:18 |
| th1a | This is a very minor point. | 19:18 |
| replaceafill | i was thinking maybe people dont use leaders too much | 19:19 |
| replaceafill | since they dont do much in the current version | 19:19 |
| replaceafill | th1a http://69.164.203.135:6660/schoolyears/2011/courses/chemistry | 19:19 |
| replaceafill | log out and login as carmen/carmen | 19:19 |
| replaceafill | carmen is a leader on that course | 19:19 |
| replaceafill | she can edit it | 19:20 |
| replaceafill | but she doesnt see the Add menu or the Responsible parties block | 19:20 |
| th1a | I was just thinking that it would be good to make escalating privileges better as a general rule of thumb. | 19:20 |
| th1a | But it is a very minor point. | 19:20 |
| replaceafill | right | 19:20 |
| th1a | I mean, making escalating privileges harder is better. | 19:20 |
| replaceafill | i blame the LeadersCrowd | 19:21 |
| replaceafill | :) | 19:21 |
| replaceafill | ok, final item: making Cancel smarter | 19:21 |
| replaceafill | and then will move to /sections | 19:21 |
| th1a | Literally you could change the permission and file a low priority bug that we'll never look at. | 19:21 |
| replaceafill | :D | 19:22 |
| th1a | Just do that (but don't file the bug) | 19:23 |
| replaceafill | what do you mean by "change the permission"? | 19:23 |
| replaceafill | change the permission on leaders.html? | 19:23 |
| th1a | So leaders can add leaders. | 19:23 |
| replaceafill | ah | 19:23 |
| replaceafill | ok | 19:23 |
| replaceafill | cool, leaders can edit leaders now | 19:24 |
| replaceafill | easier ;) | 19:24 |
| *** ignas has quit IRC | 19:24 | |
| replaceafill | done | 19:25 |
| * th1a wonders if we just broke some tests. ;-) | 19:29 | |
| replaceafill | :))) | 19:29 |
| replaceafill | we'll find out soon i hope :) | 19:30 |
| replaceafill | th1a http://69.164.203.135:6660/schoolyears/2012/courses/Swimming | 19:47 |
| replaceafill | Cancel in Add Course is smart now | 19:47 |
| replaceafill | http://69.164.203.135:6660/courses?schoolyear_id=2012 | 19:47 |
| replaceafill | i guess that's it for /courses! | 19:48 |
| th1a | Excellent. | 20:07 |
| th1a | We've got three weeks until feature freeze as of today, by the way. | 20:08 |
| aelkner | guys, courses looks nice! | 20:09 |
| replaceafill | i hope /sections and /groups will be faster | 20:09 |
| aelkner | the title together with the tabs is so easy to follow | 20:09 |
| aelkner | well, sections is more complicated than courses | 20:10 |
| aelkner | groups will be easier | 20:10 |
| replaceafill | i think /sections is just one extra step | 20:10 |
| aelkner | th1a, could i do groups after i finish terms | 20:10 |
| replaceafill | to look for the right course | 20:10 |
| replaceafill | aelkner dont you want to start with interventions? | 20:11 |
| replaceafill | and let /groups to me | 20:11 |
| aelkner | is that the plan | 20:11 |
| replaceafill | i think i can do both today | 20:11 |
| aelkner | replaceafill, we could do that | 20:11 |
| replaceafill | i mean, interventions is your baby :) | 20:11 |
| replaceafill | and i cannot touch it! :P | 20:11 |
| replaceafill | (kidding) | 20:12 |
| aelkner | well... | 20:12 |
| replaceafill | but i'll let th1a to decide | 20:12 |
| replaceafill | just my $0.02 | 20:12 |
| aelkner | but if you're already in that mindspace, i agree you should do groups | 20:12 |
| replaceafill | i think so | 20:12 |
| replaceafill | it's the same "pattern" | 20:13 |
| replaceafill | hey! i'm using your words!!! | 20:13 |
| replaceafill | :D | 20:13 |
| aelkner | :) | 20:13 |
| aelkner | i was just thinking from the point of view of having a next task + having a chance to get into that mindspace | 20:13 |
| aelkner | but it's not important | 20:14 |
| aelkner | are we alomost ready to work on the plugins? | 20:14 |
| aelkner | i noticed th1a mentioned gradebook tasks that you and he would work on, is that soon? | 20:14 |
| replaceafill | gradebook, i think he said interventions | 20:15 |
| replaceafill | that's why i came up with that | 20:15 |
| aelkner | i think you and i should each pick a plugin befreo we start | 20:15 |
| aelkner | better for us to not step on each other's merge | 20:15 |
| replaceafill | you're the one for interventions i think | 20:16 |
| replaceafill | you know it better | 20:17 |
| aelkner | i agree | 20:17 |
| aelkner | you already have mucho experience with the gradebook | 20:17 |
| replaceafill | :D | 20:17 |
| aelkner | and we can fight over the journal after that :) | 20:17 |
| replaceafill | ok, we're swtiching to spanish next week | 20:17 |
| aelkner | no (the spanish no, not the english one) | 20:18 |
| aelkner | :) | 20:18 |
| replaceafill | :D | 20:18 |
| replaceafill | ok, i'm about to push these changes to trunk | 20:18 |
| * th1a is back. | 20:24 | |
| replaceafill | aelkner i want your opinion on something | 20:27 |
| th1a | OK... | 20:27 |
| replaceafill | http://pastebin.com/kTHkYVGr | 20:27 |
| th1a | I want to finish the management views completely before moving on. | 20:27 |
| th1a | So groups next for replaceafill. | 20:27 |
| th1a | Then replaceafill > journal. | 20:27 |
| th1a | (I mis-typed about interventions) | 20:28 |
| th1a | aelkner > gradebook | 20:28 |
| th1a | yvl > calendar | 20:28 |
| th1a | Presumably aelkner > interventions, but basically, it is the red-headed stepchild still, so whomever has time. | 20:28 |
| replaceafill | th1a /sections -> /groups -> journal right? | 20:29 |
| replaceafill | i think i can have the first two by tomorrow | 20:29 |
| th1a | Whomever is free. | 20:29 |
| th1a | OK. | 20:29 |
| aelkner | red-headed stepchild? i'm not getting the reference | 20:30 |
| * replaceafill wondered the same! | 20:30 | |
| aelkner | is that a slur on irish people? :) | 20:30 |
| replaceafill | the /courses and related views pushed to trunk | 20:33 |
| replaceafill | th1a, i think i'll do /groups before /sections | 20:35 |
| replaceafill | since it's almost the same as /courses | 20:36 |
| th1a | kk | 20:38 |
| *** ignas has joined #schooltool | 20:53 | |
| replaceafill | th1a zyt? | 21:09 |
| th1a | yes | 21:09 |
| replaceafill | http://69.164.203.135:6660/groups | 21:09 |
| th1a | are you restarting? | 21:09 |
| replaceafill | oops restarting the server | 21:09 |
| replaceafill | yes | 21:09 |
| replaceafill | restarted | 21:09 |
| th1a | Got it. | 21:09 |
| th1a | Get rid of the hints. | 21:10 |
| replaceafill | gone! | 21:11 |
| replaceafill | restarted the server | 21:11 |
| replaceafill | hhmmm | 21:15 |
| replaceafill | we can't delete default groups!! | 21:15 |
| replaceafill | DependencyError :D | 21:15 |
| replaceafill | will make the Delete link smarter | 21:15 |
| replaceafill | hey! the members!!! | 21:16 |
| replaceafill | we should be able to see the members of the group, right? :D | 21:16 |
| replaceafill | unless we think we dont need that functionality anymore ;) | 21:16 |
| replaceafill | (joke) | 21:16 |
| th1a | Yes. | 21:17 |
| replaceafill | we still dont worry about import views, right? | 21:18 |
| replaceafill | ah, the Reports tab too | 21:19 |
| replaceafill | and a Calendar link | 21:19 |
| th1a | Well, there is no particular reason we're skipping import views, unless someone wants to argue for moving them. | 21:20 |
| replaceafill | i think we were going to do a full sweep on import views later | 21:20 |
| replaceafill | xls, csv, etc | 21:20 |
| replaceafill | but i'm most worried about the members views right now | 21:21 |
| replaceafill | and action link: Manage Members | 21:21 |
| replaceafill | ? | 21:21 |
| replaceafill | and we list them under the group details in group index? | 21:22 |
| replaceafill | like the old view | 21:22 |
| * replaceafill thinks is asking th1a too much :( | 21:22 | |
| th1a | I think all the exports should be centralized as reports. | 21:23 |
| th1a | But the imports probably are just actions on the container indexes. | 21:23 |
| th1a | Just under the details is fine for members. | 21:24 |
| th1a | Above responsible parties. | 21:24 |
| th1a | With a pencil. | 21:24 |
| replaceafill | ah! | 21:24 |
| replaceafill | i always forget the pencil :) | 21:24 |
| th1a | :-D | 21:25 |
| replaceafill | should i add a third action links group for Calendar and Reports | 21:25 |
| replaceafill | under ${group}'s | 21:25 |
| replaceafill | like we do for persons? | 21:25 |
| replaceafill | ${group}'s | 21:26 |
| replaceafill | - Calendar | 21:26 |
| replaceafill | - Reports | 21:26 |
| th1a | Yes. | 21:27 |
| th1a | Delete should be last. | 21:28 |
| replaceafill | ${groups}'s, Add and Actions | 21:28 |
| replaceafill | for the link groups | 21:28 |
| replaceafill | ok, will work on these changes | 21:30 |
| th1a | kk | 21:30 |
| *** fsufitch has quit IRC | 21:56 | |
| * replaceafill wonders if it's better to hide the Delete link or render it "deactivated" | 22:27 | |
| replaceafill | th1a zty? | 23:00 |
| replaceafill | oops, zyt? :D | 23:01 |
| * replaceafill is getting hungry... | 23:01 | |
| replaceafill | http://69.164.203.135:6660/schoolyears/2011/groups/baseball | 23:01 |
| replaceafill | i think group functionality is complete | 23:01 |
| replaceafill | ah, except for reports | 23:02 |
| replaceafill | - add reports view for groups | 23:02 |
| replaceafill | * Student Detail Report by Group | 23:02 |
| replaceafill | * Student Report Card by Group | 23:02 |
| replaceafill | last item of my TODO | 23:02 |
| replaceafill | but i had a question about the title: subtitle in the edit members view | 23:02 |
| replaceafill | in group index we have Groups for 2011: Baseball | 23:03 |
| replaceafill | and the Baseball: Members | 23:03 |
| replaceafill | and Baseball: Responsible parties | 23:03 |
| replaceafill | no reference to the year, is that ok? | 23:03 |
| * replaceafill goes to get lunch | 23:04 | |
| replaceafill | aelkner you there? | 23:54 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!
