| *** alga has quit IRC | 01:31 | |
| *** menesis has quit IRC | 01:53 | |
| *** aks has joined #schooltool | 06:03 | |
| *** aelkner has quit IRC | 08:03 | |
| *** aelkner has joined #schooltool | 08:22 | |
| *** Lumiere_ has joined #schooltool | 08:54 | |
| *** Lumiere has quit IRC | 08:55 | |
| *** Lumiere_ is now known as Lumiere | 08:55 | |
| *** Lumiere has joined #schooltool | 08:55 | |
| *** Lumiere has quit IRC | 09:26 | |
| *** Lumiere has joined #schooltool | 09:39 | |
| *** Lumiere has quit IRC | 09:44 | |
| *** aks has quit IRC | 09:48 | |
| *** Lumiere has joined #schooltool | 09:52 | |
| *** yvl has joined #schooltool | 10:04 | |
| *** alga has joined #schooltool | 10:13 | |
| *** aks has joined #schooltool | 10:20 | |
| *** menesis has joined #schooltool | 11:29 | |
| *** menesis has quit IRC | 13:51 | |
| *** menesis1 has joined #schooltool | 13:51 | |
| *** menesis1 is now known as menesis | 13:51 | |
| *** menesis has quit IRC | 14:03 | |
| *** aks has quit IRC | 14:21 | |
| *** menesis has joined #schooltool | 15:12 | |
| *** menesis has quit IRC | 15:17 | |
| *** menesis has joined #schooltool | 15:32 | |
| *** th1a has joined #schooltool | 15:44 | |
| *** replaceafill has joined #schooltool | 16:29 | |
| th1a | hi replaceafill, aelkner, yvl, menesis. | 16:31 |
|---|---|---|
| yvl | good morning! :) | 16:31 |
| replaceafill | good morning/afternoon | 16:31 |
| aelkner | morning | 16:32 |
| menesis | hi | 16:32 |
| th1a | I have to be somewhere for a meeting at 11:00, so we need to be a little quicker than ususal. | 16:33 |
| th1a | 11:00 is in 90 minutes, so we have about 75 minutes. | 16:33 |
| th1a | so... aelkner? | 16:33 |
| aelkner | yeah, so i added the absences and tardies columns to the gradebook last week | 16:34 |
| aelkner | also, i removed Term Grading from the journal | 16:34 |
| th1a | Do you understand yvl's feedback? | 16:36 |
| aelkner | for term grading? | 16:36 |
| th1a | Yes? | 16:36 |
| aelkner | because the question was why we did so which i'll need you to answer | 16:36 |
| th1a | I answered why we removed it. | 16:37 |
| yvl | th1a already did | 16:37 |
| th1a | Just sent the email. | 16:37 |
| th1a | But there were some technical points, too, right? | 16:37 |
| aelkner | sorry, catching up with the email... | 16:37 |
| replaceafill | testing layers | 16:37 |
| aelkner | yeah, i'll put the classes back to allow me to evolve the term grading away | 16:37 |
| aelkner | but i don't understand the part about separate test layer for including journal | 16:38 |
| aelkner | the the journal package is loaded because of what's in setup.py | 16:38 |
| yvl | when you are testing a gradebook without journal, you need a functional zcml that does not include journal | 16:38 |
| aelkner | extras_require | 16:39 |
| yvl | hmm, it should not be included automatically | 16:40 |
| yvl | oh, and it is no | 16:40 |
| yvl | t | 16:40 |
| yvl | see gradebook/browser/ftesting.zcml | 16:40 |
| yvl | <include package="schooltool.lyceum.journal" file="meta.zcml" /> | 16:40 |
| yvl | <include package="schooltool.lyceum.journal" /> | 16:40 |
| yvl | do not include that and you will be fine | 16:41 |
| th1a | Got that aelkner? | 16:42 |
| * th1a is trying to keep things moving... | 16:42 | |
| aelkner | sorry, trying to find the email that yvl says how he did a separate ftesting.zcml | 16:43 |
| yvl | I never said that | 16:43 |
| yvl | I say you should do it if you need to | 16:43 |
| yvl | anyway | 16:43 |
| yvl | let's discuss this after meeting | 16:44 |
| aelkner | ok, so that's it for me | 16:44 |
| th1a | It isn't clear to me why this is necessary either, btw. | 16:44 |
| th1a | What's next on your list, aelkner? | 16:44 |
| aelkner | XLS importer could use section id as a way to automatically link sections | 16:45 |
| th1a | Ah, yes. OK. Good. | 16:45 |
| *** Lumiere has quit IRC | 16:45 | |
| th1a | Thanks, aelkner. | 16:45 |
| th1a | replaceafill: I need your April invoice. | 16:45 |
| th1a | And you can go ahead... | 16:45 |
| replaceafill | th1a ah, will send it today | 16:45 |
| replaceafill | ok | 16:46 |
| replaceafill | last week i came back from eduJAM! 2011 | 16:46 |
| replaceafill | was great getting together with people from the sugar community | 16:46 |
| replaceafill | met people from deployments from nepal, rwanda, etc | 16:46 |
| replaceafill | you can read http://proyectojuanchacon.blogspot.com/2011/05/edujam-2011.html if you're interested | 16:47 |
| replaceafill | th1a i updated the cambodia instance | 16:47 |
| replaceafill | and now i'm waiting for the feedback loop to happen | 16:47 |
| replaceafill | on my plate i only have the 9th and 12th grade exam reports | 16:48 |
| replaceafill | could i give it a shot this week? | 16:48 |
| th1a | I was thinking you could take a break and do some CSS & JS work. | 16:48 |
| replaceafill | ah, ok | 16:48 |
| th1a | We don't want to run too far ahead of our feedback. | 16:48 |
| replaceafill | we can talk specifics later today if you want | 16:48 |
| replaceafill | correct | 16:49 |
| th1a | OK. Let's move on for now, then. | 16:49 |
| replaceafill | ok | 16:49 |
| th1a | menesis? | 16:49 |
| menesis | I finished with various branches | 16:50 |
| menesis | stable ones | 16:50 |
| menesis | there are now 1.6 branches for everything and trunk is open for development | 16:50 |
| menesis | Added several builders to buildbot | 16:51 |
| menesis | for 1.6, 1.5, and 1.4 - all series that we "support" | 16:51 |
| menesis | also "versionator" builders for all of them | 16:51 |
| th1a | Good use of scare quotes. | 16:52 |
| menesis | to check that all dependencies are still there, and what is the status of packages versions | 16:52 |
| menesis | also added debian unstable to versionator_trunk to help me see what needs to be done to sync oneiric with unstable | 16:53 |
| menesis | done nothing for debian yet | 16:53 |
| menesis | apart from maintenance branches and buildbots | 16:53 |
| menesis | I finally merged Alan's intervention refactoring branch (test_coverage) | 16:54 |
| menesis | there are two more merge requests pending | 16:55 |
| menesis | will merge them this week | 16:55 |
| th1a | Does that include Justas's timetable work? I'd like to get that merged in the next two weeks. | 16:55 |
| yvl | no, but please let me merge that | 16:56 |
| yvl | with my branch of UI remake first | 16:56 |
| menesis | no, timetables are not finished | 16:56 |
| th1a | OK, I'll leave that an open issue. | 16:58 |
| menesis | that's all to report | 16:58 |
| th1a | But we do need to merge that as soon as possible, or it will miss the next release. | 16:58 |
| * yvl agrees | 16:58 | |
| th1a | This is the kind of thing one learns with experience. ;-) | 16:59 |
| th1a | Thanks, menesis. | 16:59 |
| th1a | yvl? | 16:59 |
| yvl | worked on viewlet sorting last week | 16:59 |
| yvl | also CSS | 16:59 |
| yvl | also "test" page layout | 17:00 |
| * replaceafill liked the sorting algorithm :) | 17:00 | |
| yvl | well at least it detects cyclic dependencies :) | 17:00 |
| yvl | it's not good enough, but good for now | 17:00 |
| yvl | I'm pretty happy with CSS and layout at this point actually | 17:01 |
| yvl | now working on page templates in ST | 17:01 |
| yvl | and respective content providers, viewlet managers and such | 17:01 |
| yvl | ok, that's that | 17:03 |
| th1a | Cool. Thanks, yvl. | 17:03 |
| aelkner | talk about a quick around the table! | 17:03 |
| th1a | Once we get the rough mockups a little closer we can get everyone in on that conversation. | 17:03 |
| th1a | OK, let's address this Javascript testing issue. | 17:03 |
| th1a | One thing that is good is that we're narrowing things down to specifics. | 17:04 |
| th1a | So we don't really have to ask "how do we test all possible Javascript" | 17:04 |
| th1a | But rather, how do we test the specific Javascript elements which it is important for us to add. | 17:04 |
| th1a | And really, even narrowing that down to jquery-ui, | 17:04 |
| th1a | the MUST's within jquery-ui is just a few widgets. | 17:05 |
| th1a | So we can do YAGNI with regards to our testing framework. | 17:05 |
| yvl | just to make sure we're on the same page | 17:06 |
| th1a | Also, I think we need to be judicious about which JS actions are most mission critical. | 17:06 |
| yvl | YAGNI what? | 17:06 |
| th1a | "Sometime in the future we may try some tweaked Javascript Ajax technique, so we can't use this relatively lightweight testing framework. | 17:06 |
| th1a | " | 17:06 |
| yvl | right | 17:07 |
| th1a | So, for example, we might start using jquery-ui accordions. | 17:07 |
| th1a | http://jqueryui.com/demos/accordion/ | 17:07 |
| yvl | you really like them :) | 17:07 |
| th1a | I kinda do. | 17:07 |
| yvl | these are a good example by the way - | 17:08 |
| th1a | Actually, I like that it lets you add things in a vertical stack instead of a row of tabs. | 17:08 |
| th1a | So if someone wants 10, it doesn't break the page. | 17:08 |
| yvl | you can have everything unrolled | 17:08 |
| yvl | and have a small "wrapper" that rolls up everything and makes it an accordion | 17:08 |
| yvl | form the testing perspective, our functional tests will cover 99% of the feature | 17:09 |
| th1a | Yes. | 17:09 |
| th1a | This is not a testing problem because the page still works without JS, and what the JS does not change the database. | 17:09 |
| th1a | So the worst bug is relatively minor. | 17:09 |
| yvl | well, testing is also important for a user | 17:10 |
| yvl | if we make a mistake | 17:10 |
| yvl | and some JS events get eaten up | 17:10 |
| yvl | user will never be able to unfold the accordeon | 17:10 |
| yvl | and see the content | 17:10 |
| replaceafill | or change the dropdowns in the current gradebook | 17:10 |
| th1a | Well... that's sort of the question. | 17:10 |
| yvl | or save the grades | 17:10 |
| yvl | details like that | 17:11 |
| th1a | Let's stay on accordions. | 17:11 |
| yvl | ok | 17:11 |
| th1a | Just talk through a simple case. | 17:11 |
| th1a | I'm pretty much ok with automated testing to make sure the content is right and mostly manual testing to make sure accordions open and close. | 17:11 |
| yvl | well, I see two things that need testing there | 17:12 |
| yvl | open and close nicely, as in - library works as intended - which I do not want to test that strongly | 17:13 |
| th1a | That might not be relevant if we have to have a JS testing framework anyhow that will make it easy to test the opening of the accordion, but I'm just giving you my perspective. | 17:13 |
| yvl | we can assume the library works as we imagine it works | 17:13 |
| th1a | Right -- we don't have to write a jquery test suite! | 17:13 |
| replaceafill | if we use it correctly... | 17:13 |
| yvl | precisely. | 17:13 |
| yvl | we might break it. | 17:13 |
| yvl | without knowing it | 17:14 |
| yvl | if we use jquery that comes with Ubuntu | 17:14 |
| yvl | something will change at some point | 17:14 |
| th1a | OK. Good point. | 17:14 |
| yvl | at any point, by the way | 17:14 |
| yvl | then again - setting up proper tests with selenium will be pain | 17:15 |
| th1a | OK, let's stick a pin in that and move on for a minute. | 17:15 |
| yvl | running at least some selenium tests manually by developers - easier | 17:15 |
| yvl | ok | 17:15 |
| *** Lumiere has joined #schooltool | 17:15 | |
| th1a | So... then there is a middle category of things that might be slightly nicer in jquery-ui implementation but need to be looked at in a case by case basis. | 17:16 |
| th1a | Enhanced, buttons, tabs, that kind of thing. | 17:16 |
| th1a | In those cases, the additional testing complexity may genuinely make it not worthwhile. | 17:17 |
| th1a | (not to mention the complexity complexity) | 17:17 |
| yvl | true | 17:17 |
| th1a | For the sake of completeness, the third category is things we don't want or need in jquery-ui. | 17:18 |
| yvl | also, overdone flashyness is not necessarily better for the end user | 17:18 |
| th1a | Yes. | 17:18 |
| th1a | So... the biggie at this point is... dialogs. | 17:18 |
| th1a | I want. | 17:18 |
| th1a | And they need to be tested. | 17:18 |
| yvl | all I can say is yes and yes | 17:19 |
| th1a | So that's the real hairball. | 17:19 |
| th1a | And perhaps what replaceafill will work on this week. | 17:19 |
| yvl | no | 17:19 |
| th1a | lol | 17:19 |
| yvl | please | 17:19 |
| th1a | yvl wants. | 17:19 |
| yvl | :D | 17:19 |
| replaceafill | :/ | 17:19 |
| yvl | well that may be the case :) | 17:19 |
| yvl | what I meant is - later | 17:19 |
| yvl | first, dialogs where? | 17:20 |
| yvl | confirmation for deletion? | 17:20 |
| yvl | forms? | 17:20 |
| yvl | some of the forms? | 17:20 |
| yvl | what about "relationship set up views" | 17:20 |
| th1a | I guess I need to know what the issues are with them, and I don't think anyone of us has enough experience with them to tell me. | 17:20 |
| * yvl wants central and slim implementation in the end | 17:20 | |
| th1a | I would like to use them in lots of ways. | 17:21 |
| yvl | please, umm, enumerate in email | 17:21 |
| * yvl 's english is awful | 17:21 | |
| th1a | yvl's english is fine. | 17:22 |
| yvl | I haven't done them personally, but I talked on this topic a lot | 17:22 |
| replaceafill | do dialogs include "success confirmation messages like: your changes were saved successfully"? | 17:22 |
| replaceafill | because i think we should improve those | 17:22 |
| th1a | Yes. | 17:22 |
| replaceafill | ah ok | 17:22 |
| yvl | sure | 17:22 |
| yvl | maybe we can compose a list of what we want to do | 17:22 |
| th1a | To be honest, I don't even think that is necessary yet. | 17:23 |
| yvl | what I would like to have | 17:23 |
| yvl | is types of things to test | 17:23 |
| th1a | Basically, I need to know the cost of including each type of jquery dialog. | 17:23 |
| yvl | ok | 17:24 |
| th1a | Is adding a js confirmation dialog a two hour job? | 17:24 |
| *** alga has quit IRC | 17:24 | |
| yvl | it may be the first time :) | 17:24 |
| yvl | as for testing.......... | 17:24 |
| th1a | The main question is how hairy will it be to add modal forms. | 17:25 |
| yvl | strangely, I think that may be the easiest part :) | 17:25 |
| th1a | This is what I need to know. | 17:25 |
| th1a | It isn't even starting to add them into specific places yet. | 17:25 |
| yvl | or at least - as easy as confirmation dialog displaying what you are deleting | 17:26 |
| yvl | replaceafill, if you want, you can surely play with this! | 17:27 |
| th1a | So I would propose that replaceafill does some prototyping with jquery-ui dialogs. | 17:27 |
| yvl | ok | 17:27 |
| th1a | Within SchoolTool. | 17:27 |
| yvl | of course | 17:27 |
| yvl | I would like to see this, ideally: | 17:27 |
| yvl | a button onClick, that invokes a single JS function | 17:27 |
| yvl | preferrably in library, not ours | 17:28 |
| yvl | that renders the form - contents of a simple schooltool page | 17:28 |
| yvl | like http://schooltool/..../person/something/add_js.html | 17:28 |
| yvl | I think that should might turn out trivial | 17:29 |
| yvl | or not | 17:29 |
| th1a | Testing is definitely the hard part. | 17:29 |
| yvl | if the resulting code is 4 lines of js | 17:30 |
| yvl | auto-generated in one place in ST | 17:30 |
| yvl | we might get away without testing | 17:30 |
| *** Lumiere has quit IRC | 17:30 | |
| th1a | Well, let's find out. | 17:30 |
| yvl | sure | 17:30 |
| th1a | replaceafill: Make sense? | 17:30 |
| replaceafill | yvl define: "preferrably in library, not ours" | 17:31 |
| yvl | in jquery | 17:31 |
| yvl | I'd like to avoid our own JS functions | 17:31 |
| yvl | it might be possible | 17:31 |
| yvl | it might be as easy as binding a single onClick call | 17:32 |
| yvl | and then changing our form html to render <form></form> part | 17:32 |
| yvl | instead of whole <html> | 17:32 |
| replaceafill | ah! got it | 17:32 |
| yvl | well, keep it as simple as possible | 17:33 |
| th1a | OK. | 17:33 |
| replaceafill | i'll ask if i get stuck :P | 17:34 |
| yvl | ;) | 17:34 |
| th1a | We have two weeks until the UI sprint, which seems about right. | 17:34 |
| th1a | The UI pre-sprint has begun... | 17:34 |
| yvl | (a week ago :P) | 17:34 |
| th1a | One more issue to think about -- do we want to use some different version control paradigm to allow everyone to check in UI changes to a sprint branch? | 17:35 |
| yvl | good point | 17:35 |
| th1a | I'm going to have to be able to run a single bleeding edge branch. | 17:35 |
| th1a | We don't have to decide that now, but we'll have to figure something out. | 17:36 |
| yvl | you might end up with 4 different branches and the wisdom to look at what where :/ | 17:36 |
| yvl | but maybe we can work out something more reasonable | 17:37 |
| th1a | Well... I want everyone to see what everyone else is doing as well... | 17:37 |
| th1a | Or we could just rely only on screenshots. | 17:37 |
| th1a | Anyhow, something to consider. | 17:37 |
| replaceafill | +1 on branches | 17:37 |
| yvl | yes | 17:37 |
| th1a | OK. | 17:38 |
| th1a | All right. I think we're done then. | 17:38 |
| th1a | Have a great week, gentlemen! | 17:39 |
| * th1a drops the bag of gravel. | 17:39 | |
| yvl | this is going to be fun! :) | 17:39 |
| th1a | I guess aelkner and yvl can finish sorting out the testing question. | 17:39 |
| yvl | yes | 17:39 |
| aelkner | yep | 17:39 |
| * th1a leaves. | 17:39 | |
| yvl | see you around, th1a | 17:39 |
| aelkner | so testing_funcitonal.py icreates gradebook_functional_layer | 17:39 |
| yvl | aelkner, can I take a small break? | 17:40 |
| aelkner | which is based on ftesting.zcml that has the journal incudes | 17:40 |
| yvl | 7 min - out of coffee | 17:40 |
| aelkner | yvl, sure | 17:40 |
| * yvl back | 17:50 | |
| menesis | aelkner: I have reverted your stubs and removal of journal includes | 17:50 |
| menesis | because there are two cases: no journal, and journal | 17:50 |
| menesis | I left only a case when there is a journal | 17:50 |
| menesis | the other case is not tested | 17:50 |
| aelkner | right, that was my point | 17:51 |
| aelkner | the question is: how to create the other case? | 17:51 |
| menesis | remove journal from ftesting.zcml | 17:51 |
| aelkner | which would break the many tests that depend on the journal | 17:52 |
| menesis | and only include journal in tests that test journal integration | 17:52 |
| aelkner | again, how? | 17:52 |
| aelkner | as i was saying above, testing_funcitonal.py icreates gradebook_functional_layer | 17:53 |
| aelkner | which is based on ftesting.zcml that has the journal incudes | 17:53 |
| aelkner | collect_ftests(layer=gradebook_functional_layer) | 17:53 |
| aelkner | that collects every test by loking for .txt files | 17:54 |
| aelkner | even if i were to create a new ftesting_no_journal.zcml | 17:54 |
| aelkner | and a functional layer for it | 17:54 |
| replaceafill | aelkner why dont you create a copy of test_functional.py, use ftesting_no_journal.zcml and pass the filenames of the tests to collect_ftests | 17:54 |
| replaceafill | collect_ftests(layer=gradebook_functional_layer_with_no_journal, filenames=['THIS.txt']) | 17:55 |
| menesis | the case with no journal is the default | 17:55 |
| menesis | ftesting.zcml should not include journal | 17:55 |
| aelkner | and what would stop the other functional layer from picking up ThIS.txt? | 17:55 |
| replaceafill | aelkner ah! | 17:55 |
| replaceafill | no :( | 17:55 |
| menesis | I was just explaining why includes are still there | 17:55 |
| menesis | I don't think you need another layer | 17:56 |
| yvl | true | 17:56 |
| yvl | menesis is right | 17:56 |
| yvl | well | 17:56 |
| menesis | a test checks that there is nothing (because journal is not available) | 17:56 |
| menesis | then does registerAdapter(...Section...JournalData) | 17:56 |
| menesis | to register the needed adapters | 17:57 |
| menesis | and then checks if the data appears in report | 17:57 |
| aelkner | the thing is: | 17:58 |
| menesis | hm. okay you can't provideAdapters in ftests | 17:58 |
| menesis | :/ | 17:58 |
| yvl | well you can :) | 17:58 |
| aelkner | right, that, too | 17:58 |
| aelkner | but also, the tests click around the journal ui, so it needs to be theere | 17:58 |
| yvl | look at it this way | 17:59 |
| yvl | if gradebook is not hard-dependent on journal | 17:59 |
| yvl | journal does not exist and should not be used | 17:59 |
| yvl | so current tests are broken in my eyes | 17:59 |
| yvl | stub out whatever ui is necessary | 18:00 |
| yvl | remove clicking through unnecessary ui from tests | 18:00 |
| aelkner | get rid of extras_require inclusion of journal in setup.py? | 18:00 |
| yvl | I vote yes :) | 18:01 |
| yvl | mind - it's just a vote | 18:01 |
| yvl | menesis has different opinion :) | 18:01 |
| aelkner | well, let's have it out here | 18:01 |
| aelkner | up to this point, i think i have pointed out how things won't work as suggested | 18:02 |
| aelkner | so what to do? | 18:02 |
| yvl | menesis convinced me to leave setup.py alone | 18:02 |
| yvl | remove inclusion of lyceum.journal from ftesting.zcml | 18:03 |
| yvl | tests break | 18:03 |
| yvl | fix tests | 18:03 |
| yvl | write new tests where needed | 18:03 |
| *** Lumiere has joined #schooltool | 18:03 | |
| yvl | hmm | 18:04 |
| yvl | what breaks when lyceum.journal is removed? | 18:04 |
| aelkner | any tests that rely on journal data being loaded, then reports being run and expected journal data coming out | 18:05 |
| aelkner | also, any journal views needed for loading journal data in | 18:05 |
| yvl | well, the journal behaviour should be stubbed in my opinion | 18:06 |
| aelkner | how could it be stubbed? | 18:06 |
| yvl | personally I would go with another testing layer for these tests | 18:06 |
| yvl | add simple views that can accept data where it needs to change | 18:07 |
| yvl | and even store it temporarily wherever | 18:07 |
| yvl | even in app | 18:07 |
| aelkner | first, yvl and menesis need to agree ob the approach | 18:07 |
| aelkner | then, someone needs to explain to me technically how to make that approach work | 18:07 |
| aelkner | so first things first, what approach? | 18:08 |
| aelkner | i assume that yvl and menesis are discussing this right now... | 18:11 |
| yvl | yes | 18:17 |
| yvl | aelkner, can you remind me one thing | 18:19 |
| yvl | journal adds external activities, right? | 18:19 |
| yvl | and the code of adding them is in journal? | 18:19 |
| aelkner | no, i put that in the gradebook | 18:20 |
| yvl | crap | 18:21 |
| aelkner | the journal does not depend on the gradebook | 18:21 |
| aelkner | so it is impossible to do: | 18:21 |
| aelkner | from schooltool.gradebook.interfaces import IExternalActivities | 18:21 |
| aelkner | cando does, so it is | 18:21 |
| *** alga has joined #schooltool | 18:22 | |
| aelkner | i mentioned all of this in my email to the developers list last week | 18:22 |
| yvl | yes | 18:22 |
| yvl | sorry, that's what happens when I try to work on many things at once | 18:22 |
| yvl | things slip my mind sometimes | 18:22 |
| yvl | my fault | 18:22 |
| aelkner | understanable | 18:22 |
| yvl | hmm | 18:23 |
| yvl | maybe the issue is not that burning | 18:23 |
| yvl | can we pretend that all is fine, and do nothing | 18:23 |
| yvl | and put this as a technical debt for now | 18:23 |
| yvl | as I really would like not to work on this now | 18:24 |
| aelkner | yvl, that's fine, just so you know the outstanding issue | 18:24 |
| yvl | and Tom needs to know that it is | 18:24 |
| aelkner | i got all the external activity stuff to work, with tests | 18:24 |
| yvl | he's a manager after all! | 18:24 |
| aelkner | then i found that it failed with manual test | 18:24 |
| aelkner | because i didn't have the plug-in | 18:25 |
| aelkner | so i fixed those bugs in one of my commits | 18:25 |
| aelkner | only problem, no way to create the problem in tests | 18:25 |
| aelkner | so the ISectionAttendanceData(section, None) that fixed the problem | 18:26 |
| aelkner | will never return None because ournal is always there in tests | 18:26 |
| aelkner | that's the only reason we need to have this discussion | 18:26 |
| yvl | ok | 18:26 |
| aelkner | but if menesis and you are ok with having that scenario untested, that's your call | 18:27 |
| yvl | I need to look at this more closely at some point | 18:27 |
| yvl | preferably not now | 18:27 |
| aelkner | remember to refer back to email when you do | 18:27 |
| aelkner | i went through the trouble of writing them after all :) | 18:27 |
| menesis | aelkner: I am not happy but I was planning to sort this journal/gradebook/intervention separation myself | 18:27 |
| yvl | aelkner, can you please file a bug for me in Lauchpad? | 18:27 |
| yvl | aelkner, I read those! | 18:28 |
| yvl | just sometimes forget stuff :) | 18:28 |
| aelkner | no, i wasn't saying that you didn't read them | 18:28 |
| yvl | a bug - because it may be reassigned to menesis, for example :) | 18:28 |
| aelkner | just reminding you to refer back to them, that's all | 18:28 |
| * replaceafill will file questions for yvl as bugs from now on :P | 18:28 | |
| aelkner | i won't usually, but in this case i can file a bug | 18:29 |
| yvl | yes | 18:29 |
| yvl | it's a technical debt that needs to be marked :) | 18:29 |
| yvl | thanks aelkner | 18:29 |
| yvl | apologies for the situation you got in :) | 18:29 |
| aelkner | yvl, i pushed the change to re-include the class definitions | 18:30 |
| aelkner | evolution now works for removing term grading container | 18:30 |
| aelkner | yvl, np on the situation | 18:30 |
| yvl | aelkner, a note on your last commit | 18:31 |
| yvl | you don't need to add back ZCML | 18:31 |
| yvl | also you probably do not need implementations of the methods in TermGradingData | 18:31 |
| yvl | the important part is: | 18:32 |
| yvl | class TermGradingData(Persistent): | 18:32 |
| yvl | and class LyceumTermDataContainer(BTreeContainer): | 18:32 |
| yvl | class contents are usually not that usefull | 18:33 |
| yvl | I tend to add other stuff for reference, like: | 18:33 |
| yvl | __parent__ = None | 18:33 |
| yvl | __name__ = None | 18:33 |
| yvl | __data__ = None # OOBTree | 18:33 |
| yvl | but that is not important in this case | 18:34 |
| yvl | oh, also most of imports in journal/term.py should be removed | 18:35 |
| aelkner | ok, will do presently | 18:35 |
| aelkner | don't go away because i can do that real fast | 18:35 |
| yvl | ok | 18:35 |
| yvl | I don't remember if ITermGradingData is persisted | 18:36 |
| yvl | if not, it could be removed | 18:36 |
| yvl | (I think it's not persisted) | 18:36 |
| aelkner | cool, will try removing | 18:36 |
| aelkner | submitted bug for you, check it out please | 18:37 |
| yvl | thanks, aelkner | 18:40 |
| aelkner | yvl, i just pushed an update that removes ITermGrading and config | 18:43 |
| aelkner | manual test of evolution passed | 18:43 |
| aelkner | could you give me quick feedback? | 18:43 |
| yvl | looking | 18:44 |
| yvl | ok | 18:46 |
| yvl | please also add a cooment in term.py | 18:46 |
| yvl | that the module is obsolete | 18:46 |
| yvl | and is there for an evolution script that actually removes these objects | 18:46 |
| yvl | otherwise it looks good from first glance | 18:47 |
| aelkner | are you saying evolve1.py doesn't do that? | 18:47 |
| yvl | no, just that | 18:47 |
| yvl | it would be good for other developers to know | 18:47 |
| yvl | why there is a file term.py | 18:47 |
| yvl | by looking at it | 18:47 |
| aelkner | that i got, adding the comment and all, but what else are you saying? | 18:48 |
| yvl | oh, I was just roughly typing the comment | 18:49 |
| yvl | """ | 18:49 |
| yvl | the module is obsolete | 18:49 |
| yvl | it is here for an evolution script evolve1.py that actually removes these objects. | 18:49 |
| yvl | """ | 18:49 |
| yvl | or something like that :) | 18:49 |
| aelkner | right, will do | 18:49 |
| yvl | great :) | 18:49 |
| aelkner | and i'll update CHANGES.txt and submit the merge request | 18:49 |
| yvl | thank you | 18:50 |
| yvl | ok, it's time to go home now | 18:50 |
| yvl | need lunch! ;) | 18:50 |
| aelkner | ok, have a good evening | 18:50 |
| yvl | happy coding guys! | 18:50 |
| yvl | ( replaceafill - keep us posted when something happens with jQuery - I like shiny things ;)))) ) | 18:51 |
| replaceafill | :P | 18:51 |
| replaceafill | yvl will look for you tomorrow, maybe we can talk a little | 18:51 |
| yvl | umm, I kind of have a Skype call with th1a | 18:52 |
| yvl | at default meeting time | 18:52 |
| replaceafill | ah, ok | 18:52 |
| yvl | so we can chat before that | 18:53 |
| yvl | or email | 18:53 |
| yvl | or on Wed | 18:53 |
| replaceafill | will try email | 18:53 |
| replaceafill | sure | 18:53 |
| replaceafill | thanks | 18:53 |
| yvl | ok then... hope to hear from you soon ;) | 18:54 |
| replaceafill | ;) | 18:54 |
| *** menesis has quit IRC | 20:14 | |
| *** replaceafill has quit IRC | 20:24 | |
| *** menesis has joined #schooltool | 21:20 | |
| *** menesis has quit IRC | 21:25 | |
| *** menesis has joined #schooltool | 21:38 | |
| *** menesis has quit IRC | 22:35 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!