| *** menesis has quit IRC | 02:35 | |
| *** alga has quit IRC | 03:05 | |
| *** th1a has quit IRC | 03:56 | |
| *** aks has joined #schooltool | 06:00 | |
| *** alga has joined #schooltool | 09:31 | |
| *** aks has quit IRC | 09:49 | |
| *** povbot has joined #schooltool | 09:54 | |
| *** povbot has joined #schooltool | 09:59 | |
| *** aks has joined #schooltool | 10:21 | |
| *** aks has joined #schooltool | 10:21 | |
| *** menesis has joined #schooltool | 11:17 | |
| *** ignas has joined #schooltool | 12:48 | |
| *** aks has quit IRC | 14:20 | |
| *** th1a has joined #schooltool | 15:34 | |
| *** klausade has quit IRC | 16:53 | |
| *** klausade has joined #schooltool | 16:57 | |
| *** alga has quit IRC | 17:30 | |
| *** ignas has quit IRC | 19:13 | |
| *** alga has joined #schooltool | 19:46 | |
| *** menesis has quit IRC | 20:23 | |
| *** fsufitch has joined #schooltool | 21:01 | |
| fsufitch | aelkner: ping | 21:02 |
|---|---|---|
| aelkner | fsufitch, good afternoon | 21:02 |
| fsufitch | ello | 21:02 |
| fsufitch | aelkner: so im going to continue getting this z3c.form thing to work | 21:09 |
| fsufitch | got some errors to take care of | 21:09 |
| aelkner | sounds good | 21:10 |
| aelkner | don't let yourself get stuck on anything if you can ask me | 21:11 |
| fsufitch | okay | 21:12 |
| fsufitch | this is odd, i'm getting: | 21:15 |
| fsufitch | TypeError: __init__() got multiple values for keyword argument 'cluster' | 21:15 |
| fsufitch | when i subit the z3c form | 21:16 |
| fsufitch | *submit | 21:16 |
| fsufitch | aelkner: ping | 21:17 |
| aelkner | send the diff please? | 21:19 |
| fsufitch | ok | 21:19 |
| * th1a slaps his forehead. | 21:20 | |
| fsufitch | sent | 21:20 |
| th1a | If only we had some kind of system for managing changes in source code. | 21:20 |
| fsufitch | th1a: we *are* using bzr, just trying to keep broken commits to a minimum | 21:21 |
| th1a | You can make as many broken commits as you want in a working branch. | 21:22 |
| th1a | development branch | 21:22 |
| aelkner | th1a, i got into the habit of only commiting when tests pass | 21:23 |
| fsufitch | but... they're ugly | 21:23 |
| aelkner | ignas was clear about that back in the day | 21:23 |
| aelkner | it allows the reviewer to see clearly what code lead to things being broken | 21:24 |
| aelkner | fsufitch, in this case, however, i'm having problems looking at your diff | 21:24 |
| fsufitch | how come? | 21:24 |
| aelkner | i get: Malformed patch header. No orig name | 21:25 |
| aelkner | 'added:\n' | 21:25 |
| aelkner | when you do a bzr st | 21:25 |
| aelkner | do you see anything finny, like an unknown file? | 21:25 |
| * th1a rolls his eyes. | 21:25 | |
| fsufitch | nope | 21:25 |
| fsufitch | 2 added files, 2 modified files | 21:25 |
| aelkner | hehe | 21:27 |
| aelkner | you dsent me the st output, not the diff output | 21:27 |
| fsufitch | oh | 21:27 |
| fsufitch | derp | 21:27 |
| fsufitch | proper diff sent now | 21:28 |
| fsufitch | bah, people behind me got delicious smelling food and it's making me hungry | 21:30 |
| aelkner | fsufitch, ok, first of all, i don't see how you could be having an error since i don't see any tests | 21:31 |
| fsufitch | i am just trying to use the web interface atm | 21:31 |
| aelkner | manager.serve() gets you the web interface, so why not use it | 21:31 |
| aelkner | i've been trying to steer you away from using make run and favor the test-driven approach, so... | 21:32 |
| aelkner | also, after you've added the test and recreated the problem, go ahead and commit and push | 21:34 |
| aelkner | before pinging me | 21:34 |
| fsufitch | ok | 21:35 |
| aelkner | from time to time we can commit broken code so that i can get to it and figure out what's up | 21:35 |
| aelkner | from your diff, i don't see anything wrong, so i'l need to run the test myself to recreate | 21:35 |
| fsufitch | okay | 21:37 |
| fsufitch | ill write the test | 21:37 |
| fsufitch | but first i think im going to go get some food | 21:38 |
| aelkner | if i don't see your ping after five minutes, call my cell | 21:39 |
| fsufitch | could you send me your cell again? i checked my phone and it's not there, even though i thought it was | 21:39 |
| aelkner | sure | 21:40 |
| fsufitch | thanks | 21:41 |
| fsufitch | now, im off to go grab a bite | 21:41 |
| fsufitch | bbiab :) | 21:41 |
| fsufitch | aelkner: ping | 22:45 |
| aelkner | fsufitch, pong | 22:46 |
| fsufitch | back to work and writing that test, but now, question: how do i handle the list form elements? | 22:47 |
| fsufitch | Credit Codes is a list field, and z3c.form is rendering it as such, but i'm not sure how to work with it in the test | 22:47 |
| aelkner | ah, the list widget | 22:48 |
| fsufitch | yes | 22:48 |
| aelkner | try, doing manager.serve() right after calling up the add form and look at what comes up | 22:48 |
| aelkner | you can use firebug to inspect the elements for their names/ids | 22:49 |
| fsufitch | hmm okay | 22:49 |
| fsufitch | i was doing that | 22:49 |
| fsufitch | but my worries are mainly concerning the fact that this involves javascript | 22:49 |
| aelkner | how so? | 22:50 |
| fsufitch | testbrowser doesn't run javascript? | 22:50 |
| aelkner | why do you need it? | 22:50 |
| aelkner | it's just a form that the user fills in | 22:50 |
| fsufitch | the list widget involves pushing buttons to add new list elements | 22:50 |
| aelkner | you can submit forms even without javascript | 22:51 |
| aelkner | but i have to find the example | 22:52 |
| fsufitch | oh, the "Add" button is a submit button | 22:52 |
| fsufitch | i thought this would involve Ajax or something | 22:52 |
| aelkner | >>> manager.getForm().submit() | 22:53 |
| aelkner | no ajax | 22:53 |
| fsufitch | yes but that pushes the actual submit button, not the Add button | 22:53 |
| aelkner | wait | 22:53 |
| aelkner | ok, the getForm().submit is useful when you set a list value that has onchange="submit" | 22:54 |
| aelkner | so that's not what you want | 22:54 |
| fsufitch | er, yeah | 22:55 |
| aelkner | you can just getControl(name='?').click() | 22:55 |
| aelkner | or even just the text of the button, if it's not ambiguous | 22:55 |
| aelkner | ok, maybe 'm lying again :) | 22:56 |
| fsufitch | okay | 22:56 |
| fsufitch | like, this is what i need to click http://imgur.com/UO1i2 | 22:56 |
| aelkner | if it's the case that the button is not a submit button | 22:56 |
| fsufitch | it *is* a submit button | 22:56 |
| fsufitch | but it's not "the" submit button | 22:56 |
| aelkner | ok, do me a favor and push the broken code so i can see the same things | 22:57 |
| fsufitch | ok, one sec | 22:58 |
| fsufitch | pushed | 23:00 |
| aelkner | ok, running tests | 23:01 |
| aelkner | how did you get manager.click('New Course Info') to take you to the add form? | 23:07 |
| aelkner | that needs to be getControl('...').click() | 23:07 |
| aelkner | sorry, getLink | 23:08 |
| aelkner | >>> manager.getLink('New Course Info').click() | 23:08 |
| aelkner | anyway, i'm looking for a better widget for lists | 23:13 |
| aelkner | i know we have one somewhere in schooltool | 23:13 |
| fsufitch | okay | 23:14 |
| fsufitch | and i'm using getLink now | 23:14 |
| aelkner | check it out: | 23:16 |
| aelkner | schooltool/basicperson/interfaces.py | 23:16 |
| fsufitch | ok | 23:17 |
| aelkner | EnumValueList is derived from List | 23:17 |
| aelkner | then look at schooltool/basicperson/browser/configure.zcml | 23:17 |
| aelkner | where EnumValueList is registered against zope's standard TextAreaWidget | 23:18 |
| aelkner | that widget is handy for handling lists of text lines which is ok for now | 23:18 |
| aelkner | so what you can do is add your own version of the List-derived interface class to your interfaces.py | 23:20 |
| aelkner | and register the widget against it in browser/configure.zcml | 23:21 |
| aelkner | you could call it CourseInfoValueList for now i guess | 23:22 |
| *** fsufitch has quit IRC | 23:26 | |
| *** fsufitch has joined #schooltool | 23:30 | |
| aelkner | fsufitch, i sent you a diff that gets the TextAreaWidgets to appear | 23:52 |
| fsufitch | thanks, was doing it myself, but had to go afk for a bit | 23:52 |
| fsufitch | ill apply your diff | 23:52 |
| aelkner | you can use \n inside the value string when you go to fill in those fields | 23:53 |
| fsufitch | perfect | 23:53 |
| fsufitch | running ftests now | 23:56 |
| fsufitch | awesome, thanks :) | 23:58 |
| aelkner | np, that's what i'm here for | 23:58 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!