| *** menesis has quit IRC | 00:00 | |
| *** aks has joined #schooltool | 09:06 | |
| *** aks has quit IRC | 09:16 | |
| *** aks has joined #schooltool | 09:19 | |
| *** yvl has joined #schooltool | 09:26 | |
| *** aks has quit IRC | 09:50 | |
| *** ignas has joined #schooltool | 12:52 | |
| *** aks has joined #schooltool | 13:53 | |
| *** menesis has joined #schooltool | 14:36 | |
| *** jelkner has joined #schooltool | 15:08 | |
| *** aks has quit IRC | 15:09 | |
| *** menesis has quit IRC | 15:23 | |
| *** th1a has joined #schooltool | 15:34 | |
| *** replaceafill has joined #schooltool | 16:23 | |
| th1a | Hi aelkner, replaceafill, yvl. | 16:31 |
|---|---|---|
| replaceafill | good morning/afternoon | 16:32 |
| yvl | morning guys | 16:32 |
| aelkner | morning | 16:32 |
| th1a | First off, thanks to aelkner for the screenshots. That's exactly what we need to start doing. | 16:33 |
| th1a | (sending screenshots) | 16:33 |
| th1a | I sent a brief reply. | 16:33 |
| yvl | yes, thanks aelkner :) | 16:33 |
| aelkner | i saw the replies, thanks for them | 16:34 |
| aelkner | i'm guessing nothing has to change on the CSS front because we all seem | 16:35 |
| aelkner | to agree that table width 100% is not appropriate | 16:35 |
| th1a | I think not in this case. | 16:35 |
| aelkner | yvl did make a number of suggestions about changing how the buttons work | 16:36 |
| aelkner | i still haven't digested them all | 16:36 |
| aelkner | i can see having a confirmation step for extending a section | 16:36 |
| th1a | I'm thinking that for this version displaying the terms like this might be fine -- | 16:37 |
| yvl | from user's perspective the main thing is to allow "link existing section" in all terms | 16:37 |
| th1a | Term: Second (Third) | 16:37 |
| th1a | Where (Third) is the link. | 16:37 |
| th1a | yvl: Yes. | 16:38 |
| th1a | Also, we didn't discuss unlinking, did we? | 16:38 |
| yvl | and yes to you, th1a :) | 16:38 |
| aelkner | th1a, no, we didn't discuss unlinking | 16:38 |
| yvl | basically, the view should look the same, no matter which section you came from | 16:39 |
| th1a | There is no reason not to be able to link backwards. | 16:39 |
| aelkner | just no extend backwards, right? | 16:39 |
| th1a | Right now I can't remember what the problem with that was... | 16:40 |
| * yvl has no strong opinion on this one | 16:41 | |
| aelkner | th1a, i think you just felt that no sane user would want to extend backwards | 16:41 |
| yvl | unless he made a mistake | 16:41 |
| aelkner | i don't think you had any other reason | 16:41 |
| yvl | by creating a term in spring instead of fall | 16:41 |
| aelkner | yvl, right | 16:41 |
| yvl | and thinking that he will extend that "tomorrow" | 16:42 |
| th1a | Probably also because we were thinking about not propogating enrollment changes backwards. | 16:42 |
| th1a | But that's really a different case. | 16:42 |
| yvl | yes | 16:42 |
| aelkner | th1a, i think you were thinking about how users play around with the data sometimes | 16:42 |
| th1a | Well... don't try to inject too much analysis into my decision. | 16:43 |
| aelkner | that's ok, i just need to know if it's ok to extend backwards | 16:43 |
| th1a | I think we might as well allow linking and extending backwards. | 16:44 |
| th1a | And probably the next thing you should do is implement unlinking. | 16:44 |
| * th1a is anticipating the first bug reports... | 16:44 | |
| th1a | HOW DO I UNLINK NOW? | 16:44 |
| aelkner | but propagating backwards is not going to happen, right | 16:44 |
| aelkner | ? | 16:45 |
| th1a | It is not going to happen. | 16:45 |
| yvl | it also creates a new section, so we may also get "how do I delete now" bug reports | 16:45 |
| yvl | not that my remark matters, when I think about it :) | 16:45 |
| aelkner | th1a, how would the user unlink a section? | 16:46 |
| aelkner | i'm not sure what button i would put where on the section_linkage view | 16:46 |
| th1a | Perhaps just an "Unlink this section" link at the bottom of each section. | 16:47 |
| aelkner | so if all four terms are lnked | 16:47 |
| aelkner | and the user hits the unlink button in term two | 16:48 |
| aelkner | then the previous and next links should be broken | 16:48 |
| aelkner | and the view would only have the Term2 column filled in after that? | 16:48 |
| yvl | other way around | 16:49 |
| th1a | Term 2 would be separate and terms 1, 3, 4 linked. | 16:49 |
| yvl | t1<->t3<->t4 | 16:49 |
| aelkner | i checked, can't link terms that are not consecutive | 16:49 |
| th1a | Oh, ok. | 16:49 |
| th1a | Hm... | 16:49 |
| yvl | ok then | 16:50 |
| yvl | unlink buttons in terms 4 and 1 | 16:50 |
| th1a | Yeah, that's probably best. | 16:50 |
| aelkner | so from the outside in, so to speak | 16:50 |
| aelkner | also, we would need a confirmation button step, rght? | 16:51 |
| th1a | Sure. | 16:51 |
| yvl | please be verbose | 16:51 |
| aelkner | yvl, sure | 16:51 |
| yvl | if unlinking does not delete the section, say so | 16:51 |
| aelkner | does it not delete the section? | 16:52 |
| th1a | No. | 16:52 |
| yvl | and say so in the page | 16:52 |
| aelkner | right | 16:52 |
| yvl | confirmation page, that is | 16:52 |
| aelkner | when the user hits Link and Existing section | 16:52 |
| th1a | The warning should say -- this section will be separate, these sections will still be linked (if any). | 16:52 |
| yvl | yes :) | 16:52 |
| aelkner | i will be presenting a filter widget and search results with the section candidates for linking | 16:53 |
| aelkner | first of all, what should the buttons look like? | 16:53 |
| aelkner | just the section title is probably not enough | 16:54 |
| aelkner | titl and teacher name? | 16:54 |
| aelkner | we already defined that no section would show if it didn't have exact same course(s) | 16:54 |
| aelkner | but i guess the section title + teacher name would be necessary | 16:55 |
| aelkner | to distinguish the links from one another? | 16:55 |
| th1a | Include the database id. | 16:55 |
| aelkner | ? | 16:55 |
| th1a | Isn't there an id in the url? | 16:55 |
| aelkner | __name__ is an arbitrary number chosen by the ames chooser | 16:56 |
| th1a | Is that just unique to the course? | 16:56 |
| aelkner | names | 16:56 |
| aelkner | i don't think we want to confuse the user with that | 16:56 |
| th1a | I'm just saying, these may be difficult to distinguish. | 16:56 |
| yvl | please do | 16:56 |
| th1a | jelkner may be teaching 10 sections of CS101. | 16:57 |
| yvl | section_id is appropriate here | 16:57 |
| yvl | it is the same in URL | 16:57 |
| aelkner | so could you please type an example link text here? | 16:57 |
| th1a | You'll need a table. | 16:57 |
| jelkner | lol | 16:57 |
| aelkner | ah, a table | 16:58 |
| aelkner | it could look like the sections container view's table, right? | 16:58 |
| th1a | aelkner: This isn't going to be something that necessarily be easy. | 16:58 |
| aelkner | but only the column wth the section's ttle has a link | 16:58 |
| th1a | It is the wrong way to fix something after the fact. | 16:58 |
| th1a | aelkner: Yes, I think so. | 16:59 |
| aelkner | then, when the user clicks the link, i'll need another confirmation page, right? | 16:59 |
| th1a | It would be better to have radio buttons and a sumbit button. | 17:00 |
| yvl | yes | 17:00 |
| aelkner | i like that better | 17:00 |
| aelkner | less steps for the user | 17:00 |
| yvl | for users, in my opinion, seciton is unique by: course + instructor + students | 17:00 |
| yvl | you may consider having a table with large rows, displaying students | 17:01 |
| yvl | at least first 10 students or something | 17:01 |
| th1a | Maybe the section title link should open the section page in a new window. | 17:01 |
| aelkner | does the section container view list students in the table? | 17:01 |
| th1a | No. | 17:01 |
| yvl | probably it would be best to do a simple table with radio buttons | 17:02 |
| aelkner | can radio buttons span across table rows? | 17:02 |
| yvl | yes | 17:02 |
| aelkner | good | 17:02 |
| yvl | well, no | 17:02 |
| aelkner | bad :) | 17:03 |
| yvl | it depends on what you mean | 17:03 |
| aelkner | so we're talking about a table with trs and tds | 17:03 |
| aelkner | and we're also talking about the user clicking a radio button to select the section to link | 17:03 |
| aelkner | but each row has a different section | 17:03 |
| aelkner | so can a radio button be spread between tds | 17:04 |
| yvl | Alan, let me put it this way | 17:04 |
| aelkner | i'm thinking not | 17:04 |
| yvl | there is a similar table in add/remove members of a section | 17:04 |
| yvl | you select a student and click Add | 17:04 |
| aelkner | those are not radio buttons | 17:04 |
| yvl | my God | 17:05 |
| aelkner | those are links, any number can be clicked, not just the one | 17:05 |
| yvl | yes | 17:05 |
| yvl | those are check boxes | 17:05 |
| aelkner | that's what i meant | 17:05 |
| yvl | you can make them radio buttons | 17:05 |
| yvl | now I understand your question | 17:05 |
| yvl | yes, radio buttons can be used in a table | 17:05 |
| yvl | same like checkboxes | 17:06 |
| yvl | and you may notice, that if you click the first name of a student in that table | 17:06 |
| yvl | the checkbox is set | 17:06 |
| yvl | you should do the same with sections | 17:06 |
| aelkner | that's the lebel for= | 17:07 |
| aelkner | so, right | 17:07 |
| aelkner | i have a question about unlinking | 17:08 |
| aelkner | if a section is linked for terms 1-4 | 17:08 |
| aelkner | we already agreed that terms 1 and 4 would have an additional 'Unlink this term' button in their columns | 17:09 |
| aelkner | what if the section is only schedule for two terms? | 17:09 |
| aelkner | would both columns have unlink buttons? | 17:09 |
| aelkner | i'm thinking yes, but i wanted to check | 17:10 |
| yvl | in that case, having only one button for the second one would be a tiny bit nicer | 17:11 |
| yvl | but it's not life changing, IMHO | 17:11 |
| aelkner | but what about the idea that the view should be identical regardless of which section is the context? | 17:12 |
| yvl | the second one is always the second one | 17:12 |
| yvl | by date | 17:12 |
| aelkner | good point | 17:12 |
| yvl | but that's usability sugar | 17:13 |
| aelkner | so only have unlink button for first if there are three or more terms linked? | 17:13 |
| yvl | if it's not too much of a hassle | 17:13 |
| aelkner | no hassle at all, just need to know what we want to do | 17:13 |
| yvl | :) | 17:13 |
| th1a | OK. | 17:14 |
| aelkner | th1a, do you agree, only unlink first term if three or more terms linked? | 17:14 |
| th1a | I guess. It is a small point. | 17:14 |
| aelkner | yvl, after th1a drops the bag of gravel, i need to discuss some code ideas with you | 17:15 |
| yvl | ok | 17:15 |
| th1a | Are we ready to move on? | 17:15 |
| aelkner | yes | 17:15 |
| th1a | Are you on schedule, aelkner? | 17:15 |
| aelkner | if you don't heap any more changes on me, then yes | 17:15 |
| th1a | Good. | 17:15 |
| th1a | Before I forget: I need March invoices from replaceafill & aelkner. | 17:16 |
| th1a | replaceafill? | 17:16 |
| replaceafill | th1a ah ok, will send mine later today | 17:16 |
| replaceafill | ok | 17:16 |
| replaceafill | this week i added shifts to cambodia | 17:16 |
| aelkner | th1a, i'll send mine now while others report | 17:16 |
| replaceafill | also, report samples keep coming (and that's good) | 17:17 |
| th1a | As long as you're not letting yourself get overwhelmed. | 17:17 |
| replaceafill | while i started to work on reports, i have some questions | 17:17 |
| replaceafill | th1a sometimes i am :( | 17:17 |
| replaceafill | like with the demographics by year issue | 17:18 |
| replaceafill | i reported a couple of bugs last week about it | 17:18 |
| replaceafill | menesis already fixed the critical one | 17:18 |
| th1a | You literally have to work with people for a year before they get to dumping the pile of reports on you. | 17:18 |
| replaceafill | yvl, thanks for answering my email on the int demo field and multiple enum field | 17:19 |
| replaceafill | th1a :) | 17:19 |
| yvl | umm, I don't recall answering... but you're welcome, replaceafill? ;) | 17:19 |
| replaceafill | email in the dev list :P | 17:19 |
| replaceafill | ok, a few questions | 17:20 |
| replaceafill | i need ages of people | 17:20 |
| replaceafill | i shamelessly (if that's a word) took this: http://stackoverflow.com/questions/2217488/age-from-birthdate-in-python | 17:20 |
| replaceafill | i looked and we don't have this in trunk, correct? | 17:21 |
| yvl | correct | 17:21 |
| yvl | well, AFAIR | 17:21 |
| replaceafill | ok, also, in the census report, i have to calculate ages for students, time of service for teachers | 17:22 |
| replaceafill | and i started to think, should i use the catalog for reports | 17:22 |
| replaceafill | i mean, should i start inserting indexes for things i have to look for? | 17:22 |
| replaceafill | or should i use looping and lists to calculate totals | 17:23 |
| replaceafill | (like i did in cando) | 17:23 |
| replaceafill | which later resulted in memory issues... | 17:23 |
| yvl | all I can say at this point - it depends... | 17:23 |
| yvl | probably yes | 17:25 |
| yvl | many students | 17:25 |
| yvl | so probably makes sense to index their data | 17:25 |
| replaceafill | yvl but then i think, if i index some attributes and i need the total number of students, do i have to do: len(list(result)) | 17:26 |
| yvl | hmm, maybe you can send me a short mail | 17:26 |
| replaceafill | is that similar to using loops and lists? | 17:27 |
| replaceafill | ah ok | 17:27 |
| yvl | thanks | 17:27 |
| replaceafill | another quick question | 17:27 |
| replaceafill | do we have 1-to-1 relationships with schoolyears in trunk? | 17:27 |
| replaceafill | i mean | 17:27 |
| replaceafill | courses, levels, groups and now shifts are 1-to-many, right? | 17:28 |
| replaceafill | but now i have this SchoolInfo object | 17:28 |
| replaceafill | with information about the school | 17:28 |
| yvl | no, we do not - yet | 17:28 |
| replaceafill | which i only need one per year | 17:28 |
| yvl | closest we have - annotations | 17:28 |
| yvl | you can go with that | 17:28 |
| replaceafill | i decided one container with one object per year than annotations | 17:29 |
| replaceafill | same for location information (villages, provinces, communes, etc) | 17:29 |
| replaceafill | and if this one object per year approach is correct, how is it best to link the object with the schoolyear, by intid or by schoolyear.__name__? | 17:30 |
| replaceafill | or it doesnt matter? | 17:30 |
| yvl | see schooltool/app/app.py, getApplicationPreferences | 17:31 |
| yvl | you can do same with schoolyear | 17:31 |
| replaceafill | use annotations instead of a separated container, right? | 17:31 |
| yvl | right | 17:32 |
| replaceafill | that seems easier :P | 17:32 |
| yvl | on one hand, I'd rather have separations by int-id or something similar | 17:32 |
| yvl | but more importantly, I'd like consistency | 17:32 |
| yvl | easier to fix later :) | 17:33 |
| * replaceafill checks his notes | 17:33 | |
| replaceafill | ah | 17:33 |
| replaceafill | - Sorting vocabulary translated titles | 17:33 |
| replaceafill | would it be possible to sort titles in a vocabulary | 17:33 |
| replaceafill | where you dont have access to the request? | 17:34 |
| yvl | now that I think of it, per-int-id separation would not be that much different | 17:34 |
| replaceafill | yvl separation just feels odd, 1-to-1 containers... | 17:34 |
| yvl | no, a single container; key - intid, value - value object | 17:35 |
| yvl | sorry, I don't have a strong opinion today | 17:35 |
| yvl | will have one in ~3 weeks ;) | 17:35 |
| replaceafill | cool | 17:36 |
| replaceafill | :| | 17:36 |
| replaceafill | we will have this in 3 weeks?!??! | 17:36 |
| replaceafill | :) | 17:36 |
| yvl | no, but then I'll start thinking about that again | 17:36 |
| replaceafill | ah ok | 17:36 |
| yvl | about sorting | 17:36 |
| replaceafill | please | 17:36 |
| yvl | why do you need that? | 17:37 |
| replaceafill | it's just that i have vocabulary lists like: | 17:37 |
| yvl | users communicate with the system via http requests, so... | 17:37 |
| replaceafill | + _('Accounting/Cashier'), | 17:37 |
| replaceafill | + _('Agriculture'), | 17:37 |
| replaceafill | + _('Drama/Music/Plastic Arts'), | 17:37 |
| replaceafill | + _('Home Economy/Technology'), | 17:37 |
| replaceafill | + _('Laboratory'), | 17:37 |
| replaceafill | + _('Librarian'), | 17:37 |
| replaceafill | + _('Secretary'), | 17:37 |
| replaceafill | + _('Sports'), | 17:37 |
| replaceafill | + _('Workshop'), | 17:37 |
| replaceafill | + _('Youth') | 17:37 |
| replaceafill | sorry for the flooding | 17:37 |
| replaceafill | and all of them are message strings | 17:38 |
| replaceafill | maybe in khmer (or spanish) the sorting wont make sense | 17:38 |
| yvl | but why you can't have access to the request? | 17:38 |
| replaceafill | it's a static vocabulary | 17:39 |
| replaceafill | i just use app/utils/vocabulary for it | 17:39 |
| yvl | but you can sort it when displaying? | 17:39 |
| replaceafill | hhmm didnt think of it... | 17:39 |
| yvl | I don't know if we did that anywhere, but I think that would be the right approach | 17:40 |
| replaceafill | so, i should build the vocabulary terms on displaying time | 17:40 |
| replaceafill | there i'd have access to the request and sorting, etc | 17:41 |
| replaceafill | i have a lot of this kind of vocabularies... | 17:41 |
| replaceafill | + _('In-service training'), | 17:41 |
| replaceafill | + _('Maternity'), | 17:41 |
| replaceafill | + _('Mission'), | 17:41 |
| replaceafill | + _('Suspend'), | 17:41 |
| replaceafill | + _('Take care of health'), | 17:41 |
| replaceafill | + _('Leader'), | 17:42 |
| replaceafill | + _('Sub-leader'), | 17:42 |
| replaceafill | + _('Member'), | 17:42 |
| yvl | I understand | 17:42 |
| replaceafill | interesting, i'll try to do that | 17:42 |
| yvl | well, give it a go, if you don't find an easy way, I can look into that | 17:42 |
| replaceafill | app/utils/vocabulary was too easy :P | 17:42 |
| yvl | maybe sorting is built in in some widgets | 17:42 |
| yvl | maybe can be enabled | 17:42 |
| replaceafill | ah | 17:42 |
| replaceafill | that would be great ;) | 17:43 |
| yvl | maybe we need to extend a widget | 17:43 |
| yvl | maybe we can rebuild vocabularies on the fly | 17:43 |
| yvl | many options, need to look at code ;) | 17:43 |
| replaceafill | ok, will move on | 17:43 |
| replaceafill | - Shifts start/end times | 17:43 |
| replaceafill | shifts should have start/end times | 17:43 |
| replaceafill | but they're only used for display purposes | 17:44 |
| replaceafill | so i used plain textlines for now | 17:44 |
| replaceafill | i just was curious about a "time only" field | 17:44 |
| replaceafill | like 12:00 pm | 17:44 |
| replaceafill | or 3:30 pm | 17:44 |
| replaceafill | :) | 17:44 |
| th1a | One could be built. | 17:45 |
| replaceafill | dont know how useful would be though | 17:45 |
| replaceafill | maybe just a crazy thought of mine | 17:45 |
| replaceafill | ok th1a im putting the census report together | 17:45 |
| th1a | Moving on... | 17:45 |
| yvl | time only field? | 17:46 |
| yvl | we do have that, don't we? | 17:46 |
| replaceafill | there's a lot of sources of information for it | 17:46 |
| replaceafill | yvl really? | 17:46 |
| replaceafill | i found Date and Datetime | 17:46 |
| replaceafill | but couldnt find something like that.... | 17:46 |
| yvl | zope.schema.Time ? | 17:46 |
| replaceafill | ah?!?!?! | 17:46 |
| replaceafill | ah come on!!!! | 17:46 |
| replaceafill | :D | 17:46 |
| yvl | it's not like it works well, but still | 17:47 |
| yvl | :) | 17:47 |
| replaceafill | yvl thanks, i'll take a look | 17:47 |
| replaceafill | th1a to wrap it up, i'm also adding more tests | 17:47 |
| replaceafill | this week i'll be working mostly on the complex reports | 17:48 |
| replaceafill | last question! | 17:48 |
| replaceafill | can i replace the schooltool.cambodia branch with my current working branch? | 17:49 |
| replaceafill | i mean, i started this rewrite | 17:49 |
| replaceafill | i looked for a way to rename branches... | 17:49 |
| yvl | move your current to junk | 17:49 |
| replaceafill | ah! | 17:49 |
| replaceafill | ok will look at that | 17:50 |
| replaceafill | th1a that's it from me | 17:50 |
| th1a | Thanks replaceafill. | 17:50 |
| th1a | yvl? | 17:50 |
| th1a | Where's menesis? | 17:50 |
| yvl | He caught a cold | 17:50 |
| th1a | OK. | 17:50 |
| yvl | probably a nasty one :/ | 17:50 |
| yvl | as for my report... | 17:51 |
| yvl | finished scheduling views | 17:51 |
| yvl | almost done with calendar integration | 17:51 |
| yvl | it seems that I'll make the deadline | 17:52 |
| yvl | diff against trunk at roughly 600kb now :) | 17:52 |
| th1a | Aaaagh. | 17:52 |
| yvl | will get bigger | 17:52 |
| th1a | There's a WATERFALL ahead! | 17:53 |
| yvl | :) | 17:53 |
| yvl | I'll need to be careful when merging to trunk | 17:54 |
| yvl | a big change, so it should sit a while before getting released | 17:54 |
| yvl | anyway | 17:54 |
| th1a | It will sit until October. | 17:54 |
| yvl | yes | 17:55 |
| yvl | we should make that available in dev PPA | 17:55 |
| yvl | so people can test if they want | 17:55 |
| th1a | Yes. | 17:55 |
| yvl | and report bugs early :) | 17:55 |
| yvl | well, that's that. | 17:56 |
| th1a | OK. DON'T SLOW DOWN. | 17:56 |
| yvl | ok | 17:56 |
| th1a | I spent some time last week being bad and fiddling with tools instead of writing documentation, but at least my tools are better now. | 17:56 |
| yvl | dev speed is increasing, for what that's worht | 17:56 |
| th1a | Yes, it sounds like it, and once we get this elephant off your back, I'm expecting it to even more. | 17:57 |
| th1a | So basically I can now make a rough script in Selenium IDE, export it in Python, and add as a method in my screenshot generating script. | 17:58 |
| yvl | nice | 17:58 |
| th1a | Which can size, position, and name a whole sequence of screenshots, organized by page. | 17:59 |
| th1a | So in the long run, it should help. | 17:59 |
| th1a | Like, when we change the UI and we need a whole new set of shots. | 17:59 |
| th1a | I'll share my amusing script soon... | 18:00 |
| th1a | OK, have a great week gentlemen! | 18:00 |
| * th1a drops the bag of gravel. | 18:00 | |
| yvl | thanks! | 18:00 |
| replaceafill | thanks everybody | 18:00 |
| * yvl is keen to see the script | 18:00 | |
| aelkner | greeat week everyone | 18:01 |
| aelkner | yvl, i'm confused about your desire to have more logic in tal | 18:01 |
| aelkner | i thought you told me not to avoid python: in tal which i interpreted as: | 18:01 |
| aelkner | not so much logic in tal | 18:02 |
| aelkner | ok, i stated that wrong | 18:02 |
| yvl | I understand | 18:02 |
| yvl | I probably confused you | 18:02 |
| yvl | hmm | 18:03 |
| aelkner | could you tell me what rule you would like me to follow? | 18:03 |
| yvl | I don't like when things are calculated in tal | 18:03 |
| aelkner | ah, no calculations | 18:03 |
| aelkner | but conditions ok | 18:03 |
| yvl | sure | 18:03 |
| yvl | say, in your case | 18:03 |
| yvl | I mean the view in question | 18:03 |
| replaceafill | python: conditions are ok in templates? | 18:04 |
| yvl | it would all be ok, if the logic was really complex | 18:04 |
| yvl | replaceafill, I don't like python: | 18:04 |
| yvl | but tal:condition="foo|nothing" is really acceptable | 18:04 |
| yvl | or tal:condition="bar" | 18:04 |
| replaceafill | i usually set a view attribute for the condition and do tal:condition='view/somethingsomething' | 18:04 |
| replaceafill | ah | 18:05 |
| yvl | say, if you want to display a link to the next linked section | 18:05 |
| replaceafill | i thought you were saying something like tal:condition='python: view.somesome > 2.4' | 18:05 |
| yvl | using tal is fine | 18:05 |
| yvl | now that I do not like :) | 18:06 |
| replaceafill | right | 18:06 |
| replaceafill | i thought *that* was a python condition :D | 18:06 |
| aelkner | yvl told me tal:condition="python: view.isDisplayed(cell)" is ok | 18:06 |
| aelkner | although i could see a reason for adding the boolean while building cell | 18:07 |
| yvl | it is the case of judgement | 18:07 |
| aelkner | yielding tal:condition="cell/isDisplayed" | 18:07 |
| yvl | if you can't avoid it easily - it's ok | 18:07 |
| yvl | if you can, you should better avoid it | 18:08 |
| replaceafill | aelkner right, that's what i try to do | 18:08 |
| aelkner | ok, i think i know what i need to do now | 18:08 |
| yvl | it's not that the view was bad, aelkner | 18:08 |
| aelkner | i'll add to the email thread when i've commited those changes | 18:08 |
| yvl | it just that it seemed a bit over-complicated, when reading the tal template | 18:08 |
| aelkner | yvl, that's ok, i appreciate the input | 18:09 |
| aelkner | and i want you to like the code since you will be merging it :) | 18:09 |
| yvl | thanks for the patience, aelkner :) | 18:09 |
| yvl | I'm actually most worried about code being maintainable | 18:09 |
| aelkner | i'll go with your columns property suggestion | 18:10 |
| aelkner | but i'll add flags like isUnlinkable | 18:10 |
| aelkner | to that i can conditionally display those links | 18:10 |
| yvl | that seems fair | 18:11 |
| yvl | that seems more than fair, actually :) | 18:12 |
| aelkner | :) | 18:12 |
| yvl | maybe "canUnlink" might be easier on the eye | 18:12 |
| replaceafill | i need yvl to rename some of my view properties ;) | 18:13 |
| aelkner | indeed | 18:13 |
| yvl | :D | 18:13 |
| replaceafill | i like canX vs isXable | 18:13 |
| replaceafill | and i use isXable a lot.... | 18:13 |
| yvl | you can also use stuff like "showUnlink" | 18:14 |
| yvl | depending on the situation :) | 18:15 |
| aelkner | all good suggestions | 18:15 |
| yvl | well, it's been a long day... | 18:15 |
| yvl | :) | 18:16 |
| yvl | so... do you guys need me for anything?.. :) | 18:16 |
| aelkner | who needs you? :) | 18:16 |
| aelkner | but seriously, i'm done | 18:16 |
| aelkner | i'll send the email tonight | 18:16 |
| yvl | :)) | 18:16 |
| yvl | thanks :) | 18:16 |
| yvl | happy coding then! | 18:17 |
| yvl | see you later ;) | 18:17 |
| aelkner | cya | 18:17 |
| yvl | and, replaceafill, you can drop me a mail also ;))) | 18:17 |
| replaceafill | yvl will do thanks | 18:18 |
| replaceafill | about catalog and stuff | 18:18 |
| yvl | my pleasure :) | 18:18 |
| *** ignas has quit IRC | 19:51 | |
| replaceafill | is it me or the coverage report doesnt show modules with no tests... | 20:50 |
| th1a | Hm, I guess capture_entire_page_screenshot captures the entire page, regardless of window size. | 21:42 |
| th1a | Who would have guessed? | 21:42 |
| replaceafill | th1a really? | 21:42 |
| th1a | Yes... I was just fooling myself before. | 21:43 |
| replaceafill | from the docs i thought i would act as the imagegrab extension for firefox | 21:43 |
| th1a | It is just the whole page. | 21:43 |
| replaceafill | s/imagegrab/screengrab | 21:43 |
| replaceafill | well, the whole page but using the width of the window, right? | 21:44 |
| th1a | Oh... maybe. | 21:44 |
| th1a | Or, no I don't think so. | 21:44 |
| th1a | Although I don't know what it would use as a default. | 21:45 |
| th1a | I should just use PIL. | 21:46 |
| th1a | That looks easy enough. | 21:47 |
| th1a | box = (100, 100, 400, 400) | 21:47 |
| th1a | region = im.crop(box) | 21:47 |
| replaceafill | th1a it works like i expect | 21:47 |
| th1a | Selenium? | 21:48 |
| replaceafill | if i resize the window width to 800px | 21:48 |
| *** jelkner has quit IRC | 21:48 | |
| replaceafill | and get the screenshot from the IDE it gets me the whole page but with the 800px width | 21:48 |
| th1a | There's a minimum though. | 21:48 |
| th1a | I mean, if it thinks the window is 200px wide it scrolls. | 21:49 |
| replaceafill | ah yes, if i resize the width to almost nothing it seems like the screenshot uses the min-width of the page | 21:50 |
| replaceafill | i get around 630px width | 21:50 |
| replaceafill | google gives me 617px... | 21:51 |
| th1a | y | 21:52 |
| th1a | PIL will give me better control anyhow. | 21:52 |
| replaceafill | definitely | 21:52 |
| *** menesis has joined #schooltool | 21:54 | |
| *** replaceafill has quit IRC | 23:05 | |
| *** th1a has quit IRC | 23:25 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!