| aelkner | fsufitch, what time do you knock off today? | 00:28 |
|---|---|---|
| fsufitch | around 7 probably | 00:28 |
| fsufitch | making good progress, but im taking it in little steps to make sure i don't break anything | 00:29 |
| aelkner | could you send me your diff? | 00:29 |
| fsufitch | i'm in the middle of writing ISchoolYearContainer and its adapter, i'll send it to you once i do that | 00:30 |
| fsufitch | er | 00:30 |
| fsufitch | ICourseInfoSchoolYearContainer | 00:30 |
| aelkner | cool | 00:31 |
| *** alga has quit IRC | 00:38 | |
| fsufitch | aelkner: ping | 01:13 |
| fsufitch | the diff is here http://pastebin.com/0UpsrXK8 | 01:13 |
| aelkner | looking... | 01:13 |
| aelkner | did you ever get the free laptop shaky box when visiting that site? | 01:14 |
| aelkner | it took me to something that looks like a phishing site | 01:15 |
| fsufitch | what? | 01:15 |
| fsufitch | i have adblock | 01:16 |
| fsufitch | i dont see that stuff | 01:16 |
| aelkner | did you bzr add adapters.py? | 01:17 |
| aelkner | because i don't see it in the diff | 01:17 |
| fsufitch | yes | 01:17 |
| fsufitch | hm. | 01:17 |
| aelkner | you can justbzr diff > foo and email me the conents of foo | 01:18 |
| aelkner | and adapters.py would be included in that | 01:18 |
| fsufitch | http://pastebin.com/4bcrs2ym | 01:19 |
| fsufitch | that's what i did | 01:19 |
| fsufitch | anyway there's the adapters.py | 01:19 |
| fsufitch | oh i didnt bzr add it properly | 01:19 |
| fsufitch | oops | 01:19 |
| aelkner | root = getCourseInfoRoot(ISchoolToolApplication(None)) | 01:20 |
| aelkner | you could still use the adapter even thought the method is right there | 01:21 |
| fsufitch | true | 01:22 |
| fsufitch | hang on i broke tests, i just realized | 01:22 |
| fsufitch | i needed to clear the Data.fs first | 01:22 |
| aelkner | you don't need to use DAta.fs | 01:23 |
| aelkner | remember you're doing bin/test -u | 01:23 |
| fsufitch | nono i mean i hadn't run bin/test at first :) | 01:23 |
| fsufitch | i just checked it in the browser | 01:23 |
| fsufitch | i ran bin/test as you were readin gthe code | 01:23 |
| aelkner | ok, so you know what | 01:24 |
| aelkner | you cold make it even cleaner, smaller methods, if you create ICourseInfoSchoolYearContaner(root) | 01:24 |
| aelkner | let it do the logic in the first half | 01:25 |
| fsufitch | hmm ok | 01:25 |
| fsufitch | i only have 30 minutes left though | 01:25 |
| aelkner | ok, do you have passing tests? | 01:26 |
| fsufitch | no, the tests are testing that the subscriber thing works | 01:26 |
| fsufitch | which of course doesnt as there is no more subscriber | 01:26 |
| aelkner | yeah, get rid of those tests then | 01:27 |
| fsufitch | ugh, none of the unit tests use the adapter structure | 01:28 |
| aelkner | you should be changing README.txt to work with the changes to the implementation | 01:28 |
| fsufitch | they need to be rewritten | 01:28 |
| aelkner | that's right | 01:28 |
| aelkner | commits will almost always have changes to tests | 01:28 |
| aelkner | unless you just re-implement something to work exactly the same with existing tests | 01:29 |
| aelkner | but here you are changing the data model, adapters available, etc. | 01:30 |
| aelkner | so yes, tests will have to change | 01:30 |
| fsufitch | right | 01:31 |
| fsufitch | im just changing the tests now | 01:31 |
| *** replaceafill has quit IRC | 01:37 | |
| fsufitch | aelkner: tests pass | 01:38 |
| aelkner | great, could you sne dme the diff via email rather than paste? | 01:39 |
| fsufitch | ok | 01:39 |
| fsufitch | sent | 01:40 |
| aelkner | ok, before you commit, we have time for small canges | 01:42 |
| aelkner | schoolyear = app['schooltool.schoolyear']['2009-2010'] | 01:42 |
| aelkner | you can use ISchoolYearContainer(app), in fact we should always avoid using app['something'] | 01:43 |
| aelkner | except app['person'] until we have IPersonContainer(app) | 01:43 |
| aelkner | also, you could move from schooltool.courseinfo.adapters import getCourseInfoRoot | 01:44 |
| aelkner | and provideAdapter(getCourseInfoSchoolYear) | 01:44 |
| aelkner | to test_courseinfo.py in setup() | 01:45 |
| fsufitch | yeah, i have yet to do that | 01:45 |
| aelkner | it's looking nice, though | 01:45 |
| aelkner | and i agree that you can add more adapters next week | 01:45 |
| fsufitch | adapterss!! | 01:46 |
| aelkner | liking them? | 01:48 |
| fsufitch | heh yeah | 01:48 |
| fsufitch | but for the ISchoolYearContainer(app), how do i define/register the adapter? | 01:48 |
| aelkner | good question | 01:48 |
| aelkner | look at intervetnion tests, i thnk | 01:49 |
| fsufitch | ok | 01:49 |
| fsufitch | oh... it just works? huh. | 01:50 |
| aelkner | you found it? | 01:51 |
| aelkner | tests/tests.py | 01:51 |
| fsufitch | oh there it is | 01:51 |
| aelkner | provideAdapter(getSchoolYearContainer) | 01:51 |
| aelkner | but yes, that adapter just works | 01:51 |
| aelkner | and it uses the descriptors, too, so it's that easy to register/provide | 01:52 |
| fsufitch | sweet | 01:52 |
| aelkner | so setup() is the place to register any adpater like that that you find you need | 01:52 |
| aelkner | just provide them as you need them | 01:53 |
| fsufitch | yup | 01:55 |
| aelkner | so, are you down to zero provideAdapter calls in README.txt? | 01:55 |
| fsufitch | yup, now i am | 01:56 |
| fsufitch | and tests still pass | 01:56 |
| fsufitch | also no more app[] | 01:56 |
| aelkner | excellent | 01:56 |
| aelkner | you can commit and push now | 01:57 |
| fsufitch | committed and pushed | 01:57 |
| fsufitch | woo! | 01:57 |
| aelkner | sweet | 01:57 |
| aelkner | we can pick up where we left off next week | 01:57 |
| aelkner | good job | 01:58 |
| fsufitch | :D | 01:59 |
| aelkner | fsufitch, so that's five hours | 02:01 |
| aelkner | are you doing another five hours before next wed? | 02:01 |
| fsufitch | ill try, but no guarantees, i only have wednesdays as the schooltool-allocated time | 02:03 |
| fsufitch | anyway, i have to go | 02:04 |
| fsufitch | see you around! | 02:04 |
| aelkner | cya next week | 02:05 |
| *** fsufitch has left #schooltool | 02:06 | |
| *** jelkner has quit IRC | 02:25 | |
| *** replaceafill has joined #schooltool | 04:17 | |
| *** replaceafill has joined #schooltool | 04:17 | |
| *** fsufitch has joined #schooltool | 05:51 | |
| *** replaceafill has quit IRC | 06:35 | |
| *** replaceafill has joined #schooltool | 07:04 | |
| *** aks has joined #schooltool | 07:21 | |
| *** th1a has quit IRC | 07:47 | |
| *** aks has quit IRC | 08:17 | |
| *** alga has joined #schooltool | 08:36 | |
| *** alga has quit IRC | 08:43 | |
| replaceafill | yvl u around? | 09:33 |
| yvl | hey replaceafill | 09:33 |
| replaceafill | i have a question | 09:33 |
| replaceafill | i just realized that i'm making cambodia depend a lot on custom demographics | 09:33 |
| replaceafill | but custom demographics are global for the user | 09:33 |
| replaceafill | i mean, they have no info about the schoolyear | 09:34 |
| replaceafill | right? | 09:34 |
| replaceafill | for instance i wont be able to say "yvl's salary scale in 2011 was A.I" | 09:35 |
| yvl | you're right | 09:35 |
| replaceafill | do you think i should better create custom objects for these related to the schoolyear? | 09:35 |
| replaceafill | like im doing with shifts (based on levels) etc | 09:36 |
| yvl | it is your choice in the end, | 09:36 |
| replaceafill | :/ | 09:36 |
| yvl | but if you need per-schoolyear data, then custom objects it is | 09:36 |
| yvl | sorry, but we don't have decent API for that yet | 09:37 |
| yvl | so it's gonna be a lot of copy-paste | 09:37 |
| replaceafill | right | 09:37 |
| replaceafill | well, i'll talk to th1a about it | 09:38 |
| yvl | sure | 09:38 |
| replaceafill | thanks yvl | 09:39 |
| yvl | this is actually a data model issue | 09:39 |
| yvl | so you need to speak with the customers about this | 09:39 |
| yvl | and I promise I'll improve API in a month or two | 09:39 |
| yvl | something along the lines of multi-object annotations | 09:40 |
| replaceafill | right, that's another thought of mine, "we can fix it later" :( | 09:40 |
| yvl | :/ | 09:40 |
| replaceafill | :D | 09:40 |
| yvl | that's life :/ | 09:41 |
| yvl | anyway, at least teh code will be consistent | 09:41 |
| yvl | create a per-year container on app startup, separate items per-int-id.... gah. | 09:42 |
| replaceafill | right | 09:42 |
| replaceafill | like courses, levels, groups, etc etc etc :P | 09:42 |
| yvl | ... :) | 09:47 |
| *** alga has joined #schooltool | 10:02 | |
| *** yvl has quit IRC | 10:02 | |
| *** yvl has joined #schooltool | 10:06 | |
| *** replaceafill has quit IRC | 10:38 | |
| *** yvl has quit IRC | 10:47 | |
| *** menesis has joined #schooltool | 11:37 | |
| *** yvl has joined #schooltool | 12:01 | |
| *** menesis has quit IRC | 12:46 | |
| *** alga has quit IRC | 13:45 | |
| *** yvl has quit IRC | 13:46 | |
| *** alga has joined #schooltool | 14:07 | |
| *** menesis has joined #schooltool | 14:34 | |
| *** yvl has joined #schooltool | 15:07 | |
| *** yvl has quit IRC | 15:53 | |
| *** menesis has quit IRC | 15:53 | |
| *** Lumiere has quit IRC | 15:58 | |
| *** menesis has joined #schooltool | 16:02 | |
| *** Lumiere has joined #schooltool | 16:03 | |
| *** th1a has joined #schooltool | 17:17 | |
| *** replaceafill has joined #schooltool | 17:45 | |
| *** ignas has joined #schooltool | 19:07 | |
| *** alga has quit IRC | 19:11 | |
| *** menesis has quit IRC | 19:36 | |
| *** ignas has quit IRC | 20:43 | |
| *** menesis has joined #schooltool | 20:49 | |
| *** alga has joined #schooltool | 22:09 | |
| *** replaceafill has quit IRC | 23:23 | |
| *** alga has quit IRC | 23:27 | |
| *** alga has joined #schooltool | 23:38 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!