| fsufitch | replaceafill, buildout ran :) | 00:00 |
|---|---|---|
| fsufitch | and now my code breaks it | 00:00 |
| fsufitch | great! | 00:00 |
| replaceafill | :D | 00:00 |
| fsufitch | so everything is good | 00:00 |
| replaceafill | great | 00:00 |
| replaceafill | that's why i love web2py... | 00:00 |
| replaceafill | ... i mean buildout | 00:00 |
| replaceafill | ;) | 00:00 |
| fsufitch | hehehe :) | 00:01 |
| aelkner | replaceafill, so are you still having the PIL problem? | 00:02 |
| replaceafill | aelkner sorry, i'm not running make | 00:03 |
| aelkner | do you think it is a temporary server down issue? | 00:04 |
| fsufitch | woo! | 00:05 |
| replaceafill | i guess it's this whole workaround thing | 00:05 |
| fsufitch | aelkner, zcml restructuring complete :) | 00:05 |
| aelkner | bin/test passes? | 00:07 |
| fsufitch | aelkner, sec while i run it | 00:07 |
| aelkner | replaceafill, so am i grounded until menesis gets back? | 00:09 |
| replaceafill | aelkner you could do the same hack fsufitch did, adding [versions] to your buildout.cfg | 00:10 |
| aelkner | already did it | 00:10 |
| aelkner | the problem is with PIL though | 00:10 |
| aelkner | and fsufitch ddn't say he had that problem | 00:10 |
| aelkner | i'm going to try make realclean | 00:11 |
| aelkner | since i haven't done that since changing buildout.cfg | 00:11 |
| fsufitch | aelkner, tests pass | 00:13 |
| aelkner | ok, so commit and push | 00:14 |
| aelkner | replaceafill, still getting the PIL error | 00:17 |
| aelkner | i guess i'll just wait to see if a server somes up | 00:17 |
| aelkner | comes | 00:17 |
| fsufitch | aelkner, push'd | 00:17 |
| aelkner | if that's not it, i can add to the bug that mensis just updated | 00:18 |
| replaceafill | you probably should | 00:18 |
| aelkner | fsufitch, ok, looks good | 00:21 |
| aelkner | how is the schoolyear view? | 00:21 |
| fsufitch | rudimentary :) | 00:22 |
| fsufitch | i should update ftests to reflect what it should look like as opposed to the current test | 00:25 |
| aelkner | you could take this moment to create ftests directory and move ftests.py, README.txt there | 00:27 |
| aelkner | ftesting.zcml should stay where it is | 00:28 |
| aelkner | you can use intervention package as a guide | 00:28 |
| fsufitch | kay | 00:28 |
| fsufitch | aelkner, any particular reason the existing test uses XPaths, and should i keep doing it that way? | 00:36 |
| fsufitch | because iirc zope.testrunner has some better ways to do ftests | 00:37 |
| aelkner | ah yes, glad you asked | 00:37 |
| aelkner | we definitely all agree that xpath tests are better because they are more explicit | 00:37 |
| aelkner | >>> print manager.contents | 00:38 |
| aelkner | blah blah | 00:38 |
| aelkner | ... | 00:38 |
| aelkner | blah blah | 00:38 |
| aelkner | is too easy to get false positives | 00:38 |
| *** replaceafill has quit IRC | 00:38 | |
| fsufitch | well yes but this way i have to include stuff like CSS classes for elements | 00:38 |
| fsufitch | which is a bit silly | 00:38 |
| aelkner | well, sometimes it's important to include the tags, and you can use ... for things like class= | 00:39 |
| aelkner | but also, you can put /text() at the end of an xpath expression | 00:40 |
| aelkner | and that will give you the stuff INSIDE the tag which is explicit enough | 00:40 |
| fsufitch | hm ok | 00:40 |
| *** replaceafill has joined #schooltool | 00:40 | |
| aelkner | because by virtue of the xpath expression you use to get to the tezt(), you havce proven something | 00:40 |
| aelkner | try doing that right now in README.txt | 00:40 |
| aelkner | you can get rid of the <div> and </div> that way | 00:41 |
| fsufitch | hmm, actually im trying to select some <a>'s now | 00:47 |
| aelkner | ? | 00:48 |
| aelkner | did you change the //div test to add /text() | 00:49 |
| fsufitch | yeah im using text now | 00:49 |
| fsufitch | woo, works! | 00:52 |
| fsufitch | now to make ftests dir | 00:52 |
| fsufitch | aelkner, there actually already exists a "tests" dir | 00:53 |
| aelkner | well, tests dir is for unit tests which we don't d a lot in browser packages | 00:53 |
| aelkner | but you can keep it there | 00:53 |
| fsufitch | ok | 00:53 |
| fsufitch | just checking that it didnt have the same purpose | 00:53 |
| aelkner | ftests dir is for functional tests | 00:53 |
| aelkner | it's a place holder | 00:54 |
| aelkner | schooltool.gradebook actually has unit tests for reports | 00:54 |
| aelkner | but that was because we hadn't figured out a way to functionally test them | 00:54 |
| fsufitch | aelkner, so what's the purpose of ftesting.py? | 01:02 |
| fsufitch | i don't see the same thing in intervention | 01:03 |
| fsufitch | oh it's in ftests/ftests.py | 01:04 |
| fsufitch | wait no, the existing ftests.py just duplicated ftesting.py | 01:04 |
| aelkner | ftesting.py is unnecessary, you can remove it | 01:05 |
| fsufitch | aelkner, bam, done | 01:22 |
| fsufitch | and pushed | 01:25 |
| aelkner | ok, cool, some housekeeping that also gets you more familiar witht the code | 01:29 |
| aelkner | you could add small stuff to the existing view | 01:29 |
| aelkner | like pretend that you have courseinfo objects to list | 01:30 |
| aelkner | even though you don't already | 01:30 |
| aelkner | you can add a ul/li/a list of lnks to the existing courseinfo objects | 01:32 |
| aelkner | a change to the template, a new methodin the view class, a new test | 01:32 |
| aelkner | for now return a fake list of one | 01:33 |
| fsufitch | ok | 01:38 |
| aelkner | next week we can talk about the data model some more and lay out a plan for what objects/views you should write | 01:39 |
| fsufitch | okay | 01:44 |
| fsufitch | :) | 01:44 |
| aelkner | btw, one small thing | 01:52 |
| aelkner | you should replace the menuitem directive in browser/configure.zcml | 01:53 |
| aelkner | with the more proper viewlet manager version | 01:53 |
| aelkner | fsufitch, see "Action menu buttons" section | 01:54 |
| aelkner | of instervetnion /browser/configure.zcml | 01:54 |
| fsufitch | alright | 01:55 |
| fsufitch | thnks | 01:55 |
| fsufitch | *thanks | 01:55 |
| aelkner | np | 01:55 |
| *** alga has quit IRC | 02:13 | |
| *** replaceafill has quit IRC | 02:37 | |
| fsufitch | aelkner, ive lost my focus, ugh | 02:49 |
| fsufitch | really tired | 02:49 |
| fsufitch | ive got the view thing started though | 02:49 |
| fsufitch | thanks for the help :) | 03:02 |
| aelkner | no, see you next week | 03:08 |
| aelkner | np, i meant | 03:08 |
| *** fsufitch has quit IRC | 03:16 | |
| *** aks has joined #schooltool | 06:06 | |
| *** aks has joined #schooltool | 06:06 | |
| *** menesis has joined #schooltool | 08:16 | |
| *** yvl has quit IRC | 08:37 | |
| *** yvl has joined #schooltool | 08:40 | |
| *** aks has quit IRC | 09:45 | |
| *** aks has joined #schooltool | 10:12 | |
| *** yvl_ has joined #schooltool | 10:54 | |
| *** yvl_ has quit IRC | 10:54 | |
| *** alga has joined #schooltool | 10:57 | |
| *** alga has quit IRC | 11:18 | |
| *** alga has joined #schooltool | 12:00 | |
| *** alga has quit IRC | 13:43 | |
| *** menesis has quit IRC | 14:04 | |
| *** aks has quit IRC | 14:20 | |
| *** menesis has joined #schooltool | 15:11 | |
| *** alga has joined #schooltool | 15:38 | |
| aelkner | yvl, ayt? | 16:51 |
| yvl | yes, aelkner | 16:52 |
| th1a | aelkner: What's your itinerary today? | 16:52 |
| aelkner | i'm going to call in a sec | 16:53 |
| aelkner | yvl, did you have a chance to look over my merge requests? | 16:53 |
| yvl | sorry, not yet | 16:53 |
| aelkner | ok, never mind | 16:53 |
| *** aelkner has quit IRC | 16:58 | |
| *** replaceafill has joined #schooltool | 17:34 | |
| *** replaceafill has quit IRC | 18:08 | |
| *** alga has quit IRC | 19:39 | |
| *** menesis has quit IRC | 20:31 | |
| *** menesis has joined #schooltool | 21:49 | |
| *** replaceafill has joined #schooltool | 21:52 | |
| *** aelkner has joined #schooltool | 22:59 | |
| th1a | https://code.launchpad.net/~schooltool-developers/schooltool/st-mindmaps | 22:59 |
| th1a | bzr branch lp:~schooltool-developers/schooltool/st-mindmaps | 23:00 |
| *** th1a has quit IRC | 23:02 | |
| *** replaceafill has quit IRC | 23:32 | |
| *** aelkner has quit IRC | 23:52 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!