| *** aks_ has joined #schooltool | 05:19 | |
| *** aks_ has joined #schooltool | 05:20 | |
| *** aks_ is now known as aks | 05:20 | |
| *** menesis has quit IRC | 11:44 | |
| *** menesis has joined #schooltool | 11:49 | |
| *** menesis has quit IRC | 11:56 | |
| *** alga has joined #schooltool | 12:05 | |
| *** aks has quit IRC | 13:22 | |
| *** ignas_ has joined #schooltool | 13:35 | |
| *** jelkner has joined #schooltool | 15:10 | |
| *** th1a has joined #schooltool | 15:35 | |
| *** menesis has joined #schooltool | 15:39 | |
| *** menesis has quit IRC | 15:51 | |
| *** menesis has joined #schooltool | 15:56 | |
| th1a | menesis, yvl: I need copies of your airfare receipts and a completed expense form. | 16:11 |
|---|---|---|
| th1a | I sent an email to alga about it on Friday. | 16:12 |
| *** menesis has quit IRC | 16:18 | |
| alga | th1a: our office admin is sick, I'll take care of that today | 16:19 |
| th1a | Thanks alga. | 16:22 |
| *** menesis has joined #schooltool | 16:23 | |
| alga | th1a: do you want a signed scan or an electronic copy? | 16:25 |
| *** replaceafill has joined #schooltool | 16:25 | |
| th1a | Electronic copy is fine. | 16:25 |
| alga | also, who is the employee? POV or Justas? | 16:25 |
| th1a | Just POV is fine. | 16:25 |
| th1a | Hi menesis, yvl, aelkner, replaceafill. | 16:30 |
| yvl | hi guys! | 16:30 |
| menesis | hi | 16:30 |
| replaceafill | good morning/afternoon | 16:30 |
| th1a | Let's see... first off, sorry the post-trip invoices have taken too long to handle. | 16:32 |
| aelkner | morning | 16:32 |
| th1a | I should have taken into account the brevity of the month. | 16:32 |
| th1a | So the good news is that if you get me your February invoices on Wednesday you can get paid twice in a week. | 16:32 |
| th1a | Which I as well would appreciate. | 16:33 |
| * replaceafill will send his today | 16:33 | |
| aelkner | btw, i just thought about it, but is it going to be ok that we included portugal expenses on jan invoice? | 16:33 |
| th1a | Yes, that is fine. | 16:33 |
| th1a | That was the whole idea. | 16:33 |
| th1a | I mean, I'm the one carrying most of it on my credit card, so I'm the most motivated to get it all taken care of. | 16:34 |
| aelkner | i'll get you my feb invoice later today, too | 16:35 |
| th1a | OK, menesis, any new packaging news? | 16:35 |
| menesis | th1a: since Thursday, none | 16:36 |
| menesis | schooltool packages are still waiting in the NEW queue. | 16:36 |
| th1a | OK. Let me know when we should start pinging people about that. | 16:37 |
| th1a | What's next for you? | 16:38 |
| menesis | I still have branches to merge | 16:39 |
| menesis | replaceafill's gradebook branch | 16:40 |
| menesis | and translations | 16:40 |
| th1a | OK. | 16:40 |
| th1a | Sounds good. Good work getting the packages in! | 16:41 |
| th1a | yvl: I guess you and alga worked out a timeline for finishing timetables? | 16:42 |
| yvl | yes, th1a | 16:42 |
| yvl | alga sent you an email, IIRc | 16:42 |
| th1a | Yes, but he didn't send me the plan itself, I don't think. | 16:42 |
| yvl | hmm, right | 16:43 |
| yvl | the punchcards are hanging on my board | 16:43 |
| yvl | I can write them down if you want? | 16:43 |
| yvl | silence means yes :) | 16:44 |
| th1a | Yes. | 16:44 |
| yvl | for now, all goes according to plan | 16:44 |
| th1a | Good. Anything else? | 16:44 |
| yvl | no | 16:45 |
| yvl | I won't have much to report for few weeks :) | 16:45 |
| yvl | just the progress :) | 16:45 |
| th1a | There is nothing wrong with that. | 16:46 |
| th1a | Thanks yvl. | 16:46 |
| th1a | replaceafill? | 16:46 |
| replaceafill | ok | 16:46 |
| replaceafill | last week i worked on the forms cambodia sent | 16:46 |
| replaceafill | i wrote down how i'd implement all those fields, but i got tired with the first form | 16:47 |
| replaceafill | i still have to review the second one | 16:47 |
| replaceafill | (there's two forms: 1 for primary school and 1 for secondary) | 16:47 |
| replaceafill | so, on tuesday i jumped to the gradebook, again changes i need for cambodia | 16:48 |
| replaceafill | 1, the score refactoring and 2, the final annual grade calculation | 16:48 |
| replaceafill | and about the score refactoring i sent an email last night to the dev list | 16:48 |
| replaceafill | i'll wait for yvl's reply :) | 16:49 |
| yvl | on it, replaceafill | 16:49 |
| replaceafill | thanks | 16:49 |
| yvl | oh, I can say it here | 16:49 |
| yvl | go with "no evolution" | 16:49 |
| replaceafill | :D | 16:49 |
| yvl | also, if it makes sense | 16:49 |
| yvl | postpone splitting the class | 16:50 |
| yvl | Score or Evaluation | 16:50 |
| yvl | I don't remember which one | 16:50 |
| *** alga has quit IRC | 16:50 | |
| yvl | if you don't need the split explicitly | 16:50 |
| yvl | maybe it's less hassle not to refactor it in this run | 16:50 |
| replaceafill | i guess you split it for getting gradebook averages | 16:51 |
| yvl | and I'm not sure if it was not persistent | 16:51 |
| aelkner | what was the use case that started you down this road, why did it crash? | 16:52 |
| yvl | maybe reconstruct picks objects __new__ over Persistent's | 16:52 |
| yvl | maybe it's enough to flip the order of inheritence in the child class | 16:52 |
| aelkner | was there a new zope egg that caused the problem? | 16:52 |
| yvl | no | 16:52 |
| yvl | refactoring | 16:52 |
| replaceafill | aelkner, an existing class inherits now from Persistent | 16:53 |
| yvl | oh, and cheers on the format gradebook for tests thing! | 16:53 |
| replaceafill | :) | 16:53 |
| yvl | pretty :) | 16:53 |
| replaceafill | yvl, it makes reading the ftests so easy :) | 16:53 |
| yvl | yes! | 16:53 |
| replaceafill | and writing them too! | 16:53 |
| aelkner | i'm not aware of why we are refactoring this, can someone clue me in? | 16:54 |
| replaceafill | so, i'll try merging the two classes again | 16:54 |
| yvl | if you really need them separate, I can look into it | 16:54 |
| replaceafill | aelkner, it will be easier to extend the gradebook with "weird" calculations | 16:54 |
| yvl | just if you chose this for the sake of code correctness, I'd prefer postponing this change | 16:55 |
| replaceafill | yvl, actually, i just re-took your old refactoring approach :) | 16:55 |
| yvl | oh :))) | 16:55 |
| replaceafill | yvl, could i get away with just not subclassing Persistent? | 16:56 |
| yvl | not sure about that | 16:56 |
| replaceafill | ah ok | 16:56 |
| yvl | probably yes | 16:56 |
| yvl | unpickle the objects and look if they have persistance info | 16:57 |
| yvl | _p__something | 16:57 |
| replaceafill | ok | 16:57 |
| replaceafill | yvl, thanks i'll try that this week | 16:57 |
| replaceafill | th1a, i also got my way in cambodia mixing docs + ftests | 16:58 |
| replaceafill | i just configured sphinx the right way | 16:58 |
| replaceafill | and as menesis suggested i hide the ftest code blocks, really nice :) | 16:58 |
| th1a | I figured it just took the right Sphinx magic. | 16:58 |
| th1a | Where can I see that? | 16:59 |
| replaceafill | i'll push the changes to the cambodia branch | 16:59 |
| replaceafill | i was just evaluating the two recipes for producing sphinx docs | 16:59 |
| menesis | replaceafill: I get one warning when mixing sphinx with ftest | 16:59 |
| menesis | http://source.schooltool.org/buildbot/builders/pov-schooltool_trunk-buildout/builds/451/steps/functional%20tests/logs/stdio | 17:00 |
| menesis | Unknown directive type "toctree" | 17:00 |
| menesis | have you seen something like that? | 17:00 |
| th1a | From Sphinx or the test runner? | 17:01 |
| replaceafill | i thought toctree was "core" in sphinx | 17:01 |
| replaceafill | so you cannot blame a missing plugin, right? | 17:01 |
| menesis | sphinx generates the page fine | 17:02 |
| menesis | it's the testrunner that spews warning | 17:02 |
| replaceafill | menesis, do you know if it's possible to generate the docs in pdf using that recipe (the one used in schooltool trunk)? | 17:03 |
| replaceafill | it's possible with the collective... recipe | 17:03 |
| replaceafill | i just dont want to use many different packages than trunk | 17:03 |
| replaceafill | schooltool trunk uses: z3c.recipe.sphinxdoc | 17:04 |
| replaceafill | and cambodia is using: collective.recipe.sphinxbuilder/ | 17:04 |
| replaceafill | i can produce pdf with the second one, couldnt find a way with the first | 17:04 |
| replaceafill | (me wants to be able to send the pdf to cambodia people) | 17:05 |
| replaceafill | moving on with my report... | 17:05 |
| replaceafill | th1a, i also reorganized my papercuts notes | 17:05 |
| replaceafill | which ones i need for cambodia that i can work next | 17:05 |
| replaceafill | also tested the approach suggested by menesis on using views in testing layers to enabled/disable components | 17:06 |
| replaceafill | works great :) | 17:06 |
| th1a | Ah, good. | 17:06 |
| replaceafill | and finally i chatted a little with aelkner about coverage reports, testing approaches, life, etc :D | 17:07 |
| yvl | I saw that ;) | 17:07 |
| th1a | replaceafill: We need to set a bonus target for Cambodia tasks. | 17:07 |
| replaceafill | th1a, ah! | 17:07 |
| th1a | So send me a list of tasks and a target date. | 17:07 |
| replaceafill | th1a, ok | 17:07 |
| th1a | A realistic target date. | 17:08 |
| replaceafill | understood | 17:08 |
| replaceafill | yvl, any comment on the testing approach discussion (me and aelkner) | 17:08 |
| yvl | ok :) | 17:08 |
| yvl | the way I see it | 17:08 |
| replaceafill | am i a bad person for not caring about the mergers? :P | 17:09 |
| replaceafill | (kidding) | 17:09 |
| yvl | plugins can add, modify and remove links | 17:09 |
| yvl | also, when you test a plugin (and in this case, you should consider all ST modules as separate plugins) | 17:09 |
| yvl | you are actually testing if it works correctly with the configuration it depends on | 17:09 |
| yvl | that is especially true for functional testing | 17:10 |
| yvl | so I vote for more brittle tests | 17:10 |
| yvl | imagine you have some links | 17:10 |
| replaceafill | ah! | 17:10 |
| yvl | and you write a functional test to click it | 17:10 |
| yvl | and *somebody* adds another link with similar text just above it | 17:11 |
| yvl | now - your test is broken | 17:11 |
| yvl | and it may not be obvious why | 17:11 |
| yvl | but if you have a test that shows the "context" - other links | 17:11 |
| yvl | you'll see that there's a new link there | 17:11 |
| yvl | and that's why your test breaks later on | 17:11 |
| yvl | then again! | 17:12 |
| yvl | Alan had a strong point there also | 17:12 |
| replaceafill | why i didnt like in aelkner's approach is that, that kind of test will still pass even if i add new links in the PLUGIN | 17:12 |
| replaceafill | s/why/what | 17:12 |
| yvl | true | 17:12 |
| aelkner | hey, i can get rid of the tests altogether | 17:12 |
| yvl | :D | 17:13 |
| yvl | downside - tests are more brittle | 17:13 |
| aelkner | in a way, it tests something that core already tested wth the mock reportLinks in ftesting.zcml | 17:13 |
| yvl | true | 17:13 |
| yvl | but in this case, you assume that the core works the way it works | 17:13 |
| yvl | what if somebody refactored it? | 17:13 |
| yvl | or changed the behaviour ever so slightly | 17:14 |
| yvl | if the test brakes early - you know that the gradebook version is not compatible with xx.xx version of the core | 17:14 |
| replaceafill | fail fast! | 17:14 |
| yvl | but please, don't take this as written in stone! | 17:15 |
| aelkner | but in the case of each time a new report is added to core of lyceum journal, having to change gradebook tests! | 17:15 |
| * replaceafill writes it in stone!!! | 17:15 | |
| *** ignas_ has quit IRC | 17:15 | |
| yvl | yes, aelkner | 17:15 |
| yvl | but | 17:15 |
| yvl | if it is really unimportant of what other reports are there | 17:15 |
| *** ignas has joined #schooltool | 17:15 | |
| yvl | and you tested the order in one place at least | 17:16 |
| yvl | as in - in the beginning of some main test | 17:16 |
| yvl | like README.txt :) | 17:16 |
| yvl | there is no need to repeat all the links in every other test | 17:16 |
| yvl | and a small counter-argument :) | 17:17 |
| yvl | lyceum.journal should be merged with gradebook anyway :) | 17:17 |
| yvl | eventually | 17:17 |
| replaceafill | and then gradebook to core :P | 17:17 |
| yvl | riiiiight | 17:17 |
| replaceafill | (kidding yvl) | 17:17 |
| replaceafill | :D | 17:17 |
| yvl | ;) | 17:17 |
| aelkner | i always felt that way | 17:17 |
| aelkner | anyway, what is the conclusion? | 17:18 |
| aelkner | make tests brittle, and let the mergers fix them when they brake? | 17:18 |
| replaceafill | dont care about the mergers!!! | 17:18 |
| yvl | make one test brittle | 17:18 |
| aelkner | i was asking yvl :) | 17:18 |
| replaceafill | aelkner, :'''( | 17:18 |
| aelkner | i have tests for each context | 17:19 |
| aelkner | so there isn'[t jsut on tests | 17:19 |
| * th1a peeks back in. | 17:19 | |
| aelkner | schoolyear, term, section, etc., reports | 17:19 |
| aelkner | there isn't ust one | 17:19 |
| aelkner | just | 17:19 |
| th1a | I'd just note that in the future all reports might want to be in separate packages. | 17:19 |
| yvl | I see | 17:19 |
| yvl | (I see, aelkner) | 17:20 |
| yvl | I vote to make them brittle for now | 17:20 |
| aelkner | ok, as long as you invite the hassle, i won't object :) | 17:21 |
| yvl | you can have one test to overview what reports schooltool.gradebook adds | 17:21 |
| yvl | going to terms, sections, etc. | 17:21 |
| aelkner | how would that be done? | 17:21 |
| aelkner | the views are defined in schooltool.report | 17:21 |
| aelkner | they don't know where the reportLinks were registered | 17:22 |
| yvl | yes | 17:22 |
| yvl | but you do not test that in schooltool.report | 17:22 |
| yvl | you test that in schooltool.gradebook | 17:22 |
| aelkner | i test the mock reportLinks in schooltool.report | 17:22 |
| yvl | true | 17:22 |
| yvl | and that is good | 17:22 |
| aelkner | that's why i suggested not testing the gradebook reportLinks at all | 17:22 |
| yvl | you demonstrate, that people can add links | 17:23 |
| yvl | but in gradebook | 17:23 |
| yvl | you want to show what reports become available | 17:23 |
| replaceafill | aelkner, it's gradebook functionality, right? | 17:23 |
| yvl | when you use gradebook + all dependencies | 17:23 |
| aelkner | integration testing, right? | 17:23 |
| yvl | right | 17:24 |
| yvl | in lyceum journal, for example: | 17:24 |
| yvl | if there are links to reports that are implemented and declared as reportLinks in schooltool.lyceum.journal | 17:24 |
| yvl | you should show that if you use ST core + journal, you can see all these reports | 17:25 |
| yvl | then in gradebook, | 17:25 |
| yvl | which adds more reports | 17:25 |
| yvl | you should show (just in one test) | 17:25 |
| yvl | the total of available reports | 17:25 |
| aelkner | ok, i'll refactor them to be brittle and assume that you guys won't get confused | 17:25 |
| yvl | (because gradebook depends on journal) | 17:25 |
| aelkner | let's move on | 17:25 |
| yvl | thanks :) | 17:25 |
| replaceafill | th1a, the last point of my notes | 17:26 |
| replaceafill | next week i'm going to pycon :) | 17:26 |
| replaceafill | but i'll just take one day off (friday) | 17:26 |
| replaceafill | american airlines airplanes have power outlets ;) | 17:26 |
| replaceafill | so i'll be able to work while i travel | 17:26 |
| replaceafill | th1a, that's it from me | 17:27 |
| th1a | Thanks replaceafill. | 17:28 |
| th1a | So yes, send me your Cambodia plan. | 17:28 |
| th1a | aelkner? | 17:28 |
| replaceafill | th1a, will do | 17:28 |
| aelkner | ok, so besides the whole schooltool.gradebook reportLinks testing issue, i adressed the url adpaters problem | 17:28 |
| aelkner | yvl, sorry for the delay getting you the good news that your suggestion worked | 17:29 |
| aelkner | so the reference view works now | 17:29 |
| aelkner | then i turned my attention to schooltool.intervention | 17:29 |
| aelkner | i moved the ftests to a new ftests directory in browser | 17:30 |
| aelkner | and added a new test for the single-digit user id bug that i fixed | 17:30 |
| aelkner | replaceafill helped me get started with coverage tests, thanks for that | 17:30 |
| replaceafill | :) | 17:31 |
| aelkner | i was wondering about what level of coverage i'm trying to acheive | 17:31 |
| replaceafill | aelkner, the closest to 100% as you can? | 17:31 |
| th1a | I'm looking for level "B" coverage. | 17:31 |
| aelkner | i had assumed that the gradebook had 100% test coverage at this point, but i couldn't find a branch that does so | 17:31 |
| * th1a does not know. | 17:32 | |
| replaceafill | aelkner, as i told you, you cannot ftest generations for example | 17:32 |
| aelkner | i was going to say... | 17:32 |
| aelkner | in schooltool.intervention i have a lot a fail-safe points that handle cases where data has been corrupted | 17:33 |
| aelkner | but i can't make the data corrupt in ftests | 17:33 |
| aelkner | because the views are supposed to behave | 17:34 |
| th1a | What kind of corruption are you referring to? | 17:34 |
| yvl | users clicking stuff in a way Alan did not expect mostly | 17:35 |
| aelkner | for instance, a InterventionStudent object has a student property that returns the actual basicperson object | 17:35 |
| * replaceafill personally doesnt like fail-safe points in code | 17:35 | |
| * yvl too, replaceafill ;) | 17:35 | |
| replaceafill | :) | 17:35 |
| yvl | no offence, aelkner ! | 17:35 |
| replaceafill | again, fail fast | 17:35 |
| replaceafill | that doesnt mean, throwing exceptions at users either ;) | 17:36 |
| aelkner | that's what the fail-safes are trying to avoid | 17:36 |
| aelkner | throwing exceptions at users | 17:36 |
| menesis | incorrect data handling should be tested in unit tests, because there you can throw anything broken at your functions | 17:36 |
| menesis | but that cannot be tested functionally because such breakages cannot occur | 17:37 |
| aelkner | exactly | 17:37 |
| replaceafill | and sometimes you end with "impossible to get to" fail-safe points, according to your current implementation | 17:38 |
| aelkner | anyway, i thought there was a standard that i was being asked to acheive, but looking at the gradebook, i'm not so sure | 17:38 |
| menesis | so why write checks for impossible situations.. | 17:38 |
| aelkner | what was the overall goal of the gradebook coverage refactoring, and how do you know you acheived it? | 17:38 |
| aelkner | replaceafill? | 17:38 |
| replaceafill | aelkner, i compare | 17:38 |
| replaceafill | that's why i keep throwing screenshots at you | 17:39 |
| aelkner | you compare what? | 17:39 |
| replaceafill | before the refactoring, after the refactoring | 17:39 |
| aelkner | i was asking about the coverage report | 17:39 |
| replaceafill | from http://img220.imageshack.us/img220/1594/pantallazo1r.png -> http://img684.imageshack.us/img684/7531/pantallazotq.png | 17:39 |
| replaceafill | is it the second BETTER than the first one? | 17:40 |
| replaceafill | it's not PERFECT ;) | 17:40 |
| aelkner | better is not a milestone, so th1a, what is the sign of being done? | 17:40 |
| menesis | cp coverage coverage.old ; make coverage ; bin/coveragediff coverage.old coverage | 17:40 |
| aelkner | i can decide it's better anytime i want | 17:40 |
| aelkner | that's not a standard, nor anything th1a can sign off on | 17:41 |
| replaceafill | aelkner, you cant? | 17:41 |
| replaceafill | i thought you could ;) | 17:41 |
| yvl | hmm, th1a can assign replaceafill to decide that ;))) | 17:41 |
| replaceafill | i want that VP please :D | 17:41 |
| yvl | all important places should be covered | 17:41 |
| aelkner | watever that means | 17:41 |
| yvl | (at least all places I consider important enough) :))) | 17:42 |
| yvl | if you calculate stuff - unit tests | 17:42 |
| aelkner | you guys are having fun, but i prefer concrete suggestions | 17:42 |
| th1a | I'm in favor of getting the coverage scores as close to 100% as is possible. | 17:42 |
| yvl | if you just format data for presentation - unit tests preferred, functional ok | 17:42 |
| aelkner | say that again please | 17:43 |
| th1a | I am also in favor of everyone at this point obtaining a QA hat and writing tests TRYING TO BREAK the application. | 17:43 |
| replaceafill | aelkner, will you ask "is it close to 100% a milestone?" | 17:44 |
| th1a | That is, what if I delete the relevant terms in the middle of this. | 17:44 |
| th1a | What if I try to do this with no years. | 17:44 |
| yvl | what if user's session expires ;) | 17:44 |
| aelkner | 'close' is not a quantity | 17:44 |
| th1a | What if I try to do this and delete the year and recreate one with the same ID, | 17:44 |
| th1a | etc. | 17:44 |
| replaceafill | yvl, damn! sessions!!! | 17:44 |
| yvl | aelkner - you will not get detailed pointers, I'm afraid :( | 17:44 |
| yvl | just because there are no strict rules for this | 17:45 |
| th1a | If you want I can make it 100% for you, aelkner. | 17:45 |
| aelkner | yeah, that helps, NOT | 17:45 |
| yvl | my point - 100% is not enough in some cases | 17:45 |
| replaceafill | right, coverage is not enough | 17:45 |
| th1a | In theory you should get the bonus a year later after no bugs have been reported. | 17:45 |
| aelkner | true, the single-digit user id problem, for instance | 17:45 |
| replaceafill | th1a, :D | 17:46 |
| aelkner | th1a, whatever | 17:46 |
| yvl | aelkner, probably you will have to use your better judgement for this | 17:46 |
| th1a | aelkner, this attitude is not endearing. | 17:46 |
| yvl | and test your position against some other developer | 17:46 |
| yvl | as in - "I think it's covered quite well" | 17:47 |
| replaceafill | correct | 17:47 |
| replaceafill | that's my approach with the gradebook | 17:47 |
| yvl | "What do you guys think? Did I miss some cases?" | 17:47 |
| replaceafill | not numbers | 17:47 |
| th1a | Yes. | 17:47 |
| yvl | and you know gradebook better than anyone, aelkner | 17:47 |
| th1a | I do. | 17:47 |
| aelkner | fine, i'll just wing it as everyone else seems to be | 17:48 |
| aelkner | i won't complain it again | 17:48 |
| aelkner | about it | 17:48 |
| yvl | sorry, aelkner | 17:48 |
| yvl | I know you like clear decisions | 17:48 |
| th1a | You need to do a better job QA-ing your code. | 17:48 |
| aelkner | for instance, i'll leave the fail-safes uncovered | 17:48 |
| aelkner | because clearly there is no way to test them functionall | 17:49 |
| yvl | you can unit test them at least | 17:49 |
| aelkner | sure | 17:49 |
| yvl | so you know that this code at least works | 17:49 |
| yvl | (you don't want a typo exploding when user encounters the fail-safe) | 17:49 |
| aelkner | i can certainly disable the email utility finctionally | 17:49 |
| yvl | umm, there you should just... | 17:49 |
| aelkner | yes, 100% unit test coverage is certainly acheivable | 17:50 |
| yvl | I think replaceafill did a stub email utility that just stores "sent" emails? | 17:50 |
| th1a | The fact of the matter is that SchoolTool is in a different place now than two years ago. | 17:50 |
| th1a | We're not in "We need to get functionality out soon or nobody will ever use SchoolTool." anymore. | 17:51 |
| th1a | Now we need to pay down some of that debt. | 17:51 |
| th1a | Write some tests. | 17:51 |
| th1a | Make sure SchoolTool isn't going to blow up in people's faces. | 17:51 |
| th1a | That's what you're being paid to do now. | 17:52 |
| replaceafill | schooltool/src/schooltool/email/browser/ftests/__init__.py has stubs for email functionality | 17:52 |
| yvl | btw, aelkner - if some place is hard to test, please email me | 17:52 |
| replaceafill | and please cc me :) | 17:53 |
| yvl | it might be the case that we did not think about | 17:53 |
| yvl | (but we should!) | 17:53 |
| aelkner | for instance, lots of code fails safe if the intervention student's id has no corresponding person object | 17:53 |
| aelkner | but that code would not be reached as long as the subscriber for removing intervention students upon student removal is in place | 17:54 |
| aelkner | so i'll just leave those fail-safes as uncovered code | 17:54 |
| yvl | ok | 17:54 |
| replaceafill | -1, but thats just me :) | 17:54 |
| yvl | I feel your pain, replaceafill | 17:55 |
| th1a | tbh, if something like that can't be tested, it probably shouldn't be there. | 17:55 |
| th1a | RIght? | 17:55 |
| yvl | in my opinion, we should have stuff that ensures such integrity in core | 17:55 |
| aelkner | or i can remove the fail-safes altogether then | 17:55 |
| yvl | not in every single page in interventions | 17:55 |
| replaceafill | th1a, or at least be reviewed | 17:55 |
| yvl | th1a, you're right | 17:56 |
| yvl | but it's a monument of FIXME :) | 17:56 |
| th1a | I don't know what kind of things all these fail-safes do. | 17:56 |
| yvl | as long as they're there we all know it needs to be fixed | 17:56 |
| yvl | and that integrity code should be written | 17:56 |
| yvl | but in a single place, not in multiple | 17:57 |
| yvl | anyway, I'm rambling | 17:57 |
| th1a | Shouldn't the unit test be pretty trivial? | 17:57 |
| aelkner | yeah, no problem | 17:57 |
| yvl | cool :) | 17:58 |
| * th1a doesn't have his sarcasm detector turned high enough. | 17:58 | |
| aelkner | another thing | 17:58 |
| aelkner | i can give the code the kind of love yvl yearns for | 17:58 |
| aelkner | replacing provideBy calls with better adapter(context, None) logic | 17:58 |
| aelkner | using tests for None instead of providedBy | 17:59 |
| aelkner | it's the same difference to me, but yvl would like it better | 17:59 |
| yvl | yes I would - it's not the same for me | 18:00 |
| replaceafill | getting rid of providedBy checks is in my todo list for the gradebook | 18:00 |
| th1a | The theme of this week's meeting is I need you guys to figure out what you're doing for the next month or so so I can give you a bonus. | 18:00 |
| replaceafill | !!! | 18:01 |
| th1a | So basically, aelkner, I need you to make a proposal for how you're going to handle this. | 18:01 |
| aelkner | can you change the mm doc to not say 'full test cverage' in intervention since we have no such standard? | 18:01 |
| *** alga has joined #schooltool | 18:01 | |
| yvl | change to "very decent test coverage" | 18:01 |
| aelkner | :) | 18:02 |
| th1a | Whatever floats your boat. | 18:02 |
| replaceafill | full is the goal! | 18:02 |
| replaceafill | :D | 18:02 |
| yvl | well, ideally - it's the minimum requirement | 18:03 |
| yvl | full coverage ;) | 18:03 |
| th1a | The more important stuff is what lies beyond. | 18:03 |
| replaceafill | yvl, and i want them all to be unit, so they run fast as hell :D | 18:03 |
| th1a | OK. Wrapping up. | 18:03 |
| th1a | In other news, my PandaBoard has shipped. | 18:04 |
| th1a | Have a great week, gentlemen! | 18:04 |
| th1a | I look forward to your March plans. | 18:04 |
| * th1a drops the bag of gravel. | 18:04 | |
| replaceafill | thanks everybody | 18:04 |
| yvl | great week to you all :) | 18:05 |
| aelkner | great week everyone | 18:05 |
| alga | th1a: is the expense sheet OK? | 19:03 |
| th1a | Yes. | 19:03 |
| th1a | Thanks. | 19:04 |
| alga | Great! | 19:04 |
| *** ignas has quit IRC | 19:23 | |
| *** menesis has quit IRC | 19:49 | |
| alga | Schooltool is in Natty Universe! Hurraaaah! | 20:27 |
| th1a | \o/ | 20:27 |
| replaceafill | nice! :) | 20:27 |
| replaceafill | th1a, zyt? | 20:35 |
| th1a | Yes. | 20:35 |
| replaceafill | http://69.164.203.135/cambodiabook.html | 20:36 |
| replaceafill | http://69.164.203.135/cambodiabook.pdf | 20:36 |
| replaceafill | i still have to add all the tests, but you get the idea :) | 20:36 |
| th1a | I'm not sure I get the idea. | 20:37 |
| th1a | So this if from the test readme's instead of a separate document? | 20:37 |
| replaceafill | ah! those are functional tests | 20:37 |
| replaceafill | yes | 20:37 |
| th1a | Is this user or developer documentation? | 20:38 |
| th1a | Are the screenshots automatically generated? | 20:38 |
| replaceafill | user, the page footnotes were supposed for developers | 20:38 |
| replaceafill | but i'm going to move all those tips to a dev section or something | 20:38 |
| replaceafill | like the core book | 20:38 |
| *** alga has quit IRC | 20:39 | |
| replaceafill | th1a, no, the screenshots are not automatically... yet | 20:39 |
| replaceafill | but i was able to do it with selenium on our way back | 20:39 |
| th1a | I'm not sure this doesn't just make my job more complicated. | 20:39 |
| replaceafill | well it's not for you ;) | 20:39 |
| replaceafill | i write the ftests for cambodia :) | 20:39 |
| replaceafill | it's just an experiment i think | 20:40 |
| replaceafill | it's definitely more complicated to write all the sphinx stuff | 20:40 |
| replaceafill | hide blocks etc | 20:40 |
| th1a | I'd like to see an auto-generated book just made from the tests, but primarily as a developer reference. | 20:41 |
| replaceafill | me too | 20:42 |
| *** menesis has joined #schooltool | 20:58 | |
| *** jelkner has quit IRC | 22:10 | |
| *** alga has joined #schooltool | 22:35 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!
