| *** menesis has quit IRC | 01:15 | |
| *** svaksha has quit IRC | 02:39 | |
| *** svaksha has joined #schooltool | 02:40 | |
| *** alga has quit IRC | 03:05 | |
| *** codai2810 has joined #schooltool | 04:00 | |
| *** replaceafill has quit IRC | 04:37 | |
| *** replaceafill has joined #schooltool | 05:00 | |
| *** menesis has joined #schooltool | 05:46 | |
| *** menesis has quit IRC | 05:51 | |
| *** menesis has joined #schooltool | 06:05 | |
| *** menesis1 has joined #schooltool | 06:12 | |
| *** menesis has quit IRC | 06:12 | |
| *** menesis1 is now known as menesis | 06:12 | |
| *** codai2810 has left #schooltool | 06:18 | |
| *** th1a has quit IRC | 06:27 | |
| *** menesis has quit IRC | 07:04 | |
| *** replaceafill has quit IRC | 07:42 | |
| *** alga has joined #schooltool | 12:41 | |
| *** replaceafill has joined #schooltool | 16:41 | |
| *** menesis has joined #schooltool | 16:57 | |
| *** alga has quit IRC | 17:01 | |
| aelkner | replaceafill, what are the steps again? | 20:19 |
|---|---|---|
| replaceafill | aelkner, 'make coverage' just gives you the numbers right | 20:19 |
| aelkner | right | 20:19 |
| replaceafill | you need 'make coverage-reports-html' | 20:20 |
| replaceafill | you'll get a 'coverage' directory in your buildout | 20:20 |
| replaceafill | then you'll get a coverage/reports directory | 20:20 |
| replaceafill | with lots of html files | 20:21 |
| replaceafill | you can open any of those in your browser and navigate | 20:21 |
| aelkner | sh: enscript: not found | 20:21 |
| replaceafill | make ubuntu-environment ;) | 20:21 |
| replaceafill | but let me check | 20:21 |
| aelkner | i haven't had to do that for a long time, but it does seem to be getting enscript | 20:22 |
| replaceafill | aelkner, r u using schooltool trunk? | 20:22 |
| replaceafill | ah ok | 20:22 |
| replaceafill | yes, enscript is part of the | 20:22 |
| aelkner | did you add that recently yourself? | 20:22 |
| replaceafill | 'new' ubuntu-environment rule | 20:22 |
| replaceafill | https://bugs.launchpad.net/schooltool/+bug/594422 ;) | 20:23 |
| aelkner | i see | 20:23 |
| replaceafill | aelkner, notice that 'make coverage...' will give you unit test infor | 20:24 |
| replaceafill | ...mation | 20:24 |
| replaceafill | if you want functional tests information: | 20:24 |
| replaceafill | make ftest-coverage-reports-html | 20:24 |
| replaceafill | i focus mostly in ftest reports | 20:25 |
| aelkner | i don't see a coverage directory | 20:26 |
| replaceafill | r u using schooltool trunk? | 20:26 |
| aelkner | sorry, i do | 20:28 |
| aelkner | just looked in the wronf sandbox | 20:28 |
| replaceafill | :D | 20:28 |
| aelkner | it's not schooltool trunk, it's schooltool.intervention trunk | 20:28 |
| replaceafill | ah | 20:28 |
| * replaceafill updates his intervention trunk | 20:28 | |
| replaceafill | oops, branch format conflict | 20:29 |
| * replaceafill upgrades his intervention trunk | 20:29 | |
| replaceafill | aelkner, if you dont have {buildout}/coverage, can you check {buildout}/parts/test? | 20:30 |
| aelkner | i have all the reports now | 20:31 |
| replaceafill | ah ok | 20:31 |
| aelkner | so basically, the pink is for the lines that are not tested, right? | 20:31 |
| replaceafill | correct | 20:31 |
| replaceafill | the goal is have all the code ftested ;) | 20:32 |
| aelkner | and if i run ftest-coverage-reports, it will replace the html files from the unit test version? | 20:32 |
| replaceafill | no | 20:32 |
| replaceafill | it will create a new directory: ftest-coverage | 20:33 |
| aelkner | ah, cool, so i can have both | 20:33 |
| replaceafill | yes | 20:33 |
| aelkner | you were right about it taking forever... | 20:35 |
| replaceafill | :D | 20:35 |
| replaceafill | the gradebook takes around 30 mins | 20:35 |
| replaceafill | using fast hardware | 20:35 |
| aelkner | i'm sure the intervention will go faster as it is not as complex | 20:35 |
| replaceafill | and it doesnt have many tests ;) | 20:36 |
| replaceafill | once you're done it should take like 3 hours :P | 20:36 |
| aelkner | not really, it's not as complex a set of use cases | 20:36 |
| aelkner | you add intervention objects, and they show up later somewhere else | 20:37 |
| replaceafill | right | 20:37 |
| aelkner | not like all the edge cases in the gradebook | 20:37 |
| aelkner | btw, i replaced 'in manger.contents' with xpath in my reports tests | 20:38 |
| replaceafill | thanks! ;) | 20:38 |
| aelkner | i create a query that gives me all the report names, then i say 'in report_names' | 20:39 |
| aelkner | i still need the non-specific 'in' logic because my tests can't anticipate future reports | 20:39 |
| aelkner | but at least it goes through xpath first | 20:39 |
| replaceafill | uh? | 20:39 |
| aelkner | i create an xpath query that gets all the text() of the report links | 20:40 |
| aelkner | then i say 'Absenses by Day' in report_names | 20:40 |
| replaceafill | that's not necessary | 20:40 |
| replaceafill | manage.printQuery('//table//tr/td[2]/a/text()') | 20:40 |
| replaceafill | and then expect all the links | 20:41 |
| replaceafill | the way you're doing right now it's still weak | 20:41 |
| aelkner | and what if schooltool core adds a report in the future | 20:41 |
| replaceafill | if i *add* one, it wont detect it | 20:41 |
| replaceafill | if *i* (douglas) add one, i should run the tests right ;) | 20:41 |
| aelkner | not true | 20:42 |
| replaceafill | and *i* should updte them | 20:42 |
| aelkner | if you add a report to schooltool core in the future, you should not have to fix gradebook tests! | 20:42 |
| aelkner | that would be extremenly bad test design | 20:42 |
| replaceafill | uh? | 20:42 |
| aelkner | and frankly, annoying to the merge folks | 20:43 |
| replaceafill | if i add a report to the gradebook i should run the tests | 20:43 |
| aelkner | if you add a report to schooltool core? | 20:43 |
| aelkner | dn't forget that case | 20:43 |
| replaceafill | http://bazaar.launchpad.net/~aelkner/schooltool.gradebook/new_report_package/revision/220 is testing the gradebook, right? | 20:43 |
| aelkner | yeah, so? | 20:43 |
| aelkner | the gradebook depends on core | 20:43 |
| aelkner | so any report added in core would show up in the quryHTML | 20:44 |
| replaceafill | correct | 20:44 |
| aelkner | even if the gradebook coce doesn't know about it | 20:44 |
| replaceafill | in that point in time | 20:44 |
| replaceafill | the gradebook could be using core v 1.5, or v 1.6 | 20:44 |
| replaceafill | etc | 20:44 |
| replaceafill | it's the same when you have to update a plugin because a change in core | 20:44 |
| aelkner | anyway, you shouldn't have to update the plugin as a result of a spurious change in core | 20:45 |
| aelkner | that's just wrong | 20:45 |
| replaceafill | :D | 20:45 |
| aelkner | so my test avoids that | 20:45 |
| aelkner | and it's not so weak as you suggest | 20:46 |
| replaceafill | the word is not weak | 20:46 |
| aelkner | since the xpath query is much more specific | 20:46 |
| aelkner | than just 'in manager.contexts' | 20:46 |
| aelkner | contents | 20:46 |
| replaceafill | it's definitely better than the old way ;) | 20:47 |
| aelkner | 'the way you're doing right now it's still weak' | 20:47 |
| aelkner | i'm just quoting you | 20:47 |
| aelkner | and i want you to take it back :) | 20:47 |
| replaceafill | yep | 20:47 |
| replaceafill | nope | 20:47 |
| replaceafill | it's "KIND OF" weak | 20:48 |
| replaceafill | :d | 20:48 |
| aelkner | as you always say, 'ah come on' | 20:48 |
| replaceafill | if i work in the gradebook, and i add a test, your test will still pass | 20:48 |
| replaceafill | right? | 20:48 |
| replaceafill | sorry, if i add a report | 20:48 |
| aelkner | yes | 20:48 |
| replaceafill | see? | 20:49 |
| replaceafill | wrong :P | 20:49 |
| replaceafill | it wont force me to update the GRADEBOOK tests | 20:49 |
| aelkner | well, that's better than having to change the test when someone adds a report to core | 20:49 |
| aelkner | or lyceum journal | 20:49 |
| aelkner | or intervention | 20:49 |
| replaceafill | let's leave it for the monday meeting ;) | 20:50 |
| aelkner | i've work you out, eh? | 20:50 |
| replaceafill | i'll make sure i write it down :D | 20:50 |
| aelkner | worn | 20:50 |
| replaceafill | nah, we're just talking 'air' | 20:50 |
| aelkner | talking air? | 20:50 |
| replaceafill | ur point of view and my point of view | 20:50 |
| replaceafill | we need 'schooltool's point of view ;) | 20:50 |
| aelkner | yeah, let the mergers decide | 20:51 |
| replaceafill | i'm so glad you care about the mergers :D | 20:51 |
| aelkner | they are the ones who will have the gotcha when we are not reachable and tests are failing | 20:51 |
| aelkner | and yes, i do | 20:51 |
| replaceafill | and i'm sure they wont be able to detect what went wrong.... | 20:52 |
| aelkner | well, they probably could figure it out, but it may annoy them | 20:52 |
| aelkner | but we'll let them decide | 20:52 |
| replaceafill | i worn you out, uh? | 20:52 |
| replaceafill | :d | 20:52 |
| aelkner | no, it's just not for us to decide i guess | 20:53 |
| replaceafill | ;) | 20:53 |
| replaceafill | yvl, can you please comment on this ^ | 20:53 |
| aelkner | anyway, thanks for your help with the ftest-coverage | 20:54 |
| aelkner | i finished running | 20:55 |
| aelkner | it | 20:55 |
| replaceafill | ah cool | 20:56 |
| aelkner | the reports are nice | 20:57 |
| replaceafill | and useful ;) | 20:57 |
| replaceafill | aelkner, have you consider separating the report links? | 20:59 |
| replaceafill | core, pluginA, pluginB, etc? | 21:00 |
| aelkner | how do you suggest separating them? | 21:00 |
| aelkner | you mean in the view? | 21:00 |
| aelkner | reportLink directive does not specify the plugin, nor should it, ight? | 21:01 |
| replaceafill | if i remember your view correctly, it's a title + a table with all the links right? | 21:01 |
| replaceafill | i havent checked your latest implementation, sorry | 21:01 |
| replaceafill | i just remember what you showed in the sprint | 21:02 |
| aelkner | you are probably remembering seeing 'Category' | 21:02 |
| aelkner | Student, Group, Term, etc. | 21:02 |
| aelkner | that has nothing to do with the plugin | 21:02 |
| aelkner | any plugin or core for that matter can create register a report for an cateogryy | 21:03 |
| replaceafill | i just think about some visual difference if a plugin is enabled/disabled | 21:03 |
| aelkner | there isn't any | 21:03 |
| aelkner | the /reports view is in core | 21:03 |
| aelkner | it looks for reports that are registered via reportLink directive | 21:03 |
| aelkner | it doesn't know who registered them | 21:04 |
| replaceafill | gradebook external activities have a title for the source | 21:04 |
| aelkner | a cando source is a skilldriver | 21:05 |
| replaceafill | but whatever, i remember th1a was clear about 'we shouldnt start the report discussion from this view', so... | 21:05 |
| replaceafill | :) | 21:05 |
| aelkner | gradebook doesn't know that, right? | 21:05 |
| replaceafill | in the gradebook there are external activities + external activity | 21:05 |
| replaceafill | the first one is the source | 21:05 |
| replaceafill | for instance CanDo titles its external activities source as 'CanDo' | 21:07 |
| aelkner | but that's just a title | 21:07 |
| aelkner | not anything that can be logically tested | 21:07 |
| replaceafill | stub? :) | 21:07 |
| aelkner | yeah, and you have your mock external activities for testing | 21:07 |
| replaceafill | with a title | 21:08 |
| aelkner | and you title them stub? | 21:08 |
| aelkner | but again that's just an arbitrary title | 21:08 |
| replaceafill | title = u"Sample Source" | 21:08 |
| aelkner | not anything logical like a fixed category or something | 21:08 |
| replaceafill | but it can be used to visually separate external activity sources | 21:08 |
| replaceafill | suppose i create a 'External Activities Source' page :D | 21:09 |
| aelkner | well, good for it! | 21:09 |
| aelkner | :) | 21:09 |
| replaceafill | i can have a CanDo table | 21:09 |
| aelkner | but seriously, the reportLink directive has no such field | 21:09 |
| replaceafill | it seems like i will have a 'PyQuiz' table ;) | 21:09 |
| replaceafill | add it dude :D | 21:09 |
| replaceafill | (kidding) | 21:09 |
| aelkner | if we had another reason rather than just for testing, i could see adding a 'plugin source' attribute | 21:10 |
| aelkner | then it could be used in testing to solve the problem you are having | 21:10 |
| replaceafill | i guess the approach of having the directive is different | 21:10 |
| replaceafill | but again, "not from this view..." | 21:10 |
| aelkner | you're quoting tom referrring to the reference view | 21:11 |
| replaceafill | yep | 21:11 |
| aelkner | but the situation applies to the /reports views as well | 21:11 |
| aelkner | there i tests the report names that show up there | 21:11 |
| aelkner | and i only test for the gradebook reports, not any unforseen reports in other plugins | 21:11 |
| aelkner | keep in mind that your complaint is only a failure to test for a new gradebook report | 21:12 |
| replaceafill | you test for *7* gradebook reports ;) | 21:12 |
| aelkner | but the test there is not to catch new reports | 21:13 |
| replaceafill | again, let's take it on monday :D | 21:13 |
| aelkner | it is only to demostrate that reports show up there | 21:13 |
| replaceafill | it should! | 21:13 |
| aelkner | yeah, yeah | 21:13 |
| replaceafill | WEAK test | 21:13 |
| replaceafill | :P | 21:13 |
| replaceafill | >:D | 21:13 |
| aelkner | picky, picky | 21:13 |
| replaceafill | :D :D | 21:13 |
| replaceafill | i'd apply for the VP of functional testing!!! :D | 21:14 |
| aelkner | we'll add 'Vice president in charge of merging to your list' :) | 21:14 |
| replaceafill | fuchila! (yikes!) | 21:14 |
| replaceafill | i dont want a merging charge | 21:14 |
| aelkner | maybe we'll create a category just for testing to make you happy | 21:15 |
| aelkner | we'll see what the mergers say :) | 21:15 |
| replaceafill | let's make it interesting $$$ | 21:15 |
| replaceafill | :D | 21:15 |
| aelkner | i don't like adding complexity to the elegant reportLink directive | 21:15 |
| replaceafill | elegant? | 21:15 |
| replaceafill | :/ | 21:16 |
| aelkner | few lines, much function = elegant | 21:16 |
| replaceafill | it's the most beautiful zcml directive that i've ever seen :D | 21:16 |
| aelkner | if there were a way to automatically detect the plugin in the meta implentation | 21:17 |
| aelkner | then we wouldn't need to add it to the directive! | 21:17 |
| replaceafill | no man, too much complexity ;) | 21:17 |
| aelkner | no | 21:17 |
| aelkner | i'm talking about NOT adding the plugin to the directive | 21:18 |
| aelkner | see, that's less complex, more elegant | 21:18 |
| replaceafill | :/ | 21:18 |
| aelkner | but we could go on forever, so... | 21:18 |
| replaceafill | well, i'm happy as long as you're happy... | 21:18 |
| replaceafill | r u happy aelkner? :D | 21:18 |
| aelkner | well | 21:19 |
| aelkner | whenever you're not happy, i have this sinking feeling | 21:19 |
| replaceafill | :''''( | 21:19 |
| aelkner | i don't want to say burning, because that would be overstating it | 21:19 |
| aelkner | let's see what our mergers say at the meeting... | 21:20 |
| aelkner | i'm spent | 21:20 |
| * replaceafill thinks we should write those decisions down, seriously | 21:21 | |
| aelkner | i saw your notepad at the sprint, i have one too | 21:21 |
| replaceafill | we have lots of implicit 'dos' and 'donts' | 21:21 |
| replaceafill | and we should share those | 21:21 |
| replaceafill | and talk about them etc | 21:22 |
| aelkner | nobody wants to have a Wiki for some reason | 21:22 |
| replaceafill | i bet yvl's notepad is interesting :D | 21:22 |
| aelkner | like launchpad somehow magically replaces the need | 21:22 |
| aelkner | i don't see the magic, but that's the politically correct belief | 21:22 |
| replaceafill | i see your point | 21:23 |
| replaceafill | i just think we dont use it right | 21:23 |
| replaceafill | for instance, my notepad can be a blueprint | 21:23 |
| replaceafill | easily | 21:23 |
| replaceafill | which i edit or something everytime we decide on something | 21:23 |
| aelkner | blueprints and bugs only allow appending to the end | 21:23 |
| replaceafill | like i do in my .txt file | 21:23 |
| aelkner | wikis are much better than that! | 21:23 |
| aelkner | one doc, in-place editing, one click to view it | 21:24 |
| aelkner | blueprint, shmooprint | 21:24 |
| replaceafill | :)) | 21:24 |
| aelkner | so there, no i'm in trouble | 21:25 |
| replaceafill | hey! you can change blueprints! | 21:28 |
| replaceafill | i wonder if launchpad saves the difference in the edit, like with bugs | 21:28 |
| * replaceafill will try to put his notes in a blueprint later | 21:30 | |
| aelkner | creating one blueprint for your notes has its merits, but it doesn't compare to a multi-level html wiki | 21:35 |
| aelkner | that we can refer to with one click and edit in place | 21:36 |
| aelkner | that's all i'm saying ;) | 21:36 |
| *** replaceafill has quit IRC | 21:50 | |
| *** replaceafill has joined #schooltool | 22:55 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!