| *** replaceafill has left #schooltool | 00:50 | |
| *** replaceafill has joined #schooltool | 01:28 | |
| *** alga has quit IRC | 02:00 | |
| *** menesis has quit IRC | 02:48 | |
| *** ignas has quit IRC | 04:07 | |
| *** replaceafill has quit IRC | 04:46 | |
| *** replaceafill has joined #schooltool | 05:41 | |
| *** th1a has quit IRC | 07:35 | |
| *** replaceafill has quit IRC | 07:57 | |
| *** replaceafill has joined #schooltool | 08:11 | |
| *** replaceafill has quit IRC | 09:53 | |
| *** menesis has joined #schooltool | 10:05 | |
| *** alga has joined #schooltool | 10:11 | |
| *** ignas has joined #schooltool | 12:22 | |
| *** menesis has quit IRC | 12:39 | |
| *** menesis has joined #schooltool | 12:41 | |
| *** menesis has quit IRC | 12:41 | |
| *** menesis has joined #schooltool | 12:57 | |
| *** menesis has quit IRC | 13:02 | |
| *** menesis has joined #schooltool | 13:07 | |
| *** menesis has quit IRC | 13:09 | |
| *** menesis has joined #schooltool | 13:09 | |
| *** menesis has quit IRC | 13:33 | |
| *** menesis has joined #schooltool | 13:34 | |
| *** menesis has quit IRC | 14:44 | |
| *** ignas has quit IRC | 15:26 | |
| *** menesis has joined #schooltool | 15:36 | |
| *** ignas has joined #schooltool | 16:09 | |
| *** replaceafill has joined #schooltool | 16:19 | |
| replaceafill | yvl, i don't know if it's the appropriate way of testing it, but the importer.py is broken: https://code.launchpad.net/~replaceafill/schooltool/schooltool_dev/+merge/33492 | 16:21 |
|---|---|---|
| replaceafill | - message = translate(message, context=self.context) | 16:21 |
| replaceafill | + message = translate(message, context=self.request) | 16:21 |
| yvl | hmm, sorry about that bug | 16:22 |
| yvl | but that's not a very good way to test :| | 16:22 |
| yvl | because tests would require compiled translations | 16:22 |
| replaceafill | looking forward to see how the bug has to be shown (smile) | 16:22 |
| yvl | :D | 16:23 |
| replaceafill | compiled translations? | 16:23 |
| yvl | yes, or you will have no translations for that string | 16:25 |
| yvl | we should do something like https://bugs.edge.launchpad.net/schooltool/+bug/622615 | 16:25 |
| replaceafill | ah | 16:26 |
| yvl | and then make tests not execute registerTranslations from schooltool/common/configure.zcml and others | 16:26 |
| yvl | because currently you got two different test behaviours | 16:26 |
| yvl | one on clean checkout + make | 16:26 |
| replaceafill | oh! | 16:27 |
| yvl | another on checkout + "make compile-translations" | 16:27 |
| replaceafill | really? | 16:27 |
| replaceafill | how do you see the different behaviours? | 16:27 |
| yvl | once Zope finds at least one compiled translations file, it registers that for respective domain | 16:27 |
| yvl | get a clean chekout of trunk | 16:27 |
| yvl | run make | 16:27 |
| yvl | bin/test --at-level 2 -vs schooltool.export -t non_ascii | 16:28 |
| yvl | tests pass | 16:28 |
| yvl | make compile-translations | 16:28 |
| yvl | bin/test --at-level 2 -vs schooltool.export -t non_ascii | 16:28 |
| yvl | tests fail :) | 16:28 |
| yvl | nice? ;) | 16:28 |
| replaceafill | wow! im going to test it right now! | 16:28 |
| replaceafill | wanna see it (wink) | 16:28 |
| yvl | fixed in trunk, 2708 | 16:30 |
| replaceafill | thanks! | 16:30 |
| yvl | as for the gradebook bug, maybe patch will do for now - I guess Alan will write the fix with a test soonish | 16:32 |
| yvl | I know I'm preaching to the quire, but please be careful with updating trunks for the demo | 16:33 |
| replaceafill | i wanted to ask th1a if he considered necessary to update it, just in case | 16:36 |
| replaceafill | although on monday he said it would be good to have that fckeditor fixed | 16:36 |
| yvl | well, it's up to you (and th1a, of course :) ) | 16:38 |
| replaceafill | looking at the diff, i see it's safe | 16:38 |
| yvl | if anything bad happens for whatever reason, you can revert to an earlier revision | 16:39 |
| replaceafill | sure | 16:39 |
| yvl | though it really shouldn't :) | 16:39 |
| replaceafill | im going to update it | 16:39 |
| replaceafill | updated | 16:41 |
| replaceafill | All changes applied successfully. | 16:42 |
| replaceafill | Now on revision 2708. | 16:42 |
| yvl | tada! | 16:45 |
| replaceafill | i wish i could understand this TestMessageFallbackDomain class | 16:46 |
| replaceafill | oops, def | 16:46 |
| yvl | well, when a string needs translation, Zope searches for message domain that can translate it | 16:47 |
| yvl | for example "schooltool", "zope", "schooltool.gradebook" | 16:48 |
| * replaceafill listens... or reads... | 16:48 | |
| yvl | fallback domain is used if nothing found | 16:48 |
| replaceafill | ah | 16:48 |
| yvl | in schooltool/common/configure.zcml registerTranslations initialize "schooltool" translation domain on first encountered compiled translation | 16:49 |
| yvl | (I think) | 16:49 |
| yvl | the domain then negotiates the language to translate to | 16:50 |
| yvl | and looks at the translation catalogs it has | 16:50 |
| yvl | and then translates from those catalogs :) | 16:52 |
| yvl | one of those catalogs, to be precise. | 16:52 |
| yvl | once we move to the newer KGS, translatable messages nested via mapping will be handled correctly | 16:52 |
| replaceafill | so zope.i18n.testmessagecatalog.TestMessageFallbackDomain should be used in ALL ftests? | 16:52 |
| yvl | yes :) | 16:52 |
| replaceafill | ah! | 16:53 |
| yvl | and *no* other domains should be registered, in my opinion | 16:53 |
| replaceafill | btw | 16:54 |
| replaceafill | # XXX: Hack, zope.i18n 3.6.2 cannot translate Message's in mapping. | 16:54 |
| replaceafill | meant 3.7.2? | 16:54 |
| replaceafill | that's the egg i always get | 16:55 |
| yvl | yeah, I mixed it with zope.app.i18n | 16:55 |
| yvl | honest mistake ;) | 16:55 |
| yvl | anyway, that won't matter in two days, so... :) | 16:55 |
| replaceafill | ok, running "bin/test --at-level 2 -vs schooltool.export -t non_ascii" in fresh checkout | 16:55 |
| replaceafill | 0 errors | 16:56 |
| * yvl hopes your trunk rev is <= 2707 | 16:58 | |
| replaceafill | yes | 16:59 |
| replaceafill | i branched 2706 | 16:59 |
| replaceafill | compiling translations... | 17:00 |
| replaceafill | damn!!! | 17:01 |
| replaceafill | TypeError: ('Could not adapt', <schooltool.app.app.SchoolToolApplication object at 0x7eefa28>, <InterfaceClass zope.i18n.interfaces.IUserPreferredLanguages>) | 17:01 |
| yvl | there ya go! :) | 17:01 |
| replaceafill | running make clean | 17:02 |
| replaceafill | running the test again | 17:02 |
| replaceafill | 0 errors!!! | 17:03 |
| *** alga has quit IRC | 17:05 | |
| replaceafill | my heart is broken: Review: Disapprove | 17:06 |
| replaceafill | (kidding) | 17:06 |
| replaceafill | all the packages that include schooltool.common in their ftesting.zcml are screwed | 17:09 |
| *** th1a has joined #schooltool | 17:10 | |
| yvl | yep | 17:10 |
| yvl | they didn't include Review: Thanks option... :) | 17:11 |
| replaceafill | lol | 17:11 |
| replaceafill | Review: Thanks but no Thanks | 17:11 |
| yvl | or thanks for the tip | 17:12 |
| yvl | or something nice :) | 17:12 |
| yvl | ok... if there are no burning issues, I'll go grab a dinner | 17:13 |
| yvl | see you tomorrow - and happy coding ;) | 17:13 |
| replaceafill | thanks yvl | 17:14 |
| yvl | thank you! | 17:15 |
| yvl | people caring about i18n make me very, very happy | 17:15 |
| *** ColonelPanik has joined #schooltool | 17:30 | |
| replaceafill | wow! "Total: 1665 tests, 7 failures, 0 errors in 11 minutes 41.500 seconds." with compiled translations in trunk | 17:31 |
| *** ColonelPanik has left #schooltool | 17:32 | |
| th1a | yvl, replaceafill: fyi I sent Mark the link to the demo server last night. | 18:02 |
| replaceafill | th1a, you had set the school name as Shuttleworth hs rigth? | 18:05 |
| replaceafill | it has a new title now | 18:05 |
| th1a | I changed it. | 18:21 |
| th1a | Do you know the reference? | 18:21 |
| replaceafill | oh, isn't a real name? | 18:32 |
| replaceafill | wikipedia: "According to the myth, there were fake settlements..." | 18:33 |
| replaceafill | "According to this story, Potyomkin, who led the Crimean military campaign, had hollow facades of villages constructed along the desolate banks of the Dnieper River in order to impress the monarch and her travel party with the value of her new conquests, thus enhancing his standing in the empress' eyes."!!! | 18:34 |
| th1a | ;-) | 19:04 |
| *** menesis has quit IRC | 19:30 | |
| *** menesis has joined #schooltool | 20:30 | |
| *** replaceafill has quit IRC | 20:48 | |
| *** replaceafill has joined #schooltool | 22:09 | |
| *** replaceafill has quit IRC | 22:27 | |
| *** alga has joined #schooltool | 22:51 | |
| *** ignas has quit IRC | 23:46 | |
| *** ignas has joined #schooltool | 23:58 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!