*** ignas has joined #schooltool | 00:27 | |
*** menesis has quit IRC | 02:02 | |
*** alga_ has quit IRC | 02:31 | |
*** alga has quit IRC | 02:31 | |
*** replaceafill has joined #schooltool | 03:00 | |
*** ignas has quit IRC | 03:33 | |
*** replaceafill has quit IRC | 04:27 | |
*** replaceafill has joined #schooltool | 04:58 | |
*** ignas has joined #schooltool | 05:15 | |
*** ColonelPanik has quit IRC | 06:33 | |
replaceafill | yvl, zope.app.dependable.interfaces.IDependable is used to prevent the object from being deleted, correct? | 06:43 |
---|---|---|
*** th1a has quit IRC | 06:47 | |
replaceafill | "To prevent this user from being deleted we add a dependency" :D | 07:01 |
*** dogi_ has quit IRC | 07:11 | |
yvl | replaceafill, yes | 08:19 |
replaceafill | yvl, thanks :) | 08:20 |
replaceafill | yvl, ping | 08:40 |
yvl | png | 08:40 |
replaceafill | yvl, do you see "issues" if a new school year doesn't have the five default groups? | 08:40 |
replaceafill | i mean, if we make them optional | 08:40 |
replaceafill | maybe crowds or something breaking... | 08:41 |
yvl | the code makes assumption that they always exist | 08:41 |
replaceafill | :( | 08:41 |
yvl | I never checked how much of it | 08:42 |
replaceafill | they can't be optional then | 08:42 |
yvl | that would not be safe | 08:42 |
yvl | maybe | 08:42 |
replaceafill | got it, thanks yvl | 08:43 |
yvl | you can leave the automatic creation of the default crowds in a schoolyear | 08:43 |
yvl | and handle copying of members in a different "manual" step | 08:44 |
yvl | or something like that | 08:44 |
replaceafill | you mean, default groups? | 08:44 |
yvl | yes :) | 08:48 |
*** alga has joined #schooltool | 09:16 | |
*** alga_ has joined #schooltool | 09:16 | |
replaceafill | yvl, could you please confirm that bool(some_active_schoolyear) == False? | 09:49 |
yvl | :) | 09:59 |
yvl | well | 09:59 |
yvl | it's a container | 09:59 |
yvl | so if it's empty... | 09:59 |
yvl | (i.e. no terms) | 09:59 |
replaceafill | damn!!! terms!! | 09:59 |
replaceafill | :D | 09:59 |
yvl | ;) | 10:00 |
replaceafill | completely forgot to put terms in it! thanks yvl | 10:00 |
replaceafill | duh! | 10:00 |
replaceafill | :P | 10:00 |
replaceafill | yvl, however: | 10:01 |
replaceafill | active_schoolyear = syc.getActiveSchoolYear() | 10:01 |
replaceafill | if active_schoolyear: | 10:01 |
yvl | where did you find it? | 10:01 |
yvl | it's a bug | 10:01 |
replaceafill | should be better as "if active_schoolyear is not None" right? | 10:02 |
yvl | yes | 10:02 |
yvl | in python one should always, always compare against None | 10:02 |
yvl | when one wants to compare against None | 10:02 |
replaceafill | schooltool.group.group.InitGroupsForNewSchoolYear | 10:02 |
yvl | because great many things can be false | 10:02 |
replaceafill | like empty containers ;) | 10:03 |
yvl | oh, that's just sweet | 10:03 |
yvl | and XXX above it | 10:03 |
yvl | unit test me | 10:03 |
yvl | riiiight | 10:03 |
replaceafill | :D | 10:03 |
yvl | well, stuff happens... | 10:03 |
replaceafill | and check 'manager' vs 'managers' ;) | 10:04 |
replaceafill | for the group id | 10:04 |
yvl | yes :) | 10:04 |
yvl | on the ObjectAddedEvent sys probably are empty anyway | 10:04 |
yvl | and the code - not executed :| | 10:05 |
replaceafill | but copyAllGroups should compare against 'manager', right? | 10:05 |
replaceafill | since that's the id used aboved | 10:05 |
replaceafill | above | 10:05 |
yvl | well yes | 10:06 |
yvl | though this code could just create the groups as it does now | 10:06 |
yvl | and members could be transferred via "manage->new s.y." | 10:07 |
replaceafill | yes | 10:07 |
*** yvl has quit IRC | 10:29 | |
*** ignas has quit IRC | 10:38 | |
*** replaceafill has quit IRC | 10:52 | |
*** menesis has joined #schooltool | 11:17 | |
*** yvl has joined #schooltool | 11:30 | |
*** ignas has joined #schooltool | 11:41 | |
*** alga_ has quit IRC | 11:51 | |
*** menesis has quit IRC | 13:35 | |
*** Aiste has joined #schooltool | 14:15 | |
*** menesis has joined #schooltool | 14:24 | |
*** th1a has joined #schooltool | 16:04 | |
*** jelkner has joined #schooltool | 16:56 | |
*** alga has quit IRC | 17:05 | |
*** alga has joined #schooltool | 17:05 | |
*** Aiste has quit IRC | 17:05 | |
*** replaceafill has joined #schooltool | 17:06 | |
*** alga has quit IRC | 17:30 | |
*** ColonelPanik has joined #schooltool | 17:58 | |
*** menesis has quit IRC | 18:42 | |
*** ignas has quit IRC | 19:27 | |
*** menesis has joined #schooltool | 20:25 | |
*** ignas has joined #schooltool | 20:33 | |
*** menesis has quit IRC | 21:32 | |
*** replaceafill has quit IRC | 21:55 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!