*** alga has quit IRC | 00:42 | |
*** th1a_ has quit IRC | 01:13 | |
*** jinty has joined #schooltool | 01:29 | |
*** jinty has quit IRC | 01:30 | |
*** jinty has joined #schooltool | 01:30 | |
*** jinty_ has joined #schooltool | 01:33 | |
*** jinty has quit IRC | 01:35 | |
*** jinty_ has quit IRC | 01:50 | |
*** ignas has quit IRC | 02:08 | |
*** replaceafill has joined #schooltool | 03:16 | |
*** dlobo has joined #schooltool | 04:04 | |
*** pcardune has quit IRC | 04:50 | |
*** dlobo has quit IRC | 05:06 | |
*** replaceafill has quit IRC | 05:25 | |
*** replaceafill has joined #schooltool | 05:26 | |
*** dlobo has joined #schooltool | 05:30 | |
*** pcardune has joined #schooltool | 05:47 | |
*** dlobo has quit IRC | 06:36 | |
*** pcardune has quit IRC | 07:22 | |
*** th1a has quit IRC | 07:22 | |
*** aelkner has quit IRC | 07:33 | |
*** replaceafill has quit IRC | 07:39 | |
*** replaceafill has joined #schooltool | 07:43 | |
*** dlobo has joined #schooltool | 07:48 | |
*** pcardune has joined #schooltool | 08:01 | |
*** dlobo has quit IRC | 08:12 | |
*** aelkner has joined #schooltool | 08:46 | |
*** replaceafill has quit IRC | 08:48 | |
*** pcardune has quit IRC | 08:55 | |
*** alga has joined #schooltool | 09:13 | |
*** jinty has joined #schooltool | 09:18 | |
*** jinty has quit IRC | 09:18 | |
*** jinty has joined #schooltool | 09:18 | |
*** jinty has quit IRC | 09:23 | |
*** povbot has joined #schooltool | 10:22 | |
*** menesis has quit IRC | 10:33 | |
*** ignas has joined #schooltool | 10:52 | |
*** ignas has quit IRC | 11:23 | |
*** ignas has joined #schooltool | 11:23 | |
*** menesis has joined #schooltool | 11:51 | |
*** mgedmin has joined #schooltool | 12:39 | |
*** replaceafill has joined #schooltool | 14:18 | |
*** Aiste has joined #schooltool | 14:19 | |
*** alga has quit IRC | 15:04 | |
*** Aiste has quit IRC | 15:31 | |
*** th1a has joined #schooltool | 15:33 | |
* th1a needs to go get his coffee together. | 15:34 | |
yvl | good idea | 15:35 |
---|---|---|
th1a | I've probably confused everyone about the time anyhow. | 15:37 |
aelkner | good morning everyone | 15:44 |
yvl | morning :) | 15:44 |
aelkner | yvl: i have some comments/questions about the schoolyear add logic | 15:45 |
aelkner | two small things | 15:45 |
aelkner | 1) you don't need global DEFAULT_COURSES because you are only passing it to a method | 15:45 |
aelkner | 2) your'e course titles are not i18n ready | 15:46 |
th1a | Hi aelkner, yvl, replaceafill, Mr. Coffee. | 15:46 |
aelkner | hi th1a | 15:46 |
replaceafill | good morning | 15:47 |
yvl | well spotted, aelkner | 15:47 |
yvl | DEFAULT_COURSES was a hack to be replaced with course import as soon as feasible | 15:48 |
yvl | and as course titles are supposed to become data (instead of built-in values) | 15:48 |
aelkner | in which case either point i made is irrellavent | 15:48 |
yvl | I did not make them translatable | 15:48 |
yvl | yes, but thank you for noticing that! | 15:49 |
aelkner | another point | 15:49 |
aelkner | students are not to have usernames? | 15:49 |
yvl | yes | 15:49 |
yvl | or rather - auto-generated usernames | 15:49 |
aelkner | right now the addStudent helper uses the standard names chooser | 15:49 |
yvl | school_id-user_id | 15:50 |
aelkner | that assigns names like BasicPerson and BasicPerson-2 | 15:50 |
replaceafill | should we add a custom one? | 15:50 |
yvl | eventually, yes | 15:50 |
aelkner | ok, well for now it only makes my gradebook tests a little strange with the ids, but it's not a problem | 15:51 |
yvl | yes | 15:52 |
yvl | by the way, I merged your test fixes to my branch | 15:52 |
yvl | well, those that were in LP already | 15:52 |
yvl | thank you :) | 15:52 |
aelkner | we could use a helper to add teachers and students to sections | 15:52 |
aelkner | no prob | 15:52 |
aelkner | did you notice how i had to manually add the teacher and students? | 15:52 |
yvl | yes | 15:53 |
aelkner | i could write the helper | 15:54 |
aelkner | where should it go? | 15:54 |
yvl | well | 15:54 |
yvl | adding teachers could go anywhere | 15:54 |
yvl | we don't have that part set up yet | 15:54 |
yvl | I did auto-enrollment today | 15:54 |
yvl | if you want to add a student to a section | 15:55 |
yvl | you have to add it to a "class" | 15:55 |
yvl | for example a group named "11B" | 15:55 |
yvl | it adds him to all sections for 11B | 15:55 |
aelkner | i don't need to have any different students that are already there | 15:55 |
aelkner | if you say that you enrolled them and added instructors as well | 15:56 |
yvl | I did not add any code related to instructors | 15:56 |
yvl | but students will be assigned to sections differently | 15:56 |
yvl | you have to add them to a group | 15:57 |
yvl | like "11a" | 15:57 |
yvl | and they get into sections automatically | 15:57 |
aelkner | should we change addStudent to allow passing a group? | 15:59 |
th1a | I think yvl's solution is better. | 16:01 |
aelkner | which solution would that be | 16:01 |
yvl | I think we may want the thing that aelkner suggested | 16:01 |
yvl | when people add students, they may want to also specify the class they are assigned to | 16:02 |
yvl | also - in student edit views | 16:02 |
yvl | I'm inclined to ask replaceafill to develop that :) | 16:02 |
replaceafill | sure | 16:02 |
th1a | yvl: Right now when you add a person to a "class" they're added to the relevant sections? | 16:03 |
yvl | yes | 16:03 |
replaceafill | yvl, what if you remove it? | 16:03 |
replaceafill | him | 16:03 |
replaceafill | or change him? | 16:03 |
yvl | they get removed from sections | 16:03 |
replaceafill | ah ok | 16:04 |
th1a | Group membership in sections causes problems. | 16:04 |
th1a | Because people come and go from sections too easily. | 16:04 |
th1a | Too implicitly. | 16:04 |
yvl | yes | 16:04 |
yvl | but if we remove "edit section members".... :) | 16:05 |
aelkner | :) | 16:05 |
yvl | I did not add group membership to sections per se | 16:05 |
yvl | it's another relationship that enrolls new members of the group to certain sections | 16:05 |
th1a | Yes. | 16:05 |
th1a | That's the way to do it. | 16:06 |
th1a | So can I run all this stuff yet? | 16:06 |
yvl | hmm | 16:06 |
yvl | we are kind of in a middle of the transition at this moment | 16:07 |
yvl | (I am removing action buttons everywhere as we speak) | 16:07 |
yvl | so if you get the version with no action buttons, it will be not that easy to navigate :) | 16:07 |
yvl | but I can make navigatable version in 30-45 minutes | 16:08 |
th1a | OK. | 16:08 |
th1a | aelkner: Do you have anything to do at this point? | 16:09 |
aelkner | well | 16:09 |
aelkner | i figure i'm going to do whatever is needed | 16:09 |
aelkner | but what that is exactly at the moment... | 16:10 |
th1a | You may be done with Cambodia for a few days unless yvl has any ideas. | 16:11 |
yvl | oh, I do, I do... ;) | 16:11 |
aelkner | as soon as i am not working on cambodia, i will shift my effort to schooltool.intervention | 16:11 |
th1a | I mean, I fully expect to completely re-do the grading part once actual teachers get a look at it, so I don't want to keep twiddling it now. | 16:11 |
aelkner | getting jelkner the much needed student table | 16:11 |
aelkner | which i know lehmann wold want anyway | 16:12 |
th1a | yvl: Go ahead. | 16:12 |
*** dlobo has joined #schooltool | 16:12 | |
yvl | gimme 10 minutes to think about it | 16:12 |
yvl | I'm a bit unprepared for the meeting :| | 16:12 |
yvl | apologies again... | 16:13 |
aelkner | brb | 16:14 |
th1a | np | 16:14 |
yvl | ok... | 16:17 |
yvl | once I finish the work I'm doing now | 16:17 |
yvl | it will - of course - break the test | 16:17 |
yvl | s | 16:17 |
yvl | and make navigation difficult | 16:18 |
yvl | I took liberty of re-registering replaceafill's action / manage links | 16:18 |
yvl | so under Manage we have: | 16:18 |
yvl | School Years, Teachers, Students, Administrators, Levels | 16:18 |
yvl | Levels are more like Courses at this point | 16:18 |
yvl | there is always one term for the schoolyear | 16:19 |
yvl | but users can delete it | 16:19 |
yvl | and they should not | 16:19 |
yvl | also, the school year view (and the school year edit view) should be replaced directly with term edit | 16:20 |
yvl | and view | 16:20 |
yvl | the ones where people can set schooldays | 16:20 |
yvl | aelkner will have to check what navigation buttons are missing for getting to the gradebook and add them again | 16:21 |
yvl | important note for developers: | 16:21 |
yvl | old-style action button support is completely disabled in cambodia skin | 16:21 |
yvl | so if you need buttons that were registered like this: | 16:22 |
yvl | <page | 16:22 |
yvl | name="add.html" | 16:22 |
yvl | for="schooltool.schoolyear.interfaces.ISchoolYearContainer" | 16:22 |
yvl | class=".schoolyear.SchoolYearAddView" | 16:22 |
yvl | permission="schooltool.edit" | 16:22 |
th1a | For gradebook, you should only see the top tab for it it if you're in the teacher group, and that should be the only navigation necessary. | 16:22 |
yvl | menu="schooltool_actions" title="New School Year" /> | 16:22 |
th1a | That is, just one page. | 16:22 |
th1a | Right aelkner? | 16:22 |
yvl | you'll have to use registration like this: | 16:22 |
yvl | <navigationViewlet | 16:22 |
yvl | name="new-schoolyear" | 16:22 |
yvl | for="schooltool.schoolyear.interfaces.ISchoolYearContainer" | 16:22 |
yvl | manager="schooltool.cambodia.app.browser.interfaces.IActionMenuManager" | 16:22 |
yvl | template="templates/actionsViewlet.pt" | 16:22 |
yvl | permission="schooltool.edit" | 16:22 |
yvl | link="add.html" | 16:22 |
yvl | title="New School Year" | 16:22 |
yvl | order="10" | 16:22 |
yvl | /> | 16:22 |
yvl | th1a, that sounds right | 16:23 |
replaceafill | we don't depend on schooltool.skin anymore | 16:23 |
replaceafill | i mean in zcml | 16:23 |
yvl | yes, we should avoid using it | 16:23 |
yvl | cambodia layer | 16:24 |
yvl | the way to go | 16:24 |
yvl | and for action buttons / management links, there are *different* managers | 16:24 |
yvl | like schooltool.cambodia.app.browser.interfaces.IActionMenuManager | 16:24 |
yvl | (I didn't commit that yet by the way) | 16:24 |
yvl | overall, I'd say th1a should look at current thing when it's possible | 16:25 |
yvl | and ask Alan to add navigation, replace pages, etc. where necessary | 16:26 |
yvl | and ask Douglas to change student adding forms, and related stuff, where needed | 16:26 |
yvl | for example, to add a class dropdown | 16:26 |
yvl | maybe | 16:26 |
replaceafill | ok will do | 16:27 |
yvl | or - change the way person's homepage is displayed | 16:27 |
yvl | to include contact, if the student has any | 16:27 |
replaceafill | yes, i asked that yesterday :) | 16:27 |
yvl | umm, here homepage should be read as index.html on basic person | 16:27 |
replaceafill | yes | 16:27 |
aelkner | i'm back | 16:27 |
aelkner | i have to catch up | 16:27 |
yvl | please do | 16:27 |
yvl | replaceafill, a small comment on the data model... | 16:29 |
replaceafill | yes? | 16:29 |
aelkner | th1a: yes to your question about not needing action buttons | 16:29 |
yvl | there is a levelgroups relationship | 16:29 |
yvl | in schooltool/cambodia/grade/grade.py | 16:30 |
yvl | it relates levels (1..12 ATM) to actual groups | 16:30 |
yvl | as in - schooltool groups | 16:30 |
yvl | you may need that ;) | 16:30 |
replaceafill | ah ok | 16:31 |
yvl | and levels is simply a container in a schoolyear | 16:31 |
replaceafill | branching your latest changes... | 16:31 |
replaceafill | LevelGroups = RelationshipSchema(URILevelGroups, | 16:32 |
replaceafill | level=URILevel, | 16:32 |
replaceafill | group=URILevelGroup) | 16:32 |
yvl | that one | 16:32 |
replaceafill | level == 'classes', right? | 16:33 |
replaceafill | group == classical schooltool groups? | 16:33 |
yvl | URILevelGroup == 'classes' | 16:33 |
replaceafill | ah | 16:33 |
yvl | as in '11B', '11C', ... | 16:33 |
yvl | Level - is '11' | 16:33 |
yvl | and it has another relationship to collect courses | 16:33 |
yvl | taught at the level | 16:34 |
yvl | as in "all classes for level 11 are taught Math" | 16:34 |
yvl | see LevelCourses | 16:34 |
yvl | LevelContainerView actually uses the relationships | 16:34 |
yvl | but the code is crappy and not that easy on the eyes | 16:35 |
replaceafill | VivifyLevelContainerContainer :D | 16:35 |
* yvl sighs... | 16:35 | |
yvl | (and a bit over-designed ATM, it allows to display several groups for a section, though in reality we have 1<->1 relationship) | 16:36 |
yvl | ...when they're filtered by a course and a level | 16:36 |
yvl | anyway | 16:36 |
aelkner | let's not over-design if we can avoid it | 16:36 |
yvl | yes, aelkner | 16:37 |
yvl | it's just one method in one view that handles some weird scenario | 16:37 |
yvl | was easier to write that way | 16:37 |
yvl | that's the reason for the warning - one overdesigned method - and replaceafill should not trust it too much ;) | 16:38 |
*** alga has joined #schooltool | 16:39 | |
yvl | ok... I'm near making it work with removed action buttons now | 16:42 |
yvl | lemme finish, and I can give a link to Tom | 16:42 |
yvl | to look at it before I leave :) | 16:42 |
aelkner | is there anything i need to do before yvl goes on vacation? | 16:44 |
yvl | branch my code once I commit | 16:45 |
yvl | and try running it on clean database | 16:45 |
aelkner | can i just merge instead of rebranching? | 16:45 |
yvl | look if any buttons are missing | 16:45 |
yvl | yes, you can | 16:45 |
yvl | you will need to: | 16:45 |
yvl | bzr merge | 16:45 |
yvl | bzr ci | 16:45 |
aelkner | yeah, that's easier than rebranching | 16:47 |
yvl | well it is :) | 16:48 |
yvl | wow, it works :) | 16:52 |
yvl | ok | 16:52 |
yvl | 5 min break | 16:52 |
yvl | review and commit | 16:52 |
th1a | kk | 16:52 |
yvl | then th1a can check out and look at it | 16:52 |
replaceafill | :) | 16:53 |
replaceafill | th1a, i'm making the student form to look more like paper | 16:53 |
replaceafill | and now i'm going to include the levels dropdown | 16:53 |
th1a | kk | 16:54 |
yvl | th1a: bzr co lp:~justas-pov/schooltool/schooltool.cambodia/ | 17:02 |
yvl | and: make | 17:02 |
th1a | ok... | 17:03 |
yvl | then... make run | 17:04 |
yvl | you will notice that section names are crappy | 17:04 |
yvl | but those can (and will) be replaced were needed later on | 17:04 |
yvl | I also did not test if security is right | 17:05 |
yvl | most probably, administration will work ok, but teachers will have some glitches | 17:05 |
th1a | Oh, I forgot to mention, this has to be ready for deployment Monday morning. | 17:07 |
th1a | Nationwide. | 17:07 |
th1a | So it had better work right NOW. | 17:07 |
yvl | easy to do | 17:07 |
yvl | I'll just need additional supply of time-travelling phone booths | 17:08 |
yvl | I ran out... | 17:08 |
th1a | Mark has a warehouse full of those. | 17:08 |
th1a | Also, black obelisks. | 17:08 |
yvl | sometimes it seems true... ;) | 17:08 |
th1a | You don't think he went into space for fun do you? | 17:08 |
replaceafill | :D | 17:09 |
th1a | If I install lucid today, will I see the new theme? | 17:09 |
yvl | who would ever want to do something like that for fun??? | 17:09 |
*** ignas has quit IRC | 17:09 | |
th1a | I think a Tardis and 2001 obelisk would be more fun. | 17:10 |
yvl | :))) | 17:10 |
th1a | Than a Russian rocket. | 17:10 |
th1a | I apparently don't have shared eggs set up on my computer now. | 17:10 |
th1a | Or something. | 17:10 |
th1a | Maybe I do... | 17:11 |
th1a | This is taking a while. Whose idea were all these separate packages? | 17:11 |
yvl | well, menesis updated versions.cfg on schooltool.org I guess | 17:11 |
th1a | zope.app... | 17:12 |
yvl | if you open another terminal or something | 17:13 |
yvl | and check if it created "eggs" directory inside the branch you just checked out | 17:13 |
yvl | it would mean you have no shared eggs, definitely :) | 17:13 |
th1a | The network wasn't doing anything most of the time, so that should be a good indication too. | 17:16 |
yvl | if the last thing is something about lxml... | 17:17 |
yvl | it's gonna take a little while | 17:17 |
yvl | it is building that library probably | 17:17 |
yvl | as in - compiling C code | 17:17 |
replaceafill | yvl, when you leave today, are going to see you until monday? | 17:18 |
yvl | probably yes | 17:18 |
yvl | I'll check mail at least once a day | 17:18 |
replaceafill | i'm thinking about the changes i'm making today | 17:18 |
replaceafill | can i send you an email when it's ready | 17:19 |
replaceafill | so u can merge? | 17:19 |
yvl | and maybe appear on IRC for a short period of time | 17:19 |
yvl | yes, replaceafill | 17:19 |
replaceafill | ah ok, thanks | 17:19 |
yvl | by the way, if I don't leave work in ~20 minutes, I will be left without supper... so please kindly ask your PCs to build faster ;)) | 17:21 |
th1a | ok, I should make run now? | 17:21 |
yvl | it's done building already? | 17:21 |
th1a | Yeah. | 17:22 |
yvl | then yes, please | 17:22 |
th1a | I started turning the crank on the back of my computer faster. | 17:22 |
replaceafill | :D | 17:22 |
th1a | And pumping the bellows faster with my foot. | 17:22 |
yvl | I'm sure as a former cyclist you modded the crank into a more convenient form ;) | 17:23 |
yvl | well, when it starts | 17:23 |
yvl | you should add a schoolyear | 17:23 |
yvl | wait a while | 17:23 |
yvl | (it creates ~300 classes or so) | 17:24 |
yvl | and then go to Manage->Levels to see that they're there | 17:24 |
yvl | or add a student | 17:24 |
yvl | and go to schoolyears->2009-2010->groups | 17:24 |
yvl | select group 11A for example | 17:24 |
yvl | and add the student | 17:24 |
th1a | Ah... | 17:24 |
yvl | then go to manage->levels | 17:25 |
yvl | click on any 11A links | 17:25 |
th1a | Can you hide the calendar tab? | 17:25 |
yvl | and then click gradebook | 17:25 |
yvl | yes, th1a | 17:25 |
yvl | can we do that on Mon? | 17:25 |
th1a | Sure. | 17:25 |
replaceafill | yvl, it's just a matter of unregister the zcml to hide it? | 17:26 |
replaceafill | i could do it | 17:27 |
th1a | And the year tab? | 17:27 |
th1a | So my main route to a section is Manage > Levels? | 17:28 |
yvl | ok, yes I can | 17:28 |
th1a | I need to be able to schedule a section, right? | 17:29 |
th1a | Well... | 17:29 |
yvl | schedule a section? | 17:29 |
th1a | not really I guess. | 17:29 |
yvl | no | 17:29 |
th1a | That's not their requirement. | 17:29 |
yvl | they are added when the courses are assigned to the level | 17:29 |
th1a | We're not doing timetables at this point. | 17:30 |
th1a | replaceafill, Make sure the student form differentiates between student name, etc and contact name, etc. | 17:31 |
yvl | th1a: done | 17:31 |
replaceafill | th1a, yes, i added fieldsets | 17:31 |
yvl | CTRL+C on the server | 17:31 |
yvl | bzr up | 17:31 |
yvl | make run | 17:31 |
yvl | umm... can I silently run away now? :) | 17:31 |
th1a | yvl: Yes. | 17:32 |
th1a | Enjoy whatever crazy Lithuanian holiday you're celebrating! | 17:32 |
replaceafill | happy holiday yvl | 17:32 |
th1a | Or reflecting somberly upon. | 17:32 |
yvl | thanks th1a :) | 17:32 |
yvl | goodbye guys! | 17:32 |
th1a | replaceafill, You'll need to add the contact to the student view, right? | 17:33 |
replaceafill | yes | 17:33 |
replaceafill | and the level too | 17:33 |
replaceafill | or class | 17:33 |
replaceafill | or whatever is called! | 17:33 |
* replaceafill still confused with the terms... | 17:34 | |
th1a | Can we take "Home" out of the tabs too. | 17:34 |
th1a | ? | 17:34 |
th1a | replaceafill? | 17:40 |
replaceafill | yes | 17:40 |
th1a | aelkner: We need a link to the report card. | 17:41 |
th1a | Under "Manage." | 17:41 |
aelkner | so i need to add it to my config as yvl suggested | 17:41 |
aelkner | i can do that | 17:41 |
aelkner | where do you want it exactly | 17:41 |
aelkner | Manage->Persons>select person | 17:42 |
aelkner | then see the link? | 17:42 |
replaceafill | Persons doens't exist anymore i think | 17:42 |
replaceafill | right th1a? | 17:42 |
aelkner | i still see persons | 17:43 |
th1a | I see dead persons. | 17:44 |
aelkner | hehe | 17:44 |
aelkner | i still see lots of buttons | 17:44 |
aelkner | yvl: do i need to merge again? | 17:44 |
aelkner | i just did so half an hour ago | 17:44 |
th1a | Hm... | 17:44 |
replaceafill | maybe i'm wrong | 17:44 |
th1a | Let's just do everyone's report card as a big pdf. | 17:44 |
th1a | Just for starters. | 17:45 |
th1a | Report Cards link in Manage. | 17:45 |
th1a | Download Report Cards | 17:46 |
aelkner | so clicking Manage->Download Report Cards delivers the pdf? | 17:46 |
th1a | For all students in the current term. | 17:46 |
th1a | Yes -- and make sure it doesn't throw an exception if there are no students, terms, etc. | 17:46 |
aelkner | ok | 17:46 |
th1a | And gives a useful error message. | 17:46 |
th1a | Uh... with yvl gone you guys might have to make a branch for these changes I want for my screencast. | 17:49 |
replaceafill | yvl said he could merge | 17:49 |
replaceafill | if we send him emails | 17:50 |
aelkner | ah, that's handy | 17:50 |
th1a | OK. | 17:50 |
th1a | Are you guys working on those things I just asked you to do? | 17:57 |
replaceafill | th1a, i am formatting the student form, then will handle the level, then change the index.html view | 17:58 |
th1a | kk | 17:58 |
replaceafill | and maybe remove the tabs you just asked | 17:59 |
th1a | I'm going to go get a haircut. | 18:07 |
aelkner | i'm working on the manage tab and report card change that you just suggested | 18:09 |
th1a | kk | 18:13 |
th1a | Another small project: an unauthenticated user shouldn't see the calendar. | 18:13 |
th1a | We let you turn that off in settings, so can we have that off by default? | 18:14 |
th1a | I don't remember what it shows you... a login? | 18:14 |
*** dlobo has quit IRC | 18:22 | |
* th1a goes to get a haircut. | 18:24 | |
*** dlobo has joined #schooltool | 18:42 | |
*** alga has quit IRC | 19:14 | |
*** mgedmin has quit IRC | 19:28 | |
*** menesis has quit IRC | 19:32 | |
*** menesis has joined #schooltool | 20:30 | |
th1a | replaceafill, aelkner: OK, where are we? | 20:36 |
replaceafill | handling levels | 20:39 |
replaceafill | i mean putting them in the add/edit form of students | 20:39 |
aelkner | i made the changes you requested and pushed them to my branch | 20:44 |
aelkner | if there is no current term or no students have grades, it gives a message to that effect | 20:45 |
aelkner | otherwise, it yields a pdf with all students' report cards | 20:45 |
th1a | Cool. | 20:46 |
th1a | aelkner: So are we going to request that yvl merge these changes? | 20:47 |
aelkner | of course | 20:47 |
aelkner | but we have the rest of the day to make more | 20:47 |
aelkner | if any come to mind | 20:48 |
aelkner | but yes, i'll send him an email requested that he merge my branch | 20:48 |
aelkner | replaceafill: btw, you don't need to rebranch | 20:48 |
replaceafill | i already did :P | 20:49 |
aelkner | you can always merge with yvl's branch any time you want the latest | 20:49 |
replaceafill | yes | 20:49 |
aelkner | i'm just saying, it's easier to do it that way | 20:49 |
replaceafill | yes | 20:49 |
aelkner | yes, i rebranched once already, too | 20:49 |
aelkner | but no more, unless completely necessary :) | 20:49 |
aelkner | oh, and also, you can continue to push to your same branch | 20:50 |
th1a | One of you could just stick your branch in your personal LP space and the other could push to it, right? | 20:51 |
th1a | And I could keep looking at the new code... | 20:51 |
replaceafill | i dont think i can push to aelkner's branches | 20:52 |
replaceafill | and viceversa | 20:52 |
replaceafill | i have never tried though :) | 20:52 |
aelkner | no, we each push to our own personal branches | 20:52 |
aelkner | yvl merges from both of our personal branches | 20:53 |
th1a | Or, you can both publish your changes and replaceafill could merge aelkner's changes into his branch. | 20:53 |
replaceafill | yes | 20:53 |
th1a | This really shouldn't be difficult... | 20:53 |
aelkner | who says it is | 20:53 |
replaceafill | or we can create 7 branches and then... | 20:54 |
replaceafill | :D | 20:54 |
aelkner | to keep it simple, we should have three branches | 20:54 |
aelkner | each of our's personal | 20:54 |
aelkner | yvl's being the authoritative | 20:54 |
aelkner | if replaceafill and i need each other's changes before yvl merges | 20:55 |
aelkner | we can merge from each other | 20:55 |
th1a | Right... which would allow me to pull your changes now. | 20:55 |
aelkner | otherwise, it's simpler just to merge from yvl's each morning | 20:55 |
th1a | That's what I'm getting at. | 20:55 |
aelkner | fine | 20:56 |
th1a | It doesn't matter when it gets into trunk -- the point is letting me make suggest changes and make a screencast tomorrow. | 20:56 |
aelkner | by trunk, you mean yvl's branch for now | 20:56 |
aelkner | there is no trunk for this | 20:57 |
aelkner | that point is just for clarity btw | 20:57 |
* th1a refrains from yelling something like "THAT'S THE POINT OF A *DISTRIBUTED* REVISION CONTROL SYSTEM!!!!!!!" | 20:57 | |
replaceafill | :D | 20:58 |
aelkner | yeah, we all have agreed bzr rules for some time now | 20:58 |
* aelkner wonders why th1a is getting so excited about what seems obvious to all | 20:59 | |
replaceafill | :D | 20:59 |
th1a | I'm not excited. | 21:00 |
th1a | I didn't say anything. | 21:00 |
th1a | My eyes are not bugging out of my head. | 21:00 |
aelkner | i see a lot of caps, that's all i'm saying | 21:00 |
th1a | I'm not pulling my hair out. | 21:00 |
aelkner | :) | 21:00 |
replaceafill | :D | 21:00 |
aelkner | what hair? :) | 21:00 |
replaceafill | :)) | 21:00 |
aelkner | didn't you just get a cut? | 21:00 |
aelkner | if th1a doesn't have anything to as me, i'd like to take an hour break | 21:01 |
aelkner | ask | 21:02 |
aelkner | if you have any ideas for changes, you could write them to the channel | 21:02 |
aelkner | i just would like to bot have to respond for the next hour | 21:02 |
aelkner | not | 21:02 |
* replaceafill likes this relationship stuff | 21:03 | |
* Lumiere gives th1a a mouse and keyboard and points at a Team Fortress 2 game to go blow something up | 21:04 | |
th1a | Sorry, I was just spinning in my chair, looking at the ceiling. | 21:06 |
th1a | So is replaceafill going to merge aelkner's changes into his branch and give me the URL? | 21:07 |
replaceafill | sure | 21:07 |
replaceafill | th1a, can i finish what i'm doing first? or you want to change NOW to see aelkner's changes? | 21:07 |
th1a | You can finish. | 21:18 |
*** dlobo has quit IRC | 21:38 | |
*** dlobo has joined #schooltool | 21:43 | |
*** ignas has joined #schooltool | 22:21 | |
*** menesis has quit IRC | 22:36 | |
replaceafill | aelkner, lp:~aelkner/schooltool/schooltool.cambodia_fixes1 right? | 22:36 |
aelkner | yep | 22:46 |
replaceafill | aelkner, question | 22:46 |
replaceafill | i'm having a conflict | 22:46 |
replaceafill | does your test have? | 22:46 |
replaceafill | <a class="navigation_header" href="http://localhost/demographics">Demographics</a> | 22:46 |
replaceafill | <a class="navigation_header" href="http://localhost/@@site-preferences.html">Change Site Preferences</a> | 22:46 |
replaceafill | <a class="navigation_header" href="http://localhost/report_card.pdf">Download Report Card</a> | 22:46 |
replaceafill | <a class="navigation_header" href="http://localhost/contacts">Contacts</a> | 22:46 |
replaceafill | <a class="navigation_header" href="http://localhost/resources">Resources</a> | 22:46 |
replaceafill | <a class="navigation_header" href="http://localhost/access_control.html">Access Control</a> | 22:46 |
replaceafill | <a class="navigation_header" href="http://localhost/control">Application Control</a> | 22:47 |
replaceafill | <a class="navigation_header" href="http://localhost/categories.html">Activity Categories</a> | 22:47 |
replaceafill | <a class="navigation_header" href="http://localhost/email">Outgoing Email</a> | 22:47 |
aelkner | stop | 22:47 |
Lumiere | whoa | 22:47 |
replaceafill | <a class="navigation_header" href="http://localhost/gradebook/templates/index.html">Report Sheet Templates</a> | 22:47 |
Lumiere | spammy | 22:47 |
replaceafill | <a class="navigation_header" href="http://localhost/++etc++site/default/RootErrorReportingUtility">Errors</a> | 22:47 |
replaceafill | <a class="navigation_header" href="http://localhost/scoresystems">Score Systems</a> | 22:47 |
aelkner | don't flood the channel like that | 22:47 |
replaceafill | sorry for the flooding | 22:47 |
*** ChanServ sets mode: +o Lumiere | 22:47 | |
replaceafill | my bad | 22:47 |
Lumiere | *boot to the head* | 22:47 |
aelkner | yes, i added a line to that | 22:47 |
replaceafill | i'm sorry Lumiere | 22:47 |
aelkner | so what's the issue? | 22:47 |
replaceafill | Lumiere, last time | 22:47 |
replaceafill | just one line? | 22:47 |
aelkner | yep | 22:48 |
replaceafill | aelkner, weird, yvl's test has only four lines there | 22:49 |
replaceafill | th1a, are you there? | 22:49 |
th1a | yes. | 22:50 |
replaceafill | are we going to include everything in the Manage page? | 22:50 |
replaceafill | i mean Outgoing mail | 22:50 |
replaceafill | etc | 22:50 |
th1a | No. | 22:50 |
th1a | That's already done. | 22:50 |
replaceafill | ok, i just have adjust aelkner's old test then | 22:50 |
aelkner | replaceafill: did you merge with yvl's branch as well as mine? | 22:50 |
aelkner | what? | 22:51 |
replaceafill | aelkner, i branched yvl's first | 22:51 |
replaceafill | and then merged yours | 22:51 |
replaceafill | and got the conflict | 22:51 |
aelkner | i merged yvl's branch, and there were 16 lines in that tests before i added the one | 22:51 |
aelkner | so i don't know what you mean that there were only four tests | 22:51 |
aelkner | when did you branch yvl's branch? | 22:52 |
replaceafill | right now | 22:52 |
replaceafill | about 5:43 minutes ago | 22:52 |
replaceafill | :) | 22:52 |
replaceafill | check it out: http://bazaar.launchpad.net/~justas-pov/schooltool/schooltool.cambodia/annotate/head%3A/src/schooltool/cambodia/grade/browser/README.txt | 22:52 |
replaceafill | yvl's | 22:52 |
replaceafill | yours: http://bazaar.launchpad.net/~aelkner/schooltool/schooltool.cambodia_fixes1/annotate/head%3A/src/schooltool/cambodia/grade/browser/README.txt | 22:52 |
replaceafill | he probably moved them after you branched his | 22:53 |
replaceafill | it's ok | 22:53 |
replaceafill | it's just the "Download Report Cards" right? | 22:53 |
aelkner | right | 22:53 |
replaceafill | ok, i'm going to handle the conflict | 22:53 |
aelkner | but when you said there were only four lines there, i don't get that | 22:54 |
replaceafill | check out yvl's latest | 22:54 |
replaceafill | you will see only four lines in Manage | 22:54 |
replaceafill | aelkner, your test is creating schoolyears! | 22:57 |
aelkner | no, no | 22:58 |
aelkner | oh, yes | 22:58 |
aelkner | :) | 22:58 |
aelkner | sorry, i create the one schoolyear | 22:58 |
replaceafill | ¬¬ | 22:58 |
aelkner | why do you ask? | 22:58 |
replaceafill | because the test is getting errors there | 22:58 |
replaceafill | you should sync yvl's latest if you're going to keep working on it | 22:59 |
aelkner | i'm going to try merging with your branch to see what the problems is... | 22:59 |
replaceafill | just use yvl's | 22:59 |
aelkner | ok, i'll merge with yvl's first | 22:59 |
replaceafill | i'm doing that :( | 22:59 |
replaceafill | the tab! | 23:00 |
replaceafill | that's the error! | 23:00 |
replaceafill | the school tab is gone too | 23:00 |
th1a | The home tab? | 23:01 |
aelkner | i'll fix the problems in my branch | 23:01 |
replaceafill | no the schoolyear | 23:02 |
aelkner | so, how am i supposed to enroll teachers and students in sections now? | 23:03 |
replaceafill | same old | 23:05 |
replaceafill | the helper is not ready yet | 23:05 |
aelkner | ok, so that explains why my tests fail | 23:06 |
aelkner | he got rid of the buttons, but he didn't make sure the tests passed ?! | 23:06 |
aelkner | we need more branch discipline | 23:07 |
replaceafill | nah, yvl warned us about it | 23:07 |
aelkner | ignas always had it right | 23:07 |
replaceafill | "once I finish the work I'm doing now" | 23:07 |
replaceafill | it will - of course - break the test | 23:07 |
aelkner | oh | 23:07 |
replaceafill | ;) | 23:07 |
aelkner | he should fix tests instead of just telling us that he broke them | 23:07 |
replaceafill | ¬¬ | 23:08 |
replaceafill | or we could help fixing them ;) | 23:08 |
aelkner | anyway, what helpers did you have in mind? | 23:08 |
replaceafill | passing group to addStudent as you suggested | 23:08 |
aelkner | i didn't suggest that | 23:08 |
aelkner | you must be thinking f someone else | 23:09 |
* replaceafill sighs... | 23:09 | |
aelkner | i need to be able to enroll teachers and students in sections | 23:09 |
replaceafill | teachers too? | 23:09 |
aelkner | i.e., navigate to the section and use the 'edt instructors' and 'edit individuals' links | 23:09 |
aelkner | someone has to teach a class! | 23:10 |
aelkner | i can't test the gradebook without enrollment | 23:10 |
aelkner | so i think it was a bad idea on yvl's part to remove the action links | 23:11 |
aelkner | without anything to replace the functionality | 23:11 |
replaceafill | oh come on aelkner, we can help! | 23:11 |
replaceafill | i fixed the persons tests | 23:11 |
aelkner | i'm just saying, it's hostile to break someone else's code and then say, 'go fix it' | 23:12 |
replaceafill | i understand | 23:12 |
aelkner | anyway, i'm fixing it... | 23:13 |
replaceafill | ok, i'll stop fixing then | 23:13 |
replaceafill | wait for you to sync | 23:13 |
replaceafill | and make your tests pass | 23:13 |
replaceafill | then i'm going to sync with yours | 23:13 |
replaceafill | and make my tests pass | 23:13 |
aelkner | i can't fix my tests without removing them! | 23:13 |
aelkner | there is no way to enroll students and teachers anymore | 23:13 |
aelkner | bad, bad, bad | 23:14 |
aelkner | wait | 23:14 |
aelkner | i think i fond something | 23:14 |
aelkner | levels | 23:14 |
aelkner | they seem to have links to sections | 23:14 |
replaceafill | ¬¬ | 23:15 |
replaceafill | th1a, i'm going to run some errands, will be back in an hour | 23:19 |
replaceafill | th1a, will merge aelkner's changes to mine | 23:20 |
replaceafill | and send you the link, ok? | 23:20 |
aelkner | i'll let you know when i've pushed my non-failing (!) branch | 23:20 |
replaceafill | eehhh! | 23:20 |
replaceafill | thanks man | 23:20 |
replaceafill | :) | 23:20 |
replaceafill | you got the errors when you synched, right? | 23:20 |
th1a | Probably we need some guide to how we expect tests to work or not work on each of these customized skins. | 23:22 |
th1a | I mean, if we remove 75% of the user interface, tests will break, right? | 23:22 |
th1a | Functional tests at least. | 23:22 |
replaceafill | yes | 23:22 |
th1a | That's not surprising. | 23:23 |
replaceafill | i guess we just have to adjust | 23:23 |
replaceafill | the tests i mean | 23:23 |
replaceafill | ok, bbiab | 23:24 |
aelkner | ok | 23:24 |
th1a | I would think we'd just need new functional tests for the new UI. | 23:24 |
replaceafill | that's what we have, right? | 23:24 |
replaceafill | new ftests | 23:24 |
*** replaceafill has quit IRC | 23:26 | |
aelkner | th1a: what was your question? | 23:37 |
aelkner | are you saying we just need a FEW functional tests? | 23:38 |
aelkner | cause we've changed much and there are many tests | 23:38 |
*** dlobo has quit IRC | 23:44 | |
aelkner | replaceafill: i resolved the conflicts | 23:51 |
aelkner | fixed the gradebook and grade package tests | 23:51 |
aelkner | and pushed to my branch | 23:52 |
aelkner | merge from my branch, and then you can fix the person tests | 23:52 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!