| *** ignas has joined #schooltool | 00:10 | |
| *** dlobo has quit IRC | 00:18 | |
| *** ignas has quit IRC | 00:30 | |
| *** ignas has joined #schooltool | 00:38 | |
| *** Lumiere has quit IRC | 00:39 | |
| *** Lumiere has joined #schooltool | 00:43 | |
| *** ignas has quit IRC | 00:56 | |
| *** dlobo has joined #schooltool | 01:12 | |
| *** dlobo has quit IRC | 01:23 | |
| *** dlobo has joined #schooltool | 01:23 | |
| *** dlobo has quit IRC | 01:32 | |
| *** jelkner has joined #schooltool | 02:00 | |
| jelkner | aelkner: r u here, brother? | 02:00 |
|---|---|---|
| *** mgedmin has joined #schooltool | 02:12 | |
| *** povbot` is now known as povbot | 02:15 | |
| *** th1a has quit IRC | 02:17 | |
| *** mgedmin has quit IRC | 02:31 | |
| *** replaceafill has joined #schooltool | 02:36 | |
| *** dlobo has joined #schooltool | 02:40 | |
| *** dlobo has quit IRC | 02:43 | |
| replaceafill | jelkner, aelkner: the cause of https://bugs.launchpad.net/schooltool/+bug/494262 is that the "action" attribute of the form is wrong | 02:59 |
| replaceafill | that view is called "manage.html" and its context is a IWorksheet | 03:00 |
| replaceafill | however the action for the form is the "index.html" view of a IWorksheet | 03:00 |
| replaceafill | but aelkner knows this code better :) | 03:01 |
| *** dlobo has joined #schooltool | 03:06 | |
| *** pcardune_ has joined #schooltool | 03:07 | |
| replaceafill | jelkner, aelkner: https://bugs.launchpad.net/schooltool.gradebook/+bug/494262/comments/1 | 03:07 |
| *** dlobo_ has joined #schooltool | 03:07 | |
| *** pcardune_ has quit IRC | 03:07 | |
| *** pcardune has quit IRC | 03:08 | |
| *** ignas has joined #schooltool | 03:31 | |
| *** jelkner has quit IRC | 03:33 | |
| *** dlobo has quit IRC | 03:34 | |
| *** dlobo_ is now known as dlobo | 03:34 | |
| aelkner | replaceafill: thanks for tracking that down, i'll take of the bug and submit the merge request | 03:56 |
| replaceafill | aelkner, :) | 03:58 |
| *** dlobo has quit IRC | 03:59 | |
| *** dlobo has joined #schooltool | 04:40 | |
| *** aelkner has quit IRC | 04:53 | |
| *** replaceafill has quit IRC | 05:03 | |
| *** aelkner has joined #schooltool | 05:11 | |
| *** krushik has quit IRC | 05:22 | |
| *** dlobo has quit IRC | 05:41 | |
| *** alga has quit IRC | 06:11 | |
| *** ignas has quit IRC | 06:33 | |
| *** pcardune has joined #schooltool | 07:23 | |
| *** dlobo has joined #schooltool | 07:36 | |
| *** dlobo has quit IRC | 07:45 | |
| *** pcardune has quit IRC | 08:13 | |
| *** replaceafill has joined #schooltool | 08:47 | |
| *** replaceafill has quit IRC | 09:32 | |
| *** yvl has joined #schooltool | 10:11 | |
| *** alga has joined #SchoolTool | 13:14 | |
| aelkner | yvl: ping | 13:18 |
| yvl | aelkner: pong in 3 mins | 13:20 |
| aelkner | hunting coffee, no doubt | 13:20 |
| yvl | yes :) | 13:25 |
| yvl | I'm back now :) | 13:25 |
| aelkner | sorry, wasn't watching | 13:29 |
| aelkner | so | 13:29 |
| aelkner | i wanted to discuss your intervention hack | 13:29 |
| aelkner | it was right to XXX it | 13:30 |
| yvl | yes, I remember, please go on | 13:30 |
| aelkner | i felt that making a class to hold the data and the validity check | 13:30 |
| aelkner | would at least make it more self-documenting | 13:30 |
| aelkner | but i agree it's a short-term solution | 13:31 |
| aelkner | ideally, schooltool.email should catch bad email | 13:31 |
| aelkner | and log it | 13:31 |
| aelkner | you understand that in the case of schooltool.interv\ention | 13:31 |
| aelkner | the email is built and sent AFTER the message or goal is added to the system | 13:32 |
| aelkner | so i would need to rearchitect the way email is built/validated | 13:32 |
| aelkner | and the view class has to be a complicated sub-class of AddView | 13:33 |
| yvl | I thing you see the problem clearly :) | 13:33 |
| yvl | the way I see it | 13:33 |
| yvl | our email client cannot evaluate the validity of email 100% | 13:33 |
| yvl | because you never know what crazy stuff happens on the server | 13:33 |
| yvl | for example, it blocks email domain, or something | 13:34 |
| yvl | so | 13:34 |
| yvl | schooltool.email should have .validate() method somewhere | 13:34 |
| yvl | it is really fresh and immature | 13:34 |
| yvl | so I'm kind of agreeing with your short-term solution | 13:35 |
| aelkner | did you have a chance to look at my branch? | 13:35 |
| yvl | yes, but not thoroughly | 13:35 |
| aelkner | the EmailMessage class | 13:35 |
| aelkner | it has the data/validity/send methods | 13:35 |
| aelkner | it could be moved to schooltool.email | 13:35 |
| *** ignas has joined #schooltool | 13:36 | |
| aelkner | hey ignas | 13:36 |
| aelkner | we were just talking schooltool.email | 13:36 |
| yvl | or rather - merged | 13:36 |
| aelkner | yeah, all i did in the one diff was | 13:36 |
| aelkner | to move your hack to a validity check in the new class | 13:36 |
| aelkner | i think your checks were right | 13:37 |
| aelkner | they just needed to live with the data | 13:37 |
| aelkner | imho, that is | 13:37 |
| aelkner | also, note how handy this line of trusting python code can be | 13:37 |
| aelkner | EMailMessage(sender, recipients, ...).send() | 13:38 |
| aelkner | with the built-in validity check in send() | 13:38 |
| aelkner | nothing can crash | 13:38 |
| yvl | but you'll never know if it did anything | 13:38 |
| aelkner | we should log when someone tries to send an invalid message | 13:38 |
| yvl | ok, anyway - I'm good with the EmailMessage class | 13:39 |
| yvl | I'm good with the check isValid | 13:39 |
| aelkner | we already have a queue | 13:39 |
| aelkner | so it can stay there with an explanation | 13:39 |
| yvl | .send() and it's usage is really a subject to change while schooltool.email matures | 13:39 |
| aelkner | well, i thought it wouldn't be a bad idea to have an EmailMessage class | 13:40 |
| aelkner | anyway | 13:40 |
| aelkner | could you do me a favor | 13:40 |
| yvl | yes? | 13:40 |
| aelkner | when you talk to Gediminas, please back me up on merging my EmailMessage class into schooltool.intervention | 13:41 |
| aelkner | we can get rid of it when schooltool.email makes it no longer necessary | 13:41 |
| yvl | will do | 13:41 |
| aelkner | thanks | 13:41 |
| yvl | by the way | 13:42 |
| yvl | I think it would be good to move the... | 13:42 |
| yvl | [looking at the code...] | 13:43 |
| yvl | yes, refactor how email is sent in interventions | 13:44 |
| yvl | as goal creation views want to control the validity of email | 13:44 |
| yvl | email sending should not be handled in a subscriber, *after* the goal is already created | 13:45 |
| yvl | but that's for the future | 13:45 |
| aelkner | right | 13:45 |
| aelkner | we can discuss that at the January sprint? | 13:45 |
| yvl | sure :) | 13:45 |
| yvl | other than that... | 13:45 |
| aelkner | we haven't discussed it yet | 13:46 |
| aelkner | but tom told me that we are to have a refactor sprint | 13:46 |
| aelkner | i'm very glad tor this | 13:46 |
| * yvl too | 13:47 | |
| yvl | we'll have a load of preparations to do before the sprint ;) | 13:47 |
| aelkner | that's why i mentioned the sprint for issues like that complicated refactor of intervention email | 13:47 |
| yvl | ah, I'd like the goal creator to be deduced from principal | 13:47 |
| yvl | I'll make a note in the branch review | 13:47 |
| aelkner | it is | 13:48 |
| aelkner | that's part os my new branch | 13:48 |
| aelkner | in the same diff with the dublincore evolve script | 13:48 |
| yvl | oh, wait | 13:48 |
| yvl | yes | 13:48 |
| aelkner | unfortunately, message already had sender as an attribute | 13:48 |
| aelkner | but such a name for goal creator i found inappropriate | 13:49 |
| aelkner | so that's a slight inconsistency | 13:49 |
| aelkner | both objects have created attribute | 13:49 |
| yvl | ah, yes | 13:49 |
| yvl | I was searching for something like: IPerson(self.request.principal, None) | 13:49 |
| yvl | instead of : self.request.principal._person.username | 13:50 |
| ignas | gmorning | 13:50 |
| aelkner | aah | 13:50 |
| aelkner | moring ignas | 13:50 |
| yvl | have some coffee ;) | 13:51 |
| ignas | you yvl yvl person! | 13:51 |
| aelkner | i'm on the opposite end of the clock, the end of my weirdly scheduled day | 13:51 |
| yvl | sorry, ignas: have a lot of coffee instead :) | 13:52 |
| yvl | ok, aelkner, I'll write several comments on the merge request | 13:52 |
| yvl | small tweaks mainly | 13:53 |
| aelkner | thanks | 13:53 |
| yvl | If you don't mind I won't check evolution thoroughly | 13:54 |
| yvl | hope you tested it well ;) | 13:54 |
| aelkner | well... :) | 13:54 |
| yvl | I take it for a yes! :) | 13:54 |
| aelkner | you'll ust have to trust me then ;) | 13:54 |
| aelkner | yvl: regarding planning for the upcoming sprint | 13:58 |
| aelkner | what do you say you an i schedule a couple of meetings a week outside of the monday meeting | 13:59 |
| aelkner | since my schedule is so erratic, finding me by chance is not as convenient | 14:00 |
| yvl | I see | 14:00 |
| yvl | I'm kind of humped for the next few weeks | 14:00 |
| yvl | on the other hand, it would be really good to talk to you | 14:00 |
| aelkner | it's just a matter of commiting to two specific hours a week | 14:01 |
| aelkner | we don't even have to fill them | 14:01 |
| yvl | true :) | 14:01 |
| yvl | any specific things you want to talk about? | 14:01 |
| aelkner | i would say we should organize out goals into categories | 14:02 |
| aelkner | just off the top of my head | 14:02 |
| aelkner | 1) | 14:02 |
| aelkner | testing consistency | 14:02 |
| aelkner | common routines for building test data | 14:02 |
| aelkner | too much redundancy in this area | 14:03 |
| yvl | good ones | 14:03 |
| aelkner | and too many different techniques | 14:03 |
| yvl | please go on! | 14:03 |
| aelkner | i'm already moving away from using ...123... | 14:03 |
| aelkner | and using anaylzeQuery instead | 14:03 |
| aelkner | but there's more to it than that | 14:04 |
| aelkner | some of it shoudl wait until we are looking at the code together | 14:04 |
| aelkner | but just thinking ahead, ther is definitely that issue of inconsistent and therefore wasteful techniques | 14:04 |
| aelkner | btw | 14:05 |
| aelkner | i would say we should have a google doc for this, wouldn't you? | 14:05 |
| aelkner | and build it together/when we are not meeting | 14:06 |
| yvl | please go ahead with that | 14:06 |
| yvl | the more of the things get written down, the better | 14:06 |
| aelkner | ggogle is giving me a server error | 14:06 |
| yvl | :)))) | 14:07 |
| aelkner | i'll set that up in the next couple of days | 14:07 |
| aelkner | and start it off with such thoughts | 14:07 |
| yvl | great! | 14:07 |
| yvl | other things... as you are more familiar with gradebook and interventions than me :) | 14:08 |
| *** alga has quit IRC | 14:08 | |
| aelkner | :) | 14:08 |
| yvl | check if you want some generic behaviour | 14:09 |
| yvl | I mean if you see that there's a lot of code duplication because of the way Zope / ST is written | 14:09 |
| yvl | or some things are inconvenient for you to do | 14:09 |
| aelkner | yes, there's testing consistency, and there's coding consistency | 14:09 |
| yvl | (e.g. require looking up a bunch of notes on how to write that thing or another) | 14:09 |
| aelkner | ah :) | 14:10 |
| yvl | I'd like to address both in the sprint | 14:10 |
| aelkner | schooltool.realationship | 14:10 |
| aelkner | : | 14:10 |
| aelkner | :) | 14:10 |
| yvl | actually: testing / code / documentation | 14:10 |
| aelkner | that one could use better interfaces for idiots | 14:10 |
| aelkner | like myself :) | 14:10 |
| yvl | I agree that common tasks should be easy to do | 14:11 |
| aelkner | it's silly to have to look at that code and follow the property logic and annotations | 14:11 |
| yvl | It's one of my long-term goals in ST | 14:11 |
| aelkner | until your head stops spinning :) | 14:11 |
| aelkner | but maybe you don't see that as an issue | 14:12 |
| yvl | I see that issue, I just don't have a quick solution for it yet ;) | 14:12 |
| aelkner | let's save that one for when we're face to face :) | 14:13 |
| yvl | ok | 14:13 |
| aelkner | but i'll mention it in the googledoc | 14:13 |
| yvl | meanwhile, try to find other places that annoy you | 14:13 |
| yvl | and things that require copy-paste-edit-edit | 14:13 |
| aelkner | btw, how long can you stand a Rhode Island sprint? :) | 14:14 |
| aelkner | i'd be psyched for a whole week | 14:14 |
| aelkner | but that's jmust me | 14:14 |
| aelkner | i don't know if tom could hold out that long, or you for that matter | 14:14 |
| aelkner | i feel that i personally would benefit from that kind of work together | 14:15 |
| aelkner | and i think the project could use all it can get | 14:15 |
| yvl | I can do two weeks for that matter | 14:16 |
| yvl | but there's a matter of budget | 14:16 |
| aelkner | true | 14:16 |
| aelkner | and i'd be down for two weeks as well | 14:16 |
| aelkner | we'll see what tom thinks | 14:16 |
| yvl | (and if it was moved to NYC, it would be twice as awesome ;))) ) | 14:16 |
| aelkner | $ | 14:17 |
| yvl | I think we'll have to come up with reasonable timespan though | 14:17 |
| aelkner | think Rhode Island, Days Inn :) | 14:17 |
| yvl | never been there... so I'm quite anxious ;) | 14:18 |
| aelkner | btw, a day trip to nyc on the weekend would certainly be reasonable | 14:18 |
| aelkner | and not hurt the budget so much | 14:18 |
| aelkner | Rhode Island to NYC is ~ 2 hrs | 14:19 |
| aelkner | anywat, we'll see what tom has to say | 14:19 |
| yvl | ok, don't get me psyched too much :)) | 14:19 |
| aelkner | :) | 14:20 |
| yvl | thanks for the chat | 14:20 |
| yvl | I'll be looking for that google doc ;) | 14:20 |
| aelkner | to you, too | 14:20 |
| *** krushik has joined #schooltool | 15:15 | |
| *** replaceafill has joined #schooltool | 15:32 | |
| *** yvl has quit IRC | 15:58 | |
| *** menesis has joined #schooltool | 16:14 | |
| *** th1a has joined #schooltool | 16:25 | |
| *** dlobo has joined #schooltool | 16:42 | |
| *** dlobo has quit IRC | 17:10 | |
| *** dlobo has joined #schooltool | 17:33 | |
| *** mgedmin has joined #schooltool | 17:47 | |
| *** replaceafill has quit IRC | 18:11 | |
| *** replaceafill has joined #schooltool | 18:14 | |
| *** alga has joined #SchoolTool | 19:48 | |
| *** pcardune has joined #schooltool | 19:49 | |
| *** replaceafill has quit IRC | 19:54 | |
| *** pcardune has quit IRC | 19:57 | |
| *** pcardune has joined #schooltool | 19:57 | |
| *** ignas has quit IRC | 20:07 | |
| *** pcardune_ has joined #schooltool | 20:10 | |
| *** pcardune has quit IRC | 20:11 | |
| *** pcardune_ is now known as pcardune | 20:11 | |
| *** menesis has quit IRC | 20:14 | |
| *** mgedmin has quit IRC | 20:31 | |
| *** menesis has joined #schooltool | 20:43 | |
| *** jelkner has joined #schooltool | 21:20 | |
| *** jelkner has quit IRC | 21:21 | |
| *** dlobo has quit IRC | 23:31 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!