| *** ignas has quit IRC | 01:39 | |
| *** replaceafill has quit IRC | 01:42 | |
| *** replaceafill has joined #schooltool | 03:31 | |
| *** th1a has quit IRC | 05:26 | |
| *** replaceafill has quit IRC | 08:34 | |
| *** mgedmin has joined #schooltool | 09:59 | |
| *** alga has joined #SchoolTool | 11:18 | |
| *** ignas has joined #schooltool | 14:26 | |
| *** Aiste has joined #schooltool | 16:09 | |
| ignas | aelkner: did you look at the weighted average bug? | 16:34 |
|---|---|---|
| ignas | aelkner: I mean - is it still a bug? | 16:34 |
| *** jelkner has joined #schooltool | 17:28 | |
| *** replaceafill has joined #schooltool | 17:36 | |
| *** mgedmin has quit IRC | 18:28 | |
| *** Aiste has quit IRC | 18:29 | |
| *** replaceafill has quit IRC | 18:43 | |
| *** replaceafill has joined #schooltool | 19:03 | |
| *** alga has quit IRC | 19:51 | |
| *** th1a has joined #schooltool | 20:23 | |
| *** jelkner has quit IRC | 20:23 | |
| *** jelkner has joined #schooltool | 20:24 | |
| *** replaceafill has quit IRC | 21:09 | |
| *** jcrowley has joined #schooltool | 21:28 | |
| *** replaceafill has joined #schooltool | 21:49 | |
| replaceafill | ignas, ping | 21:53 |
| *** jcrowley has quit IRC | 22:05 | |
| *** replaceafill has quit IRC | 22:13 | |
| *** replaceafill has joined #schooltool | 22:47 | |
| *** jelkner has quit IRC | 22:48 | |
| *** jelkner has joined #schooltool | 22:52 | |
| ignas | replaceafill: pong | 23:07 |
| replaceafill | hey ignas | 23:08 |
| ignas | hi | 23:08 |
| replaceafill | i was reviewing some bugs to help | 23:08 |
| replaceafill | and found two related to csv importing | 23:08 |
| replaceafill | that maybe i could fix | 23:08 |
| replaceafill | https://bugs.launchpad.net/schooltool/+bug/251868 | 23:08 |
| replaceafill | is sanitizing like the namechooser does enough? | 23:09 |
| ignas | not really | 23:09 |
| replaceafill | :O | 23:09 |
| ignas | you don't want to pick an invalid name if username was provided | 23:09 |
| ignas | but should rather show an error | 23:09 |
| ignas | we should be careful about the data users are providing us | 23:09 |
| ignas | like in add person form | 23:10 |
| ignas | you get an error if your provided username is invalid | 23:10 |
| th1a | Yes, better to raise an error and explain clearly what the problem is. | 23:10 |
| ignas | and you have to try until you get it right | 23:10 |
| ignas | hi Tom | 23:10 |
| ignas | th1a: can you bug aelkner when you get a chance about the weighted averages bug, I want to have as little high/critical bugs in our release as possible ;) | 23:11 |
| replaceafill | ignas, i will review the add person form then and check its validation | 23:13 |
| ignas | good | 23:14 |
| th1a | ignas: Yes. | 23:14 |
| aelkner | ignas: i'll look at it now | 23:16 |
| ignas | aelkner: thanks | 23:16 |
| Lumiere | if you can make the error say what line the errors on a csv was on... it is very useful. It is really annoying if an error says: | 23:17 |
| Lumiere | "KeyError: username invalid" | 23:17 |
| Lumiere | more useful would be "KeyError: username invalid on line 4" | 23:18 |
| ignas | username itself, why it's invalid and the line it's on | 23:18 |
| Lumiere | yea | 23:18 |
| Lumiere | well, I am not always sure showing the username is good | 23:18 |
| Lumiere | it could be a security risk | 23:18 |
| Lumiere | (if that's why it was rejected) | 23:18 |
| ignas | emm | 23:18 |
| ignas | if you can import persons | 23:18 |
| ignas | believe me you can see their list | 23:19 |
| th1a | If that's a security risk we're probably screwed. | 23:19 |
| ignas | so we should show the username they have entered | 23:19 |
| ignas | if '@@index.html' is invalid, the error message should include it | 23:19 |
| ignas | makes it a lot easier | 23:19 |
| Lumiere | yea | 23:19 |
| *** jelkner has quit IRC | 23:23 | |
| replaceafill | ignas, this is the other one i thought i could fix https://bugs.launchpad.net/schooltool/+bug/253663 | 23:24 |
| ignas | yeah, though - you should look at all the CSV import forms | 23:25 |
| ignas | it might be a common bug | 23:25 |
| replaceafill | yes | 23:25 |
| ignas | this time branch from trunk ;) | 23:26 |
| replaceafill | :) | 23:26 |
| replaceafill | suffix? | 23:26 |
| replaceafill | csvimport_fixes? | 23:26 |
| ignas | will do | 23:27 |
| aelkner | ignas: i verified that the bug was invalid and changed the status in launchpad | 23:27 |
| replaceafill | ignas, thanks man | 23:27 |
| ignas | aelkner: cool | 23:27 |
| ignas | th1a: i need your help with empty_data.xls | 23:30 |
| th1a | Yes? | 23:30 |
| ignas | th1a: i have separated sections into separate sheets by term and year | 23:30 |
| ignas | and now I am not sure how it should be documented propery | 23:30 |
| ignas | we want additional headers "school year" and "term" for section sheets | 23:30 |
| th1a | OK. | 23:30 |
| ignas | and section sheets must be named "Section...." | 23:30 |
| ignas | anything can go in the name, but the beginning must be "Section" | 23:31 |
| th1a | Does what's in the name have any effect on the resulting section? | 23:31 |
| ignas | no | 23:32 |
| ignas | in sample data i am putting year and term in there, but just so I could tell them apart | 23:32 |
| ignas | the actual term and year are in the sheet itself | 23:32 |
| ignas | (spaces and dashes are invalid as sheet names, so I can't put ids in the sheet name) | 23:33 |
| th1a | I think it is wise to keep them meaningless anyhow. | 23:33 |
| ignas | yeah, can't "search and replace" in them | 23:33 |
| ignas | which I did a lot when switching sample data to different school years | 23:34 |
| th1a | Making sure I have the latest packages running... | 23:35 |
| * th1a spent the morning in the hospital waiting room (everything is fine). | 23:35 | |
| ignas | I am making xls imports "reimportable" now, so I could test for some other bugs | 23:37 |
| ignas | I chose the "import is appending data only" at the moment | 23:37 |
| ignas | so if you have different set of members for a group - they will be "added" to the group | 23:38 |
| th1a | OK. | 23:38 |
| ignas | though missing members will not be removed | 23:38 |
| th1a | That is the correct behavior, I think. | 23:38 |
| Lumiere | for sections, people can just 'Duplicate Sheet' | 23:39 |
| Lumiere | ignas: maybe have a "remove" tag for groups | 23:40 |
| Lumiere | so |username|remove| would pull it? | 23:40 |
| Lumiere | or ensure it isn't in? | 23:40 |
| ignas | Lumiere: don't know really, i'd rather have a checkbox for a different import mode | 23:40 |
| Lumiere | ignas: I guess that means you're also looking at the integer/string/float issues? | 23:40 |
| ignas | in the future | 23:41 |
| Lumiere | ignas: that might work too | 23:41 |
| ignas | Lumiere: nothing to look at, you can mark the column as text | 23:41 |
| ignas | just have to know how ;) | 23:41 |
| ignas | apparently - our users know how to do that :D | 23:41 |
| Lumiere | ignas: can we do something for people who won't understand that | 23:41 |
| Lumiere | ignas: like ME :P | 23:41 |
| ignas | Lumiere: I can guide you click by click and you can add that to our documentation ;) | 23:42 |
| ignas | I'd make a screencast if I had the tools | 23:42 |
| ignas | and knew how to do it | 23:42 |
| Lumiere | ignas: got a windows box? | 23:42 |
| Lumiere | if so search google for jing | 23:42 |
| ignas | hmm, I hava a Gaming box, but it can run windows too ;) | 23:43 |
| Lumiere | but, really this is something we should handle... and it would be a dealbreaker if it happened to me without support | 23:43 |
| ignas | converting float to string especially when it is in an ID is dangerous | 23:44 |
| Lumiere | ignas: except converting an int to a float is even more dangerous | 23:47 |
| Lumiere | given that it *adds data* | 23:48 |
| ignas | well - that is being performed by open office | 23:48 |
| Lumiere | (I guess I am just totally bewildered that spreadsheets don't understand freaking int) | 23:48 |
| ignas | you have to force them to treat your data as strings | 23:48 |
| ignas | which as I said is "Select columns, Data -> Text to Columns, Select column, Set Column type to Text" | 23:50 |
| Lumiere | yea | 23:50 |
| ignas | was quite amazed to see that already done on an xls file that was attached to a bug report... | 23:50 |
| Lumiere | heh | 23:52 |
| * th1a has to go get dinner... I'll have a look at the spreadsheets later. | 23:54 | |
| ignas | th1a: thanks | 23:56 |
| ignas | i'll go sleep | 23:56 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!