| *** th1a has joined #schooltool | 00:01 | |
| *** jboisture has quit IRC | 00:06 | |
| *** fsufitch has quit IRC | 00:12 | |
| *** jstraw has quit IRC | 00:55 | |
| *** ignas has joined #schooltool | 02:05 | |
| *** th1a has quit IRC | 02:13 | |
| *** ccarey has joined #schooltool | 03:04 | |
| *** ignas has quit IRC | 03:17 | |
| *** ccarey has quit IRC | 03:43 | |
| *** fsufitch has joined #schooltool | 03:45 | |
| *** Aiste has joined #schooltool | 09:02 | |
| *** wbrady has joined #schooltool | 16:24 | |
| *** mattva01 has quit IRC | 16:27 | |
| *** Aiste has quit IRC | 17:30 | |
| *** Aiste has joined #schooltool | 17:31 | |
| *** wbrady has quit IRC | 17:53 | |
| *** wbrady has joined #schooltool | 18:26 | |
| *** jboisture has joined #schooltool | 19:06 | |
| *** whaddon has joined #schooltool | 19:07 | |
| *** ccarey has joined #schooltool | 19:30 | |
| *** Aiste has quit IRC | 19:44 | |
| ccarey | fsufitch: ping | 20:01 |
|---|---|---|
| fsufitch | ccarey: pong | 20:01 |
| ccarey | i think i might have to use javascript to position the description bar | 20:02 |
| ccarey | unless | 20:02 |
| ccarey | is there a way to get the length of the window in css? | 20:02 |
| ccarey | position:fixed applies both horizontally and vertically, not one or the other | 20:03 |
| *** ccarey has quit IRC | 20:39 | |
| *** ccarey has joined #schooltool | 20:46 | |
| *** th1a has joined #schooltool | 21:32 | |
| *** aelkner has joined #schooltool | 21:32 | |
| ccarey | hello aelkner | 21:33 |
| aelkner | hey ccarey | 21:33 |
| aelkner | how goies the battle? | 21:33 |
| aelkner | still fighting with the pickel error? | 21:34 |
| ccarey | nope we fixed that yesterday morning | 21:34 |
| aelkner | too cool | 21:34 |
| aelkner | i didn't see the checkin | 21:34 |
| ccarey | the evaluator had a proxy attached to it | 21:35 |
| ccarey | we didn't check it in yet | 21:35 |
| aelkner | well done | 21:35 |
| ccarey | which would probably be a good idea | 21:35 |
| aelkner | please try to check in anytime you hut a milestone | 21:35 |
| aelkner | hit | 21:35 |
| ccarey | ok | 21:35 |
| ccarey | when i upgraded to hardy, my ssh keys were changed | 21:35 |
| aelkner | bummer | 21:35 |
| ccarey | so i have to get set up with commit access again | 21:35 |
| aelkner | th1a: do you know how he shold go about that? | 21:36 |
| th1a | Send the public key to jinty, I think. | 21:37 |
| th1a | You should keep a copy of your keys! | 21:37 |
| th1a | Put them on a usb key. | 21:37 |
| ccarey | can i change my ssh keys back? | 21:37 |
| ccarey | because i should have them in a copy of the email i sent | 21:37 |
| aelkner | yeah, if you could find that in your sent folder | 21:38 |
| ccarey | ok when its time to commit i'll transfer it over | 21:39 |
| ccarey | the emails are saved on my pc | 21:39 |
| aelkner | how many files changed? | 21:40 |
| aelkner | you could emailo them to me? | 21:40 |
| ccarey | we have them open in gobby | 21:40 |
| ccarey | if that would be easier | 21:41 |
| ccarey | gradebook.py is where we fixed the proxy error | 21:41 |
| *** jboisture has quit IRC | 21:44 | |
| aelkner | ok, thanks | 21:46 |
| aelkner | ccarey: i imiagine i can get rid of the commented code right before the removeSecurityProxy bit | 21:47 |
| aelkner | that was when you were debugging, right? | 21:47 |
| ccarey | yes go ahead and uncomment it | 21:48 |
| aelkner | uh, that wouldn't work | 21:48 |
| aelkner | unless the code after it should be indented to be included in the else | 21:49 |
| ccarey | oh you mean just delete the code? | 21:49 |
| *** wbrady has quit IRC | 21:49 | |
| ccarey | cause filip and i thought it wasnt neccessary | 21:49 |
| aelkner | let's think about this | 21:50 |
| aelkner | was that code there before you were fixing the bug? | 21:50 |
| ccarey | yes | 21:50 |
| aelkner | i seems to make sense | 21:51 |
| aelkner | the logic is: | 21:51 |
| aelkner | if the student has already been evaluated for that competency | 21:51 |
| aelkner | then just update the score | 21:51 |
| ccarey | rather than making a new object? | 21:51 |
| aelkner | otherwise we need to create a new one | 21:51 |
| aelkner | right | 21:51 |
| aelkner | although | 21:52 |
| aelkner | what if a different teacher is scoring them this time around | 21:52 |
| aelkner | then we would need to update the evaluator as well | 21:52 |
| aelkner | looks like this code was never completely correct | 21:52 |
| aelkner | and not commented which is bad | 21:52 |
| aelkner | check out my change in gobby | 21:53 |
| ccarey | ok | 21:53 |
| aelkner | i think that's it | 21:54 |
| aelkner | test that out | 21:54 |
| ccarey | now it handles the case of the teacher changing | 21:54 |
| ccarey | ok | 21:54 |
| aelkner | right | 21:55 |
| aelkner | testing | 21:55 |
| aelkner | um, i assume that the tests are still failing even if you fixed the pickle problem | 21:56 |
| ccarey | it hasn't been set up everywhere to link to go.html | 21:56 |
| ccarey | right | 21:57 |
| aelkner | i'm failing at line 136, you? | 21:57 |
| ccarey | line 105 | 21:58 |
| aelkner | hmm | 21:59 |
| ccarey | its failing when trying to reach the gradebook as a manager | 21:59 |
| ccarey | because its looking for index.html | 21:59 |
| aelkner | why would i get further? | 21:59 |
| ccarey | we changed it to go.html | 21:59 |
| aelkner | could you load up your browser README.txt in gobby? | 21:59 |
| ccarey | line 34 of configure.zcml | 21:59 |
| ccarey | ok | 21:59 |
| ccarey | fsufitch: ping | 22:00 |
| aelkner | um, i saved the README.txt and i doesn | 22:01 |
| aelkner | doesn't show up as a diff | 22:01 |
| aelkner | ah, the change was in configure | 22:01 |
| aelkner | so i get it | 22:02 |
| aelkner | ccarey: why did you change index.html to go.html? | 22:02 |
| aelkner | not that it's a bad idea | 22:02 |
| aelkner | i just don't understand | 22:02 |
| ccarey | fsufitch said it needed to match with the go interface | 22:04 |
| ccarey | so i've been testing it logged in as the teacher for now | 22:04 |
| aelkner | he might be right, i don't remember | 22:05 |
| aelkner | ok, i get the same error | 22:07 |
| aelkner | the men item needs to change | 22:07 |
| aelkner | check out line 114 of the browser config | 22:09 |
| aelkner | oh, i see you're changing the page template | 22:09 |
| ccarey | changed the link to link to go.html | 22:09 |
| ccarey | its testing | 22:10 |
| ccarey | i don't suggest saving it yet | 22:10 |
| ccarey | is there a javascript event for catching the usage of the scroll bars? | 22:11 |
| aelkner | it's ok if you're not done | 22:11 |
| aelkner | i'm still at 105, probably cause it's not ready | 22:11 |
| aelkner | but it doesn't crash | 22:12 |
| aelkner | it just doesn't pass the diff | 22:12 |
| aelkner | ccarey: btw, i can work on other parts while you're bringing the page template in line | 22:14 |
| ccarey | ok | 22:14 |
| aelkner | what's your feeling about how soon you can have tests passing | 22:14 |
| aelkner | i'd like to commit something for the gradebook before you refine it | 22:15 |
| ccarey | we haven't written tests for filldown or the competency description bar yet | 22:15 |
| aelkner | that's good | 22:15 |
| ccarey | which is what filip and i are working on | 22:15 |
| aelkner | ok, but that's unfortunate | 22:15 |
| aelkner | ok for this time | 22:15 |
| aelkner | and i know you didn't have commit access | 22:15 |
| aelkner | but it's important that we commit as frequwntly as possible | 22:16 |
| aelkner | it make s it easier for us to follow the diffs | 22:16 |
| ccarey | sry i'll remember that for next time | 22:16 |
| aelkner | that's ok | 22:16 |
| aelkner | for now, let's do this | 22:16 |
| aelkner | get the filldown stuff to not fail | 22:16 |
| aelkner | i mean in the tests | 22:17 |
| aelkner | it doesn't have to work manually | 22:17 |
| aelkner | i'll just explain the incomplete filldown in the checkin comment | 22:17 |
| ccarey | ok | 22:17 |
| ccarey | fsufitch: PING | 22:17 |
| aelkner | this is why he wants to come to the career center | 22:17 |
| aelkner | he's probably getting distracted by his family | 22:18 |
| aelkner | tell you what | 22:18 |
| aelkner | feel free to disable anything that causes failures | 22:18 |
| aelkner | you don't have to remove, just comment | 22:18 |
| aelkner | ping me when the tests pass or you have a question | 22:19 |
| ccarey | alright | 22:19 |
| ccarey | aelkner, whenever the form is submitted, it links to gradeCompetencies rather than gradeCompetencies/go.htm | 22:30 |
| ccarey | l | 22:30 |
| aelkner | check out the action attribute of the form | 22:31 |
| aelkner | you could change that | 22:31 |
| ccarey | great i think that did it | 22:32 |
| aelkner | you mean, tests pass? | 22:32 |
| ccarey | running them now | 22:32 |
| ccarey | i just mean it fixed the broken link | 22:33 |
| aelkner | ccarey: where are you with the testing? | 23:03 |
| ccarey | the group and the comps are not changing | 23:03 |
| ccarey | when i change groups | 23:03 |
| ccarey | i'm not sure if its the ftest browser or not | 23:03 |
| ccarey | because it works when i manually run it in firefox | 23:03 |
| aelkner | hmm | 23:03 |
| aelkner | could it be that problem you had at the sprint, not being sure how to set the pulldown value? | 23:04 |
| ccarey | that's what i'm trying | 23:04 |
| ccarey | i've tried every way i've looked up | 23:04 |
| aelkner | did you look at schooltool.gradebook? | 23:05 |
| ccarey | i looked through some of it | 23:05 |
| ccarey | i can look through again | 23:05 |
| ccarey | is it possible that the form isn't being submitted when running ftests> | 23:06 |
| aelkner | i was considering the same thing | 23:06 |
| aelkner | that would suck | 23:06 |
| ccarey | i could manually set the form in the ftest to see if thats the case | 23:07 |
| ccarey | *submit | 23:07 |
| aelkner | i just did :) | 23:07 |
| ccarey | hey it worked | 23:08 |
| aelkner | crap, it didn't for me | 23:08 |
| ccarey | that means i can simplify choosing the group | 23:09 |
| ccarey | because was trying more complicated methods to see if it would capture it | 23:09 |
| aelkner | i don't like hitting the submit button in the test | 23:10 |
| aelkner | i just tried it to see what we cold learn | 23:11 |
| aelkner | the test should exactly reflect the user action | 23:11 |
| ccarey | right | 23:11 |
| aelkner | so why do i still fail | 23:11 |
| aelkner | wait | 23:11 |
| aelkner | i see you changed something else | 23:12 |
| aelkner | oh, there you go again :) | 23:12 |
| ccarey | when i first got it it failed, but it loaded the proper page | 23:13 |
| aelkner | so i'm at 166, you too? | 23:14 |
| aelkner | ccarey: if you are, then that means we're both passed the diff | 23:15 |
| ccarey | yup i'm there | 23:15 |
| aelkner | in that case, i'd like to remove the submit change line | 23:15 |
| aelkner | ok? | 23:15 |
| aelkner | that may have been a red herring | 23:15 |
| ccarey | alright | 23:15 |
| aelkner | that didn't go well | 23:16 |
| ccarey | the group selector gets submitted with onchange="this.form.submit()" | 23:17 |
| aelkner | right | 23:17 |
| ccarey | but the ftest browser should be able to handle events like onchange, right? | 23:17 |
| aelkner | so why not in the test? what about schooltool.gradebook? | 23:18 |
| aelkner | we should look at that test ad compare | 23:18 |
| aelkner | also the page template | 23:18 |
| aelkner | um, do you have the missing README.txt from your version of the schooltool.gradebook | 23:22 |
| aelkner | ccarey: my schooltool.gradebook egg seems to be missing a lot of things | 23:22 |
| ccarey | i can load it into gobby for you | 23:22 |
| ccarey | do you need the page template also? | 23:22 |
| aelkner | ok | 23:23 |
| ccarey | the worksheet selector also uses onchange="this.form.submit()" | 23:24 |
| ccarey | however, the option that is selected uses <option selected="selected" | 23:24 |
| ccarey | aelkner, which README.txt do we need to be looking at? | 23:25 |
| aelkner | browser | 23:25 |
| ccarey | oops | 23:26 |
| ccarey | i had that one open before | 23:26 |
| ccarey | but i loaded the wrong one | 23:26 |
| aelkner | ccarey: now that we know that you can't test javascript | 23:30 |
| aelkner | we should maybe consider making the serve handle the fill down | 23:31 |
| aelkner | all the teacher want s to be able to do is put a value there ad have it result in all rows below it changin to that value | 23:31 |
| ccarey | hmm | 23:33 |
| aelkner | i'm discussing this with th1a right now | 23:34 |
| ccarey | but that leaves the danger of the user accidentally overwriting values they didn't want to overwrite, and it has already been submitted | 23:34 |
| aelkner | i'm not clear on what you mean there | 23:35 |
| aelkner | could you break that down in to actions | 23:35 |
| aelkner | and results | 23:35 |
| ccarey | actually with the submit fill down button | 23:36 |
| ccarey | that wouldn't happen | 23:36 |
| ccarey | there was some other reason though | 23:36 |
| aelkner | th1a has convinced me that we don't need to test fil down | 23:38 |
| aelkner | it's a javascript thing, not a server-side thing | 23:38 |
| aelkner | all we need to test is that values entered into the fields end up in the database | 23:38 |
| aelkner | it's not important to the server code how the values got there | 23:39 |
| ccarey | alright | 23:39 |
| aelkner | so that was easy | 23:39 |
| aelkner | :) | 23:39 |
| ccarey | =) | 23:39 |
| aelkner | so let's get these tests passing and some code checked in | 23:40 |
| ccarey | right | 23:40 |
| ccarey | so pressing the submit changes button is how we'll submit the form in the test? | 23:40 |
| aelkner | i'd rather do it like stephan did | 23:41 |
| aelkner | we have the same hidden form_submitted text field | 23:41 |
| aelkner | so the first time you change the group, have the comment be the same as stephan said | 23:41 |
| ccarey | aelkner, instead of grabbing the browser.url, can we explicitly state it | 23:50 |
| aelkner | come again? | 23:51 |
| ccarey | because it already has ?form-submitted... etc attached to it | 23:51 |
| ccarey | when it needs to be switched again | 23:51 |
| aelkner | oh | 23:51 |
| ccarey | try running the tests | 23:51 |
| aelkner | i understand | 23:51 |
| aelkner | so i agree | 23:51 |
| aelkner | use the whole url | 23:51 |
| aelkner | or | 23:52 |
| aelkner | set up a variable for the base | 23:52 |
| aelkner | i.e. base_url = browser.url | 23:52 |
| aelkner | then use that | 23:52 |
| ccarey | ok | 23:52 |
| aelkner | ccarey: could you add some paragraphs between those test like i started to do | 23:54 |
| ccarey | sure | 23:55 |
| ccarey | aelkner: the scoresystem has to be set up in the ftest | 23:57 |
| ccarey | i can add that | 23:57 |
| th1a | aelkner is taking a shit. | 23:57 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!