| aelkner | ignas: i have a question about overrides | 00:05 |
|---|---|---|
| ignas | yes | 00:07 |
| aelkner | i thought that if you includeOverrides | 00:10 |
| aelkner | and in the file there is a registration that's the same | 00:10 |
| aelkner | as one that already exists | 00:11 |
| aelkner | it would take the override | 00:11 |
| aelkner | i'm getting conflict errors unless I make sure | 00:11 |
| aelkner | the layer is different than the one that i'm overriding | 00:11 |
| aelkner | why would i get conflicts if i specify the same everything | 00:11 |
| aelkner | except for the class which i want to be my class | 00:12 |
| aelkner | do you know? | 00:12 |
| aelkner | ignas: have you every come across this problem? | 00:14 |
| ignas | hmm | 00:16 |
| ignas | maybe the overrides are included in the wrong place | 00:16 |
| aelkner | i was wondering about whether it would matter where i pu them | 00:16 |
| ignas | could you lisppaste5 the error | 00:16 |
| lisppaste5 | aelkner pasted "overrides conflict" at http://paste.lisp.org/display/56231 | 00:18 |
| *** ccarey has joined #schooltool | 00:19 | |
| ccarey | hi ignas | 00:20 |
| ignas | ccarey: hi | 00:20 |
| ignas | ccarey: did you get your commit issues resolved? | 00:20 |
| ignas | aelkner: where is the override included? | 00:21 |
| aelkner | in the same directory | 00:21 |
| ignas | I think that's the problem | 00:21 |
| aelkner | oh? | 00:21 |
| ignas | you should include override in the same level the original was included i think | 00:22 |
| ignas | so somewhere up the stack | 00:22 |
| ccarey | ignas: i sent an email out to jinty on monday, i'm just waiting for a reply | 00:22 |
| ignas | ccarey: i see | 00:22 |
| ignas | ccarey: I think jinty is very busy this week | 00:22 |
| ignas | aelkner: anyway - just use a different layer | 00:22 |
| ignas | a lot cleaner than overrides | 00:22 |
| ignas | overrides have to be included in the sla.app.configure.zcml or somewhere around there | 00:23 |
| ignas | from what I can recall | 00:23 |
| aelkner | how would zope know the difference between schooltool.sla.app...... from anything else? | 00:24 |
| aelkner | i mean, compared to schooltool.app.browser | 00:24 |
| ignas | hmm, I can only vaguely recall the semantics of overrides | 00:25 |
| ignas | it's something about a tree being built out of includes | 00:25 |
| ignas | and the need to include overrides in the same branch that includes the zcml with the original component | 00:26 |
| ignas | or higher | 00:26 |
| ignas | so you must includeOverrides the overriden adapter | 00:26 |
| ignas | somewhere higher or is it lower in the hierarchy than the schooltool.demographics include is in | 00:27 |
| aelkner | but schooltool.sla isn't even at a higher level than schooltool.app | 00:27 |
| ignas | well - where is schooltool.sla included in? | 00:27 |
| ignas | instance/configure.zcml ? | 00:27 |
| ignas | or was it instance/site.zcml | 00:28 |
| aelkner | let me check | 00:28 |
| aelkner | <configure xmlns="http://namespaces.zope.org/zope"> | 00:28 |
| aelkner | <include package="schooltool.sla" /> | 00:28 |
| aelkner | <include files="plugins/*.zcml" /> | 00:28 |
| aelkner | </configure> | 00:28 |
| aelkner | that's my instance/schooll.zcml | 00:29 |
| ignas | and what's the content of schooltool/sla/configure.zcml | 00:29 |
| aelkner | i already have an overrides there for the dashboard | 00:30 |
| aelkner | maybe i should just put the other stuff there | 00:30 |
| ignas | you should | 00:30 |
| ignas | because it's at the same level schooltool.app include is | 00:31 |
| ignas | or higher | 00:31 |
| aelkner | i'll try that, thanks | 00:31 |
| aelkner | ignas: that did the trick! | 00:34 |
| aelkner | ignas: when you talk of using a different layer, does that involve creating a different skin? | 00:44 |
| aelkner | i ask out of curiosity because the overrides thing works | 00:45 |
| ignas | yes | 00:45 |
| ignas | it involves creating a different skin | 00:45 |
| aelkner | i would not want to do that if i didn't have to | 00:45 |
| aelkner | then you have to put ++skin++ everywhere | 00:46 |
| ignas | ??? | 00:46 |
| ignas | why? | 00:46 |
| aelkner | unless i use the defaultSkin override? | 00:46 |
| ignas | well - why override | 00:46 |
| ignas | you just do not include anything that sets the skin | 00:47 |
| ignas | just like lyceum, stapp2007 stapp2005 stap2008spring does | 00:47 |
| aelkner | schooltool.app.browser sets the skin doesn't it? | 00:47 |
| ignas | no | 00:47 |
| aelkner | oh | 00:47 |
| ignas | only the top level school configs set the skin | 00:48 |
| ignas | and functional tests | 00:48 |
| aelkner | so if i setup my own skin like lyceum does, it will be the default skin | 00:49 |
| aelkner | is that right? | 00:49 |
| ignas | if you will set defaultSkin in your configuration | 00:49 |
| ignas | then - yes | 00:50 |
| aelkner | and lyceum does that | 00:50 |
| ignas | well - look at lyceum/app/configuration.zcml ;) | 00:50 |
| ignas | yes it does that | 00:50 |
| aelkner | ok | 00:50 |
| ignas | stapp2007 does that too | 00:50 |
| *** mgedmin has quit IRC | 01:18 | |
| *** ccarey has quit IRC | 01:46 | |
| *** ignas has quit IRC | 02:40 | |
| *** th1a_ has quit IRC | 05:58 | |
| *** pcardune has quit IRC | 08:03 | |
| *** exibit has joined #schooltool | 10:29 | |
| *** exibit has left #schooltool | 10:29 | |
| *** exibit has joined #schooltool | 10:32 | |
| *** exibit has left #schooltool | 10:32 | |
| *** exibit has joined #schooltool | 10:33 | |
| *** exibit has left #schooltool | 10:34 | |
| *** didymo has quit IRC | 12:03 | |
| *** ignas has joined #schooltool | 14:01 | |
| *** wbrady has joined #schooltool | 15:12 | |
| *** ignas has quit IRC | 15:47 | |
| *** aelkner has quit IRC | 15:49 | |
| *** wjohnsto has joined #schooltool | 15:56 | |
| *** ignas has joined #schooltool | 16:08 | |
| wjohnsto | ignas: hello | 16:12 |
| ignas | hi | 16:13 |
| wjohnsto | I created a bzr so you can look at my files for the event link | 16:13 |
| wjohnsto | http://maddog.yhspatriot.net/~wjohnsto/eventLink/ | 16:14 |
| ignas | a bzr? | 16:14 |
| wjohnsto | yes | 16:14 |
| ignas | i can see the files | 16:15 |
| ignas | and have downloaded them | 16:15 |
| ignas | but what do you mean by "bzr" ? | 16:15 |
| wjohnsto | well | 16:15 |
| ignas | a bzr repository | 16:15 |
| wjohnsto | it doesn't matter about the bzr | 16:15 |
| wjohnsto | yea | 16:15 |
| ignas | it does not look like a repository though | 16:16 |
| wjohnsto | I really just created a public directory | 16:16 |
| ignas | oh | 16:16 |
| ignas | it looks like a public directory | 16:16 |
| wjohnsto | sorry, the bzr is elsewhere | 16:17 |
| wjohnsto | *bzr repository | 16:17 |
| ignas | I see | 16:17 |
| wjohnsto | those files are found in schooltool.app.browser.templates | 16:20 |
| wjohnsto | if you didn't already know :-\ | 16:20 |
| ignas | i know | 16:20 |
| ignas | i still prefer patches usually | 16:20 |
| ignas | it's easier to apply | 16:20 |
| wjohnsto | sorry | 16:21 |
| ignas | hmm | 16:27 |
| ignas | it's only showing 1 change in cal_daily | 16:27 |
| *** alga has joined #SchoolTool | 16:28 | |
| wjohnsto | ok hold on | 16:28 |
| ignas | and cal_weekly seems to be the same as original | 16:28 |
| wjohnsto | Oh yes, try it now | 16:30 |
| wjohnsto | it is the exact same change in cal_weekly as in cal_daily | 16:30 |
| wjohnsto | http://maddog.yhspatriot.net/~wjohnsto/eventLink/ | 16:30 |
| wjohnsto | There is also an edit in event_add.pt | 16:33 |
| wjohnsto | I forgot about that | 16:33 |
| ignas | :) | 16:33 |
| ignas | maybe you could just post the patch? | 16:34 |
| wjohnsto | ok | 16:34 |
| ignas | and - it seems that I can't download the event_add.pt | 16:43 |
| ignas | some problems with permissions | 16:43 |
| wjohnsto | you should be able to now | 16:44 |
| ignas | cal_weekly view is still shown as unmodified | 16:46 |
| wjohnsto | it should be changed | 16:47 |
| wjohnsto | I just updated it again | 16:47 |
| ignas | now it's good | 16:48 |
| *** wbrady has quit IRC | 16:49 | |
| ignas | why: | 16:49 |
| ignas | + <input type="hidden" tal:condition="request/next_url|nothing" | 16:49 |
| ignas | + tal:attributes="value request/next_url" | 16:49 |
| ignas | + name="next_url" /> | 16:49 |
| ignas | in calendar views? | 16:49 |
| ignas | they don't even have forms in them ... | 16:49 |
| wjohnsto | good point | 16:50 |
| wjohnsto | . | 16:50 |
| wjohnsto | it should work fine without those things | 16:51 |
| wjohnsto | that is only needed in event_add.pt | 16:51 |
| ignas | and your patch won't work with view links | 16:51 |
| ignas | it might even break them | 16:51 |
| ignas | because you are doing something like: event/index.html&foo=bar | 16:52 |
| ignas | without the "?" after html | 16:52 |
| ignas | not a good idea | 16:52 |
| ignas | and - there are no functional tests that would see whether both - eventEdit and eventView links still work | 16:52 |
| ignas | which is the reason you haven't noticed the problem | 16:52 |
| ignas | i'd suggest moving the logic behind addition of the nexturl parameter into linkAllowed or editLink | 16:53 |
| ignas | editLink is probably the place you want it in | 16:53 |
| wjohnsto | ok | 16:53 |
| wjohnsto | I will work on that | 16:54 |
| wjohnsto | but I have to run | 16:54 |
| wjohnsto | I have class and I'm late :-O | 16:54 |
| ignas | see you | 16:54 |
| wjohnsto | c ya | 16:54 |
| *** wjohnsto has quit IRC | 16:54 | |
| *** ignas has quit IRC | 17:16 | |
| *** pcardune has joined #schooltool | 17:36 | |
| *** alga has quit IRC | 18:05 | |
| *** ignas has joined #schooltool | 18:09 | |
| *** jelkner has joined #schooltool | 20:44 | |
| *** pcardune_ has joined #schooltool | 21:15 | |
| *** mgedmin has joined #schooltool | 21:16 | |
| *** pcardune has quit IRC | 21:33 | |
| *** ignas has quit IRC | 21:49 | |
| *** mgedmin has quit IRC | 23:30 | |
| *** didymo has joined #schooltool | 23:35 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!