*** ccarey has joined #schooltool | 00:15 | |
*** Aiste has quit IRC | 00:48 | |
*** Aiste has joined #schooltool | 00:49 | |
*** pcardune has quit IRC | 00:52 | |
*** jfroche has quit IRC | 00:52 | |
*** pcardune has joined #schooltool | 00:54 | |
*** jfroche has joined #schooltool | 00:54 | |
*** Aiste has quit IRC | 00:55 | |
*** Aiste has joined #schooltool | 00:56 | |
*** wbrady has joined #schooltool | 01:12 | |
*** ccarey has quit IRC | 02:24 | |
*** wbrady has quit IRC | 04:13 | |
*** didymo has joined #schooltool | 04:37 | |
*** lisppaste5 has quit IRC | 04:47 | |
*** SteveA has quit IRC | 04:47 | |
*** lisppaste5 has joined #schooltool | 04:49 | |
*** SteveA has joined #schooltool | 04:49 | |
*** lisppaste5 has quit IRC | 06:51 | |
*** subir has joined #schooltool | 08:29 | |
*** didymo has quit IRC | 10:44 | |
*** alga has joined #SchoolTool | 13:08 | |
*** subir has quit IRC | 13:41 | |
*** ignas has joined #schooltool | 13:45 | |
*** mgedmin has joined #schooltool | 14:01 | |
*** aelkner has quit IRC | 15:14 | |
*** wbrady has joined #schooltool | 15:15 | |
*** th1a has joined #schooltool | 15:19 | |
*** wjohnsto has joined #schooltool | 15:27 | |
wjohnsto | ignas: ayt? | 15:30 |
---|---|---|
ignas | yes | 15:30 |
wjohnsto | I am trying to edit a link, but whenever I change anything to it I get a runtime error on my server | 15:31 |
ignas | anything? | 15:31 |
ignas | and what kind of error? | 15:32 |
ignas | when starting server ? | 15:32 |
ignas | looking at some view? | 15:32 |
ignas | running tests? | 15:32 |
wjohnsto | when I start the server | 15:32 |
wjohnsto | it says | 15:32 |
wjohnsto | "AttributeError: 'SimpleViewClass from /home/wjohnsto/schooltool/src' object has no attribute 'cursor'" | 15:32 |
ignas | is a full traceback available? | 15:33 |
ignas | what does svn diff say? | 15:33 |
wjohnsto | it happens when I try to edit this link<a tal:attributes="href event/linkAllowed" tal:omit-tag="not:event/linkAllowed" tal:content="event/title">(title)</a> | 15:33 |
ignas | and what are you changing it to? | 15:34 |
wjohnsto | <a tal:attributes="href ${event/linkAllowed}?next_url=${request/URL}" tal:omit-tag="not:event/linkAllowed"tal:content="event/title">(title)</a> | 15:36 |
wjohnsto | and also editing the omit tag | 15:36 |
ignas | why edit the omit tag? | 15:37 |
wjohnsto | ignas: if you want the entire traceback I'll pm it to you | 15:37 |
ignas | pm it to me | 15:38 |
wjohnsto | well I assume you would need to edit the omit tag as well | 15:38 |
ignas | why? | 15:38 |
wjohnsto | I haven't even tried that yet though | 15:38 |
ignas | you don't need to | 15:38 |
ignas | you should not edit omit tag actually | 15:38 |
wjohnsto | ok | 15:38 |
ignas | Compilation failed | 15:41 |
ignas | zope.tal.taldefs.TALError: Invalid variable name "URL}" in expression | 15:41 |
ignas | maybe you forgot to add "string:" ? | 15:41 |
wjohnsto | ah | 15:43 |
wjohnsto | thank you, that fixed it | 15:44 |
wjohnsto | pcardune: ayt? | 16:04 |
wjohnsto | I have gotten the next_url into the url for the edit event page. However, it still sends me back to the schooltool calendar because when I click 'UPDATE_SUBMIT', self.request.has_key('next_url') returns False | 16:06 |
wjohnsto | so the url looks like "localhost.../edit.html?date=2008-02-14?next_url=http://localhost:7080/persons/manager/calendar/daily.html" | 16:07 |
wjohnsto | but I never actually go to the next_url | 16:08 |
mgedmin | you need to add something like <input tal:condition="request/next_url|nothing" type="hidden" name="next_url" tal:attributes="value request/next_url" /> | 16:13 |
mgedmin | to the event edit form | 16:13 |
wjohnsto | I have the in the controls where the Update Submit button is defined | 16:15 |
*** aelkner_ has joined #schooltool | 16:24 | |
ignas | wjohnsto: why 2 ? not ?foo=bar&next_url=url | 16:24 |
wjohnsto | the date is defined by event/linkAllowed, I'm not actually sure how to change that | 16:30 |
ignas | date is not the problem | 16:31 |
ignas | ${event/linkAllowed}?next_url=${request/URL} is | 16:31 |
ignas | and you can add next_url in the linkAllowed method anyway | 16:32 |
wjohnsto | ok | 16:32 |
*** wbrady has quit IRC | 16:49 | |
*** wjohnsto has quit IRC | 16:49 | |
*** lisppaste5 has joined #schooltool | 16:51 | |
*** mgedmin has quit IRC | 16:59 | |
*** jinty has joined #schooltool | 17:50 | |
ignas | jinty: hi | 18:03 |
ignas | aelkner_: ayt? | 18:08 |
*** mgedmin has joined #schooltool | 18:13 | |
jinty | ignas: cool | 18:34 |
jinty | got your mail | 18:34 |
jinty | any suggestions on a name for the package? | 18:35 |
ignas | the repo path is /var/local/bzr/schooltool/schooltool.bzr | 18:35 |
ignas | don't know really | 18:35 |
ignas | schooltool.bzr is not very good | 18:35 |
ignas | but it's there already ;) | 18:35 |
jinty | vanguardistas.project? | 18:35 |
ignas | oh | 18:36 |
ignas | for that one | 18:36 |
ignas | good enough | 18:36 |
* jinty feels really bad making a package for a single interface.... | 18:36 | |
ignas | well | 18:36 |
jinty | any mods you think we should make to the interface? | 18:36 |
ignas | vanguardistas.buildtools could contain it | 18:37 |
ignas | no mods, i have implemented my bzr backend | 18:37 |
ignas | in such a way | 18:37 |
ignas | that i would not have to change unit tests from your svn backend :) | 18:37 |
* ignas is lazy | 18:37 | |
jinty | I suppose I should morve the test as well then | 18:37 |
ignas | not really | 18:38 |
jinty | I think buildtools is the wrong placce | 18:38 |
ignas | oh | 18:38 |
jinty | it depends on apt | 18:38 |
ignas | which test are you talking about? | 18:38 |
jinty | tests/project.txt | 18:38 |
ignas | well - i had to modify it a bit | 18:39 |
ignas | i mean - your's had some lines about "we know internal svn structure" ;) | 18:39 |
ignas | with some abuse of that | 18:39 |
ignas | which was not too good for bzr | 18:39 |
* jinty want's to move IProject into vanguardistas.builder and have vanguardistas.svn depend on vanguardistas.builder | 18:43 | |
ignas | my main problem is integration with the rest of the stuff that is already installed | 18:43 |
ignas | jinty: makes sense | 18:43 |
jinty | assuming that vanguardistas.svn is an extension of vanguardiistas.builder | 18:44 |
ignas | especially if vanguardistas.builder assumes that components in vanguardistas.svn implement that interface | 18:44 |
jinty | Hmm, it seems that I need a largish re-factoring | 18:46 |
jinty | how should the builder find the project? | 18:46 |
jinty | as a utility? | 18:46 |
ignas | no idea, really, getUtilitiesFor makes sense to query for all the projects available | 18:47 |
jinty | getUtilitiesFor(IProject) | 18:47 |
ignas | so registering every project as a named utility | 18:47 |
ignas | makes sense | 18:47 |
jinty | then wrap them in a LocationProxy on traversal? | 18:48 |
ignas | makes sense too | 18:48 |
*** fsufitch has joined #schooltool | 18:49 | |
jinty | ok, I'll see what I can do to make that work | 18:49 |
ignas | cool | 18:50 |
ignas | you can just fix up permissions on the repository and commit changes to schooltool.bzr as well | 18:50 |
jinty | I'll have a look around it | 18:52 |
jinty | also, how about merging IProject and IExtendedProject while we're about it? | 18:52 |
ignas | well - not like we are going to add any more version control systems | 18:52 |
ignas | and even if we are - we can just stub the methods to say "Unavaliable in this VCS" | 18:53 |
jinty | and all version control systems have changelogs | 18:53 |
jinty | ok, so then I'll do it | 18:53 |
ignas | cool :) | 18:53 |
ignas | waiting to see it working | 18:53 |
*** ignas has quit IRC | 18:59 | |
fsufitch | Lumiere: ayt? | 19:16 |
aelkner_ | ignas: you were looking for me? | 19:34 |
*** pcardune has quit IRC | 19:50 | |
*** jhancock has joined #schooltool | 20:22 | |
*** jhancock_ has joined #schooltool | 20:23 | |
*** jhancock has quit IRC | 20:41 | |
*** jinty has quit IRC | 20:48 | |
*** ignas has joined #schooltool | 21:01 | |
*** jhancock__ has joined #schooltool | 21:04 | |
*** jhancock__ is now known as jhancock | 21:04 | |
*** jhancock_ has quit IRC | 21:18 | |
*** pcardune has joined #schooltool | 21:41 | |
*** th1a has quit IRC | 22:16 | |
*** pcardune has quit IRC | 22:31 | |
*** didymo has joined #schooltool | 23:14 | |
aelkner_ | ignas: ayt? | 23:14 |
ignas | aelkner_: yes | 23:17 |
aelkner_ | you were looking for me? | 23:17 |
ignas | yes | 23:17 |
ignas | it seems that something is not ok with your person refactoring | 23:17 |
aelkner_ | yes? | 23:17 |
aelkner_ | oh? | 23:17 |
ignas | could you try writing a functional test for basic person that checks whether advisor field works properly | 23:18 |
ignas | lyceum functional tests seem to be failing | 23:18 |
ignas | because control "Advisor" can't be found | 23:18 |
aelkner_ | did you try to manaully edit the person? | 23:18 |
ignas | no, had no time for that yet | 23:18 |
ignas | just noticed that the test is not working anymore in buildbot | 23:19 |
aelkner_ | btw, it's basicperson that changed, not person | 23:19 |
ignas | yes, I know | 23:19 |
ignas | lyceum is using basicperson | 23:19 |
aelkner_ | and when i called up the person, it had the advisor field | 23:19 |
ignas | I understand | 23:20 |
ignas | but something has changed | 23:20 |
ignas | either the label | 23:20 |
ignas | or the connection between the text and the label | 23:20 |
ignas | and i didn't see any functional tests for the functionality that you worked on in schooltool anyway | 23:20 |
ignas | i mean - the test was present only in lyceum | 23:21 |
aelkner_ | i didn't add any funcitonal tests becuase i didn't add any functionality | 23:21 |
ignas | which apparently is not the best place for it to be | 23:21 |
aelkner_ | i just changed the implementation | 23:21 |
aelkner_ | fact is there was never a test for the advisor field | 23:21 |
ignas | yes, I understand, just that - if functionality is not covered by tests - you add the test, then change it | 23:21 |
ignas | or things might break | 23:21 |
aelkner_ | understood | 23:21 |
aelkner_ | ignas: i went into my jelkner-buildout and updatied schooltool | 23:26 |
aelkner_ | i get the advisor field in the person edit form | 23:26 |
aelkner_ | what kind of test should i do for the advisor field? | 23:26 |
aelkner_ | i don't even know if there's anything i could set it to | 23:26 |
ignas | http://codebrowse.launchpad.net/~ignas/schooltool/lyceum/annotate/ignas%40pov.lt-20080130141331-73ct14cqlp2dr2w5?file_id=lyceum_person.txt-20070830141058-qffbqsi3ps0e4gih-6630 | 23:30 |
ignas | is the test that is failing for lyceum | 23:31 |
ignas | it would be a good idea to "backport" it to schooltool.basicperson | 23:31 |
ignas | because the test is essentially for the same class | 23:31 |
ignas | so there shouldn't be too many changes required | 23:31 |
ignas | maybe just removing all the references to lyceum, and normalizing the vocabulary to be more schooltool oriented | 23:31 |
ignas | other than that - just plain copy paste to schooltool/basicperson/wherever_functional_tests_are | 23:32 |
ignas | should be enough to start working on it | 23:32 |
aelkner_ | i see a problem already | 23:33 |
aelkner_ | the change i made was to the edit form, not the add form | 23:33 |
aelkner_ | the add form uses an interface it set up that's not the interface of the context | 23:34 |
ignas | so much for changing the implementation ;) | 23:35 |
fsufitch | aelkner_: ping | 23:35 |
aelkner_ | yes? | 23:35 |
fsufitch | yay you're there | 23:35 |
fsufitch | i wanted to get to work on cando stuffs earlier today, but the Data.fs on the cando developer page doesn't work for me | 23:36 |
fsufitch | http://www.careercenter.arlington.k12.va.us/cando/developers.htm | 23:36 |
aelkner_ | i wouldn't be surprised | 23:37 |
aelkner_ | that file is WAY out of date | 23:37 |
fsufitch | ah | 23:37 |
aelkner_ | why do you need to ues it? | 23:37 |
aelkner_ | you can just start with a fresh Data.fs | 23:37 |
fsufitch | i need a sizable amount of data for one of my bugs to occur | 23:38 |
fsufitch | the thing with the competency title not staying in the right place when you scroll to the right | 23:38 |
aelkner_ | send dwelsh an email asking for him to post a newer Data.fs | 23:38 |
fsufitch | about when would i have it? ;) | 23:38 |
fsufitch | i'd like to get to work today | 23:39 |
aelkner_ | true, it could take days | 23:39 |
aelkner_ | you could always just enter the comps yourself | 23:39 |
aelkner_ | you just need one competency group | 23:39 |
aelkner_ | to have 30 or so comps | 23:39 |
ignas | fsufitch: in what ways is the Data.fs failing? | 23:39 |
aelkner_ | it wouldn't take you more thean ten minutes to enter the comps | 23:39 |
ignas | maybe the evolution scripts can get fixed easily | 23:39 |
fsufitch | it's refering to a SchooltoolApplication object, which is not defined | 23:39 |
ignas | hmm | 23:40 |
aelkner_ | that's weird | 23:40 |
fsufitch | yeah | 23:40 |
ignas | lisppaste5: url | 23:40 |
lisppaste5 | To use the lisppaste bot, visit http://paste.lisp.org/new/schooltool and enter your paste. | 23:40 |
ignas | fsufitch: could you give me the full traceback + error message | 23:41 |
fsufitch | ignas: ok | 23:41 |
lisppaste5 | fsufitch pasted "Error" at http://paste.lisp.org/display/55914 | 23:42 |
fsufitch | brb | 23:42 |
fsufitch | back | 23:46 |
ignas | in schooltool/src/schooltool/app/__init__.py | 23:47 |
ignas | find the line that looks like: SchoolToolApplication='schooltool.app.app.SchoolToolApplication' | 23:47 |
ignas | and try replacing it with SchoolToolApplication='schooltool.app.app:SchoolToolApplication' | 23:47 |
fsufitch | ok | 23:48 |
fsufitch | hang on a sec | 23:48 |
fsufitch | i have the schooltool stuff in an egg... | 23:49 |
fsufitch | should i shance it there | 23:49 |
fsufitch | ? | 23:49 |
fsufitch | *change | 23:49 |
ignas | yes, but not to what I have told you ;) | 23:49 |
ignas | give me a sec | 23:49 |
ignas | deprecated('This class has moved to schooltool.app.app. ' | 23:50 |
ignas | 'The reference will be gone in 0.15', | 23:50 |
ignas | SchoolToolApplication='schooltool.app.app:SchoolToolApplication', | 23:50 |
ignas | ApplicationPreferences='schooltool.app.app.ApplicationPreferences') | 23:50 |
ignas | is the faulty block | 23:50 |
fsufitch | okay? | 23:50 |
ignas | i think it should look like: | 23:50 |
ignas | deprecated('This class has moved to schooltool.app.app. ' | 23:50 |
ignas | 'The reference will be gone in 0.15', | 23:50 |
ignas | 'schooltool.app.app', | 23:50 |
ignas | 'SchoolToolApplication', | 23:50 |
ignas | 'ApplicationPreferences') | 23:50 |
fsufitch | you lost me | 23:51 |
ignas | just delete the old deprecated block in __init__ | 23:52 |
ignas | the one that mentions SchoolToolApplication | 23:52 |
ignas | and place the one i have posted (the last one) instead | 23:52 |
fsufitch | okay | 23:52 |
fsufitch | and this is where locationwise? | 23:52 |
fsufitch | it's not in any of the cando code | 23:53 |
ignas | yes | 23:53 |
fsufitch | this is the egg i have to change? | 23:53 |
ignas | it's in schooltool egg | 23:53 |
ignas | yes | 23:53 |
fsufitch | ah | 23:53 |
ignas | just to see if you can make it work | 23:53 |
fsufitch | ok | 23:53 |
fsufitch | alrite i changed it | 23:54 |
ignas | try starting up now | 23:55 |
fsufitch | TypeError: deprecated() takes exactly 1 argument (4 given) | 23:55 |
aelkner_ | ignas: could you look at basicperson.browser.person for a second | 23:55 |
aelkner_ | the PersonAddForm is where the for fields are set | 23:55 |
aelkner_ | and whereas I added IStudent to the form fields for the edit view | 23:55 |
aelkner_ | I'm not sure if that would work for the add form | 23:56 |
aelkner_ | at least in the edit form, there is a context | 23:56 |
aelkner_ | and i know from experience that formlib knows to adapt the context to IStudent | 23:56 |
aelkner_ | when it's dealing with one of its fields | 23:56 |
aelkner_ | in the case of the add form, there is no context other than the container | 23:57 |
ignas | fsufitch: oh, ok, my bad | 23:57 |
ignas | back to plan B | 23:57 |
fsufitch | plan b = ? | 23:57 |
ignas | deprecated('This class has moved to schooltool.app.app. ' | 23:57 |
ignas | 'The reference will be gone in 0.15', | 23:57 |
ignas | SchoolToolApplication='schooltool.app.app:SchoolToolApplication', | 23:57 |
ignas | ApplicationPreferences='schooltool.app.app:ApplicationPreferences') | 23:57 |
aelkner_ | so how would it be able to accept the IStudent fields? | 23:57 |
ignas | aelkner_: i think it has an object already when it performs apply changes | 23:58 |
aelkner_ | ah yes, it call form.applyChanges AFTER it calls the object factory | 23:59 |
ignas | fsufitch: use the above code, instead ;) | 23:59 |
aelkner_ | so that would work | 23:59 |
fsufitch | i did | 23:59 |
fsufitch | zope.app.generations.interfaces.UnableToEvolve: (5, u'schooltool', 24) | 23:59 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!