*** shapr has quit IRC | 00:01 | |
th1a | hi mhz | 00:06 |
---|---|---|
th1a | SchoolTool itself would be the higher priority. | 00:06 |
mhz | th1a: by 'irself' you mean the application? | 00:06 |
mhz | application = system | 00:07 |
th1a | Yes. We use Bazaar on http://launchpad.net. | 00:07 |
th1a | Yes. | 00:07 |
th1a | The application. | 00:07 |
mhz | oh, okis | 00:07 |
*** shapr has joined #schooltool | 00:10 | |
*** wrobel has quit IRC | 00:23 | |
*** mhz is now known as mhz_food | 00:46 | |
*** alga has joined #SchoolTool | 01:04 | |
*** jinty has quit IRC | 01:31 | |
*** alga has quit IRC | 02:33 | |
*** pcardune has joined #schooltool | 02:56 | |
*** pcardune has quit IRC | 02:57 | |
*** mhz_food is now known as mhz | 04:04 | |
*** vidasp has quit IRC | 04:10 | |
*** mhz is now known as mhz_zZZZzz | 06:27 | |
*** mhz_zZZZzz has left #schooltool | 06:28 | |
*** wrobel has joined #schooltool | 08:59 | |
*** mgedmin has joined #schooltool | 11:42 | |
*** jinty has joined #schooltool | 12:40 | |
*** thisfred has joined #schooltool | 13:06 | |
*** alga has joined #SchoolTool | 13:14 | |
*** jinty has quit IRC | 13:22 | |
*** gintas has joined #schooltool | 13:28 | |
mgedmin | povbuildbot, where are you? :-/ | 13:30 |
*** ignas has joined #schooltool | 13:31 | |
strichter | mgedmin: everyone I show the coverage HTML to loves it! I think it would be one of those tools that should make it into Zope 3 core. | 13:40 |
mgedmin | z3's test.py has --coverage, doesn't it? | 13:48 |
mgedmin | all you need is the plaintext2html conversion script | 13:49 |
mgedmin | schooltool's test.py --coverage was inspired by zope 3 | 13:49 |
mgedmin | although I had to tweak it a lot to make it work | 13:50 |
mgedmin | (e.g. move test module imports under the profiler, so that top-level of various code modules isn't marked as "not covered") | 13:50 |
strichter | I see | 13:51 |
strichter | yes, Zope 3 has --coverage | 13:51 |
strichter | but the plaintext2html script would be useful | 13:51 |
mgedmin | absolutely | 13:51 |
strichter | maybe you can also port your tweaks | 13:52 |
mgedmin | that's on my (long) todo list | 13:52 |
strichter | I am trying right now to get your script working on a trunk Zope 3 | 13:52 |
mgedmin | the 2html script is in the schooltool repository (bin/coverage_reports.py) | 13:52 |
strichter | right, I copied that into the trunk, but it does not do anything there | 13:52 |
strichter | so I have to look what's going on | 13:53 |
mgedmin | which trunk? | 13:53 |
strichter | Zope 3 trunk | 13:53 |
mgedmin | do you have coverage/*.cover files? | 13:53 |
mgedmin | look at schooltool's makefile | 13:53 |
strichter | yes | 13:53 |
mgedmin | the 'coverage-reports-html' rule | 13:53 |
strichter | yes, that's all the same | 13:53 |
mgedmin | ah | 13:53 |
mgedmin | I just remembered | 13:54 |
mgedmin | bin/coverage_reports.py has a hardcoded rule | 13:54 |
mgedmin | "ignore everything that does not match schooltool*.cover" | 13:54 |
mgedmin | there are a lot of misleading zope.*.cover files | 13:54 |
strichter | ah | 13:54 |
mgedmin | not to mention strangely-named <doctest\ *.cover | 13:54 |
mgedmin | in coverage | 13:54 |
mgedmin | +1 for making the filter pattern a command-line argument | 13:54 |
strichter | yeah | 13:55 |
strichter | ok, now it is doing something | 13:55 |
strichter | I am just gonna checkout how well Zope is tested. | 13:56 |
strichter | mmh, it di dnot generate an index.html | 13:57 |
strichter | oh, it's zope.html | 13:57 |
strichter | wow, in comparison to Zope 3, SchoolTool is amazingly well-tested | 13:58 |
strichter | mmh, there must be some false positives | 13:59 |
strichter | I know that I tested the number parsing really well, but it shows it as not being tested | 13:59 |
strichter | it also does not seem to catch all files | 14:01 |
*** strichter is now known as srichter | 14:04 | |
mgedmin | did you notice any false positives in schooltool? | 14:06 |
srichter | yeah, a few, but they are hard to check | 14:06 |
srichter | for example, I have an AbstractScoreSystem | 14:06 |
srichter | clearly the raise NotImplementedError calls are never executed | 14:06 |
srichter | however, I would be okay writing a test for it | 14:07 |
mgedmin | but those are not false positives | 14:07 |
mgedmin | I mean, have you noticed any places that are tested, but the coverage tool misses them? | 14:08 |
srichter | oh, no not yet, not in SchoolTool | 14:08 |
mgedmin | (I remember there once were problems with doctests) | 14:08 |
mgedmin | (and I remember I had problems like this when I tried using hotshot for tracking coverage) | 14:08 |
mgedmin | (and I remember problems with trace.py in Python 2.3) | 14:08 |
srichter | if doctest would not be working, we could not have 93% coverage in schooltool.requirement :-) | 14:09 |
mgedmin | hmm, I wonder why __init__.py is not mentioned at all in http://source.schooltool.org/coverage/schooltool.html | 14:12 |
* mgedmin finishes hookig up the coverage report generator to buildbot and runs a final test | 14:15 | |
mgedmin | it would be nice to push http://source.schooltool.org/trac/changeset/2355 upstream into Python | 14:21 |
povbot | /svn/commits: * mg committed revision 5738: | 14:28 |
povbot | /svn/commits: Mention HTML unit test coverage reports. | 14:28 |
povbot | /svn/commits: Remove the ancient obsolete and incorrect text about functional test interdependencies. | 14:28 |
mgedmin | a long article about test coverage reports: http://www-128.ibm.com/developerworks/java/library/j-cq01316/?ca=dgr-lnxw01CodeQuality1 | 14:46 |
mgedmin | doesn't say anything unobvious, though | 14:46 |
srichter | :-) | 14:47 |
srichter | I think Tim would be able to apply the fix | 14:47 |
*** vidasp has joined #schooltool | 15:02 | |
*** mgedmin has quit IRC | 15:03 | |
*** mgedmin has joined #schooltool | 15:15 | |
*** gintas has quit IRC | 15:56 | |
*** mgedmin has quit IRC | 15:56 | |
*** mgedmin has joined #schooltool | 16:13 | |
*** tiredbones has left #schooltool | 16:16 | |
*** erchache has joined #schooltool | 16:34 | |
erchache | hi | 16:38 |
povbot | /svn/commits: * mg committed revision 5739: | 17:14 |
povbot | /svn/commits: Unit Test coverage reports: | 17:14 |
povbot | /svn/commits: * show the revision number and generation date in the footer of each page * disable syntax highlighting (instead of omitting the source code altogether) | 17:14 |
povbot | /svn/commits: when enscript is not installed | 17:14 |
povbot | /svn/commits: * enclose filenames in double quotes before passing them to os.popen; this | 17:14 |
povbot | /svn/commits: is not fullproof, but at least should handle spaces in pathnames | 17:14 |
*** povbuildbot has joined #schooltool | 17:20 | |
*** erchache has quit IRC | 17:24 | |
mgedmin | povbuildbot, hello | 17:24 |
mgedmin | povbuildbot, help | 17:24 |
mgedmin | povbuildbot: help | 17:25 |
povbuildbot | Get help on what? (try 'help <foo>', or 'commands' for a command list) | 17:25 |
mgedmin | povbuildbot: commands | 17:25 |
povbuildbot | buildbot commands: commands, dance, destroy, excited, force, hello, help, last, list, source, status, stop, version, watch | 17:25 |
mgedmin | povbuildbot: status | 17:25 |
povbuildbot | pov-schooltool: idle, last build 448827 secs ago: build successful | 17:25 |
povbuildbot | pov-schooltool-coverage: building(computing unit test coverage) | 17:25 |
mgedmin | povbuildbot: help watch | 17:25 |
povbuildbot | Usage: watch <which> - announce the completion of an active build | 17:25 |
mgedmin | povbuildbot: help dance | 17:25 |
povbuildbot | No usage info for 'dance' | 17:25 |
mgedmin | povbuildbot: dance | 17:26 |
povbuildbot | 0-< | 17:26 |
povbuildbot | 0-/ | 17:26 |
povbuildbot | 0-\ | 17:26 |
mgedmin | povbuildbot: hello | 17:26 |
povbuildbot | yes? | 17:26 |
mgedmin | povbuildbot: last | 17:26 |
povbuildbot | last build [pov-schooltool]: 448868 secs ago: build successful | 17:26 |
povbuildbot | last build [pov-schooltool-coverage]: 615 secs ago: exception svn | 17:26 |
mgedmin | povbuildbot: list | 17:26 |
povbuildbot | try 'list builders' | 17:26 |
mgedmin | povbuildbot: list builders | 17:26 |
povbuildbot | Configured builders: pov-schooltool pov-schooltool-coverage | 17:26 |
mgedmin | povbuildbot: watch pov-schooltool-coverage | 17:26 |
povbuildbot | watching build pov-schooltool-coverage #5 until it finishes.. | 17:26 |
povbuildbot | Hey! build pov-schooltool-coverage #5 is complete: Success [build successful] | 18:06 |
povbuildbot | Build details are at http://source.schooltool.org/buildbot/pov-schooltool-coverage/builds/5 | 18:06 |
mgedmin | hm, what's the difference between 'Revision' and 'Last Changed Rev' in 'svn info' output? | 18:13 |
mgedmin | the python folks use 'last change rev': http://mail.python.org/pipermail/python-dev/2005-December/058854.html | 18:14 |
mgedmin | no, svnversion is a better bet | 18:17 |
povbot | /svn/commits: * mg committed revision 5740: | 18:17 |
povbot | /svn/commits: Use svnversion instead of svn info. | 18:17 |
*** gintas has joined #schooltool | 18:20 | |
mgedmin | aha! | 19:11 |
srichter | must be fun chatting with povbuildbot | 19:21 |
*** gintas has quit IRC | 20:30 | |
*** vidasp has quit IRC | 20:36 | |
*** thisfred has quit IRC | 21:27 | |
*** vidasp has joined #schooltool | 22:18 | |
*** ignas has quit IRC | 22:21 | |
*** mgedmin has quit IRC | 22:39 | |
*** alga has quit IRC | 22:44 | |
*** jinty has joined #schooltool | 22:52 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!