| *** srichter has quit IRC | 00:17 | |
| *** srichter has joined #schooltool | 00:39 | |
| *** srichter has quit IRC | 01:13 | |
| *** srichter has joined #schooltool | 05:04 | |
| *** hoffman|edubu has quit IRC | 06:06 | |
| *** Aiste has joined #schooltool | 09:31 | |
| *** tamere has joined #schooltool | 11:32 | |
| *** tamere has left #schooltool | 11:47 | |
| *** ignas has quit IRC | 12:06 | |
| *** mgedmin has joined #schooltool | 12:15 | |
| *** ignas has joined #schooltool | 12:45 | |
| *** vidasp has joined #schooltool | 13:24 | |
| povbot` | /svn/commits: * alga committed revision 5144: | 14:03 |
|---|---|---|
| povbot` | /svn/commits: A view to generate sample data. | 14:03 |
| *** srichter has quit IRC | 14:20 | |
| povbot` | /svn/commits: * ignas committed revision 5145: | 14:49 |
| povbot` | /svn/commits: Bug fix for Issue381 (broken monthly recurrence rules). | 14:49 |
| *** jinty has joined #schooltool | 14:58 | |
| povbot` | /svn/commits: * ignas committed revision 5146: | 15:09 |
| povbot` | /svn/commits: Fixed rest-client system path was not constructed properly. | 15:09 |
| *** srichter has joined #schooltool | 15:14 | |
| *** thisfred has joined #schooltool | 15:29 | |
| *** ignas has quit IRC | 16:14 | |
| *** ignas has joined #schooltool | 16:14 | |
| *** mgedmin has quit IRC | 16:16 | |
| *** mgedmin has joined #schooltool | 16:17 | |
| * mgedmin clears the mailman queue | 16:20 | |
| *** bskahan has joined #schooltool | 16:21 | |
| mgedmin | th1a, a long time ago you said you'd take care of pending mailman moderator requests | 16:21 |
| th1a | I do on rare occasions. | 16:21 |
| mgedmin | yesterday I noticed and approved a few non-member submissions on the list | 16:21 |
| mgedmin | a bunch of them were from mark's canonical address | 16:22 |
| th1a | Oh, that's where those came from. | 16:22 |
| mgedmin | I thought you'd notice ;-) | 16:22 |
| th1a | You didn't happen to that address to the list, did you? | 16:23 |
| mgedmin | to <what> that address to the list? | 16:23 |
| th1a | add, that is. | 16:24 |
| mgedmin | I added it to the whilelist | 16:24 |
| mgedmin | I hope | 16:24 |
| th1a | whitelist? | 16:24 |
| mgedmin | firefox was very unhappy with the huge queue | 16:24 |
| mgedmin | it ate 90% of my RAM | 16:24 |
| mgedmin | and took ages to post the form | 16:24 |
| th1a | The whole system is a disaster. | 16:25 |
| mgedmin | agreed | 16:25 |
| mgedmin | th1a, http://lists.schooltool.org/mailman/admin/schooltool/privacy/sender | 16:25 |
| mgedmin | there's a whitelist of non-members there | 16:25 |
| th1a | Ah. Thanks. | 16:25 |
| mgedmin | I do not see mark's address there, though | 16:26 |
| mgedmin | perhaps my aborted form submission only let the messages through but didn't change any settings | 16:26 |
| * mgedmin shrugs | 16:26 | |
| mgedmin | mailman is ... not nice | 16:26 |
| mgedmin | today I ssh'ed into the server, played a bit with shell scripts, unplickled the queued messages, piped them to spamassassin, and told mailman to discard those that were spam | 16:27 |
| mgedmin | and processed the rest via the web, by looking for word 'school' | 16:27 |
| th1a | That sounds like a good idea. | 16:27 |
| mgedmin | if you could take a look at the pending requests, say, once a week, that would prevent huge browser-killing queues from piling up (hint, hint) | 16:28 |
| *** alga has joined #schooltool | 16:28 | |
| mgedmin | perhaps it would be a good idea to move mailman to the new server, and filter all incoming mail through spambayes | 16:28 |
| mgedmin | ok, the meeting is about to start -- I'll shut up about mailman now | 16:29 |
| th1a | Good morning/evening all. | 16:30 |
| th1a | srichter, bskahan: ayt? | 16:31 |
| alga | Hello | 16:31 |
| alga | First let me introduce someone | 16:32 |
| alga | vidasp is Vidas Pažusis, our new employee | 16:32 |
| th1a | Hello, vidasp. | 16:32 |
| alga | He's a physics PhD student working for us part time since today :-) | 16:33 |
| bskahan | hi vidasp | 16:33 |
| th1a | More physicists! | 16:33 |
| th1a | Zope 3 seems to make sense to physicists, so I guess that's good :-) | 16:34 |
| alga | he he | 16:34 |
| th1a | srichter is a physicist. | 16:34 |
| vidasp | hi everybody | 16:34 |
| th1a | Although he doesn't seem to actually be here. | 16:34 |
| alga | th1a, maybe you can ping him on the phone? | 16:35 |
| th1a | Well, srichter mentioned that he's going to be traveling (to a sprint) this week? | 16:36 |
| bskahan | yeah | 16:36 |
| th1a | I don't know that I have his phone number. | 16:36 |
| th1a | I'll have to look. | 16:36 |
| bskahan | not sure what the timeframe for that is though | 16:36 |
| th1a | Does everyone need to talk to him? | 16:36 |
| mgedmin | apparently not | 16:37 |
| th1a | I don't think I have his phone number anyhow. | 16:38 |
| th1a | I mean, I can't find it. | 16:38 |
| th1a | So let's plow ahead. | 16:38 |
| th1a | bskahan: Let's get up to date on the website status first. | 16:38 |
| bskahan | I sent Gus an email on friday, haven't gotten a response yet | 16:39 |
| bskahan | but he'll probably roll the DNS as soon as he gets that | 16:39 |
| th1a | And that'll take a day or so to propogate? | 16:40 |
| bskahan | yes | 16:40 |
| th1a | OK. | 16:40 |
| bskahan | as soon as that rolls I'll set up the cado mailing list | 16:40 |
| bskahan | I want to make sure all the MX dns stuff is still right with the existing lists | 16:40 |
| th1a | OK. | 16:41 |
| th1a | We should spend a bit more time fixing (simplifying) the documentation and product index pages. | 16:41 |
| th1a | Is there a time today we can do that? | 16:41 |
| bskahan | yeah | 16:41 |
| bskahan | what sort of things are you thinking? | 16:42 |
| th1a | Just finishing what we started in the doc index. | 16:42 |
| th1a | Did you work on the chroot problem any further? | 16:43 |
| bskahan | not successfully, but that's my #1 task at the moment | 16:43 |
| bskahan | I'm setting up 2 | 16:43 |
| bskahan | one for demo and one for your school | 16:43 |
| th1a | If srichter isn't going to be doing much work this week, are there things you can do to get ahead of him on the viewlet work? | 16:44 |
| bskahan | yes | 16:44 |
| bskahan | I can continue moving existing view to pagelets based on the work he did allready | 16:45 |
| th1a | OK. After the chroots & demo servers are up, that's probably the biggest priority. | 16:45 |
| bskahan | ok | 16:45 |
| th1a | The rest of the website stuff isn't particularly time-sensitive. | 16:46 |
| * bskahan nods | 16:46 | |
| th1a | bskahan: Anything else? | 16:47 |
| bskahan | no, I think that's it for mew | 16:47 |
| bskahan | me | 16:47 |
| th1a | OK. POV? | 16:47 |
| alga | Things done last week: | 16:47 |
| alga | * reviewing srichter's refactorings | 16:47 |
| alga | * triaging and fixing bugs: 405 381 379 347 396, found more bugs | 16:47 |
| alga | * missing functional tests for overlay portlet | 16:47 |
| alga | * Started implementing pluggable sample data generators | 16:47 |
| alga | Basically, some of us are still stuck in the bugfixing phase | 16:48 |
| th1a | You have done a good job of shaking loose bugs, but it is a little depressing. | 16:48 |
| alga | And some haven't yet gotten round to reading all of srichter's checkin messages on the refactor branch | 16:48 |
| * mgedmin blushes | 16:48 | |
| th1a | mgedmin: On the whole, you haven't run into many issues with the refactor branch, though, right? | 16:49 |
| ignas | well | 16:49 |
| alga | personally, I think it's fine | 16:49 |
| mgedmin | I'm the one who hasn't gotten round to looking at it deeply | 16:50 |
| mgedmin | we have encountered issues | 16:50 |
| mgedmin | for example, the restive interface plainly doesn't work in the trunk | 16:50 |
| mgedmin | (probably a Zope3-trunk realted breakage) | 16:50 |
| ignas | it is good enough, some things stoped working though and will have to be fixed | 16:50 |
| mgedmin | and there are no functional tests for schoolbell | 16:50 |
| mgedmin | (there are two, but they are disabled, and do not work anyway) | 16:50 |
| th1a | Well, not having functional tests for SchoolBell is acceptable, I suppose, since we don't really know how we're going to build it yet. | 16:51 |
| th1a | I spent a lot of time stressing that we needed to focus on SchoolTool, so that may be the inevitable result. | 16:52 |
| alga | th1a, but it feels that there are a lot of unfinished flaky things in the calendaring code | 16:53 |
| th1a | The REST tests passed until they were broken by the Zope 3 trunk, right? | 16:53 |
| mgedmin | the tests pass now | 16:53 |
| mgedmin | the code is broken | 16:53 |
| ignas | the server itself | 16:54 |
| mgedmin | it's an integration problem somewhere | 16:54 |
| th1a | alga: Oh, so it isn't so much that there aren't SchoolBell ftests as there aren't *calendaring* ftests? | 16:54 |
| mgedmin | zope3 style functional tests directly create HTTPRequest objects, and that part works | 16:54 |
| alga | th1a: that is not so, sorry to have mislead you | 16:54 |
| * mgedmin is confused | 16:54 | |
| * th1a is confused. | 16:55 | |
| alga | calendaring code is tested, but still has problems | 16:55 |
| alga | schoolbell app does not have ftests | 16:55 |
| mgedmin | schooltool/schoolbell restive server doesn't work | 16:55 |
| mgedmin | three unrelated issues | 16:55 |
| mgedmin | (or groups of issues?) | 16:55 |
| th1a | OK, so the policy on SchoolBell as a standalone app in the trunk is that it is a low priority. | 16:56 |
| mgedmin | ok | 16:56 |
| th1a | As long as srichter has a plan for getting it to work sometime next spring, that's fine with me. | 16:57 |
| th1a | Are we these issues going into the tracker? | 16:57 |
| th1a | I guess I should read the unread issues in my inbox. | 16:58 |
| th1a | Do we need to make any decisions about outstanding (and recently found) bugs? | 17:00 |
| th1a | Which ones to fix? | 17:00 |
| ignas | the amount of bugs is kind of overwhelming, so prioritizing them might be nice ... | 17:02 |
| mgedmin | all the problems I've found are in the issue tracker | 17:02 |
| ignas | i allways have the urge to fix something instead of doing the real important work ;) | 17:02 |
| alga | We'll definitely need REST working to finish this contract :-) | 17:02 |
| ignas | s/allways/always | 17:02 |
| th1a | alga: That's certainly true. | 17:02 |
| th1a | Do you have any sense of why it broke? | 17:03 |
| mgedmin | WSGI support in zope 3 trunk, I guess | 17:03 |
| alga | ignas has a hacky workaround | 17:03 |
| mgedmin | some interfaces changed | 17:03 |
| mgedmin | order of method arguments | 17:03 |
| mgedmin | I'd like to talk to srichter about this | 17:04 |
| mgedmin | he made a couple of WSGI/servertype related changes in the refactor branch | 17:04 |
| th1a | OK. Can you send him an email? | 17:04 |
| mgedmin | I can | 17:04 |
| mgedmin | although I think he got the issue by mail from the issue tracker | 17:04 |
| th1a | Well, an extra ping might help. Did you add him to the default nosy list? | 17:06 |
| th1a | Why do grants persist after a person is deleted? | 17:06 |
| ignas | because grants are stored separately | 17:07 |
| th1a | Is that hard to fix or just an oversight? | 17:08 |
| ignas | it is not very hard to fix i guess | 17:08 |
| th1a | Well, it seems like that would be a good one to fix. | 17:09 |
| th1a | OK, before I get too rambly. What are the goals for this week? | 17:09 |
| th1a | For POV? | 17:09 |
| alga | I'll go on working on sample data | 17:11 |
| ignas | i'll be working on restclient | 17:12 |
| ignas | the library | 17:12 |
| mgedmin | we'll continue bugtracking & bugfixing | 17:12 |
| th1a | ignas: Have you started on the restclient? | 17:13 |
| ignas | yep | 17:13 |
| alga | th1a: re bugtracking | 17:13 |
| alga | there is a list of issues re. timezones | 17:13 |
| th1a | Yes. | 17:14 |
| alga | bskahan kind of promised to fix all those on his spare time | 17:14 |
| th1a | This is the hell that SteveA warned us against. | 17:14 |
| th1a | Yes, bskahan did, didn't he? | 17:14 |
| alga | hi did promise | 17:14 |
| alga | but he never ever fixed a tz bug | 17:15 |
| alga | in the past month or so | 17:15 |
| th1a | bskahan? | 17:15 |
| alga | http://issues.schooltool.org/issue?%3Aaction=search&%3Asearch_text=&title=&%3Acolumns=title&topic=&id=&%3Acolumns=id&creation=&creator=&activity=&%3Acolumns=activity&%3Asort=activity&priority=&%3Agroup=priority&status=-1%2C1%2C2%2C3%2C4%2C5%2C6%2C7&%3Acolumns=status&assignedto=19&%3Acolumns=assignedto&%3Apagesize=50&%3Astartwith=0&%3Asortdir=on&%3Aqueryname= | 17:16 |
| alga | essentially, our approach to timezones is wrong | 17:17 |
| th1a | I was afraid you were going to say something like that. | 17:17 |
| alga | the right thing to do is to store the events *with* timezones | 17:17 |
| alga | not convert everything to UTC | 17:17 |
| ignas | which would have to reflect in the UI in some way | 17:18 |
| th1a | Hm. | 17:19 |
| th1a | So just bugfixing is unlikely to solve the problem anyhow? | 17:19 |
| alga | not all problems | 17:19 |
| alga | but some issues are just simple unfinished things | 17:20 |
| alga | like boundaries of dates | 17:20 |
| mgedmin | let's split this into two parts | 17:20 |
| mgedmin | 1) we can support many use cases by storing times in UTC | 17:20 |
| mgedmin | 2) we can support more use cases if we store time + timezone | 17:20 |
| mgedmin | there are a number of bugs in our implementation of (1) | 17:21 |
| mgedmin | let's fix those | 17:21 |
| alga | yep | 17:21 |
| th1a | OK. | 17:21 |
| th1a | I'll follow up with bskahan. | 17:22 |
| alga | any feedback would be nice | 17:22 |
| alga | 'cause we assign issues to bskahan and nothing happens | 17:23 |
| th1a | Understood. | 17:23 |
| alga | we don't know whether he agrees with them or not | 17:23 |
| alga | whether he even notices | 17:23 |
| th1a | Apparently not noticing at the moment. | 17:23 |
| mgedmin | we included a couple of timezone-related bugs in our contract, as part of the bugfixing story | 17:24 |
| mgedmin | I don't see why we shouldn't just go ahead and fix those | 17:24 |
| th1a | If they're in the contract, definitely do that. | 17:24 |
| th1a | Anything else before we wrap up? | 17:26 |
| mgedmin | I don't think so | 17:26 |
| th1a | OK. I'll talk to bskahan about the timezone bugs. | 17:27 |
| th1a | Welcome aboard vidasp. | 17:28 |
| * th1a bangs the virtual gavel. | 17:28 | |
| srichter | darn, too late :-( | 17:30 |
| srichter | I was so into my grading today :-( | 17:30 |
| th1a | Physicists! | 17:30 |
| srichter | anything else I should know? | 17:30 |
| th1a | The main point seems to be that REST was broken by the Z3 trunk. | 17:31 |
| srichter | oh, probably the result stuff | 17:31 |
| th1a | POV has some REST related stories to complete, so they need it to work. | 17:32 |
| srichter | I will catch up as soon as I have my stuff graded | 17:35 |
| srichter | I will also work from home thise afternoon | 17:35 |
| th1a | srichter: OK. | 17:36 |
| alga | srichter: there's an issue assigned to you in the tracker | 17:48 |
| *** alga has quit IRC | 17:48 | |
| mgedmin | srichter, http://issues.schooltool.org/issue411 | 17:48 |
| mgedmin | we though you might know what is going on from a glance | 17:49 |
| mgedmin | we suspect that you know everything about Zope 3 WSGI support and server types | 17:49 |
| srichter | that is a true assumption :-) | 18:14 |
| srichter | basically get rid of passing in any output stream :-) | 18:14 |
| srichter | I'll fix the bug this afternoon, or at least have a detailed look at it | 18:14 |
| * srichter got a new 24'' 1920x1200 plasma screen this weekend and hopes to increase his productivity greatly once he gets it working properly ;-) | 18:16 | |
| mgedmin | woohoo | 18:27 |
| *** Aiste has quit IRC | 18:31 | |
| *** Aiste has joined #schooltool | 18:34 | |
| povbot` | /svn/commits: * mg committed revision 5147: | 18:38 |
| povbot` | /svn/commits: Tiny refactoring. | 18:38 |
| bskahan | mgedmin, I missed alga earlier, I will tackle the bugs assigned to me in the issue tracker | 18:40 |
| ignas | mgedmin, we had a way to get all possible Relationship URI's out of schooltool through RESTive interface, should i reimplement it or just hardcode the list of relationships in the client code ? | 19:02 |
| mgedmin | ignas, yes | 19:03 |
| *** srichter has quit IRC | 19:08 | |
| *** jinty has quit IRC | 19:44 | |
| *** vidasp has quit IRC | 19:52 | |
| povbot` | /svn/commits: * mg committed revision 5148: | 19:53 |
| povbot` | /svn/commits: Calendar overlay API enhancement: `overlaid_calendars.add()` now returns the ICalendarOverlayInfo object. | 19:53 |
| povbot` | /svn/commits: This is necessary if you want to disable timetable overlay on the new calendar: | 19:53 |
| povbot` | /svn/commits: >>> info = person.overlaid_calendars.add(other.calendar) >>> IShowTimetables(info).showTimetables = False | 19:53 |
| *** pcardune has joined #schooltool | 20:00 | |
| *** Aiste has quit IRC | 20:04 | |
| povbot` | /svn/commits: * mg committed revision 5149: | 20:07 |
| povbot` | /svn/commits: Oops. Forgot to add the file. | 20:07 |
| mgedmin | th1a, http://issues.schooltool.org/issue367 (duplicate events in calendar overlay) | 20:10 |
| mgedmin | the proposed solution is to disable the Timetable checkbox by default | 20:10 |
| mgedmin | for groups | 20:10 |
| mgedmin | and, I assume, sections | 20:10 |
| mgedmin | but keep the checkbox enabled by default for persons and resources | 20:11 |
| mgedmin | is that right? | 20:11 |
| *** ignas has quit IRC | 20:15 | |
| *** jinty has joined #schooltool | 20:16 | |
| *** Aiste has joined #schooltool | 20:22 | |
| *** pcardune has quit IRC | 20:27 | |
| *** srichter has joined #schooltool | 20:41 | |
| th1a | mgedmin: Only leave it enabled for persons. | 20:43 |
| mgedmin | ok | 20:46 |
| bskahan | mgedmin, do we have a use case where a person would have a timetable and another user would subscribe to it? | 20:49 |
| mgedmin | real-world use case? | 20:50 |
| mgedmin | "When does my buddy Paulius have lessons?" | 20:50 |
| th1a | bskahan: Certainly the main office often has to locate a student. | 20:51 |
| * mgedmin edits src/schooltool/app/browser/overlay.py | 20:53 | |
| * mgedmin adds a print statement, runs the tests, and is mystified when none fail | 20:54 | |
| * mgedmin adds raise NotImplementedError and gets the failure he wants | 20:54 | |
| * mgedmin discovers that the debug print was eaten by a wildcard in the doctest | 20:54 | |
| *** pcardune has joined #schooltool | 20:57 | |
| *** pcardune has quit IRC | 20:58 | |
| *** pcardune has joined #schooltool | 20:59 | |
| pcardune | jinty, ayt? | 21:18 |
| jinty | indeed | 21:25 |
| jinty | pcardune: time for an update to cando? | 21:25 |
| povbot` | /svn/commits: * mg committed revision 5150: | 21:28 |
| povbot` | /svn/commits: Refactoring: extracted method CalendarSelectionView._updateSelection, added unit test. Added a TODO comment where the code will have to be modified to fix issue 367. | 21:28 |
| povbot` | /svn/commits: * srichter committed revision 5151: | 21:40 |
| povbot` | /svn/commits: Implemented ignas' suggestion of the fix for issue 411. I agree that this is the best way of doing it. | 21:40 |
| srichter | mgedmin: I fixed 411 | 21:40 |
| mgedmin | srichter, joy! | 21:40 |
| mgedmin | srichter, have you seen how the developer mode menu interacts with the daily calendar view? | 21:41 |
| srichter | no | 21:41 |
| mgedmin | try it, it is fun | 21:41 |
| srichter | ok, will do | 21:41 |
| mgedmin | the menu hides behind every second hourly bar | 21:41 |
| mgedmin | and behind all events | 21:41 |
| srichter | oh yeah, I have seen that | 21:42 |
| srichter | too much CSS woodoo for me | 21:42 |
| mgedmin | also, the absolutely positioned daily/weekly/monthly/yearly icons | 21:42 |
| mgedmin | yeah | 21:42 |
| srichter | I refer to our CSS guys to fix that :-) | 21:42 |
| mgedmin | perhaps .devmode { z-order: 999; } or something would help | 21:42 |
| mgedmin | I should create an issue for this | 21:42 |
| mgedmin | srichter, could you take a look at http://issues.schooltool.org/issue391 | 21:44 |
| mgedmin | its related to one of your refactorings | 21:44 |
| mgedmin | permissions for the IShowTimetables adapter | 21:45 |
| mgedmin | perhaps it can be fixed by making it a trusted adapter? | 21:45 |
| * mgedmin runs make ftest | 21:45 | |
| * mgedmin discovers that he cannot commit a fix for issue 367 because he just triggered issue 391 in functional tests | 21:46 | |
| srichter | I have a look | 21:47 |
| * mgedmin tries to add trusted="true" to the IShowTimetables adapter | 21:48 | |
| * mgedmin runs make ftest and gets a bunch of HTTPError: HTTP Error 500: Internal Server Error | 21:48 | |
| pcardune | jinty, it's time for a new update | 21:48 |
| mgedmin | aha! ForbiddenAttribute: ('showTimetables', <schooltool.app.app.ShowTimetables object at 0xb5d1c5ac>) | 21:49 |
| * mgedmin adds security declarations for the adapter | 21:50 | |
| * mgedmin gets different ftest failures | 21:51 | |
| mgedmin | Unauthorized: (<schooltool.app.app.ShowTimetables object at 0xb5d638ac>, 'showTimetables', 'schooltool.view') | 21:51 |
| * mgedmin adds goes to ShowTimetables.__init__ | 21:52 | |
| * mgedmin adds self.__parent__ = context.__parent__ # for local security grants | 21:52 | |
| * mgedmin runs ftests | 21:52 | |
| mgedmin | srichter, I've a fix for issue 391 | 21:54 |
| mgedmin | patch: http://issues.schooltool.org/file72/fix-for-issue391.patch | 21:54 |
| jinty | pcardune: looking at the changelog now, | 21:54 |
| mgedmin | all it needs is a functional test | 21:54 |
| jinty | pcardune: in future could you add which rvisions have been merged to the log? "merge from trunk" tells me nothing | 21:55 |
| pcardune | yes, i can do that | 21:57 |
| pcardune | when i did the merge, i just said merge -r 390:HEAD blah blah blah | 21:57 |
| srichter | mgedmin: an ftest should be easy using test browser :-) | 22:00 |
| jinty | pcardune: yeah, it's a fundamental problem with svn. the standard workaround is something like: svn ci -m 'merged from trunk, used command svn merge -r 390:HEAD blah' | 22:00 |
| srichter | I wonder whether we should have a directory in which we can put tests for issues | 22:00 |
| pcardune | jinty, that makes sense, i'll be sure to do that next time | 22:00 |
| srichter | I would prefer not having those test be around the documentation driven ones | 22:00 |
| mgedmin | srichter, do you want to write that easy ftest? | 22:01 |
| mgedmin | otoh, perhaps I can do it | 22:01 |
| mgedmin | if I'm careful enough | 22:01 |
| srichter | well, you just follow your own recipe from the original report | 22:01 |
| pcardune | jinty, going to lunch now, will be back in 30 minutes or so, email me if there are any problems | 22:02 |
| pcardune | jinty, actually, i won't be back for 2 hours, as I have class. | 22:03 |
| jinty | no worries, I'll mail you when I'm finished | 22:03 |
| povbot` | /svn/commits: * alga committed revision 5152: | 22:04 |
| povbot` | /svn/commits: Set svn:keywrods. | 22:04 |
| mgedmin | alga, I hope you didn't really set svn:keywrods | 22:06 |
| mgedmin | oh, screw the separate ftest for 391, my change that fixes 367 requires the fix for 391 anyway | 22:07 |
| mgedmin | so I've got an (indirect) regression test | 22:07 |
| * mgedmin waves hands vigorously | 22:07 | |
| srichter | he he | 22:08 |
| srichter | fine with me :-) | 22:08 |
| *** srichter has quit IRC | 22:09 | |
| povbot` | /svn/commits: * mg committed revision 5153: | 22:10 |
| povbot` | /svn/commits: Fix issue 391: traceback when trying to uncheck timetable overlay checkbox. | 22:10 |
| povbot` | /svn/commits: (This fix should come with a functional test, but, as it happens, my subsequent fix for issue 367 triggers this bug in our existing functional test suite.) | 22:10 |
| mgedmin | aargh, my fix for 391 fixes functional tests, but breaks unit tests | 22:13 |
| mgedmin | this is what happens when you try to fix multiple issues in a single dirty sandbox | 22:13 |
| povbot` | /svn/commits: * mg committed revision 5154: | 22:15 |
| povbot` | /svn/commits: Oops. My fix for issue 391 broke unit tests, and I didn't notice. | 22:15 |
| povbot` | /svn/commits: * mg committed revision 5155: | 22:17 |
| povbot` | /svn/commits: Fix issue 367: duplicate timetable events showing up in calendars. | 22:17 |
| povbot` | /svn/commits: The implemented fix is the one suggested in the issue tracker: when you include calendars of sections/groups/resources, disable the timetable checkbox by default. | 22:17 |
| mgedmin | srichter is gone :-/ | 22:20 |
| mgedmin | I wanted to ask a question about restive cookies | 22:20 |
| mgedmin | bskahan, you're the CSS guru | 22:45 |
| mgedmin | srichter would be happy if you looked at http://issues.schooltool.org/issue414 | 22:46 |
| th1a | Actually, I think tvon is responsible for the devmode CSS. | 22:46 |
| th1a | Well, more precisely, he volunteered to help srichter, iirc. | 22:47 |
| mgedmin | ah, ok | 22:47 |
| th1a | It wasn't part of a formal contract. | 22:47 |
| tvon | srichter is the one that fixed positioned it... I can take a look at it if you like | 22:47 |
| th1a | However, it seems like we should be able to clean it up as part of the overall UI rearrangement which is underway. | 22:48 |
| th1a | That is, I'm not sure that there is much point in fixing it this week. | 22:48 |
| mgedmin | I hope that it can be fixed by adding a single CSS rule | 22:49 |
| mgedmin | .devmode {z-order:999;} or something | 22:49 |
| tvon | thats what I was thinking | 22:49 |
| th1a | Well, I presume this will become some kind of "viewlet." | 22:49 |
| mgedmin | good night, all | 22:54 |
| *** mgedmin has quit IRC | 22:54 | |
| *** Aiste has quit IRC | 22:54 | |
| *** bskahan has quit IRC | 23:11 | |
| *** srichter has joined #schooltool | 23:15 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!