| *** gintas has quit IRC | 00:06 | |
| povbot | /svn/commits: * srichter committed revision 4649: | 00:06 |
|---|---|---|
| povbot | /svn/commits: Let's rid ourselves from duplicate view_macros.pt templates. | 00:06 |
| tvon | bskahan? | 01:04 |
| srichter | tvon: he is not here | 01:08 |
| srichter | not in my channel list at least | 01:08 |
| tvon | srichter: yeah, I noticed after I said something | 01:08 |
| srichter | tvon: we now have only one view_macros.pt that is shared between ST/SB in my refactoring branch | 01:09 |
| tvon | srichter: nice | 01:09 |
| tvon | dammit | 01:11 |
| tvon | It's hard to provide a regeression test for something when you can't reproduce it | 01:11 |
| tvon | but I *think* know what the problem was | 01:11 |
| tvon | ah, perhaps... | 01:12 |
| tvon | srichter: is there a concept of roles in z3? | 01:22 |
| srichter | yes | 01:22 |
| srichter | the default security policy implements them | 01:23 |
| tvon | ah | 01:23 |
| povbot | /svn/commits: * tvon committed revision 4650: | 01:42 |
| povbot | /svn/commits: Fix for issue328, please backport. | 01:42 |
| *** munkee has quit IRC | 04:06 | |
| *** munkee has joined #schooltool | 04:14 | |
| povbot | /svn/commits: * tvon committed revision 4651: | 04:59 |
| povbot | /svn/commits: broken ftest | 04:59 |
| povbot | /svn/commits: * tvon committed revision 4652: | 05:09 |
| povbot | /svn/commits: working on 329. KHTML has no love for self-closing divs. | 05:09 |
| povbot | /svn/commits: * tvon committed revision 4653: | 05:26 |
| povbot | /svn/commits: the rest of the layout problem in issue329. please backport this and r4652 | 05:26 |
| povbot | /svn/commits: * bskahan committed revision 4654: | 06:37 |
| povbot | /svn/commits: generation script to make schooltool's application calendar public and set security policy to the 0.11 defaults. | 06:37 |
| povbot | /svn/commits: I'm not sure if this is a good idea for back porting because the change in security policy - from unset on containers, to denyAccess - may result in unexpected behavior in existing sites. | 06:37 |
| povbot | /svn/commits: It's probably the correct way for SchoolTool to set access from now on though. | 06:37 |
| povbot | /svn/commits: Dragons: The old evolve3.py is now evolve4.py. This shouldn't hurt people using release tarballs, but it may play havoc with devlopers svn sandboxes, sorry about that. | 06:37 |
| povbot | /svn/commits: * bskahan committed revision 4655: | 06:43 |
| povbot | /svn/commits: correct a docstring | 06:43 |
| *** tvon has quit IRC | 06:52 | |
| *** tvon has joined #schooltool | 07:36 | |
| *** tvon has quit IRC | 08:13 | |
| *** tvon has joined #schooltool | 08:25 | |
| *** mgedmin has joined #schooltool | 10:48 | |
| *** ignas has joined #schooltool | 10:59 | |
| *** Aiste has joined #schooltool | 11:01 | |
| *** ignas has quit IRC | 11:01 | |
| *** ignas has joined #schooltool | 11:01 | |
| *** jonesieboy has joined #schooltool | 11:41 | |
| jonesieboy | Hi all - anyone around to offer a bit of help/reassurance to someone looking at the possibility of developing a component to plug into SchoolTool? | 11:44 |
| jonesieboy | Guess not :) I'll be back! | 11:48 |
| *** jonesieboy has left #schooltool | 11:48 | |
| *** jinty has joined #schooltool | 12:12 | |
| *** jinty has quit IRC | 12:23 | |
| *** jinty has joined #schooltool | 12:23 | |
| povbot | /svn/commits: * jinty committed revision 4656: | 13:02 |
| povbot | /svn/commits: Port 4571, 4576 to the schoolbell release branch (http://issues.schooltool.org/issue320) | 13:02 |
| povbot | /svn/commits: * jinty committed revision 4657: | 13:05 |
| povbot | /svn/commits: Back-port 4573 and 4578 to the schooltool release branch. | 13:05 |
| povbot | /svn/commits: * jinty committed revision 4658: | 13:11 |
| povbot | /svn/commits: merged 4631:4655 from debian-packaging into debian-packaging-nozope3 | 13:11 |
| ignas | any CanDo folks here ? | 13:41 |
| *** SteveA has quit IRC | 13:48 | |
| *** SteveA has joined #schooltool | 13:51 | |
| *** bskahan has joined #schooltool | 14:11 | |
| * jinty gets really irritated with having to download zope for about the 5th time today and goes to kill the schooltool external | 14:30 | |
| povbot | /svn/commits: * jinty committed revision 4659: | 14:35 |
| povbot | /svn/commits: Kill the schooltool zope external. | 14:35 |
| *** ignas has quit IRC | 14:36 | |
| povbot | /svn/commits: * jinty committed revision 4660: | 14:50 |
| povbot | /svn/commits: Remove Zope from the schoolbell tarball and update the README (sync from schoolbell). | 14:50 |
| *** bskahan has quit IRC | 15:16 | |
| *** bskahan has joined #schooltool | 15:49 | |
| povbot | /svn/commits: * jinty committed revision 4661: | 15:53 |
| povbot | /svn/commits: Add compatibility for building current release tarballs to the non-zope3 packaging stuff. tested as much as I can without having the rc3 tarballs. | 15:53 |
| *** ignas has joined #schooltool | 16:29 | |
| *** srichter has quit IRC | 16:30 | |
| *** srichter has joined #schooltool | 16:34 | |
| *** strichter has joined #schooltool | 16:35 | |
| *** bskahan has quit IRC | 16:43 | |
| *** bskahan has joined #schooltool | 17:02 | |
| *** strichter has quit IRC | 17:12 | |
| *** jonesieboy has joined #schooltool | 17:53 | |
| *** jonesieboy has quit IRC | 17:56 | |
| *** th1a has joined #schooltool | 17:57 | |
| th1a | bskahan: ayt? | 17:57 |
| bskahan | hi tom | 17:57 |
| th1a | Hey. Wasn't stopping resources from being added to groups an Etria story at some point? | 17:58 |
| bskahan | yes, there's no more members-resources | 17:59 |
| bskahan | iirc | 18:00 |
| th1a | Was that in this contract? | 18:00 |
| bskahan | I think so, let me look | 18:00 |
| th1a | We need a generations script to boot them out as well. | 18:00 |
| bskahan | ok, that was discussed and voted down | 18:00 |
| th1a | It seems like John Baillie's bug might be related to having resources in groups. | 18:01 |
| bskahan | interesting | 18:01 |
| bskahan | ok, I'll do a generation to remove them | 18:01 |
| bskahan | it shouldn't be difficult | 18:01 |
| th1a | OK. Should be simple enough. | 18:01 |
| bskahan | we talked about the generation initially and the conclusion was to not change existing groups on people | 18:02 |
| bskahan | but I think that was just a path of least resistence decision | 18:02 |
| mgedmin | why? | 18:02 |
| th1a | OK. I guess I forgot our conclusion. | 18:02 |
| th1a | It probably didn't seem to make much difference one way or another. | 18:02 |
| bskahan | mgedmin: in case people using 0.10 had set up groups with resources allready | 18:02 |
| mgedmin | I'm not saying that is bad, but I'd feel better if the database state after an upgrade can always be exactly recreated by starting from a fresh DB and doing operations TTW or via REST | 18:03 |
| mgedmin | it's just a feeling I have | 18:03 |
| bskahan | this gets into my issues with the ACL generation script as well | 18:04 |
| bskahan | in place generations are great, but there's no way to tell people about what changed | 18:04 |
| bskahan | so when john baillie (for example) start wondering where all his projectors went ... | 18:05 |
| srichter | using REST to recreate the previous DB state is impossible | 18:05 |
| srichter | think about logging operations | 18:05 |
| th1a | Well, perhaps we could wait to see if resources in groups is actually the source of the problem. | 18:06 |
| th1a | I guess I could try to replicate it locally. | 18:06 |
| bskahan | th1a: I'm reasonably certain that having a resource in a group isn't the direct cause of the problem, it may be the root cause of the permissions error but we probably can fix a permissions error there without actually removing resources | 18:08 |
| bskahan | I'll experiment with it now | 18:08 |
| *** gintas has joined #schooltool | 18:09 | |
| th1a | bskahan: OK. Sounds prudent. | 18:12 |
| gintas | tvon, your change in rev 4650 is not well-tested | 18:15 |
| gintas | that revision looks a bit messy as well, so I'd like to have reliable unit tests before I backport it | 18:18 |
| gintas | bskahan, can you deal with 332? | 18:19 |
| bskahan | gintas: sure, which behavior do you think is correct? | 18:20 |
| bskahan | th1a: can you look at my comment on 332? | 18:20 |
| th1a | I'd say a) is fine. | 18:21 |
| povbot | /svn/commits: * gintas committed revision 4662: | 18:22 |
| povbot | /svn/commits: Backported revisions 4652, 4653 (should fix issue 329). | 18:22 |
| bskahan | ok | 18:22 |
| bskahan | th1a: on issue 333 (john's issue) | 18:23 |
| bskahan | I can't recreate it | 18:23 |
| gintas | and whoever disallowed resources as members of groups needs to write a generation script | 18:23 |
| gintas | or maybe not | 18:24 |
| bskahan | gintas: if you were using 0.10 and had spent time creating groups of resources and did an apt-get upgrade to find those groups empty, would you be happy? | 18:24 |
| th1a | OK. Let's wait and see what the problem is. | 18:24 |
| bskahan | I'd like to boot them in a generation because I think in the long run it will be a source of hard to track down bugs | 18:25 |
| gintas | this does not look like a critical bug, I think we can release rc3 without a fix | 18:25 |
| bskahan | I've created (in 0.10) a group with 1 person and 1 resource. added an event to the group, subscribed the user to the groups calendar | 18:26 |
| bskahan | after upgrade it continues to work as expected | 18:26 |
| gintas | tvon, are you there? | 18:26 |
| gintas | I need you to finish up 328 | 18:26 |
| th1a | Maybe I'll see if John will send me his Data.fs. | 18:26 |
| bskahan | th1a: that would be good, if he CC's it to me I'll start working on it | 18:27 |
| bskahan | or to the list | 18:27 |
| th1a | OK. I'll send him an email in a second. | 18:27 |
| bskahan | ask him to send the _pre-upgrade_ data.fs | 18:28 |
| bskahan | if possible | 18:28 |
| bskahan | gintas: is 328 the only thing stopping RC3? | 18:29 |
| gintas | I'd like a fix for 332 too, it does not look that hard | 18:33 |
| gintas | but I definitely don't want to ship rc3 without a fix for 328 | 18:34 |
| gintas | if Tom does not turn up I may decide to release with the fix that he's committed, after testing it manually thoroughly | 18:35 |
| gintas | he will still owe me some unit tests though | 18:35 |
| gintas | bskahan, can you fix 332 during the next hour or so? | 18:36 |
| gintas | if not, I'll just release without it, it's not that big of a deal (and the fix should not affect much anyway, so it's not risky) | 18:37 |
| bskahan | working on it now | 18:37 |
| gintas | how long do you think it will take? | 18:39 |
| gintas | by the way, are you solving the general problem or just fixing the persons importer? | 18:40 |
| gintas | I think that probably the same problem is in the groups & resources importer, isn't it? | 18:41 |
| bskahan | gintas: I think so | 18:42 |
| gintas | so, will your fix apply for resources and groups too? | 18:42 |
| bskahan | yes | 18:43 |
| gintas | great | 18:45 |
| gintas | how long do you think it will take for you to finish the fix? | 18:46 |
| gintas | jinty, are you there? | 18:51 |
| *** Aiste has quit IRC | 18:56 | |
| gintas | bskahan, will you land the fix in the next 15 minutes? otherwise I'm releasing rc3 now | 19:06 |
| *** th1a has quit IRC | 19:08 | |
| tvon | gintas: 328 is fixed as far as I know | 19:14 |
| *** alga has joined #SchoolTool | 19:15 | |
| gintas | tvon, are you sure it is tested well? | 19:16 |
| gintas | I added a 'b0rk' into a random place and all the tests passed | 19:16 |
| gintas | replace the 'print' you had in there with an 'assert False' | 19:17 |
| tvon | print? | 19:17 |
| gintas | see my reply to rev 4650 | 19:18 |
| tvon | ugh | 19:18 |
| gintas | happens to me too occasionally | 19:19 |
| gintas | anyway, the fix seems to be working | 19:19 |
| gintas | I backported the fix | 19:20 |
| gintas | you can check in the missing test later | 19:20 |
| tvon | okay | 19:21 |
| povbot | /svn/commits: * gintas committed revision 4663: | 19:22 |
| povbot | /svn/commits: Backported revision 4650 (without the spurious 'print' statement). This is not well tested, but seemed to work well enough for me. | 19:22 |
| povbot | /svn/commits: By the way, a functional test broke because the order of overlaid calendars was switched around. I'm not sure why this happened, it could be one of those undeterministic order bugs. | 19:22 |
| *** thisfred has joined #schooltool | 19:24 | |
| bskahan | gintas: sorry about that, got pulled away by a phone call. I have a fix for 332 but I'm having trouble reproducing it in the tests to get a regression test done | 19:26 |
| gintas | that's odd | 19:26 |
| gintas | the bug should be easy to reproduce | 19:26 |
| gintas | I cloned one line in src/schoolbell/app/browser/ftests/app.txt and got a failure | 19:27 |
| gintas | line 800 | 19:27 |
| bskahan | gintas: working on unit tests | 19:28 |
| bskahan | one sec | 19:28 |
| bskahan | think I know what it is | 19:28 |
| gintas | ok | 19:29 |
| gintas | bskahan, how's it going? | 19:37 |
| bskahan | fine, there was no PersonCSVImporterView test | 19:38 |
| gintas | ok | 19:39 |
| gintas | I was planning to do the release before going home | 19:39 |
| gintas | looks like I'll just pack it up and upload after I get back, so you don't need to hurry then | 19:39 |
| * bskahan nods | 19:43 | |
| bskahan | sorry it took so long | 19:43 |
| gintas | nah, it's fine | 19:43 |
| gintas | I got all the packing stuff automated, so I can build packages with a single keypress | 19:44 |
| gintas | so there's not much of a difference when I get to build the packages | 19:44 |
| gintas | I'd just like to upload rc3 today | 19:44 |
| bskahan | cool | 19:44 |
| bskahan | I'll be done shortly I hope | 19:45 |
| gintas | well, I still have to write the announcement, create the directories in plone, etc. | 19:45 |
| * bskahan nods | 19:45 | |
| gintas | I'll be heading home then, I should be back online in an hour | 19:45 |
| gintas | hopefully you'll be done by then | 19:45 |
| gintas | bye | 19:46 |
| *** gintas has quit IRC | 19:46 | |
| bskahan | for dry_run in [True, False]: | 19:50 |
| bskahan | for rowdata in rows: | 19:50 |
| bskahan | self.createAndAdd(rowdata, dry_run) | 19:50 |
| tvon | runs through twice, first one is a dry run | 19:57 |
| tvon | (if "wtf" is what you meant) | 19:57 |
| bskahan | started like that | 20:01 |
| bskahan | figured out why now | 20:01 |
| jinty | gintas: I'm here now | 20:03 |
| bskahan | tvon: do you know why the assert dry_run, ("...") is in BaseCSVimporter? | 20:04 |
| jinty | drat, didn' t realise he left already | 20:04 |
| * tvon looks | 20:04 | |
| *** mgedmin has quit IRC | 20:05 | |
| tvon | bskahan: that came from the old csvimporter | 20:05 |
| bskahan | ok, it doesn't get raised in any test so I'm removing it | 20:06 |
| tvon | it will be raised if there are errors and it is not a dry run | 20:08 |
| tvon | I guess if it could be tested it would be accounted for and not necessary | 20:09 |
| povbot | /svn/commits: * bskahan committed revision 4664: | 20:16 |
| povbot | /svn/commits: fix for issue332 - persons/@@person-csvimport.html error This should be backported. | 20:16 |
| *** ignas has quit IRC | 20:41 | |
| *** thisfred has quit IRC | 20:56 | |
| *** alga has quit IRC | 21:00 | |
| *** bskahan has quit IRC | 21:04 | |
| jinty | gintas: I have to go and have supper. But let me know your questions and I will try resolve them later tonight or tomorrow morning, | 21:25 |
| *** gintas has joined #schooltool | 21:48 | |
| *** bskahan has joined #schooltool | 21:57 | |
| povbot | /svn/commits: * gintas committed revision 4665: | 22:46 |
| povbot | /svn/commits: Backported rev 4664, added missing i18n:translate in person-csvimport.pt. | 22:46 |
| povbot | /svn/commits: * gintas committed revision 4666: | 22:57 |
| povbot | /svn/commits: Tagging SchoolBell 1.2rc3. | 22:57 |
| povbot | /svn/commits: * gintas committed revision 4667: | 22:58 |
| povbot | /svn/commits: Tagging SchoolTool 0.11rc3. | 22:58 |
| povbot | /svn/commits: * gintas committed revision 4668: | 23:05 |
| povbot | /svn/commits: Updated Czech translation. | 23:05 |
| povbot | /svn/commits: * gintas committed revision 4669: | 23:16 |
| povbot | /svn/commits: Bumped version number for rc3. | 23:16 |
| povbot | /svn/commits: * gintas committed revision 4670: | 23:18 |
| povbot | /svn/commits: Bumped version, bound ST rc3 to SB rc3. | 23:18 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!