| *** bska|pycon has quit IRC | 00:07 | |
| *** th1a has joined #schooltool | 00:25 | |
| *** th1a has quit IRC | 00:55 | |
| *** th1a has joined #schooltool | 01:01 | |
| *** mgedmin has quit IRC | 01:03 | |
| *** tv|pycon has quit IRC | 01:06 | |
| *** mgedmin has joined #schooltool | 01:07 | |
| *** th1a has quit IRC | 01:09 | |
| *** mgedmin has quit IRC | 01:51 | |
| *** gintas has quit IRC | 02:10 | |
| *** SteveA_ has quit IRC | 05:35 | |
| *** SteveA_ has joined #schooltool | 05:35 | |
| *** SteveA_ has quit IRC | 06:25 | |
| *** th1a has joined #schooltool | 06:40 | |
| *** tvon has joined #schooltool | 06:53 | |
| *** SteveA_ has joined #schooltool | 09:37 | |
| *** ignas_ has joined #schooltool | 11:58 | |
| ignas_ | i am so lonely, that i have decided to join you in this cosy channel :) | 11:58 |
|---|---|---|
| *** gintas has joined #schooltool | 13:11 | |
| *** gintas has quit IRC | 13:23 | |
| *** stan has joined #schooltool | 13:39 | |
| stan | how can u get reminders, possibly via email, from schoolbell? | 13:44 |
| ignas_ | iirc we do not have it implemented in schoolbell 1.0 | 14:00 |
| ignas_ | at least the email part | 14:00 |
| *** gintas has joined #schooltool | 14:01 | |
| * tvon pokes th1a | 14:08 | |
| *** regebro has joined #schooltool | 14:13 | |
| regebro | Hello peoples! I'm probably gonna pester you with a bunch of questions today. ;) | 14:14 |
| regebro | Q1: Why are recurrence rules immutable? | 14:14 |
| gintas | do you have the old SchoolTool or the new SchoolBell in mind? | 14:15 |
| regebro | Oh, SchoolBell1.0. | 14:16 |
| gintas | as far as I remember, in SchoolTool we had calendars as sets of events, so events had to be immutable, therefore parts of events, such as recurrence rules, too | 14:16 |
| gintas | hmm | 14:16 |
| regebro | I forgot to even check if there is a special channel for that, i sthere? | 14:16 |
| gintas | I think CalendarEvents are mutable now | 14:16 |
| gintas | no | 14:16 |
| gintas | I wonder | 14:16 |
| ignas_ | no there are no special channels for schoolbell | 14:16 |
| regebro | OK, great. | 14:17 |
| gintas | it looks like it's a legacy thing | 14:17 |
| gintas | we reused much of the old SchoolTool's code in SchoolBell | 14:17 |
| regebro | OK, that's good, because I couldn't see why it was like that. Thanks! I'm back to the code! :) | 14:17 |
| gintas | CalendarEvents were made mutable, but we might have missed recurrence rules | 14:17 |
| gintas | there's probably no good reason to have them immutable any more | 14:18 |
| ignas_ | i guess it was done to save some time/complexity and increase the code reuse ... | 14:18 |
| ignas_ | the recurence rules are objects of different types so one should replace one rule with another if the rulk would change from daily to weekly | 14:19 |
| ignas_ | s/rulk/rule | 14:19 |
| ignas_ | it's either reimplementing recurrence rules from the ground to make them truly mutable, or just reuse the old code (inheriting the immutability of rules ...) | 14:20 |
| gintas | nah | 14:33 |
| gintas | we just missed them, it should be no big deal to make them mutable | 14:33 |
| regebro | Right. | 14:37 |
| regebro | As you may or may not know, faassen snitched your recurrence implementation for use on our calendar. ;) | 14:38 |
| regebro | But I want them to be mutable... | 14:38 |
| regebro | So I'm looking into that. I may make some other rearrangements as well, but the implementations should be quite compatible anyway. | 14:39 |
| gintas | I think just turning the r/o properties into normal attributes would be fine | 14:43 |
| regebro | Right. | 14:43 |
| gintas | just take care not to break the restrictions coded in _validate(). | 14:44 |
| ignas_ | and i think one should refactor DailyRecurence WeeklyRecurrence and others into one class ... | 14:44 |
| gintas | huh? | 14:45 |
| regebro | Daily and Weekly could be the same, but Monthly and Yearly can't. | 14:45 |
| gintas | they're quite different, it's a bad idea to merge them | 14:46 |
| regebro | In any case, this is also a UI question, how to select which rule should be used? | 14:46 |
| ignas_ | that's why i think it is weird making them mutable ... like you had to replace Daily with Daily when modifying it ... | 14:46 |
| ignas_ | aftermaking themmutableyou will be capable to modify the daily recurrence, yet you will have tu replace it with a new rule if it changes to monthly | 14:47 |
| * ignas_ had not enough sleep tonight, so you can just ignore him ;) | 14:47 | |
| gintas | regebro, just do whatever you find most convenient | 14:47 |
| gintas | if immutability gets in the way, get rid of it | 14:47 |
| regebro | I didn't have enough sleep either, and faassen is sick. not a good day, this. ;) | 14:47 |
| regebro | I'll test around a bit. | 14:48 |
| regebro | Intuitively, I would merge them all into the same object and have a drop down to change the recurrence type. | 14:49 |
| *** mgedmin has joined #schooltool | 14:49 | |
| regebro | but... that makes the expansion rules big and unwildy, and I don't want to do that. | 14:49 |
| regebro | I want to keep the flexibility to replace it with new recurrences like "easter" recurrences and stuff. | 14:49 |
| regebro | Anyway, I'll see what I can figure out on how to make a UI to replace them. In worst case, I'll just skip that part, and not make it possible to change the recurrence type. | 14:50 |
| regebro | It's not in this projects specifications to do that. ;) | 14:50 |
| *** th1a has quit IRC | 14:51 | |
| *** tvon has quit IRC | 14:55 | |
| gintas | regebro, OTOH ignas is right in that treating recurrence rules as immutable is easier | 14:58 |
| mgedmin | why? | 14:59 |
| gintas | I still think that enforcing that in code is a leftover from SchoolTool | 14:59 |
| ignas_ | mgedmin, logs? | 14:59 |
| regebro | Does Zope3 transparently handle immutables with replace()? Or do you need to make special stuff for that? | 14:59 |
| mgedmin | Zope 3 doesn't | 15:00 |
| mgedmin | but I think our calendar event editing form is a bit too complex for zope 3 to handle automatically | 15:00 |
| mgedmin | anyway | 15:00 |
| regebro | ok | 15:02 |
| ignas_ | a bit is a little understatement ;) | 15:02 |
| *** Aiste has joined #schooltool | 15:11 | |
| *** gintas has quit IRC | 15:13 | |
| regebro | OK, Q2: in your recurrencerule.apply() you pass event and enddate. Why event, and not startdate? | 15:35 |
| regebro | Any reason? | 15:35 |
| regebro | (All you ever do is cur = start = event.dtstart.date() ;) | 15:35 |
| ignas_ | regebro, file and line would be more helpfull | 15:42 |
| ignas_ | i am working on anotherparts of the application ofthemoomentso switchingcontextsis kind of difficult | 15:42 |
| mgedmin | regebro, no reason, I guess | 15:42 |
| regebro | recurrent.py, many lines. ;) | 15:43 |
| regebro | for example line 115, ignas_ | 15:43 |
| regebro | mgedmin: OK, just wanted to make sure, so I'm not missing anything important. Thanks. | 15:44 |
| mgedmin | I guess the only theoretical reason is that a hyphotetical recurrence rule might possibly want to use other fields | 15:44 |
| regebro | Hmm. OK. | 15:45 |
| ignas_ | simple - we do not have the enddate the file you mentioned line 259 | 15:45 |
| ignas_ | for example | 15:45 |
| ignas_ | ooignore the simple and the stuff :) | 15:45 |
| ignas_ | too much coffee, not enough sleep | 15:46 |
| ignas_ | but yess that place is the only instance of any other attribute of event being accessed in the generator | 15:47 |
| regebro | right.... OK, got it. | 15:48 |
| regebro | thanks ignas_ | 15:48 |
| regebro | It makes it complicatedif your startdate is not the same as the date in the event, though. event, startdate and enddate would be useful parameters. | 15:50 |
| regebro | Ah, well, details... | 15:50 |
| *** gintas has joined #schooltool | 16:00 | |
| *** stan has quit IRC | 17:31 | |
| *** th1a has joined #schooltool | 17:44 | |
| *** maka has joined #schooltool | 17:45 | |
| *** tvon has joined #schooltool | 17:52 | |
| *** th1a has quit IRC | 17:53 | |
| *** maka has quit IRC | 17:55 | |
| *** gintas has quit IRC | 18:24 | |
| *** ignas has quit IRC | 18:43 | |
| *** ignas_ is now known as ignas | 18:43 | |
| *** ignas_ has joined #schooltool | 18:43 | |
| *** ignas has quit IRC | 18:45 | |
| *** bskahan has joined #schooltool | 19:15 | |
| *** tvon has quit IRC | 19:37 | |
| *** tvon has joined #schooltool | 19:38 | |
| *** bskahan has quit IRC | 19:49 | |
| *** th1a has joined #schooltool | 20:01 | |
| *** bskahan has joined #schooltool | 20:17 | |
| *** th1a has quit IRC | 20:21 | |
| *** th1a has joined #schooltool | 20:23 | |
| *** SteveA__ has joined #schooltool | 20:24 | |
| *** SteveA__ is now known as SteveA | 20:24 | |
| *** SteveA_ has quit IRC | 20:32 | |
| *** mgedmin has quit IRC | 20:49 | |
| *** alga has joined #SchoolTool | 21:00 | |
| *** th1a has quit IRC | 21:03 | |
| *** th1a has joined #schooltool | 21:04 | |
| *** regebro has quit IRC | 21:30 | |
| *** th1a has quit IRC | 21:38 | |
| *** tvon has quit IRC | 21:44 | |
| *** munkee has joined #schooltool | 22:01 | |
| *** tvon has joined #schooltool | 22:08 | |
| *** Aiste has quit IRC | 22:18 | |
| *** Aiste has joined #schooltool | 22:24 | |
| *** tvon has quit IRC | 22:27 | |
| *** th1a has joined #schooltool | 23:03 | |
| *** SteveA_ has joined #schooltool | 23:12 | |
| *** SteveA has quit IRC | 23:15 | |
| *** SteveA_ is now known as SteveA | 23:15 | |
| *** th1a has quit IRC | 23:26 | |
| *** th1a has joined #schooltool | 23:31 | |
| *** th1a has quit IRC | 23:36 | |
| *** bskahan has quit IRC | 23:42 | |
| *** th1a has joined #schooltool | 23:54 | |
| *** th1a has quit IRC | 23:58 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!