*** tvon has left #schooltool | 00:03 | |
bskahan | anyone know why schooltool.main doesn't get a coverage report | 00:17 |
---|---|---|
bskahan | th1a: you around? | 00:17 |
*** hazmat has quit IRC | 00:20 | |
*** tvon has joined #schooltool | 00:22 | |
bskahan | I'm stumped, this is the last piece of migration, and it should be trivial | 00:25 |
jinty | adeiu, hasta manana! | 00:32 |
*** jinty has quit IRC | 00:32 | |
*** hazmat has joined #schooltool | 00:34 | |
th1a | hey | 00:51 |
th1a | Had a little nap. | 00:51 |
th1a | That dhtml scheduling hack is nice. | 00:52 |
bskahan | it was similar to a thought I had for the calendar UI | 00:53 |
bskahan | for changing event time/day | 00:54 |
th1a | More dragging and dropping would be nice. | 00:54 |
bskahan | got the problem down to one pretty simple example bug | 01:19 |
bskahan | going to dinner, write a test case for the bug after | 01:19 |
*** hazmat has quit IRC | 01:23 | |
*** hazmat has joined #schooltool | 01:23 | |
*** hazmat has quit IRC | 02:14 | |
*** d2m has quit IRC | 02:18 | |
*** d2m has joined #schooltool | 09:29 | |
*** th1a has quit IRC | 09:40 | |
*** bskahan has quit IRC | 09:54 | |
*** Aiste has joined #schooltool | 10:31 | |
*** Aiste has quit IRC | 11:40 | |
*** Aiste has joined #schooltool | 11:48 | |
*** mgedmin has joined #schooltool | 11:53 | |
* mgedmin looking at http://minittml.alioth.debian.org/ | 11:56 | |
* mgedmin installing trang | 11:59 | |
mgedmin | one important thing before the 0.9 release | 12:17 |
mgedmin | do the README and debian/copyright explicitly acknowledge what schoolbell contains some icons from GNOME? | 12:17 |
mgedmin | If you just define __eq__ but not __ne__ in your class, will Python handle != correctly? | 12:21 |
* mgedmin tries | 12:21 | |
mgedmin | no | 12:21 |
* mgedmin looks for jinty but does not see him | 12:22 | |
*** tvon has quit IRC | 12:31 | |
*** SteveA has quit IRC | 12:31 | |
*** tvon has joined #schooltool | 12:31 | |
mgedmin | tvon, where do the nice schoolbell icons come from? | 12:35 |
mgedmin | could you update the copyright section in the README (and debian/copyright) to explicitly mention them? | 12:39 |
mgedmin | currently the README claims that all files in src/schooltool (except some in src/schooltool/translation) are (c) shuttleworth foundation | 12:40 |
*** SteveA has joined #schooltool | 12:46 | |
*** mgedmin has quit IRC | 13:03 | |
*** Aiste has quit IRC | 13:22 | |
*** Aiste has joined #schooltool | 13:38 | |
*** SteveA has quit IRC | 14:04 | |
*** SteveA has joined #schooltool | 14:06 | |
*** gintas has joined #schooltool | 14:09 | |
*** mgedmin has joined #schooltool | 14:56 | |
*** Aiste has quit IRC | 15:17 | |
*** alga has joined #SchoolTool | 15:34 | |
*** th1a has joined #schooltool | 16:31 | |
*** jinty has joined #schooltool | 18:26 | |
*** SteveA_ has joined #schooltool | 18:30 | |
*** SteveA has quit IRC | 18:31 | |
*** SteveA_ is now known as SteveA | 18:31 | |
* jinty just read the irc logs | 18:31 | |
jinty | mgedmin: __eq__ was only for the unit tests, it has absolutely no use outside that and is not in any interfaces. Do i need to bother to define __ne__? everything seems to work | 18:36 |
jinty | maybe I should anyway. | 18:38 |
*** Aiste has joined #schooltool | 18:46 | |
* jinty considers committing an imaginary timetabling client with illusionary tests under src/timetabling | 18:47 | |
mgedmin | jinty, a simple ``def __ne__(self, other): return not self.__eq__(other)`` would be nice | 19:26 |
jinty | will do | 19:33 |
*** gintas has quit IRC | 19:49 | |
tvon | mgedmin: theyre GNOME, I'll update it now | 20:07 |
mgedmin | ok | 20:10 |
* mgedmin tries the db conversion script | 20:10 | |
mgedmin | no exceptions | 20:10 |
mgedmin | I'm not sure what the expected contents of the database should be, though | 20:11 |
* jinty is going to create a trunk/packaging directory | 20:16 | |
*** bskahan has joined #schooltool | 20:48 | |
* tvon debates moving all the gnome icons into a subdir | 21:13 | |
th1a | I'd prefer that. | 21:13 |
tvon | aight | 21:13 |
bskahan | should put up a wiki page with the icons we want to replace | 21:14 |
tvon | www/gnome/ ? since they are all from gnome | 21:14 |
th1a | There aren't many, right? If we're getting rid of the little "event" and "resource" icons. | 21:14 |
bskahan | mgedmin: I can't get the same error to occur in a test | 21:15 |
tvon | th1a: there are 12 I believe | 21:16 |
th1a | OK. I guess I know where to find them now. | 21:16 |
mgedmin | bskahan, are you talking about a regular unit test, or the db conversion test script? | 21:16 |
mgedmin | where do you see the error then? | 21:16 |
bskahan | both, the same thing works fine in the unit test | 21:16 |
mgedmin | I ran the test script today | 21:17 |
mgedmin | I saw no errors | 21:17 |
mgedmin | can you commit a version of the script that shows the error? | 21:17 |
bskahan | one sec | 21:17 |
bskahan | committed main.py with 3 commented lines | 21:23 |
bskahan | uncomment them to break migration | 21:23 |
* mgedmin looks | 21:24 | |
bskahan | something about accessing link.source in anyway stops the method | 21:25 |
*** Aiste has quit IRC | 21:31 | |
mgedmin | did not fail for me | 21:31 |
bskahan | try hitting the site | 21:33 |
bskahan | after its running in the db-convert test | 21:34 |
bskahan | should throw TraversalError: 'community' | 21:34 |
bskahan | on the front page | 21:34 |
bskahan | because the migration never actually happens | 21:34 |
mgedmin | ah | 21:35 |
mgedmin | hmm | 21:35 |
mgedmin | I expected an exception | 21:35 |
bskahan | it fails silently | 21:35 |
mgedmin | wtf? try: ... except: pass ! | 21:35 |
mgedmin | ok, I got the error now | 21:36 |
mgedmin | 'except: pass' is evil! | 21:36 |
* bskahan agrees | 21:36 | |
th1a | Don't be evil. | 21:36 |
bskahan | it relates to the test stubs | 21:36 |
bskahan | will fix | 21:37 |
* mgedmin is mystified | 21:42 | |
bskahan | me too | 21:43 |
* mgedmin hates pdb | 21:50 | |
mgedmin | hmm, I found the pickled version of that Link object | 22:20 |
mgedmin | the string 'source' does not appear in the pickle | 22:20 |
bskahan | shouldn't it fail to provide the interface in that case? | 22:22 |
mgedmin | if you call verifyObject on it, I expect it would fail | 22:29 |
mgedmin | ok, I'm going to check out 0.8 and try looking inside that Data.fs with the old version | 22:30 |
*** bskahan has quit IRC | 22:33 | |
*** bskahan has joined #schooltool | 22:34 | |
mgedmin | something strange | 22:38 |
mgedmin | there is only one person ("Manager") in the database | 22:38 |
bskahan | at what point? | 22:38 |
* mgedmin pauses | 22:38 | |
bskahan | there should be manager and bskahan | 22:39 |
mgedmin | d'oh! mv Data.fs-0.8 Data.fs | 22:39 |
* bskahan nods | 22:39 | |
mgedmin | aha! | 22:42 |
mgedmin | I get the same error with 0.8 | 22:42 |
mgedmin | if I insert a loop that prints all sources of all links inside prepareDatabase | 22:43 |
mgedmin | kinda strange, isn't it? | 22:43 |
bskahan | the only thing I could think of was something not being setup yet | 22:43 |
bskahan | but what gets me is that link.reltype is correct | 22:44 |
mgedmin | all of the attributes seem to be correct | 22:44 |
bskahan | unless they need source | 22:44 |
bskahan | the sane link objects do have a source if you test it in other places | 22:45 |
bskahan | s/sane/same/ | 22:45 |
mgedmin | I found three links on persons, and they all show the error | 22:46 |
mgedmin | strange | 22:46 |
*** hazmat has joined #schooltool | 22:53 | |
* mgedmin slaps himself | 22:55 | |
mgedmin | links did not have 'source' or 'target' in 0.8 | 22:56 |
mgedmin | they had '__parent__' and 'traverse()' | 22:56 |
bskahan | damn | 22:56 |
mgedmin | http://source.schooltool.org/viewcvs/trunk/schooltool/src/schooltool/relationship.py?rev=2365&r1=2334&r2=2365 | 22:57 |
mgedmin | you can replace 'link.target' with 'link.relationship.traverse(link).__parent__' and it should work | 22:59 |
bskahan | damn | 23:00 |
bskahan | yeah thats it | 23:00 |
bskahan | thanks | 23:00 |
mgedmin | good luck | 23:01 |
mgedmin | I'll be going then | 23:01 |
mgedmin | have a nice weekend | 23:01 |
*** mgedmin has quit IRC | 23:01 | |
th1a | That was a tricky one. | 23:17 |
* bskahan nods | 23:27 | |
bskahan | no uselful traceback | 23:27 |
bskahan | just failed silently | 23:27 |
bskahan | which is still wierd | 23:28 |
th1a | Yeah. | 23:28 |
* jinty hates plone | 23:32 | |
bskahan | heh | 23:32 |
th1a | Are you trying to do structured text with it? | 23:32 |
th1a | So are we doing an rc now or are we just going to put out 0.9? | 23:33 |
bskahan | should still do an RC | 23:33 |
bskahan | just for people to report bugs | 23:33 |
bskahan | I'm not sure how many people are downloading RCs and reporting bugs, but its good to give them the chance | 23:34 |
jinty | I'm in between, but lean to the way we normally do it. i.e. RC | 23:34 |
th1a | I think it is good for us finding bugs. | 23:35 |
th1a | The fact of the matter is that it doesn't make much difference. | 23:35 |
th1a | I'd lean toward doing an rc. | 23:35 |
jinty | In fact, yes, I think the policy should be: for RC's most bugs can be fixed | 23:35 |
jinty | and after, security only | 23:35 |
* bskahan agrees | 23:36 | |
* jinty thinks about writing up a release policy | 23:36 | |
jinty | so, bskahan, can I go and branch the trees now? | 23:37 |
* jinty taps his foot impatiently | 23:39 | |
bskahan | not yet sorry | 23:39 |
bskahan | I have to do the relationship migration without any of the normal relationship tools | 23:40 |
bskahan | since they expect Links to have the current attributes | 23:40 |
th1a | Which relationships? | 23:40 |
bskahan | URIMembership and URISubscriptuion | 23:40 |
th1a | Ah. | 23:40 |
th1a | OK. | 23:40 |
bskahan | normally its easy | 23:41 |
jinty | in theory everything is simple | 23:41 |
bskahan | exactly | 23:41 |
* jinty jumps up and down, screams at plone, then decides brute force is the best option | 23:52 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!