**** BEGIN LOGGING AT Wed Nov 10 12:55:06 2004 | ||
-->You are now talking on #schooltool | 12:55 | |
---Topic for #schooltool is http://schooltool.org | 12:55 | |
---Topic for #schooltool set by Aiste at Mon Oct 18 12:47:26 2004 | 12:55 | |
-->hazmat (~hazmat@c-24-15-10-12.client.comcast.net) has joined #schooltool | 13:55 | |
<--hazmat has quit (Connection timed out) | 14:23 | |
-->gregaway (gregweb@82.123.203.62.cust.bluewin.ch) has joined #schooltool | 14:38 | |
-->thisfred (~thisfred@a213-84-57-72.adsl.xs4all.nl) has joined #schooltool | 14:58 | |
-->alga (~alga@office.pov.lt) has joined #SchoolTool | 15:21 | |
alga | hi th1a | 15:22 |
---|---|---|
alga | now I have a question regarding 'responsible for a resource' | 15:23 |
alga | we already have the 'owner' in the resource booking event | 15:23 |
alga | the manager can set the owner (i.e. book on behalf of anybody), and the owner then sees his booking in his calendar. | 15:25 |
alga | the problem is that you can't really change this field. the resource has to be unbooked and booked by a different person to effectively change the owner | 15:26 |
alga | would prominently displaying the owner be enough or is something more needed for this story? | 15:27 |
-->jinty (~jinty@80-28-103-230.adsl.nuria.telefonica-data.net) has joined #schooltool | 16:20 | |
<--stockholm has quit (Read error: 54 (Connection reset by peer)) | 17:47 | |
-->stockholm (~andi@petrus.schuldei.org) has joined #schooltool | 17:48 | |
-->gregweb (gregweb@129.48.77.83.cust.bluewin.ch) has joined #schooltool | 17:53 | |
<--gregaway has quit (Read error: 110 (Connection timed out)) | 18:10 | |
<--stockholm has quit (Read error: 104 (Connection reset by peer)) | 18:40 | |
-->stockholm (~andi@petrus.schuldei.org) has joined #schooltool | 18:40 | |
th1a | alga: Do you have a minute? | 19:20 |
alga | yes | 19:21 |
th1a | I've got one little bug in my csv import changes that I can't figure out. | 19:22 |
th1a | I've got things coming back double quoted, like ' "jay hacker"' instead of 'jay hacker' | 19:23 |
th1a | I'm not sure what would cause that. | 19:23 |
th1a | In general. | 19:25 |
alga | hm, even though you're not quoting stuff, right? | 19:27 |
alga | But what about te thing I asked you ~4 hours ago? | 19:27 |
th1a | Oh. Sorry. I hadn't noticed that. Let me read it. | 19:28 |
---pere is now known as pere_poff | 19:28 | |
th1a | What you describe sounds fine. | 19:31 |
alga | so, basically, nothing needs to be done? | 19:34 |
th1a | Can any user with add permission set the owner? | 19:38 |
alga | the owner is the person who booked the resource. | 19:38 |
alga | he has the booking event in his calendar | 19:38 |
alga | so, as of now, you cannot change the owner | 19:39 |
alga | if we do it, shoud it automagically move the booking event to the new owner? | 19:39 |
th1a | But do you have to be a manager to set someone else as owner, or can regular users with "add" permission do it? | 19:41 |
mgedmin | you have to be a manager | 19:42 |
<--Aiste has quit (Read error: 110 (Connection timed out)) | 19:42 | |
th1a | Hm. Let's think of the case of a Library. | 19:44 |
th1a | The Librarian may want to be the only person who adds events to the library calendar. | 19:44 |
th1a | But it would be useful for the bookings to appear on the calendars of the teachers using the library, rather than his personal calendar (since they're also all on the main library calendar anyhow). | 19:45 |
th1a | But we also don't want to have to make him a site manager to do this. | 19:45 |
th1a | Perhaps anyone with add permission should be able to set the responsible party. | 19:46 |
th1a | It doesn't seem like something that would be subject to abuse. | 19:46 |
alga | OK | 19:46 |
alga | but modify is reqired for deletions, right? | 19:47 |
th1a | The default owner should be the active user. | 19:47 |
th1a | Yes. | 19:47 |
alga | OK, that makes it clear | 19:47 |
alga | thanks | 19:47 |
th1a | Having to delete the event to change the responsible party doesn't seem like a problem. | 19:47 |
th1a | Because generally it would more accurately represent what was happening. | 19:48 |
SteveA | are there any docs on what facets are for and how they work? | 19:49 |
th1a | On a high level, I think. | 19:49 |
alga | SteveA: I doubt that | 19:49 |
th1a | Not enough to develop with them. | 19:49 |
alga | th1a: did you get my mail regarding restricted membership? | 19:51 |
th1a | Yes. | 19:52 |
alga | what do you think? | 19:52 |
th1a | Does the form restrict your choices to valid ones when you're adding members? | 19:55 |
<--thisfred has quit ("Farewell, cruel channel...") | 19:56 | |
th1a | SteveA: I think architecture.txt is still the best explanation of facets. | 19:56 |
SteveA | found some stuff hhttp://source.schooltool.org/viewcvs/trunk/schooltool/doc/architecture.txt?rev=1980&view=markupere: | 19:56 |
th1a | Right. | 19:57 |
-->Aiste (~aiste@adsl-213-190-44-43.takas.lt) has joined #schooltool | 20:01 | |
mgedmin | I've been looking at bug reports in the issue tracker | 20:16 |
mgedmin | http://issues.schooltool.org/issue118 says that the description in the group edit form is too technical | 20:16 |
mgedmin | (and mentions a typo that is now fixed) | 20:16 |
th1a | Let me look at the page again. | 20:17 |
mgedmin | th1a: how would you suggest rephrasing the description? | 20:17 |
th1a | That's not a very useful bug report, is it? :-) | 20:21 |
alga | th1a: the 'add members/subgroups' form only shows valid members when the restriction is on | 20:21 |
th1a | alga: OK. That sounds right. | 20:21 |
th1a | alga: I'll have a look at it later. | 20:21 |
alga | ok | 20:21 |
th1a | mgedmin: I can't remember if there is something else that I was referring to that has also been changed. There needs to be some clearer representation of group relationships, but that's a pretty big UI question. Not really a bug. | 20:23 |
th1a | mgedmin: You might as well just close the bug. | 20:24 |
mgedmin | ok | 20:24 |
mgedmin | the most important bit (typo) has been fixed, after all ;) | 20:24 |
th1a | At least I'm feeling enough on top of things to fix typos now all by myself. | 20:25 |
<--rabidbt has quit (Remote closed the connection) | 20:27 | |
-->rabidbt (~rabidbt@66.45.74.16) has joined #schooltool | 20:33 | |
th1a | Right now when I run test.py I'm getting 1 failure and 2 errors (at rev 2036). Is this the same as what you're getting at POV, or is something else wrong with my setup? | 20:39 |
th1a | I just want to make sure I don't have some underlying problem I don't know about. | 20:40 |
*mgedmin is running tests now | 20:41 | |
th1a | mgedmin: thanks. | 20:41 |
mgedmin | all unit tests passed | 20:42 |
mgedmin | th1a: can you paste the names of failing tests? | 20:42 |
mgedmin | do you have changes in your sandbox? | 20:42 |
th1a | I don't think so. | 20:42 |
mgedmin | perhaps you have pyc files without corresponding py files | 20:43 |
th1a | That's what I'm trying to figure out. | 20:43 |
mgedmin | running 'make' would fix that | 20:43 |
th1a | Trying 'make' and running tests again... | 20:43 |
mgedmin | recently we renamed csv.py to csvimport.py, you might still have a pyc from an older version and that would break 'import csv' in the same package | 20:43 |
th1a | Ah. | 20:43 |
mgedmin | actually, if you ran tests with 'make test', then all stale pyc should have been removed | 20:44 |
*mgedmin 's tests finished successfully | 20:44 | |
th1a | That cleared up the errors, and might explain why I spent the last five hours of my life trying to figure out why the changes I was making to csvimport.py weren't working. | 20:45 |
-->hoffman (~hoffman@pool-64-223-50-152.prov.east.verizon.net) has joined #schooltool | 20:46 | |
hoffman | Here's the remaining failure: | 20:47 |
hoffman | ====================================================================== | 20:47 |
hoffman | FAIL: schooltool.tests.test_icalendar.TestVEvent.test_validate_rrule_exceptions | 20:47 |
hoffman | ---------------------------------------------------------------------- | 20:47 |
hoffman | Traceback (most recent call last): | 20:47 |
hoffman | File "/home/hoffman/schooltool/src/schooltool/tests/test_icalendar.py", line 424, in test_validate_rrule_exceptions | 20:47 |
hoffman | (date(1996, 4, 2), date(1996, 4, 4))) | 20:47 |
hoffman | File "/usr/lib/python2.3/unittest.py", line 302, in failUnlessEqual | 20:47 |
hoffman | raise self.failureException, \ | 20:47 |
hoffman | AssertionError: (datetime.date(1996, 4, 1), datetime.date(1996, 4, 3)) != (datetime.date(1996, 4, 2), datetime.date(1996, 4, 4)) | 20:47 |
mgedmin | that is definitely interesting | 20:48 |
mgedmin | it looks like a bug in the test | 20:48 |
mgedmin | times in UTC are converted to local time | 20:49 |
mgedmin | you are in a different time zone, that's why you see the failure and we don't | 20:49 |
th1a | That makes sense. | 20:50 |
mgedmin | fix committed | 20:51 |
th1a | Is it better to use "make test" than "python test.py" | 20:53 |
th1a | OK. They all pass in this time zone now, too. | 20:54 |
mgedmin | when you want to run all schooltool tests, make test is better | 20:54 |
mgedmin | when you're developing and want to run only a subset, python test.py is more suitable because it is more flexible | 20:54 |
th1a | OK. | 20:55 |
th1a | It's much faster, too! | 20:56 |
th1a | make test, that is. | 20:56 |
mgedmin | it skips ZODB tests which are very slow | 20:57 |
th1a | Ah. | 20:57 |
mgedmin | make test is basically equivalent to python test.py schooltool | 20:57 |
<--hoffman (~hoffman@pool-64-223-50-152.prov.east.verizon.net) has left #schooltool ("Leaving") | 20:57 | |
th1a | I see. | 20:57 |
mgedmin | make test also makes sure that all extension modules are compiled | 20:58 |
mgedmin | and that there are no stale *.pyc files in the source tree | 20:58 |
mgedmin | and sets the locale to "C" to prevent translations from breaking unit tests | 20:58 |
mgedmin | (which is actually not necessary any more) | 20:58 |
mgedmin | (we changed schooltool so that translation language is specified in the config file rather than using the system locale) | 20:59 |
<--alga has quit ("cd ~") | 21:57 | |
**** ENDING LOGGING AT Wed Nov 10 22:57:25 2004 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!